Re: [PATCH v5 5/6] ASoC: SDCA: Create ALSA controls from DisCo

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Mon, May 12, 2025 at 03:53:36PM +0200, Pierre-Louis Bossart wrote:
> 
> > +static bool exported_control(struct sdca_control *control)
> > +{
> > +	/* No need to export control for something that only has one value */
> > +	if (control->has_fixed)
> > +		return false;
> 
> why is that? It'd simplify userspace if there was always a way to
> get a value, even if it's fixed?

Well mostly it is because various things in the stack get
sad with a single value control you can't set. If we wanted
to change that I would suggest we add a FIXME. It isn't really
critical and I would really like to get more of this class
driver stuff moving, it has been out for review for a really long
time now.

> > @@ -99,6 +113,7 @@ int sdca_asoc_count_component(struct device *dev, struct sdca_function_data *fun
> >  		case SDCA_ENTITY_TYPE_OT:
> >  			*num_routes += !!entity->iot.clock;
> >  			*num_routes += !!entity->iot.is_dataport;
> > +			*num_controls += !entity->iot.is_dataport;
> 
> shouldn't the same line be added for TYPE_IT?

This is just the cutting on the patch generation, case
SDCA_ENTITY_TYPE_IT: is the line right above so this runs for
both.

Thanks,
Charles