Re: [PATCH v5 6/6] ASoC: SDCA: Create DAI drivers from DisCo

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Mon, May 12, 2025 at 04:00:18PM +0200, Pierre-Louis Bossart wrote:
> > +		switch (entity->type) {
> > +		case SDCA_ENTITY_TYPE_IT:
> > +			stream = &dais[j].playback;
> > +			stream_suffix = "Playback";
> > +			break;
> > +		case SDCA_ENTITY_TYPE_OT:
> > +			stream = &dais[j].capture;
> > +			stream_suffix = "Capture";
> > +			break;
> > +		default:
> > +			continue;
> > +		}
> > +
> > +		if (!entity->iot.is_dataport)
> > +			continue;
> 
> should this be moved as the first test in the for() loop? The switch
> cases for IT/OT only makes sense for streaming/dataport terminals, no?

Can't be first in the loop since the entities can be different
types and the iot is part of a union so it is only safe to access
is_dataport once you know it is a terminal entity.

Thanks,
Charles