Re: [PATCH v5 4/6] ASoC: SDCA: Create DAPM widgets and routes from DisCo

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, May 14, 2025 at 02:30:00PM +0100, Charles Keepax wrote:
> On Wed, May 14, 2025 at 02:15:01PM +0200, Pierre-Louis Bossart wrote:
> > Humm, that one doesn't seem right. There could be cases
> > where the DETECTED_MODE is inconclusive, or that additional
> > vendor-specific steps are needed to decide which SELECTED_MODE
> > makes sense. I don't think we should assume everything is
> > handled internally, or we have to define what 'internally'
> > means. This cannot be generic SDCA stuff, it has to be
> > configurable for specific implementations/vendors.
> 
> Ok yeah I see, the current code reads the DETECTED_MODE in
> the IRQ handler and then updates the selected mode. I guess
> currently what is missing is the handling for the JACK_UNKNOWN
> case, which could probably require user-space. I think it would
> be pretty easy to export the DETECTED_MODE as well I will have a
> look.

Should hopefully be able to send a new spin tomorrow. I have
managed to include all the comments I think.

I started being a little more unsure on this DETECTED_MODE again,
but I am going to go with forcing the export of DETECTED_MODE
for now and we can revise later if we have a better plan.

My concerns really are most custom handling will actually
want to live in the kernel, except the case where the system
wants to present a dialog to the user to select the jack device
manually. In that manual case I also can't see any reason why
just setting the selected mode to unknown would not make the
most sense, but the spec does not say the device should do that.

Thanks,
Charles