All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
	Joerg Roedel <joerg.roedel@amd.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][KVM][retry 3] Add support for Pause Filtering to AMD SVM
Date: Wed, 20 May 2009 12:04:48 +0300	[thread overview]
Message-ID: <4A13C7B0.10507@redhat.com> (raw)
In-Reply-To: <1242809657.26820.559.camel@twins>

Peter Zijlstra wrote:

  

>> It's a fully virtualized guest.  There's no way to get this without 
>> patching the guest kernel.
>>     
>
> Yes there is.. virtualized monitor-wait stuff coupled with a
> monitor-wait based spinlock implementation.
>   

That only works if the guest uses monitor/mwait.  Not all of the guests 
are under our control.  I don't know whether Windows uses 
monitor/mwait.  Further, we don't have timed exits on mwait like we do 
with pause.

I've also heard that monitor/mwait are very slow and only usable on idle 
loop stuff.

> Once we go change silicon, you might as well do it right.
>   

None of the major x86 vendors are under my control.

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
	Joerg Roedel <joerg.roedel@amd.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][retry 3] Add support for Pause Filtering to AMD SVM
Date: Wed, 20 May 2009 12:04:48 +0300	[thread overview]
Message-ID: <4A13C7B0.10507@redhat.com> (raw)
In-Reply-To: <1242809657.26820.559.camel@twins>

Peter Zijlstra wrote:

  

>> It's a fully virtualized guest.  There's no way to get this without 
>> patching the guest kernel.
>>     
>
> Yes there is.. virtualized monitor-wait stuff coupled with a
> monitor-wait based spinlock implementation.
>   

That only works if the guest uses monitor/mwait.  Not all of the guests 
are under our control.  I don't know whether Windows uses 
monitor/mwait.  Further, we don't have timed exits on mwait like we do 
with pause.

I've also heard that monitor/mwait are very slow and only usable on idle 
loop stuff.

> Once we go change silicon, you might as well do it right.
>   

None of the major x86 vendors are under my control.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-05-20  9:05 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 14:09 [PATCH][KVM] Add support for Pause Filtering to AMD SVM Mark Langsdorf
2009-05-05 16:05 ` Bert Wesarg
2009-05-07 13:55 ` Joerg Roedel
2009-05-07 15:00   ` [PATCH][KVM][retry 1] " Mark Langsdorf
2009-05-07 15:00     ` [PATCH][retry " Mark Langsdorf
2009-05-07 15:31     ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:15       ` Ingo Molnar
2009-05-11 14:15         ` [PATCH][retry " Ingo Molnar
2009-05-11 14:24         ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:24           ` [PATCH][retry " Avi Kivity
2009-05-11 14:33           ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 14:33             ` [PATCH][retry " Ingo Molnar
2009-05-11 14:51             ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:51               ` [PATCH][retry " Avi Kivity
2009-05-11 14:59               ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 14:59                 ` [PATCH][retry " Ingo Molnar
2009-05-11 15:12                 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:12                   ` [PATCH][retry " Avi Kivity
2009-05-11 15:18                   ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 15:18                     ` [PATCH][retry " Ingo Molnar
2009-05-11 15:28                     ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:28                       ` [PATCH][retry " Avi Kivity
2009-05-11 15:36                       ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-11 15:36                         ` [PATCH][retry " Langsdorf, Mark
2009-05-11 15:40                         ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:58                 ` [PATCH][KVM][retry 1] Add support for Pause Filtering to AMDSVM Langsdorf, Mark
2009-05-11 15:58                   ` [PATCH][retry " Langsdorf, Mark
2009-05-11 15:01               ` [PATCH][KVM][retry 1] Add support for Pause Filtering to AMD SVM Peter Zijlstra
2009-05-11 15:01                 ` [PATCH][retry " Peter Zijlstra
2009-05-11 15:06                 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:06                   ` [PATCH][retry " Avi Kivity
2009-05-11 14:42           ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-11 15:05             ` Avi Kivity
2009-05-11 15:05               ` [PATCH][retry " Avi Kivity
2009-05-08 17:03     ` [PATCH][KVM][retry 2] " Mark Langsdorf
2009-05-08 17:03       ` [PATCH][retry " Mark Langsdorf
2009-05-08 18:44       ` [PATCH][KVM][retry " Avi Kivity
2009-05-08 18:44         ` [PATCH][retry " Avi Kivity
2009-05-08 18:47         ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-08 18:47           ` [PATCH][retry " Langsdorf, Mark
2009-05-19 18:56       ` [PATCH][KVM][retry 3] " Mark Langsdorf
2009-05-19 18:56         ` [PATCH][retry " Mark Langsdorf
2009-05-20  7:40         ` [PATCH][KVM][retry " Ingo Molnar
2009-05-20  7:59         ` Peter Zijlstra
2009-05-20  7:59           ` [PATCH][retry " Peter Zijlstra
2009-05-20  8:38           ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  8:38             ` [PATCH][retry " Avi Kivity
2009-05-20  8:42             ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20  8:42               ` [PATCH][retry " Peter Zijlstra
2009-05-20  8:49               ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  8:49                 ` [PATCH][retry " Avi Kivity
2009-05-20  8:54                 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20  8:54                   ` [PATCH][retry " Peter Zijlstra
2009-05-20  9:04                   ` Avi Kivity [this message]
2009-05-20  9:04                     ` Avi Kivity
2009-05-20  9:10                     ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20  9:10                       ` [PATCH][retry " Peter Zijlstra
2009-05-20  9:17                       ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  9:17                         ` [PATCH][retry " Avi Kivity
2009-05-20 13:52                       ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-20 13:52                         ` [PATCH][retry " Langsdorf, Mark
2009-05-20 12:00         ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 12:00           ` [PATCH][retry " Avi Kivity
2009-05-20 22:25         ` [PATCH][KVM][retry 4] " Mark Langsdorf
2009-05-20 22:25           ` [PATCH][retry " Mark Langsdorf
2009-05-21  8:47           ` [PATCH][KVM][retry " Avi Kivity
2009-05-21  8:47             ` [PATCH][retry " Avi Kivity
2009-07-08  5:19           ` [PATCH][KVM][retry " Sheng Yang
2009-07-08  5:19             ` [PATCH][retry " Sheng Yang
2009-07-08 14:59             ` [PATCH][KVM][retry " Langsdorf, Mark
2009-07-08 14:59               ` [PATCH][retry " Langsdorf, Mark
2009-07-09  1:50               ` [PATCH][KVM][retry " Sheng Yang
2009-07-09  1:50                 ` [PATCH][retry " Sheng Yang
2009-07-22 22:40                 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-07-22 22:40                   ` [PATCH][retry " Langsdorf, Mark
2009-08-05  9:08                   ` [PATCH][KVM][retry " Zhai, Edwin
2009-08-05  9:08                     ` [PATCH][retry " Zhai, Edwin
2009-05-11 14:38 ` [PATCH][KVM] " Peter Zijlstra
2009-05-11 14:51   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A13C7B0.10507@redhat.com \
    --to=avi@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.