All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	peterz@infradead.org, Ingo Molnar <mingo@elte.hu>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][KVM][retry 4] Add support for Pause Filtering to AMD SVM
Date: Thu, 21 May 2009 11:47:22 +0300	[thread overview]
Message-ID: <4A15151A.6000708@redhat.com> (raw)
In-Reply-To: <200905201725.18046.mark.langsdorf@amd.com>

Mark Langsdorf wrote:
> This feature creates a new field in the VMCB called Pause
> Filter Count.  If Pause Filter Count is greater than 0 and
> intercepting PAUSEs is enabled, the processor will increment
> an internal counter when a PAUSE instruction occurs instead
> of intercepting.  When the internal counter reaches the
> Pause Filter Count value, a PAUSE intercept will occur.
>
> This feature can be used to detect contended spinlocks,
> especially when the lock holding VCPU is not scheduled.
> Rescheduling another VCPU prevents the VCPU seeking the
> lock from wasting its quantum by spinning idly.  Perform
> the reschedule by increasing the the credited time on
> the VCPU.
>
> Experimental results show that most spinlocks are held
> for less than 1000 PAUSE cycles or more than a few
> thousand.  Default the Pause Filter Counter to 3000 to
> detect the contended spinlocks.
>
> Processor support for this feature is indicated by a CPUID
> bit.
>
> On a 24 core system running 4 guests each with 16 VCPUs,
> this patch improved overall performance of each guest's
> 32 job kernbench by approximately 1%.  Further performance
> improvement may be possible with a more sophisticated
> yield algorithm.
>   

Please split this into a scheduler patch and a kvm patch.


-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	peterz@infradead.org, Ingo Molnar <mingo@elte.hu>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][retry 4] Add support for Pause Filtering to AMD SVM
Date: Thu, 21 May 2009 11:47:22 +0300	[thread overview]
Message-ID: <4A15151A.6000708@redhat.com> (raw)
In-Reply-To: <200905201725.18046.mark.langsdorf@amd.com>

Mark Langsdorf wrote:
> This feature creates a new field in the VMCB called Pause
> Filter Count.  If Pause Filter Count is greater than 0 and
> intercepting PAUSEs is enabled, the processor will increment
> an internal counter when a PAUSE instruction occurs instead
> of intercepting.  When the internal counter reaches the
> Pause Filter Count value, a PAUSE intercept will occur.
>
> This feature can be used to detect contended spinlocks,
> especially when the lock holding VCPU is not scheduled.
> Rescheduling another VCPU prevents the VCPU seeking the
> lock from wasting its quantum by spinning idly.  Perform
> the reschedule by increasing the the credited time on
> the VCPU.
>
> Experimental results show that most spinlocks are held
> for less than 1000 PAUSE cycles or more than a few
> thousand.  Default the Pause Filter Counter to 3000 to
> detect the contended spinlocks.
>
> Processor support for this feature is indicated by a CPUID
> bit.
>
> On a 24 core system running 4 guests each with 16 VCPUs,
> this patch improved overall performance of each guest's
> 32 job kernbench by approximately 1%.  Further performance
> improvement may be possible with a more sophisticated
> yield algorithm.
>   

Please split this into a scheduler patch and a kvm patch.


-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-05-21  8:47 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 14:09 [PATCH][KVM] Add support for Pause Filtering to AMD SVM Mark Langsdorf
2009-05-05 16:05 ` Bert Wesarg
2009-05-07 13:55 ` Joerg Roedel
2009-05-07 15:00   ` [PATCH][KVM][retry 1] " Mark Langsdorf
2009-05-07 15:00     ` [PATCH][retry " Mark Langsdorf
2009-05-07 15:31     ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:15       ` Ingo Molnar
2009-05-11 14:15         ` [PATCH][retry " Ingo Molnar
2009-05-11 14:24         ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:24           ` [PATCH][retry " Avi Kivity
2009-05-11 14:33           ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 14:33             ` [PATCH][retry " Ingo Molnar
2009-05-11 14:51             ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 14:51               ` [PATCH][retry " Avi Kivity
2009-05-11 14:59               ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 14:59                 ` [PATCH][retry " Ingo Molnar
2009-05-11 15:12                 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:12                   ` [PATCH][retry " Avi Kivity
2009-05-11 15:18                   ` [PATCH][KVM][retry " Ingo Molnar
2009-05-11 15:18                     ` [PATCH][retry " Ingo Molnar
2009-05-11 15:28                     ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:28                       ` [PATCH][retry " Avi Kivity
2009-05-11 15:36                       ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-11 15:36                         ` [PATCH][retry " Langsdorf, Mark
2009-05-11 15:40                         ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:58                 ` [PATCH][KVM][retry 1] Add support for Pause Filtering to AMDSVM Langsdorf, Mark
2009-05-11 15:58                   ` [PATCH][retry " Langsdorf, Mark
2009-05-11 15:01               ` [PATCH][KVM][retry 1] Add support for Pause Filtering to AMD SVM Peter Zijlstra
2009-05-11 15:01                 ` [PATCH][retry " Peter Zijlstra
2009-05-11 15:06                 ` [PATCH][KVM][retry " Avi Kivity
2009-05-11 15:06                   ` [PATCH][retry " Avi Kivity
2009-05-11 14:42           ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-11 15:05             ` Avi Kivity
2009-05-11 15:05               ` [PATCH][retry " Avi Kivity
2009-05-08 17:03     ` [PATCH][KVM][retry 2] " Mark Langsdorf
2009-05-08 17:03       ` [PATCH][retry " Mark Langsdorf
2009-05-08 18:44       ` [PATCH][KVM][retry " Avi Kivity
2009-05-08 18:44         ` [PATCH][retry " Avi Kivity
2009-05-08 18:47         ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-08 18:47           ` [PATCH][retry " Langsdorf, Mark
2009-05-19 18:56       ` [PATCH][KVM][retry 3] " Mark Langsdorf
2009-05-19 18:56         ` [PATCH][retry " Mark Langsdorf
2009-05-20  7:40         ` [PATCH][KVM][retry " Ingo Molnar
2009-05-20  7:59         ` Peter Zijlstra
2009-05-20  7:59           ` [PATCH][retry " Peter Zijlstra
2009-05-20  8:38           ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  8:38             ` [PATCH][retry " Avi Kivity
2009-05-20  8:42             ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20  8:42               ` [PATCH][retry " Peter Zijlstra
2009-05-20  8:49               ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  8:49                 ` [PATCH][retry " Avi Kivity
2009-05-20  8:54                 ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20  8:54                   ` [PATCH][retry " Peter Zijlstra
2009-05-20  9:04                   ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  9:04                     ` [PATCH][retry " Avi Kivity
2009-05-20  9:10                     ` [PATCH][KVM][retry " Peter Zijlstra
2009-05-20  9:10                       ` [PATCH][retry " Peter Zijlstra
2009-05-20  9:17                       ` [PATCH][KVM][retry " Avi Kivity
2009-05-20  9:17                         ` [PATCH][retry " Avi Kivity
2009-05-20 13:52                       ` [PATCH][KVM][retry " Langsdorf, Mark
2009-05-20 13:52                         ` [PATCH][retry " Langsdorf, Mark
2009-05-20 12:00         ` [PATCH][KVM][retry " Avi Kivity
2009-05-20 12:00           ` [PATCH][retry " Avi Kivity
2009-05-20 22:25         ` [PATCH][KVM][retry 4] " Mark Langsdorf
2009-05-20 22:25           ` [PATCH][retry " Mark Langsdorf
2009-05-21  8:47           ` Avi Kivity [this message]
2009-05-21  8:47             ` Avi Kivity
2009-07-08  5:19           ` [PATCH][KVM][retry " Sheng Yang
2009-07-08  5:19             ` [PATCH][retry " Sheng Yang
2009-07-08 14:59             ` [PATCH][KVM][retry " Langsdorf, Mark
2009-07-08 14:59               ` [PATCH][retry " Langsdorf, Mark
2009-07-09  1:50               ` [PATCH][KVM][retry " Sheng Yang
2009-07-09  1:50                 ` [PATCH][retry " Sheng Yang
2009-07-22 22:40                 ` [PATCH][KVM][retry " Langsdorf, Mark
2009-07-22 22:40                   ` [PATCH][retry " Langsdorf, Mark
2009-08-05  9:08                   ` [PATCH][KVM][retry " Zhai, Edwin
2009-08-05  9:08                     ` [PATCH][retry " Zhai, Edwin
2009-05-11 14:38 ` [PATCH][KVM] " Peter Zijlstra
2009-05-11 14:51   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A15151A.6000708@redhat.com \
    --to=avi@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.langsdorf@amd.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.