From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] ARM: at91/dt: add ethernet phy to at91rm9200ek board
Date: Mon, 18 Nov 2013 09:39:23 +0100 [thread overview]
Message-ID: <5289D23B.6090101@overkiz.com> (raw)
In-Reply-To: <1377687819-10653-1-git-send-email-b.brezillon@overkiz.com>
On 28/08/2013 13:03, Boris BREZILLON wrote:
> Add ethernet phy node in at91rm9200ek.dts.
> The reg register is not specified, as it may differ depending on the init
> process of the board:
> ADDR0/1 phy pins are connected to PA13/14 rm9200 pins. Which means the phy
> will take its address from these pins during the reset process.
>
> The macb driver will launch a full scan on the mdio bus to discover the phy
> address.
>
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> ---
> arch/arm/boot/dts/at91rm9200ek.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91rm9200ek.dts b/arch/arm/boot/dts/at91rm9200ek.dts
> index d2d72c3..37b0880 100644
> --- a/arch/arm/boot/dts/at91rm9200ek.dts
> +++ b/arch/arm/boot/dts/at91rm9200ek.dts
> @@ -47,6 +47,11 @@
> macb0: ethernet at fffbc000 {
> phy-mode = "rmii";
> status = "okay";
> +
> + phy0: ethernet-phy {
> + interrupt-parent = <&pioC>;
> + interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
rm9200 pio controller does not support specific edge detection.
The line above should be replaced with:
interrupts = <4 IRQ_TYPE_EDGE_BOTH>;
or
interrupts = <4 0>;
Nicolas, I know you were planning to push this patch for 3.14.
If you haven't done it yet (or if you changed your mind), I can send a
new version including this fix.
> + };
> };
>
> usb1: gadget at fffb0000 {
>
WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
To: Boris BREZILLON
<b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Ian Campbell
<ian.campbell-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Joachim Eastwood
<manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/9] ARM: at91/dt: add ethernet phy to at91rm9200ek board
Date: Mon, 18 Nov 2013 09:39:23 +0100 [thread overview]
Message-ID: <5289D23B.6090101@overkiz.com> (raw)
In-Reply-To: <1377687819-10653-1-git-send-email-b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
On 28/08/2013 13:03, Boris BREZILLON wrote:
> Add ethernet phy node in at91rm9200ek.dts.
> The reg register is not specified, as it may differ depending on the init
> process of the board:
> ADDR0/1 phy pins are connected to PA13/14 rm9200 pins. Which means the phy
> will take its address from these pins during the reset process.
>
> The macb driver will launch a full scan on the mdio bus to discover the phy
> address.
>
> Signed-off-by: Boris BREZILLON <b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
> ---
> arch/arm/boot/dts/at91rm9200ek.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91rm9200ek.dts b/arch/arm/boot/dts/at91rm9200ek.dts
> index d2d72c3..37b0880 100644
> --- a/arch/arm/boot/dts/at91rm9200ek.dts
> +++ b/arch/arm/boot/dts/at91rm9200ek.dts
> @@ -47,6 +47,11 @@
> macb0: ethernet@fffbc000 {
> phy-mode = "rmii";
> status = "okay";
> +
> + phy0: ethernet-phy {
> + interrupt-parent = <&pioC>;
> + interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
rm9200 pio controller does not support specific edge detection.
The line above should be replaced with:
interrupts = <4 IRQ_TYPE_EDGE_BOTH>;
or
interrupts = <4 0>;
Nicolas, I know you were planning to push this patch for 3.14.
If you haven't done it yet (or if you changed your mind), I can send a
new version including this fix.
> + };
> };
>
> usb1: gadget@fffb0000 {
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: Boris BREZILLON <b.brezillon@overkiz.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Russell King <linux@arm.linux.org.uk>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Joachim Eastwood <manabian@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: at91/dt: add ethernet phy to at91rm9200ek board
Date: Mon, 18 Nov 2013 09:39:23 +0100 [thread overview]
Message-ID: <5289D23B.6090101@overkiz.com> (raw)
In-Reply-To: <1377687819-10653-1-git-send-email-b.brezillon@overkiz.com>
On 28/08/2013 13:03, Boris BREZILLON wrote:
> Add ethernet phy node in at91rm9200ek.dts.
> The reg register is not specified, as it may differ depending on the init
> process of the board:
> ADDR0/1 phy pins are connected to PA13/14 rm9200 pins. Which means the phy
> will take its address from these pins during the reset process.
>
> The macb driver will launch a full scan on the mdio bus to discover the phy
> address.
>
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> ---
> arch/arm/boot/dts/at91rm9200ek.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91rm9200ek.dts b/arch/arm/boot/dts/at91rm9200ek.dts
> index d2d72c3..37b0880 100644
> --- a/arch/arm/boot/dts/at91rm9200ek.dts
> +++ b/arch/arm/boot/dts/at91rm9200ek.dts
> @@ -47,6 +47,11 @@
> macb0: ethernet@fffbc000 {
> phy-mode = "rmii";
> status = "okay";
> +
> + phy0: ethernet-phy {
> + interrupt-parent = <&pioC>;
> + interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
rm9200 pio controller does not support specific edge detection.
The line above should be replaced with:
interrupts = <4 IRQ_TYPE_EDGE_BOTH>;
or
interrupts = <4 0>;
Nicolas, I know you were planning to push this patch for 3.14.
If you haven't done it yet (or if you changed your mind), I can send a
new version including this fix.
> + };
> };
>
> usb1: gadget@fffb0000 {
>
next prev parent reply other threads:[~2013-11-18 8:39 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 11:00 [PATCH 0/9] ARM: at91/dt: add missing devices to rm9200ek board Boris BREZILLON
2013-08-28 11:00 ` Boris BREZILLON
2013-08-28 11:02 ` [PATCH 1/9] ARM: at91/dt: add rm9200 spi0 chip select pins definitions Boris BREZILLON
2013-08-28 11:02 ` Boris BREZILLON
2013-11-20 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:59 ` boris brezillon
2013-11-20 15:59 ` boris brezillon
2013-11-20 17:05 ` boris brezillon
2013-11-20 17:05 ` boris brezillon
2013-08-28 11:03 ` [PATCH 2/9] ARM: at91/dt: add ethernet phy to at91rm9200ek board Boris BREZILLON
2013-08-28 11:03 ` Boris BREZILLON
2013-11-18 8:39 ` boris brezillon [this message]
2013-11-18 8:39 ` boris brezillon
2013-11-18 8:39 ` boris brezillon
2013-08-28 11:04 ` [PATCH 3/9] ARM: at91/dt: add usb1 vbus and pullup pins Boris BREZILLON
2013-08-28 11:04 ` Boris BREZILLON
2013-11-20 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:48 ` boris brezillon
2013-11-20 15:48 ` boris brezillon
2013-11-20 15:48 ` boris brezillon
2013-08-28 11:05 ` [PATCH 4/9] ARM: at91/dt: add atmel, pullup-gpio to at91rm9200ek usb1 definition Boris BREZILLON
2013-08-28 11:05 ` [PATCH 4/9] ARM: at91/dt: add atmel,pullup-gpio " Boris BREZILLON
2013-08-28 11:06 ` [PATCH 5/9] ARM: at91/dt: add mmc0 slot0 support to at91rm9200ek board Boris BREZILLON
2013-08-28 11:06 ` Boris BREZILLON
2013-11-20 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 16:14 ` boris brezillon
2013-11-20 16:14 ` boris brezillon
2013-11-20 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 9:48 ` Linus Walleij
2013-11-21 9:48 ` Linus Walleij
2013-11-21 10:34 ` boris brezillon
2013-11-21 10:34 ` boris brezillon
2013-11-26 13:46 ` Linus Walleij
2013-11-26 13:46 ` Linus Walleij
2013-11-26 13:46 ` Linus Walleij
2013-11-26 17:55 ` boris brezillon
2013-11-26 17:55 ` boris brezillon
2013-11-26 17:55 ` boris brezillon
[not found] ` <5294D64D.7000100@overkiz.com>
2013-11-29 10:03 ` Linus Walleij
2013-11-29 10:03 ` Linus Walleij
2013-11-29 10:30 ` boris brezillon
2013-11-29 10:30 ` boris brezillon
2013-11-29 10:30 ` boris brezillon
2013-11-29 13:31 ` Linus Walleij
2013-11-29 13:31 ` Linus Walleij
2013-11-29 15:30 ` boris brezillon
2013-11-29 15:30 ` boris brezillon
2013-12-09 10:34 ` boris brezillon
2013-12-09 10:34 ` boris brezillon
2013-12-09 10:34 ` boris brezillon
2013-12-12 17:52 ` Linus Walleij
2013-12-12 17:52 ` Linus Walleij
2013-08-28 11:07 ` [PATCH 6/9] ARM: at91/dt: add spi0 " Boris BREZILLON
2013-08-28 11:07 ` Boris BREZILLON
2013-11-20 15:00 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:00 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-28 11:08 ` [PATCH 7/9] ARM: at91/dt: add i2c devices connected " Boris BREZILLON
2013-08-28 11:08 ` Boris BREZILLON
2013-11-20 15:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 16:17 ` boris brezillon
2013-11-20 16:17 ` boris brezillon
2013-08-28 12:37 ` [PATCH 8/9] ARM: at91/dt: add new at91rm9200ek_mmc board Boris BREZILLON
2013-08-28 12:37 ` Boris BREZILLON
2013-11-20 15:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 16:31 ` boris brezillon
2013-11-20 16:31 ` boris brezillon
2013-11-20 16:31 ` boris brezillon
2013-11-20 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 8:44 ` Nicolas Ferre
2013-11-21 8:44 ` Nicolas Ferre
2013-11-21 8:44 ` Nicolas Ferre
2013-08-28 12:38 ` [PATCH 9/9] ARM: at91/dt: add new at91rm9200ek_dataflash board Boris BREZILLON
2013-08-28 12:38 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5289D23B.6090101@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.