From: b.brezillon@overkiz.com (boris brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] ARM: at91/dt: add rm9200 spi0 chip select pins definitions
Date: Wed, 20 Nov 2013 16:59:49 +0100 [thread overview]
Message-ID: <528CDC75.1010404@overkiz.com> (raw)
In-Reply-To: <20131120145609.GC14627@ns203013.ovh.net>
On 20/11/2013 15:56, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:02 Wed 28 Aug , Boris BREZILLON wrote:
>> Add spi0 cs pinctrl pins definitions.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>> ---
>> arch/arm/boot/dts/at91rm9200.dtsi | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi
>> index f770655..69b76c7 100644
>> --- a/arch/arm/boot/dts/at91rm9200.dtsi
>> +++ b/arch/arm/boot/dts/at91rm9200.dtsi
>> @@ -486,6 +486,26 @@
>> AT91_PIOA 1 AT91_PERIPH_A AT91_PINCTRL_NONE /* PA1 periph A SPI0_MOSI pin */
>> AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PA2 periph A SPI0_SPCK pin */
>> };
>> +
>> + pinctrl_spi0_cs0: spi0_cs0-0 {
>> + atmel,pins =
>> + <AT91_PIOA 3 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PA3 periph A SPI0_NPCS0 pin */
>> + };
>> +
>> + pinctrl_spi0_cs1: spi0_cs1-0 {
>> + atmel,pins =
>> + <AT91_PIOA 4 AT91_PERIPH_GPIO AT91_PINCTRL_MULTI_DRIVE>; /* PA4 GPIO SPI0_NPCS1 pin */
>> + };
>> +
>> + pinctrl_spi0_cs2: spi0_cs2-0 {
>> + atmel,pins =
>> + <AT91_PIOA 5 AT91_PERIPH_GPIO AT91_PINCTRL_MULTI_DRIVE>; /* PA5 GPIO SPI0_NPCS2 pin */
>> + };
>> +
>> + pinctrl_spi0_cs3: spi0_cs3-0 {
>> + atmel,pins =
>> + <AT91_PIOA 6 AT91_PERIPH_GPIO AT91_PINCTRL_MULTI_DRIVE>; /* PA6 GPIO SPI0_NPCS3 pin */
>> + };
> nack the pin are not multidrive there is only one master
Right, this is a mistake.
But the pins should be configured as OUTPUT with HIGH level
(see
http://lxr.free-electrons.com/source/arch/arm/mach-at91/at91rm9200_devices.c#L589).
>
> Best Regards,
> J.
>> };
>>
>> pioA: gpio at fffff400 {
>> --
>> 1.7.9.5
>>
WARNING: multiple messages have this Message-ID (diff)
From: boris brezillon <b.brezillon@overkiz.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Russell King <linux@arm.linux.org.uk>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Joachim Eastwood <manabian@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/9] ARM: at91/dt: add rm9200 spi0 chip select pins definitions
Date: Wed, 20 Nov 2013 16:59:49 +0100 [thread overview]
Message-ID: <528CDC75.1010404@overkiz.com> (raw)
In-Reply-To: <20131120145609.GC14627@ns203013.ovh.net>
On 20/11/2013 15:56, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:02 Wed 28 Aug , Boris BREZILLON wrote:
>> Add spi0 cs pinctrl pins definitions.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>> ---
>> arch/arm/boot/dts/at91rm9200.dtsi | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi
>> index f770655..69b76c7 100644
>> --- a/arch/arm/boot/dts/at91rm9200.dtsi
>> +++ b/arch/arm/boot/dts/at91rm9200.dtsi
>> @@ -486,6 +486,26 @@
>> AT91_PIOA 1 AT91_PERIPH_A AT91_PINCTRL_NONE /* PA1 periph A SPI0_MOSI pin */
>> AT91_PIOA 2 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PA2 periph A SPI0_SPCK pin */
>> };
>> +
>> + pinctrl_spi0_cs0: spi0_cs0-0 {
>> + atmel,pins =
>> + <AT91_PIOA 3 AT91_PERIPH_A AT91_PINCTRL_NONE>; /* PA3 periph A SPI0_NPCS0 pin */
>> + };
>> +
>> + pinctrl_spi0_cs1: spi0_cs1-0 {
>> + atmel,pins =
>> + <AT91_PIOA 4 AT91_PERIPH_GPIO AT91_PINCTRL_MULTI_DRIVE>; /* PA4 GPIO SPI0_NPCS1 pin */
>> + };
>> +
>> + pinctrl_spi0_cs2: spi0_cs2-0 {
>> + atmel,pins =
>> + <AT91_PIOA 5 AT91_PERIPH_GPIO AT91_PINCTRL_MULTI_DRIVE>; /* PA5 GPIO SPI0_NPCS2 pin */
>> + };
>> +
>> + pinctrl_spi0_cs3: spi0_cs3-0 {
>> + atmel,pins =
>> + <AT91_PIOA 6 AT91_PERIPH_GPIO AT91_PINCTRL_MULTI_DRIVE>; /* PA6 GPIO SPI0_NPCS3 pin */
>> + };
> nack the pin are not multidrive there is only one master
Right, this is a mistake.
But the pins should be configured as OUTPUT with HIGH level
(see
http://lxr.free-electrons.com/source/arch/arm/mach-at91/at91rm9200_devices.c#L589).
>
> Best Regards,
> J.
>> };
>>
>> pioA: gpio@fffff400 {
>> --
>> 1.7.9.5
>>
next prev parent reply other threads:[~2013-11-20 15:59 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 11:00 [PATCH 0/9] ARM: at91/dt: add missing devices to rm9200ek board Boris BREZILLON
2013-08-28 11:00 ` Boris BREZILLON
2013-08-28 11:02 ` [PATCH 1/9] ARM: at91/dt: add rm9200 spi0 chip select pins definitions Boris BREZILLON
2013-08-28 11:02 ` Boris BREZILLON
2013-11-20 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:56 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:59 ` boris brezillon [this message]
2013-11-20 15:59 ` boris brezillon
2013-11-20 17:05 ` boris brezillon
2013-11-20 17:05 ` boris brezillon
2013-08-28 11:03 ` [PATCH 2/9] ARM: at91/dt: add ethernet phy to at91rm9200ek board Boris BREZILLON
2013-08-28 11:03 ` Boris BREZILLON
2013-11-18 8:39 ` boris brezillon
2013-11-18 8:39 ` boris brezillon
2013-11-18 8:39 ` boris brezillon
2013-08-28 11:04 ` [PATCH 3/9] ARM: at91/dt: add usb1 vbus and pullup pins Boris BREZILLON
2013-08-28 11:04 ` Boris BREZILLON
2013-11-20 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:57 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:48 ` boris brezillon
2013-11-20 15:48 ` boris brezillon
2013-11-20 15:48 ` boris brezillon
2013-08-28 11:05 ` [PATCH 4/9] ARM: at91/dt: add atmel, pullup-gpio to at91rm9200ek usb1 definition Boris BREZILLON
2013-08-28 11:05 ` [PATCH 4/9] ARM: at91/dt: add atmel,pullup-gpio " Boris BREZILLON
2013-08-28 11:06 ` [PATCH 5/9] ARM: at91/dt: add mmc0 slot0 support to at91rm9200ek board Boris BREZILLON
2013-08-28 11:06 ` Boris BREZILLON
2013-11-20 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 14:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 16:14 ` boris brezillon
2013-11-20 16:14 ` boris brezillon
2013-11-20 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:20 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 9:48 ` Linus Walleij
2013-11-21 9:48 ` Linus Walleij
2013-11-21 10:34 ` boris brezillon
2013-11-21 10:34 ` boris brezillon
2013-11-26 13:46 ` Linus Walleij
2013-11-26 13:46 ` Linus Walleij
2013-11-26 13:46 ` Linus Walleij
2013-11-26 17:55 ` boris brezillon
2013-11-26 17:55 ` boris brezillon
2013-11-26 17:55 ` boris brezillon
[not found] ` <5294D64D.7000100@overkiz.com>
2013-11-29 10:03 ` Linus Walleij
2013-11-29 10:03 ` Linus Walleij
2013-11-29 10:30 ` boris brezillon
2013-11-29 10:30 ` boris brezillon
2013-11-29 10:30 ` boris brezillon
2013-11-29 13:31 ` Linus Walleij
2013-11-29 13:31 ` Linus Walleij
2013-11-29 15:30 ` boris brezillon
2013-11-29 15:30 ` boris brezillon
2013-12-09 10:34 ` boris brezillon
2013-12-09 10:34 ` boris brezillon
2013-12-09 10:34 ` boris brezillon
2013-12-12 17:52 ` Linus Walleij
2013-12-12 17:52 ` Linus Walleij
2013-08-28 11:07 ` [PATCH 6/9] ARM: at91/dt: add spi0 " Boris BREZILLON
2013-08-28 11:07 ` Boris BREZILLON
2013-11-20 15:00 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:00 ` Jean-Christophe PLAGNIOL-VILLARD
2013-08-28 11:08 ` [PATCH 7/9] ARM: at91/dt: add i2c devices connected " Boris BREZILLON
2013-08-28 11:08 ` Boris BREZILLON
2013-11-20 15:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:01 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 16:17 ` boris brezillon
2013-11-20 16:17 ` boris brezillon
2013-08-28 12:37 ` [PATCH 8/9] ARM: at91/dt: add new at91rm9200ek_mmc board Boris BREZILLON
2013-08-28 12:37 ` Boris BREZILLON
2013-11-20 15:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 15:02 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 16:31 ` boris brezillon
2013-11-20 16:31 ` boris brezillon
2013-11-20 16:31 ` boris brezillon
2013-11-20 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 8:44 ` Nicolas Ferre
2013-11-21 8:44 ` Nicolas Ferre
2013-11-21 8:44 ` Nicolas Ferre
2013-08-28 12:38 ` [PATCH 9/9] ARM: at91/dt: add new at91rm9200ek_dataflash board Boris BREZILLON
2013-08-28 12:38 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528CDC75.1010404@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.