Review of "all machines" page (master:0add8abc12b850e38a6ec7dcf2856fab2c0107b6)

Review of "all machines" page (master:0add8abc12b850e38a6ec7dcf2856fab2c0107b6)

[Barros Pena, Belen]

I was asked to review the state of all machines page
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently assigned
to Michael) to give an idea of how much work is left to do. The short
answer is: quite a bit.

This is the list of issues I've found


* The "Show rows" menu doesn't seem to be working properly. When you load
the page, the table always shows 10 rows, independently of the value
selected in the "show rows" menu

* The machine name should not have a blue icon next to it

* The machine file information is not coming in

* The layer name should be a link to the layer details page

* The branch, tag or commit column always shows a commit. For machines
coming from layers from the OpenEmbedded layer source, this column should
be showing a branch name instead

* The help text in the "add layer" buttons is currently hardcoded (it
shows the same layer name for all machines)

* You cannot add layers / select machine functionality is not in place

* The 'layer' column should be sortable (currently isn't)

* Sorting and the "edit columns" menu do not interact as explained in page
21 of the design document

* Sorting by layer source reverts the sorting by machine, setting it to z
to a. This should not happen: when I sort by layer source, machines with
the same layer source should be sorted in alphabetical order (a to z)

* The "select" column filter is not in place

* When applying a filter, the page heading does not update to show the
number of results returned by the filter

* It doesn't look like the search functionality is in place. When you try
to search, you get an error saying that the "Machine object has no
attribute 'search_allowed_fields'". This is the full trace:


Environment:

Request Method: GET

Request URL: 
http://0.0.0.0:8000/toastergui/machines/?orderby=name%3A%2B&count=10&search
=3g&page=1

Django Version: 1.6

Python Version: 2.7.3

Installed Applications:

('django.contrib.auth',

 'django.contrib.contenttypes',

 'django.contrib.messages',

 'django.contrib.sessions',

 'django.contrib.admin',

 'django.contrib.staticfiles',

 'django.contrib.humanize',

 'orm',

 'toastermain',

 'south',

 'toastergui',

 'bldviewer',

 'bldcontrol')

Installed Middleware:

('django.middleware.common.CommonMiddleware',

 'django.contrib.sessions.middleware.SessionMiddleware',

 'django.middleware.csrf.CsrfViewMiddleware',

 'django.contrib.auth.middleware.AuthenticationMiddleware',

 'django.contrib.messages.middleware.MessageMiddleware')



Traceback:

File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"

in get_response

  114.                     response = wrapped_callback(request,

*callback_args, **callback_kwargs)

File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in machines

  2383.         queryset_with_search = _get_queryset(Machine,

queryset_all, None, search_term, ordering_string, '-name')

File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in
_get_queryset

  234.         queryset = _get_search_results(search_term, queryset, model)

File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in

_get_search_results

  201.                 model.search_allowed_fields)


Exception Type: AttributeError at /toastergui/machines/

Exception Value: type object 'Machine' has no attribute
'search_allowed_fields'

Cheers

Belén

Re: Review of "all machines" page

[Michael Wood]

Current work in progress available for testing at poky-contrib 
michaelw/all-machines

(If there's no in-line comment it's an item that's still TODO).

Michael

On 06/11/14 16:53, Barros Pena, Belen wrote:
> I was asked to review the state of all machines page
> (https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently assigned
> to Michael) to give an idea of how much work is left to do. The short
> answer is: quite a bit.
>
> This is the list of issues I've found
>
>
> * The "Show rows" menu doesn't seem to be working properly. When you load
> the page, the table always shows 10 rows, independently of the value
> selected in the "show rows" menu
Fixed

>
> * The machine name should not have a blue icon next to it
Fixed
>
> * The machine file information is not coming in
Unfortunately we have no information available on the machine file that 
I can find to display

>
> * The layer name should be a link to the layer details page
Fixed
>
> * The branch, tag or commit column always shows a commit. For machines
> coming from layers from the OpenEmbedded layer source, this column should
> be showing a branch name instead
>
> * The help text in the "add layer" buttons is currently hardcoded (it
> shows the same layer name for all machines)
Fixed
>
> * You cannot add layers / select machine functionality is not in place
Fixed - Apart from the funny tooltip thing
>
> * The 'layer' column should be sortable (currently isn't)
>
> * Sorting and the "edit columns" menu do not interact as explained in page
> 21 of the design document
>
> * Sorting by layer source reverts the sorting by machine, setting it to z
> to a. This should not happen: when I sort by layer source, machines with
> the same layer source should be sorted in alphabetical order (a to z)
>
> * The "select" column filter is not in place
>
> * When applying a filter, the page heading does not update to show the
> number of results returned by the filter
>
> * It doesn't look like the search functionality is in place. When you try
> to search, you get an error saying that the "Machine object has no
> attribute 'search_allowed_fields'". This is the full trace:
Think this last one is fixed at least I couldn't reproduce it. The no 
results state is missing.

Re: Review of "all machines" page

[Barros Pena, Belen]

Thanks, Michael.

A couple of comments in line, plus a couple of new things I've been able
to look at thanks to your fixes:

* the add layer notifications need to match the ones in all other pages.
Currently they say:

"You have added 2 layers: meta-handheld and its dependencies
meta-initramfs. Go to project configuration"

We should show the project name instead of the 'go to project
configuration' link, and the name of the layer added should be a link to
the layer details page. You can see how the notifications should look like
by adding a layer from the layer details page using the latest poky/master
branch

This is the commit that applied the changes

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=088c19d6442653c6b
39003057512d75b6c9508b7

* The 2-stage select machine process is not in place either. When I click
the 'select machine' button, I am brought to the project page, the machine
is changed, but I get no notification that the change has been made.



On 30/01/2015 19:49, "Michael Wood" <michael.g.wood@intel.com> wrote:

>Current work in progress available for testing at poky-contrib
>michaelw/all-machines
>
>(If there's no in-line comment it's an item that's still TODO).
>
>Michael
>
>>
>>
>> * The "Show rows" menu doesn't seem to be working properly. When you
>>load
>> the page, the table always shows 10 rows, independently of the value
>> selected in the "show rows" menu
>Fixed

Yes: it now shows 10 when you load the page, and there are 10 machines
listed per page. But the last selected value doesn't seem to be stored in
the cookie. If I select, for example, 50 rows, then visit a couple of
other pages, then I go back to the all machines page, the value is set
back to 10.

>>
>> * The machine file information is not coming in
>Unfortunately we have no information available on the machine file that
>I can find to display

We would need to check how the layer index gathers this information, and
do the same if we can. This sounds like a nice to have, and it might be,
but it is actually a 'very nice' to have. Basically, it is useful to be
able to quickly get to the source files if you need to understand what
they are doing. Can I ask you to have a chat with Paul to see how we can
provide this?

Re: Review of "all machines" page

[Michael Wood]

Progress update michaelw/all-machines

On 02/02/15 10:28, Barros Pena, Belen wrote:
> Thanks, Michael.
>
> A couple of comments in line, plus a couple of new things I've been able
> to look at thanks to your fixes:
>
> * the add layer notifications need to match the ones in all other pages.
> Currently they say:
>
> "You have added 2 layers: meta-handheld and its dependencies
> meta-initramfs. Go to project configuration"
>
> We should show the project name instead of the 'go to project
> configuration' link, and the name of the layer added should be a link to
> the layer details page. You can see how the notifications should look like
> by adding a layer from the layer details page using the latest poky/master
> branch
>
> This is the commit that applied the changes
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=088c19d6442653c6b
> 39003057512d75b6c9508b7
Fixed: a27a66d875c909114ce52875c52f703ddbbe71c5
> * The 2-stage select machine process is not in place either. When I click
> the 'select machine' button, I am brought to the project page, the machine
> is changed, but I get no notification that the change has been made.
>
This is something that needs implementation in the project page if it 
isn't already, I will come back to this for the layerdetails page too.

>
> On 30/01/2015 19:49, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> Current work in progress available for testing at poky-contrib
>> michaelw/all-machines
>>
>> (If there's no in-line comment it's an item that's still TODO).
>>
>> Michael
>>
>>>
>>> * The "Show rows" menu doesn't seem to be working properly. When you
>>> load
>>> the page, the table always shows 10 rows, independently of the value
>>> selected in the "show rows" menu
>> Fixed
> Yes: it now shows 10 when you load the page, and there are 10 machines
> listed per page. But the last selected value doesn't seem to be stored in
> the cookie. If I select, for example, 50 rows, then visit a couple of
> other pages, then I go back to the all machines page, the value is set
> back to 10.

Fixed: 34124b4223b4bda0b238db35161a2e6ba20436f0
>>> * The machine file information is not coming in
>> Unfortunately we have no information available on the machine file that
>> I can find to display
> We would need to check how the layer index gathers this information, and
> do the same if we can. This sounds like a nice to have, and it might be,
> but it is actually a 'very nice' to have. Basically, it is useful to be
> able to quickly get to the source files if you need to understand what
> they are doing. Can I ask you to have a chat with Paul to see how we can
> provide this?

Fixed: I talked to Paul, it does look like we can re-construct the link 
to the conf file, I didn't realise it but this is what the layer index 
does too and I've added it in
63ceb98ac1b6bc63560665582543394eeff05c2b from some random testing this 
does seem to work.

Re: Review of "all machines" page

[Barros Pena, Belen]

Yep, everything seems to work, except for a small problem with the
notifications. 

See below.

Thanks!!

Belén

On 03/02/2015 16:25, "Michael Wood" <michael.g.wood@intel.com> wrote:

>Progress update michaelw/all-machines
>
>On 02/02/15 10:28, Barros Pena, Belen wrote:
>> Thanks, Michael.
>>
>> A couple of comments in line, plus a couple of new things I've been able
>> to look at thanks to your fixes:
>>
>> * the add layer notifications need to match the ones in all other pages.
>> Currently they say:
>>
>> "You have added 2 layers: meta-handheld and its dependencies
>> meta-initramfs. Go to project configuration"
>>
>> We should show the project name instead of the 'go to project
>> configuration' link, and the name of the layer added should be a link to
>> the layer details page. You can see how the notifications should look
>>like
>> by adding a layer from the layer details page using the latest
>>poky/master
>> branch
>>
>> This is the commit that applied the changes
>>
>> 
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=088c19d6442653c
>>6b
>> 39003057512d75b6c9508b7
>Fixed: a27a66d875c909114ce52875c52f703ddbbe71c5

Something funny going on with the project name: it's wrapped with an
anchor tag, but there is no href attribute in it, so it doesn't link
anywhere. Also, the 'Go to project configuration' can go, since the
project name goes there.

>> * The 2-stage select machine process is not in place either. When I
>>click
>> the 'select machine' button, I am brought to the project page, the
>>machine
>> is changed, but I get no notification that the change has been made.
>>
>This is something that needs implementation in the project page if it
>isn't already, I will come back to this for the layerdetails page too.
>
>>
>> On 30/01/2015 19:49, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>
>>> Current work in progress available for testing at poky-contrib
>>> michaelw/all-machines
>>>
>>> (If there's no in-line comment it's an item that's still TODO).
>>>
>>> Michael
>>>
>>>>
>>>> * The "Show rows" menu doesn't seem to be working properly. When you
>>>> load
>>>> the page, the table always shows 10 rows, independently of the value
>>>> selected in the "show rows" menu
>>> Fixed
>> Yes: it now shows 10 when you load the page, and there are 10 machines
>> listed per page. But the last selected value doesn't seem to be stored
>>in
>> the cookie. If I select, for example, 50 rows, then visit a couple of
>> other pages, then I go back to the all machines page, the value is set
>> back to 10.
>
>Fixed: 34124b4223b4bda0b238db35161a2e6ba20436f0

>>>> * The machine file information is not coming in
>>> Unfortunately we have no information available on the machine file that
>>> I can find to display
>> We would need to check how the layer index gathers this information, and
>> do the same if we can. This sounds like a nice to have, and it might be,
>> but it is actually a 'very nice' to have. Basically, it is useful to be
>> able to quickly get to the source files if you need to understand what
>> they are doing. Can I ask you to have a chat with Paul to see how we can
>> provide this?
>
>Fixed: I talked to Paul, it does look like we can re-construct the link
>to the conf file, I didn't realise it but this is what the layer index
>does too and I've added it in
>63ceb98ac1b6bc63560665582543394eeff05c2b from some random testing this
>does seem to work.
>
>
>

Re: Review of "all machines" page

[Michael Wood]

Update 2
HEAD @ commit 469c5b7428248935ea3b95228e5292445e34de96
poky-contrib michaelw/all-machines


On 30/01/15 18:49, Michael Wood wrote:
> Current work in progress available for testing at poky-contrib 
> michaelw/all-machines
>
> (If there's no in-line comment it's an item that's still TODO).
>
> Michael
>
> On 06/11/14 16:53, Barros Pena, Belen wrote:
>> I was asked to review the state of all machines page
>> (https://bugzilla.yoctoproject.org/show_bug.cgi?id=6593 currently 
>> assigned
>> to Michael) to give an idea of how much work is left to do. The short
>> answer is: quite a bit.
>>
>> This is the list of issues I've found
>>
>>
>> * The "Show rows" menu doesn't seem to be working properly. When you 
>> load
>> the page, the table always shows 10 rows, independently of the value
>> selected in the "show rows" menu
> Fixed
>
>>
>> * The machine name should not have a blue icon next to it
> Fixed
>>
>> * The machine file information is not coming in
> Unfortunately we have no information available on the machine file 
> that I can find to display
>

Fixed (update 2)

>>
>> * The layer name should be a link to the layer details page
> Fixed
>>
>> * The branch, tag or commit column always shows a commit. For machines
>> coming from layers from the OpenEmbedded layer source, this column 
>> should
>> be showing a branch name instead
>>

Fixed (update 2)


>> * The help text in the "add layer" buttons is currently hardcoded (it
>> shows the same layer name for all machines)
> Fixed
>>
>> * You cannot add layers / select machine functionality is not in place
> Fixed - Apart from the funny tooltip thing will come back to this
>>
>> * The 'layer' column should be sortable (currently isn't)

Fixed (update 2)

>>
>> * Sorting and the "edit columns" menu do not interact as explained in 
>> page
>> 21 of the design document
>>
>> * Sorting by layer source reverts the sorting by machine, setting it 
>> to z
>> to a. This should not happen: when I sort by layer source, machines with
>> the same layer source should be sorted in alphabetical order (a to z)

>>
>> * The "select" column filter is not in place
>>

Fixed (update 2)

>> * When applying a filter, the page heading does not update to show the
>> number of results returned by the filter
>>


Was this for filters or Search? I've implemented it for search but I 
didn't see in the designs the same thing happens for filters.


>> * It doesn't look like the search functionality is in place. When you 
>> try
>> to search, you get an error saying that the "Machine object has no
>> attribute 'search_allowed_fields'". This is the full trace:
> Think this last one is fixed at least I couldn't reproduce it. The no 
> results state is missing.

Re: Review of "all machines" page

[Michael Wood]

Latest Update 3
HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
poky-contrib michaelw/all-machines

>> * In the no results page, the word "Machines" in the heading should not be
>> capitalised, to match all other states of the heading
> Fixed (update 3)

> * Something funny going on with the layers: the openembedded-core layer
> appears as if it is not added to the project, but it is definitely added
> (it is added by default to all our projects). What's worse, when you click
> on 'add layer', you actually end up with 2 openembedded-core layers added
> to the project. When you hover over the second one, it seems to be coming
> from the oe repo, instead of the poky repo, and has not branch. I am not
> sure how up-to-date your branch is with master. If it is fully up-to-date,
> something has broken down with the layers :/

Fixed (update 3)

Yes Alex was explaining that this was likely to happen because we'll see 
duplicates if we get the same layer but from a different source. It's 
going to make the page pretty slow.

>> * Also in the no results page, the "show all machines" link is not
>> working. When you click on it, nothing happens.
> Fixed (update 3)

>>>
>>> * The "Show rows" menu doesn't seem to be working properly. When you 
>>> load
>>> the page, the table always shows 10 rows, independently of the value
>>> selected in the "show rows" menu
>> Fixed
>>
>>>
>>> * The machine name should not have a blue icon next to it
>> Fixed
>>>
>>> * The machine file information is not coming in
>> Unfortunately we have no information available on the machine file 
>> that I can find to display
>>
>
> Fixed (update 2)
>
>>>
>>> * The layer name should be a link to the layer details page
>> Fixed
>>>
>>> * The branch, tag or commit column always shows a commit. For machines
>>> coming from layers from the OpenEmbedded layer source, this column 
>>> should
>>> be showing a branch name instead
>>>
>
> Fixed (update 2)
>
>
>>> * The help text in the "add layer" buttons is currently hardcoded (it
>>> shows the same layer name for all machines)
>> Fixed
>>>
>>> * You cannot add layers / select machine functionality is not in place
>> Fixed - Apart from the funny tooltip thing will come back to this
>>>
>>> * The 'layer' column should be sortable (currently isn't)
>
> Fixed (update 2)
>
>>>
>>> * Sorting and the "edit columns" menu do not interact as explained 
>>> in page
>>> 21 of the design document
>>>
Fixed (update 3)
>>> * Sorting by layer source reverts the sorting by machine, setting it 
>>> to z
>>> to a. This should not happen: when I sort by layer source, machines 
>>> with
>>> the same layer source should be sorted in alphabetical order (a to z)
>

Fixed I think (update 3)

>>>
>>> * The "select" column filter is not in place
>>>
>
> Fixed (update 2)
>
>>> * When applying a filter, the page heading does not update to show the
>>> number of results returned by the filter
>>>
>
>
> Was this for filters or Search? I've implemented it for search but I 
> didn't see in the designs the same thing happens for filters.
> A: Both
Fixed (update 3)


Things coming back to also for layerdetails
  - Funny tooltip thing
  - machine change confirm

Michael

Re: Review of "all machines" page

[Barros Pena, Belen]

On 05/02/2015 19:00, "Michael Wood" <michael.g.wood@intel.com> wrote:

>Latest Update 3
>HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>poky-contrib michaelw/all-machines

The show rows menu seems to be acting up again :/ When you select a value,
nothing happens

>
>> * Something funny going on with the layers: the openembedded-core layer
>> appears as if it is not added to the project, but it is definitely added
>> (it is added by default to all our projects). What's worse, when you
>>click
>> on 'add layer', you actually end up with 2 openembedded-core layers
>>added
>> to the project. When you hover over the second one, it seems to be
>>coming
>> from the oe repo, instead of the poky repo, and has not branch. I am not
>> sure how up-to-date your branch is with master. If it is fully
>>up-to-date,
>> something has broken down with the layers :/
>
>Fixed (update 3)

It's not working for me: the machines provided by layers added to the
project now don't show at all in the all machines page. You can check it
out using the filter in the 'select' column. It says that the number of
machines provided by layers added to the project is 0.

>>>> * Sorting by layer source reverts the sorting by machine, setting it
>>>> to z
>>>> to a. This should not happen: when I sort by layer source, machines
>>>> with
>>>> the same layer source should be sorted in alphabetical order (a to z)
>>
>
>Fixed I think (update 3)

It's not working for me. When I sort by layer source, I still get the zynq
machine at the top of the page (sorting by that column is also sorting the
machines from z to a for some reason).

>
>>>>
>>>> * The "select" column filter is not in place
>>>>
>>
>> Fixed (update 2)
>>
>>>> * When applying a filter, the page heading does not update to show the
>>>> number of results returned by the filter
>>>>
>>
>>
>> Was this for filters or Search? I've implemented it for search but I
>> didn't see in the designs the same thing happens for filters.
>> A: Both
>Fixed (update 3)
>
>
>Things coming back to also for layerdetails
>  - Funny tooltip thing
>  - machine change confirm

Do you want me to open issues for this?

Thanks!!

Belén

>
>Michael

[review-request] michaelw/all-machines

[Michael Wood]

poky-contrib michaelw/all-machines

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=michaelw/all-machines

(for anyone else following, the issues below were due to a browser 
issue/data import)

On 06/02/15 11:28, Barros Pena, Belen wrote:
> On 05/02/2015 19:00, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> Latest Update 3
>> HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>> poky-contrib michaelw/all-machines
> The show rows menu seems to be acting up again :/ When you select a value,
> nothing happens
>
>>> * Something funny going on with the layers: the openembedded-core layer
>>> appears as if it is not added to the project, but it is definitely added
>>> (it is added by default to all our projects). What's worse, when you
>>> click
>>> on 'add layer', you actually end up with 2 openembedded-core layers
>>> added
>>> to the project. When you hover over the second one, it seems to be
>>> coming
>>> from the oe repo, instead of the poky repo, and has not branch. I am not
>>> sure how up-to-date your branch is with master. If it is fully
>>> up-to-date,
>>> something has broken down with the layers :/
>> Fixed (update 3)
> It's not working for me: the machines provided by layers added to the
> project now don't show at all in the all machines page. You can check it
> out using the filter in the 'select' column. It says that the number of
> machines provided by layers added to the project is 0.
>
>>>>> * Sorting by layer source reverts the sorting by machine, setting it
>>>>> to z
>>>>> to a. This should not happen: when I sort by layer source, machines
>>>>> with
>>>>> the same layer source should be sorted in alphabetical order (a to z)
>> Fixed I think (update 3)
> It's not working for me. When I sort by layer source, I still get the zynq
> machine at the top of the page (sorting by that column is also sorting the
> machines from z to a for some reason).
>
>>>>> * The "select" column filter is not in place
>>>>>
>>> Fixed (update 2)
>>>
>>>>> * When applying a filter, the page heading does not update to show the
>>>>> number of results returned by the filter
>>>>>
>>>
>>> Was this for filters or Search? I've implemented it for search but I
>>> didn't see in the designs the same thing happens for filters.
>>> A: Both
>> Fixed (update 3)
>>
>>
>> Things coming back to also for layerdetails
>>   - Funny tooltip thing
>>   - machine change confirm
> Do you want me to open issues for this?
>
> Thanks!!
>
> Belén
>
>> Michael

Re: [review-request] michaelw/all-machines

[Barros Pena, Belen]

On 06/02/2015 16:04, "Michael Wood" <michael.g.wood@intel.com> wrote:

>poky-contrib michaelw/all-machines
>
>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=michaelw/all
>-machines
>
>(for anyone else following, the issues below were due to a browser
>issue/data import)

Yep, that it's true. All UI issues are fixed now.

>
>On 06/02/15 11:28, Barros Pena, Belen wrote:
>> On 05/02/2015 19:00, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>
>>> Latest Update 3
>>> HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>>> poky-contrib michaelw/all-machines
>> The show rows menu seems to be acting up again :/ When you select a
>>value,
>> nothing happens
>>
>>>> * Something funny going on with the layers: the openembedded-core
>>>>layer
>>>> appears as if it is not added to the project, but it is definitely
>>>>added
>>>> (it is added by default to all our projects). What's worse, when you
>>>> click
>>>> on 'add layer', you actually end up with 2 openembedded-core layers
>>>> added
>>>> to the project. When you hover over the second one, it seems to be
>>>> coming
>>>> from the oe repo, instead of the poky repo, and has not branch. I am
>>>>not
>>>> sure how up-to-date your branch is with master. If it is fully
>>>> up-to-date,
>>>> something has broken down with the layers :/
>>> Fixed (update 3)
>> It's not working for me: the machines provided by layers added to the
>> project now don't show at all in the all machines page. You can check it
>> out using the filter in the 'select' column. It says that the number of
>> machines provided by layers added to the project is 0.
>>
>>>>>> * Sorting by layer source reverts the sorting by machine, setting it
>>>>>> to z
>>>>>> to a. This should not happen: when I sort by layer source, machines
>>>>>> with
>>>>>> the same layer source should be sorted in alphabetical order (a to
>>>>>>z)
>>> Fixed I think (update 3)
>> It's not working for me. When I sort by layer source, I still get the
>>zynq
>> machine at the top of the page (sorting by that column is also sorting
>>the
>> machines from z to a for some reason).
>>
>>>>>> * The "select" column filter is not in place
>>>>>>
>>>> Fixed (update 2)
>>>>
>>>>>> * When applying a filter, the page heading does not update to show
>>>>>>the
>>>>>> number of results returned by the filter
>>>>>>
>>>>
>>>> Was this for filters or Search? I've implemented it for search but I
>>>> didn't see in the designs the same thing happens for filters.
>>>> A: Both
>>> Fixed (update 3)
>>>
>>>
>>> Things coming back to also for layerdetails
>>>   - Funny tooltip thing
>>>   - machine change confirm
>> Do you want me to open issues for this?
>>
>> Thanks!!
>>
>> Belén
>>
>>> Michael
>

Re: [review-request] michaelw/all-machines

[Michael Wood]

One commit was missing and has now been added to the branch, if it's 
easier I can submit this a separate patch.

commit ab531d30f7a1bef411d50491e5341671f97120ce
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Mon Feb 9 13:54:14 2015 +0000

     bitbake: toaster: All machines Fix filter counts

     Filter counts needed to take into account the filters that had
     previously been applied.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>


Thanks,

Michael

On 06/02/15 16:08, Barros Pena, Belen wrote:
> On 06/02/2015 16:04, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> poky-contrib michaelw/all-machines
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=michaelw/all
>> -machines
>>
>> (for anyone else following, the issues below were due to a browser
>> issue/data import)
> Yep, that it's true. All UI issues are fixed now.
>
>> On 06/02/15 11:28, Barros Pena, Belen wrote:
>>> On 05/02/2015 19:00, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>>
>>>> Latest Update 3
>>>> HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>>>> poky-contrib michaelw/all-machines
>>> The show rows menu seems to be acting up again :/ When you select a
>>> value,
>>> nothing happens
>>>
>>>>> * Something funny going on with the layers: the openembedded-core
>>>>> layer
>>>>> appears as if it is not added to the project, but it is definitely
>>>>> added
>>>>> (it is added by default to all our projects). What's worse, when you
>>>>> click
>>>>> on 'add layer', you actually end up with 2 openembedded-core layers
>>>>> added
>>>>> to the project. When you hover over the second one, it seems to be
>>>>> coming
>>>>> from the oe repo, instead of the poky repo, and has not branch. I am
>>>>> not
>>>>> sure how up-to-date your branch is with master. If it is fully
>>>>> up-to-date,
>>>>> something has broken down with the layers :/
>>>> Fixed (update 3)
>>> It's not working for me: the machines provided by layers added to the
>>> project now don't show at all in the all machines page. You can check it
>>> out using the filter in the 'select' column. It says that the number of
>>> machines provided by layers added to the project is 0.
>>>
>>>>>>> * Sorting by layer source reverts the sorting by machine, setting it
>>>>>>> to z
>>>>>>> to a. This should not happen: when I sort by layer source, machines
>>>>>>> with
>>>>>>> the same layer source should be sorted in alphabetical order (a to
>>>>>>> z)
>>>> Fixed I think (update 3)
>>> It's not working for me. When I sort by layer source, I still get the
>>> zynq
>>> machine at the top of the page (sorting by that column is also sorting
>>> the
>>> machines from z to a for some reason).
>>>
>>>>>>> * The "select" column filter is not in place
>>>>>>>
>>>>> Fixed (update 2)
>>>>>
>>>>>>> * When applying a filter, the page heading does not update to show
>>>>>>> the
>>>>>>> number of results returned by the filter
>>>>>>>
>>>>> Was this for filters or Search? I've implemented it for search but I
>>>>> didn't see in the designs the same thing happens for filters.
>>>>> A: Both
>>>> Fixed (update 3)
>>>>
>>>>
>>>> Things coming back to also for layerdetails
>>>>    - Funny tooltip thing
>>>>    - machine change confirm
>>> Do you want me to open issues for this?
>>>
>>> Thanks!!
>>>
>>> Belén
>>>
>>>> Michael

Re: [review-request] michaelw/all-machines

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 4016 bytes --]

Hello,

I've picked this up for submission with manual merges.

Thank you !

Alex

On Mon, Feb 9, 2015 at 2:00 PM, Michael Wood <michael.g.wood@intel.com>
wrote:

> One commit was missing and has now been added to the branch, if it's
> easier I can submit this a separate patch.
>
> commit ab531d30f7a1bef411d50491e5341671f97120ce
> Author: Michael Wood <michael.g.wood@intel.com>
> Date:   Mon Feb 9 13:54:14 2015 +0000
>
>     bitbake: toaster: All machines Fix filter counts
>
>     Filter counts needed to take into account the filters that had
>     previously been applied.
>
>     Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>
>
> Thanks,
>
> Michael
>
>
> On 06/02/15 16:08, Barros Pena, Belen wrote:
>
>> On 06/02/2015 16:04, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>
>>  poky-contrib michaelw/all-machines
>>>
>>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/
>>> log/?h=michaelw/all
>>> -machines
>>>
>>> (for anyone else following, the issues below were due to a browser
>>> issue/data import)
>>>
>> Yep, that it's true. All UI issues are fixed now.
>>
>>  On 06/02/15 11:28, Barros Pena, Belen wrote:
>>>
>>>> On 05/02/2015 19:00, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>>>
>>>>  Latest Update 3
>>>>> HEAD cd28aecfa1119d31b085ff7eb4447e138ac76eb2
>>>>> poky-contrib michaelw/all-machines
>>>>>
>>>> The show rows menu seems to be acting up again :/ When you select a
>>>> value,
>>>> nothing happens
>>>>
>>>>  * Something funny going on with the layers: the openembedded-core
>>>>>> layer
>>>>>> appears as if it is not added to the project, but it is definitely
>>>>>> added
>>>>>> (it is added by default to all our projects). What's worse, when you
>>>>>> click
>>>>>> on 'add layer', you actually end up with 2 openembedded-core layers
>>>>>> added
>>>>>> to the project. When you hover over the second one, it seems to be
>>>>>> coming
>>>>>> from the oe repo, instead of the poky repo, and has not branch. I am
>>>>>> not
>>>>>> sure how up-to-date your branch is with master. If it is fully
>>>>>> up-to-date,
>>>>>> something has broken down with the layers :/
>>>>>>
>>>>> Fixed (update 3)
>>>>>
>>>> It's not working for me: the machines provided by layers added to the
>>>> project now don't show at all in the all machines page. You can check it
>>>> out using the filter in the 'select' column. It says that the number of
>>>> machines provided by layers added to the project is 0.
>>>>
>>>>  * Sorting by layer source reverts the sorting by machine, setting it
>>>>>>>> to z
>>>>>>>> to a. This should not happen: when I sort by layer source, machines
>>>>>>>> with
>>>>>>>> the same layer source should be sorted in alphabetical order (a to
>>>>>>>> z)
>>>>>>>>
>>>>>>> Fixed I think (update 3)
>>>>>
>>>> It's not working for me. When I sort by layer source, I still get the
>>>> zynq
>>>> machine at the top of the page (sorting by that column is also sorting
>>>> the
>>>> machines from z to a for some reason).
>>>>
>>>>  * The "select" column filter is not in place
>>>>>>>>
>>>>>>>>  Fixed (update 2)
>>>>>>
>>>>>>  * When applying a filter, the page heading does not update to show
>>>>>>>> the
>>>>>>>> number of results returned by the filter
>>>>>>>>
>>>>>>>>  Was this for filters or Search? I've implemented it for search but
>>>>>> I
>>>>>> didn't see in the designs the same thing happens for filters.
>>>>>> A: Both
>>>>>>
>>>>> Fixed (update 3)
>>>>>
>>>>>
>>>>> Things coming back to also for layerdetails
>>>>>    - Funny tooltip thing
>>>>>    - machine change confirm
>>>>>
>>>> Do you want me to open issues for this?
>>>>
>>>> Thanks!!
>>>>
>>>> Belén
>>>>
>>>>  Michael
>>>>>
>>>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 7473 bytes --]