[PATCH v2 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

[PATCH v2 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

[Yakir Yang]

The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
Changes in v2:
- Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel

 .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt

diff --git a/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
new file mode 100644
index 0000000..4214151
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
@@ -0,0 +1,7 @@
+LG 9.7" (2048x1536 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "lg,lp097qx1-spa1"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

[Yakir Yang]

The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v2:
- Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel

 .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt

diff --git a/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
new file mode 100644
index 0000000..4214151
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
@@ -0,0 +1,7 @@
+LG 9.7" (2048x1536 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "lg,lp097qx1-spa1"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1

[PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Yakir Yang]

The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2: None

 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3a7bdf1..41020e1 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
 	},
 };
 
+static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
+	.clock = 205210,
+	.hdisplay = 2048,
+	.hsync_start = 2048 + 150,
+	.hsync_end = 2048 + 150 + 5,
+	.htotal = 2048 + 150 + 5 + 5,
+	.vdisplay = 1536,
+	.vsync_start = 1536 + 3,
+	.vsync_end = 1536 + 3 + 1,
+	.vtotal = 1536 + 3 + 1 + 9,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc lg_lp097qx1_spa1 = {
+	.modes = &lg_lp097qx1_spa1_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 2048,
+		.height = 1536,
+	},
+};
+
 static const struct drm_display_mode lg_lp129qe_mode = {
 	.clock = 285250,
 	.hdisplay = 2560,
@@ -1460,6 +1482,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "lg,lp120up1",
 		.data = &lg_lp120up1,
 	}, {
+		.compatible = "lg,lp097qx1-spa1",
+		.data = &lg_lp097qx1_spa1,
+	}, {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
 	}, {
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Yakir Yang]

The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2: None

 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3a7bdf1..41020e1 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
 	},
 };
 
+static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
+	.clock = 205210,
+	.hdisplay = 2048,
+	.hsync_start = 2048 + 150,
+	.hsync_end = 2048 + 150 + 5,
+	.htotal = 2048 + 150 + 5 + 5,
+	.vdisplay = 1536,
+	.vsync_start = 1536 + 3,
+	.vsync_end = 1536 + 3 + 1,
+	.vtotal = 1536 + 3 + 1 + 9,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc lg_lp097qx1_spa1 = {
+	.modes = &lg_lp097qx1_spa1_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 2048,
+		.height = 1536,
+	},
+};
+
 static const struct drm_display_mode lg_lp129qe_mode = {
 	.clock = 285250,
 	.hdisplay = 2560,
@@ -1460,6 +1482,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "lg,lp120up1",
 		.data = &lg_lp120up1,
 	}, {
+		.compatible = "lg,lp097qx1-spa1",
+		.data = &lg_lp097qx1_spa1,
+	}, {
 		.compatible = "lg,lp129qe",
 		.data = &lg_lp129qe,
 	}, {
-- 
1.9.1

Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Emil Velikov]

Hi Yakir,

On 8 June 2016 at 12:52, Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> Changes in v2: None
>
>  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3a7bdf1..41020e1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
>         },
>  };
>
> +static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1.

> +static const struct panel_desc lg_lp097qx1_spa1 = {
> +       .modes = &lg_lp097qx1_spa1_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 2048,
> +               .height = 1536,
These are the physical dimensions of the panel. From the documentation
(at the top of the file)

@width: width (in millimeters) of the panel's active display area
...

Thierry, perhaps it's worth renaming 'size' it to
"physical_{size,dimensions}" and/or alike to make it clearer ?
Looks like we have a few cases were people got confused -
innolux_zj070na_01p and samsung_ltn101nt05.

Regards,
Emil
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Emil Velikov]

Hi Yakir,

On 8 June 2016 at 12:52, Yakir Yang <ykk@rock-chips.com> wrote:
> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2: None
>
>  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3a7bdf1..41020e1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
>         },
>  };
>
> +static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1.

> +static const struct panel_desc lg_lp097qx1_spa1 = {
> +       .modes = &lg_lp097qx1_spa1_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 2048,
> +               .height = 1536,
These are the physical dimensions of the panel. From the documentation
(at the top of the file)

@width: width (in millimeters) of the panel's active display area
...

Thierry, perhaps it's worth renaming 'size' it to
"physical_{size,dimensions}" and/or alike to make it clearer ?
Looks like we have a few cases were people got confused -
innolux_zj070na_01p and samsung_ltn101nt05.

Regards,
Emil

Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]

On Wed, Jun 08, 2016 at 01:20:22PM +0100, Emil Velikov wrote:
> Hi Yakir,
> 
> On 8 June 2016 at 12:52, Yakir Yang <ykk@rock-chips.com> wrote:
> > The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
> > connected using eDP interfaces.
> >
> > Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> > ---
> > Changes in v2: None
> >
> >  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 3a7bdf1..41020e1 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
> >         },
> >  };
> >
> > +static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
> I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1.
> 
> > +static const struct panel_desc lg_lp097qx1_spa1 = {
> > +       .modes = &lg_lp097qx1_spa1_mode,
> > +       .num_modes = 1,
> > +       .size = {
> > +               .width = 2048,
> > +               .height = 1536,
> These are the physical dimensions of the panel. From the documentation
> (at the top of the file)
> 
> @width: width (in millimeters) of the panel's active display area
> ...
> 
> Thierry, perhaps it's worth renaming 'size' it to
> "physical_{size,dimensions}" and/or alike to make it clearer ?

I like size because it's nice and short, and it's accurate. 2048x1536 is
a resolution, not a size. Like you said, it's already documented, and if
people looked at other descriptors they should realize that it's not the
same as the horizontal and vertical resolutions.

> Looks like we have a few cases were people got confused -
> innolux_zj070na_01p and samsung_ltn101nt05.

Yeah, well, I'm to blame for that, I should've reviewed more carefully.
Thanks for bringing that to my attention, I'll go fix those up.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Yakir Yang]

Emil,

On 06/08/2016 08:20 PM, Emil Velikov wrote:
> Hi Yakir,
>
> On 8 June 2016 at 12:52, Yakir Yang <ykk@rock-chips.com> wrote:
>> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2: None
>>
>>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 3a7bdf1..41020e1 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
>>          },
>>   };
>>
>> +static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
> I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1.

Ah, yes, done  :)

>> +static const struct panel_desc lg_lp097qx1_spa1 = {
>> +       .modes = &lg_lp097qx1_spa1_mode,
>> +       .num_modes = 1,
>> +       .size = {
>> +               .width = 2048,
>> +               .height = 1536,
> These are the physical dimensions of the panel. From the documentation
> (at the top of the file)
>
> @width: width (in millimeters) of the panel's active display area
> ...

Got it, this should be the "display area"
Display area     262.656(H) X 164.16(V)         (12.2”diagonal)

Thanks,
- Yakir

>
> Thierry, perhaps it's worth renaming 'size' it to
> "physical_{size,dimensions}" and/or alike to make it clearer ?
> Looks like we have a few cases were people got confused -
> innolux_zj070na_01p and samsung_ltn101nt05.
>
> Regards,
> Emil
>
>
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel

[Yakir Yang]

Emil,

On 06/08/2016 08:20 PM, Emil Velikov wrote:
> Hi Yakir,
>
> On 8 June 2016 at 12:52, Yakir Yang <ykk@rock-chips.com> wrote:
>> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2: None
>>
>>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 3a7bdf1..41020e1 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1040,6 +1040,28 @@ static const struct panel_desc lg_lp120up1 = {
>>          },
>>   };
>>
>> +static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
> I believe that lg_lp097qx1_spa1 should be moved/sorted before lg_lp120up1.

Ah, yes, done  :)

>> +static const struct panel_desc lg_lp097qx1_spa1 = {
>> +       .modes = &lg_lp097qx1_spa1_mode,
>> +       .num_modes = 1,
>> +       .size = {
>> +               .width = 2048,
>> +               .height = 1536,
> These are the physical dimensions of the panel. From the documentation
> (at the top of the file)
>
> @width: width (in millimeters) of the panel's active display area
> ...

Got it, this should be the "display area"
Display area     262.656(H) X 164.16(V)         (12.2”diagonal)

Thanks,
- Yakir

>
> Thierry, perhaps it's worth renaming 'size' it to
> "physical_{size,dimensions}" and/or alike to make it clearer ?
> Looks like we have a few cases were people got confused -
> innolux_zj070na_01p and samsung_ltn101nt05.
>
> Regards,
> Emil
>
>
>

[PATCH v2 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding

[Yakir Yang]

The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD
panel connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v2:
- Add Rob's acked for dt-bindings of Samsung LSN122DL01 panel

 .../devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt   | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt b/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt
new file mode 100644
index 0000000..dba298b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt
@@ -0,0 +1,7 @@
+Samsung 12.2" (2560x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "samsung,lsn122dl01-c01"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding

[Yakir Yang]

The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD
panel connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v2:
- Add Rob's acked for dt-bindings of Samsung LSN122DL01 panel

 .../devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt   | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt b/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt
new file mode 100644
index 0000000..dba298b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt
@@ -0,0 +1,7 @@
+Samsung 12.2" (2560x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "samsung,lsn122dl01-c01"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1

[PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

[Yakir Yang]

The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2: None

 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 41020e1..067a5c4 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
+	.clock = 271560,
+	.hdisplay = 2560,
+	.hsync_start = 2560 + 48,
+	.hsync_end = 2560 + 48 + 32,
+	.htotal = 2560 + 48 + 32 + 80,
+	.vdisplay = 1600,
+	.vsync_start = 1600 + 2,
+	.vsync_end = 1600 + 2 + 5,
+	.vtotal = 1600 + 2 + 5 + 57,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc samsung_lsn122dl01_c01 = {
+	.modes = &samsung_lsn122dl01_c01_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 2560,
+		.height = 1600,
+	},
+};
+
 static const struct drm_display_mode samsung_ltn101nt05_mode = {
 	.clock = 54030,
 	.hdisplay = 1024,
@@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "qiaodian,qd43003c0-40",
 		.data = &qd43003c0_40,
 	}, {
+		.compatible = "samsung,lsn122dl01-c01",
+		.data = &samsung_lsn122dl01_c01,
+	}, {
 		.compatible = "samsung,ltn101nt05",
 		.data = &samsung_ltn101nt05,
 	}, {
-- 
1.9.1

Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

[Stéphane Marchesin]

On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org> wrote:
> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> Changes in v2: None
>
>  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 41020e1..067a5c4 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>         .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>
> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> +       .clock = 271560,
> +       .hdisplay = 2560,
> +       .hsync_start = 2560 + 48,
> +       .hsync_end = 2560 + 48 + 32,
> +       .htotal = 2560 + 48 + 32 + 80,
> +       .vdisplay = 1600,
> +       .vsync_start = 1600 + 2,
> +       .vsync_end = 1600 + 2 + 5,
> +       .vtotal = 1600 + 2 + 5 + 57,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_desc samsung_lsn122dl01_c01 = {
> +       .modes = &samsung_lsn122dl01_c01_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 2560,
> +               .height = 1600,

These are meant to be the physical dimensions (same thing for the
other patches btw).

Stéphane

> +       },
> +};
> +
>  static const struct drm_display_mode samsung_ltn101nt05_mode = {
>         .clock = 54030,
>         .hdisplay = 1024,
> @@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
>                 .compatible = "qiaodian,qd43003c0-40",
>                 .data = &qd43003c0_40,
>         }, {
> +               .compatible = "samsung,lsn122dl01-c01",
> +               .data = &samsung_lsn122dl01_c01,
> +       }, {
>                 .compatible = "samsung,ltn101nt05",
>                 .data = &samsung_ltn101nt05,
>         }, {
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

[Stéphane Marchesin]

On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2: None
>
>  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 41020e1..067a5c4 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>         .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>
> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> +       .clock = 271560,
> +       .hdisplay = 2560,
> +       .hsync_start = 2560 + 48,
> +       .hsync_end = 2560 + 48 + 32,
> +       .htotal = 2560 + 48 + 32 + 80,
> +       .vdisplay = 1600,
> +       .vsync_start = 1600 + 2,
> +       .vsync_end = 1600 + 2 + 5,
> +       .vtotal = 1600 + 2 + 5 + 57,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_desc samsung_lsn122dl01_c01 = {
> +       .modes = &samsung_lsn122dl01_c01_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 2560,
> +               .height = 1600,

These are meant to be the physical dimensions (same thing for the
other patches btw).

Stéphane

> +       },
> +};
> +
>  static const struct drm_display_mode samsung_ltn101nt05_mode = {
>         .clock = 54030,
>         .hdisplay = 1024,
> @@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
>                 .compatible = "qiaodian,qd43003c0-40",
>                 .data = &qd43003c0_40,
>         }, {
> +               .compatible = "samsung,lsn122dl01-c01",
> +               .data = &samsung_lsn122dl01_c01,
> +       }, {
>                 .compatible = "samsung,ltn101nt05",
>                 .data = &samsung_ltn101nt05,
>         }, {
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

[Yakir Yang]

Stéphane,

On 06/10/2016 08:04 AM, Stéphane Marchesin wrote:
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2: None
>>
>>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 41020e1..067a5c4 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>>          .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>>   };
>>
>> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
>> +       .clock = 271560,
>> +       .hdisplay = 2560,
>> +       .hsync_start = 2560 + 48,
>> +       .hsync_end = 2560 + 48 + 32,
>> +       .htotal = 2560 + 48 + 32 + 80,
>> +       .vdisplay = 1600,
>> +       .vsync_start = 1600 + 2,
>> +       .vsync_end = 1600 + 2 + 5,
>> +       .vtotal = 1600 + 2 + 5 + 57,
>> +       .vrefresh = 60,
>> +};
>> +
>> +static const struct panel_desc samsung_lsn122dl01_c01 = {
>> +       .modes = &samsung_lsn122dl01_c01_mode,
>> +       .num_modes = 1,
>> +       .size = {
>> +               .width = 2560,
>> +               .height = 1600,
> These are meant to be the physical dimensions (same thing for the
> other patches btw).

Got it, so this should be the "active area" in panel book.
Display area     262.656(H) X 164.16(V)         (12.2”diagonal)


Thanks,
-Yakir

> Stéphane
>
>> +       },
>> +};
>> +
>>   static const struct drm_display_mode samsung_ltn101nt05_mode = {
>>          .clock = 54030,
>>          .hdisplay = 1024,
>> @@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
>>                  .compatible = "qiaodian,qd43003c0-40",
>>                  .data = &qd43003c0_40,
>>          }, {
>> +               .compatible = "samsung,lsn122dl01-c01",
>> +               .data = &samsung_lsn122dl01_c01,
>> +       }, {
>>                  .compatible = "samsung,ltn101nt05",
>>                  .data = &samsung_ltn101nt05,
>>          }, {
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel

[Yakir Yang]

Stéphane,

On 06/10/2016 08:04 AM, Stéphane Marchesin wrote:
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2: None
>>
>>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 41020e1..067a5c4 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>>          .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>>   };
>>
>> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
>> +       .clock = 271560,
>> +       .hdisplay = 2560,
>> +       .hsync_start = 2560 + 48,
>> +       .hsync_end = 2560 + 48 + 32,
>> +       .htotal = 2560 + 48 + 32 + 80,
>> +       .vdisplay = 1600,
>> +       .vsync_start = 1600 + 2,
>> +       .vsync_end = 1600 + 2 + 5,
>> +       .vtotal = 1600 + 2 + 5 + 57,
>> +       .vrefresh = 60,
>> +};
>> +
>> +static const struct panel_desc samsung_lsn122dl01_c01 = {
>> +       .modes = &samsung_lsn122dl01_c01_mode,
>> +       .num_modes = 1,
>> +       .size = {
>> +               .width = 2560,
>> +               .height = 1600,
> These are meant to be the physical dimensions (same thing for the
> other patches btw).

Got it, so this should be the "active area" in panel book.
Display area     262.656(H) X 164.16(V)         (12.2”diagonal)


Thanks,
-Yakir

> Stéphane
>
>> +       },
>> +};
>> +
>>   static const struct drm_display_mode samsung_ltn101nt05_mode = {
>>          .clock = 54030,
>>          .hdisplay = 1024,
>> @@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
>>                  .compatible = "qiaodian,qd43003c0-40",
>>                  .data = &qd43003c0_40,
>>          }, {
>> +               .compatible = "samsung,lsn122dl01-c01",
>> +               .data = &samsung_lsn122dl01_c01,
>> +       }, {
>>                  .compatible = "samsung,ltn101nt05",
>>                  .data = &samsung_ltn101nt05,
>>          }, {
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>

[PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Yakir Yang]

The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2:
- Add dt-bindings of Sharp LQ123P1JX31 panel in v2

 .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
new file mode 100644
index 0000000..81938c0
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
@@ -0,0 +1,7 @@
+Sharp 12.3" (2400x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "sharp,lq123p1jx31,"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Yakir Yang]

The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2:
- Add dt-bindings of Sharp LQ123P1JX31 panel in v2

 .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
new file mode 100644
index 0000000..81938c0
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
@@ -0,0 +1,7 @@
+Sharp 12.3" (2400x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "sharp,lq123p1jx31,"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Doug Anderson]

Yakir,

On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2:
> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>
>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>  1 file changed, 7 insertions(+)

Seems sane to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Doug Anderson]

Yakir,

On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2:
> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>
>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>  1 file changed, 7 insertions(+)

Seems sane to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Rob Herring]

On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
> connected using eDP interfaces.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2:
> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
> 
>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
> new file mode 100644
> index 0000000..81938c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
> @@ -0,0 +1,7 @@
> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "sharp,lq123p1jx31,"
                                             ^
Need to drop the comma.

No regulators or resets or pwms?

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Rob Herring]

On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
> connected using eDP interfaces.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2:
> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
> 
>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
> new file mode 100644
> index 0000000..81938c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
> @@ -0,0 +1,7 @@
> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "sharp,lq123p1jx31,"
                                             ^
Need to drop the comma.

No regulators or resets or pwms?

Rob

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Doug Anderson]

Rob,

On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2:
>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>
>>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>> new file mode 100644
>> index 0000000..81938c0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>> @@ -0,0 +1,7 @@
>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>> +
>> +Required properties:
>> +- compatible: should be "sharp,lq123p1jx31,"
>                                              ^
> Need to drop the comma.

Thanks for catching!

> No regulators or resets or pwms?

Could be more explicit I guess, but Yakir does say:

> This binding is compatible with the simple-panel binding, which is specified
> in simple-panel.txt in this directory.

In that document it shows:

Required properties:
- power-supply: regulator to provide the supply voltage

Optional properties:
- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
- enable-gpios: GPIO pin to enable or disable the panel
- backlight: phandle of the backlight device attached to the panel


In general Yakir's bindings document match a huge chunk of the current
existing bindings.  Do this:
  cd Documentation/devicetree/bindings/display/panel
  grep -C20 "This binding is compatible with the simple-panel" *

You'll find a huge chunk of files which are rather formulaic.  It
might make sense to just have one file and a list of panels which are
simple panels?


-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Doug Anderson]

Rob,

On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2:
>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>
>>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>> new file mode 100644
>> index 0000000..81938c0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>> @@ -0,0 +1,7 @@
>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>> +
>> +Required properties:
>> +- compatible: should be "sharp,lq123p1jx31,"
>                                              ^
> Need to drop the comma.

Thanks for catching!

> No regulators or resets or pwms?

Could be more explicit I guess, but Yakir does say:

> This binding is compatible with the simple-panel binding, which is specified
> in simple-panel.txt in this directory.

In that document it shows:

Required properties:
- power-supply: regulator to provide the supply voltage

Optional properties:
- ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
- enable-gpios: GPIO pin to enable or disable the panel
- backlight: phandle of the backlight device attached to the panel


In general Yakir's bindings document match a huge chunk of the current
existing bindings.  Do this:
  cd Documentation/devicetree/bindings/display/panel
  grep -C20 "This binding is compatible with the simple-panel" *

You'll find a huge chunk of files which are rather formulaic.  It
might make sense to just have one file and a list of panels which are
simple panels?


-Doug

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Rob Herring]

On Fri, Jun 10, 2016 at 11:40 AM, Doug Anderson <dianders@chromium.org> wrote:
> Rob,
>
> On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
>> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>>> connected using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>>
>>>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> new file mode 100644
>>> index 0000000..81938c0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> @@ -0,0 +1,7 @@
>>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq123p1jx31,"
>>                                              ^
>> Need to drop the comma.
>
> Thanks for catching!
>
>> No regulators or resets or pwms?
>
> Could be more explicit I guess, but Yakir does say:
>
>> This binding is compatible with the simple-panel binding, which is specified
>> in simple-panel.txt in this directory.
>
> In that document it shows:
>
> Required properties:
> - power-supply: regulator to provide the supply voltage
>
> Optional properties:
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - enable-gpios: GPIO pin to enable or disable the panel
> - backlight: phandle of the backlight device attached to the panel

Ah yes, NM.

> In general Yakir's bindings document match a huge chunk of the current
> existing bindings.  Do this:
>   cd Documentation/devicetree/bindings/display/panel
>   grep -C20 "This binding is compatible with the simple-panel" *
>
> You'll find a huge chunk of files which are rather formulaic.  It
> might make sense to just have one file and a list of panels which are
> simple panels?

If we're just documenting compatible strings, then maybe so.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Rob Herring]

On Fri, Jun 10, 2016 at 11:40 AM, Doug Anderson <dianders@chromium.org> wrote:
> Rob,
>
> On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
>> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>>> connected using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>>
>>>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> new file mode 100644
>>> index 0000000..81938c0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> @@ -0,0 +1,7 @@
>>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq123p1jx31,"
>>                                              ^
>> Need to drop the comma.
>
> Thanks for catching!
>
>> No regulators or resets or pwms?
>
> Could be more explicit I guess, but Yakir does say:
>
>> This binding is compatible with the simple-panel binding, which is specified
>> in simple-panel.txt in this directory.
>
> In that document it shows:
>
> Required properties:
> - power-supply: regulator to provide the supply voltage
>
> Optional properties:
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - enable-gpios: GPIO pin to enable or disable the panel
> - backlight: phandle of the backlight device attached to the panel

Ah yes, NM.

> In general Yakir's bindings document match a huge chunk of the current
> existing bindings.  Do this:
>   cd Documentation/devicetree/bindings/display/panel
>   grep -C20 "This binding is compatible with the simple-panel" *
>
> You'll find a huge chunk of files which are rather formulaic.  It
> might make sense to just have one file and a list of panels which are
> simple panels?

If we're just documenting compatible strings, then maybe so.

Rob

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Doug Anderson]

Hi,

On Fri, Jun 10, 2016 at 10:54 AM, Rob Herring <robh@kernel.org> wrote:
>> In general Yakir's bindings document match a huge chunk of the current
>> existing bindings.  Do this:
>>   cd Documentation/devicetree/bindings/display/panel
>>   grep -C20 "This binding is compatible with the simple-panel" *
>>
>> You'll find a huge chunk of files which are rather formulaic.  It
>> might make sense to just have one file and a list of panels which are
>> simple panels?
>
> If we're just documenting compatible strings, then maybe so.

I'm happy to post such a patch if folks would prefer.  ...but since
it's the kind of patch that is nearly certain to produce conflicts /
miss in-flight patches, it might make sense for one of the maintainers
of this directory write/post it at the most expedient time and manage
transitions.  I'm OK either way, so just let me know.

Until that happens, I'd presume that the best course of action is to
keep posting bindings using the current formulaic approach and to
deviate as little as possible from the formula to make later
unification easier.  ;)


Thanks!

-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Doug Anderson]

Hi,

On Fri, Jun 10, 2016 at 10:54 AM, Rob Herring <robh@kernel.org> wrote:
>> In general Yakir's bindings document match a huge chunk of the current
>> existing bindings.  Do this:
>>   cd Documentation/devicetree/bindings/display/panel
>>   grep -C20 "This binding is compatible with the simple-panel" *
>>
>> You'll find a huge chunk of files which are rather formulaic.  It
>> might make sense to just have one file and a list of panels which are
>> simple panels?
>
> If we're just documenting compatible strings, then maybe so.

I'm happy to post such a patch if folks would prefer.  ...but since
it's the kind of patch that is nearly certain to produce conflicts /
miss in-flight patches, it might make sense for one of the maintainers
of this directory write/post it at the most expedient time and manage
transitions.  I'm OK either way, so just let me know.

Until that happens, I'd presume that the best course of action is to
keep posting bindings using the current formulaic approach and to
deviate as little as possible from the formula to make later
unification easier.  ;)


Thanks!

-Doug

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Yakir Yang]

On 06/11/2016 12:40 AM, Doug Anderson wrote:
> Rob,
>
> On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
>> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>>> connected using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>>
>>>   .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> new file mode 100644
>>> index 0000000..81938c0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> @@ -0,0 +1,7 @@
>>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq123p1jx31,"
>>                                               ^
>> Need to drop the comma.
> Thanks for catching!

Done,

>
>> No regulators or resets or pwms?
> Could be more explicit I guess, but Yakir does say:
>
>> This binding is compatible with the simple-panel binding, which is specified
>> in simple-panel.txt in this directory.
> In that document it shows:
>
> Required properties:
> - power-supply: regulator to provide the supply voltage
>
> Optional properties:
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - enable-gpios: GPIO pin to enable or disable the panel
> - backlight: phandle of the backlight device attached to the panel
>
>
> In general Yakir's bindings document match a huge chunk of the current
> existing bindings.  Do this:
>    cd Documentation/devicetree/bindings/display/panel
>    grep -C20 "This binding is compatible with the simple-panel" *
>
> You'll find a huge chunk of files which are rather formulaic.  It
> might make sense to just have one file and a list of panels which are
> simple panels?
>
>
> -Doug
>
>
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding

[Yakir Yang]

On 06/11/2016 12:40 AM, Doug Anderson wrote:
> Rob,
>
> On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring <robh@kernel.org> wrote:
>> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote:
>>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
>>> connected using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
>>>
>>>   .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> new file mode 100644
>>> index 0000000..81938c0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
>>> @@ -0,0 +1,7 @@
>>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel
>>> +
>>> +Required properties:
>>> +- compatible: should be "sharp,lq123p1jx31,"
>>                                               ^
>> Need to drop the comma.
> Thanks for catching!

Done,

>
>> No regulators or resets or pwms?
> Could be more explicit I guess, but Yakir does say:
>
>> This binding is compatible with the simple-panel binding, which is specified
>> in simple-panel.txt in this directory.
> In that document it shows:
>
> Required properties:
> - power-supply: regulator to provide the supply voltage
>
> Optional properties:
> - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
> - enable-gpios: GPIO pin to enable or disable the panel
> - backlight: phandle of the backlight device attached to the panel
>
>
> In general Yakir's bindings document match a huge chunk of the current
> existing bindings.  Do this:
>    cd Documentation/devicetree/bindings/display/panel
>    grep -C20 "This binding is compatible with the simple-panel" *
>
> You'll find a huge chunk of files which are rather formulaic.  It
> might make sense to just have one file and a list of panels which are
> simple panels?
>
>
> -Doug
>
>
>

[PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Yakir Yang]

The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2:
- Add detail timing of Sharp LQ123P1JX31 panel in v2

 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 067a5c4..38b6660 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1314,6 +1314,29 @@ static const struct panel_desc samsung_ltn140at29_301 = {
 	},
 };
 
+static const struct drm_display_mode sharp_lq123p1jx31_mode = {
+	.clock = 252750,
+	.hdisplay = 2400,
+	.hsync_start = 2400 + 48,
+	.hsync_end = 2400 + 48 + 32,
+	.htotal = 2400 + 48 + 32 + 80,
+	.vdisplay = 1600,
+	.vsync_start = 1600 + 3,
+	.vsync_end = 1600 + 3 + 10,
+	.vtotal = 1600 + 3 + 10 + 33,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sharp_lq123p1jx31 = {
+	.modes = &sharp_lq123p1jx31_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 2400,
+		.height = 1600,
+	},
+};
+
 static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
 	.clock = 33300,
 	.hdisplay = 800,
@@ -1537,6 +1560,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "samsung,ltn140at29-301",
 		.data = &samsung_ltn140at29_301,
 	}, {
+		.compatible = "sharp,lq123p1jx31",
+		.data = &sharp_lq123p1jx31,
+	}, {
 		.compatible = "shelly,sca07010-bfn-lnn",
 		.data = &shelly_sca07010_bfn_lnn,
 	}, {
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Yakir Yang]

The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v2:
- Add detail timing of Sharp LQ123P1JX31 panel in v2

 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 067a5c4..38b6660 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1314,6 +1314,29 @@ static const struct panel_desc samsung_ltn140at29_301 = {
 	},
 };
 
+static const struct drm_display_mode sharp_lq123p1jx31_mode = {
+	.clock = 252750,
+	.hdisplay = 2400,
+	.hsync_start = 2400 + 48,
+	.hsync_end = 2400 + 48 + 32,
+	.htotal = 2400 + 48 + 32 + 80,
+	.vdisplay = 1600,
+	.vsync_start = 1600 + 3,
+	.vsync_end = 1600 + 3 + 10,
+	.vtotal = 1600 + 3 + 10 + 33,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sharp_lq123p1jx31 = {
+	.modes = &sharp_lq123p1jx31_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 2400,
+		.height = 1600,
+	},
+};
+
 static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
 	.clock = 33300,
 	.hdisplay = 800,
@@ -1537,6 +1560,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "samsung,ltn140at29-301",
 		.data = &samsung_ltn140at29_301,
 	}, {
+		.compatible = "sharp,lq123p1jx31",
+		.data = &sharp_lq123p1jx31,
+	}, {
 		.compatible = "shelly,sca07010-bfn-lnn",
 		.data = &shelly_sca07010_bfn_lnn,
 	}, {
-- 
1.9.1

Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Doug Anderson]

Yakir,

On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
> using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2:
> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Looks good to me.  Values in the table match the EDID I see from this
panel and everything else looks to be in order.

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Doug Anderson]

Yakir,

On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
> using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v2:
> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Looks good to me.  Values in the table match the EDID I see from this
panel and everything else looks to be in order.

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>

Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Doug Anderson]

Hi,

On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
> Yakir,
>
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>> using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2:
>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>
>>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>
> Looks good to me.  Values in the table match the EDID I see from this
> panel and everything else looks to be in order.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>

Sorry for not noticing.  :(  ...but as others have pointed out for
your earlier patches, the size is incorrect.  I found the correct size
and it should be:

               .width = 259,
               .height = 173,


-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Doug Anderson]

Hi,

On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
> Yakir,
>
> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>> using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v2:
>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>
>>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>
> Looks good to me.  Values in the table match the EDID I see from this
> panel and everything else looks to be in order.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>

Sorry for not noticing.  :(  ...but as others have pointed out for
your earlier patches, the size is incorrect.  I found the correct size
and it should be:

               .width = 259,
               .height = 173,


-Doug

Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Yakir Yang]

Doug,

On 06/11/2016 12:11 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
>> Yakir,
>>
>> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>>> using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>>
>>>   drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>>   1 file changed, 26 insertions(+)
>> Looks good to me.  Values in the table match the EDID I see from this
>> panel and everything else looks to be in order.
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
> Sorry for not noticing.  :(  ...but as others have pointed out for
> your earlier patches, the size is incorrect.  I found the correct size
> and it should be:
>
>                 .width = 259,
>                 .height = 173,
>

Ah, thanks, would correct it now :-D

- Yakir

> -Doug
>
>
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel

[Yakir Yang]

Doug,

On 06/11/2016 12:11 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
>> Yakir,
>>
>> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>>> using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>>
>>>   drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>>   1 file changed, 26 insertions(+)
>> Looks good to me.  Values in the table match the EDID I see from this
>> panel and everything else looks to be in order.
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
> Sorry for not noticing.  :(  ...but as others have pointed out for
> your earlier patches, the size is incorrect.  I found the correct size
> and it should be:
>
>                 .width = 259,
>                 .height = 173,
>

Ah, thanks, would correct it now :-D

- Yakir

> -Doug
>
>
>