From: Krzysztof Kozlowski <krzk@kernel.org>
To: George Moussalem <george.moussalem@outlook.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveenkumar I <quic_ipkumar@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY
Date: Thu, 13 Aug 2026 12:48:59 +0200 [thread overview]
Message-ID: <71cfe76b-ea84-47f8-9ff7-945d69efbdcd@kernel.org> (raw)
In-Reply-To: <SN7PR19MB67369ED27F676F6197A0727A9DDB2@SN7PR19MB6736.namprd19.prod.outlook.com>
On 13/08/2026 12:28, George Moussalem wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
>>> +
>>> + phy@4b0000 {
>>> + compatible = "qcom,ipq5332-uniphy-usb-ss-phy";
>>> + reg = <0x4b0000 0x800>;
>>
>> That is the same address as PCI PHY, so you have one device, not two.
>
> yes, AFAIK they're separate PHYs (pcie-28lp vs usb-ss-22ull) sharing the
> same MMIO register space in IPQ5332. To enable USB3, the compatible
> string, clocks, resets, and related USB3 properties override the PCIe
> properties. In IPQ5018, the PHYs have different register address spaces,
> hence representing it as a new devicetree node.
>
Same MMIO space is same device, IMO, especially that you have the same
registers (looking at the driver).
>>
>> Best regards,
>> Krzysztof
>>
>
> Best regards,
> George
>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: George Moussalem <george.moussalem@outlook.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Praveenkumar I <quic_ipkumar@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY
Date: Thu, 13 Aug 2026 12:48:59 +0200 [thread overview]
Message-ID: <71cfe76b-ea84-47f8-9ff7-945d69efbdcd@kernel.org> (raw)
In-Reply-To: <SN7PR19MB67369ED27F676F6197A0727A9DDB2@SN7PR19MB6736.namprd19.prod.outlook.com>
On 13/08/2026 12:28, George Moussalem wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
>>> +
>>> + phy@4b0000 {
>>> + compatible = "qcom,ipq5332-uniphy-usb-ss-phy";
>>> + reg = <0x4b0000 0x800>;
>>
>> That is the same address as PCI PHY, so you have one device, not two.
>
> yes, AFAIK they're separate PHYs (pcie-28lp vs usb-ss-22ull) sharing the
> same MMIO register space in IPQ5332. To enable USB3, the compatible
> string, clocks, resets, and related USB3 properties override the PCIe
> properties. In IPQ5018, the PHYs have different register address spaces,
> hence representing it as a new devicetree node.
>
Same MMIO space is same device, IMO, especially that you have the same
registers (looking at the driver).
>>
>> Best regards,
>> Krzysztof
>>
>
> Best regards,
> George
>
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-08-13 10:49 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 9:34 [PATCH v2 00/14] Enable USB3 for Qualcomm IPQ5018 and IPQ5332 George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:34 ` [PATCH v2 01/14] dt-bindings: phy: Document the Qualcomm IPQ5332 UNIPHY USB Super-speed PHY George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:41 ` sashiko-bot
2026-08-12 9:41 ` sashiko-bot
2026-08-13 8:58 ` Krzysztof Kozlowski
2026-08-13 8:58 ` Krzysztof Kozlowski
2026-08-13 10:28 ` George Moussalem
2026-08-13 10:28 ` George Moussalem
2026-08-13 10:48 ` Krzysztof Kozlowski [this message]
2026-08-13 10:48 ` Krzysztof Kozlowski
2026-08-12 9:34 ` [PATCH v2 02/14] phy: qcom: Introduce Qualcomm IPQ5332 Super-Speed USB UNIPHY driver George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:48 ` sashiko-bot
2026-08-12 9:48 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 03/14] arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:51 ` sashiko-bot
2026-08-12 9:51 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 04/14] arm64: dts: qcom: ipq5332: Flatten usb controller node George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 10:25 ` sashiko-bot
2026-08-12 10:25 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 05/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:56 ` sashiko-bot
2026-08-12 9:56 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 06/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5332 George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:46 ` sashiko-bot
2026-08-12 9:46 ` sashiko-bot
2026-08-13 9:12 ` Krzysztof Kozlowski
2026-08-13 9:12 ` Krzysztof Kozlowski
2026-08-12 9:34 ` [PATCH v2 07/14] dt-bindings: usb: qcom,snps-dwc3: Add clocks for USB3 on Qualcomm IPQ5018 George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:51 ` sashiko-bot
2026-08-12 9:51 ` sashiko-bot
2026-08-13 9:09 ` Krzysztof Kozlowski
2026-08-13 9:09 ` Krzysztof Kozlowski
2026-08-12 9:34 ` [PATCH v2 08/14] arm64: dts: qcom: ipq5332: Add clocks required for USB3 support George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-13 15:38 ` Dmitry Baryshkov
2026-08-13 15:38 ` Dmitry Baryshkov
2026-08-12 9:34 ` [PATCH v2 09/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:48 ` sashiko-bot
2026-08-12 9:48 ` sashiko-bot
2026-08-13 15:38 ` Dmitry Baryshkov
2026-08-13 15:38 ` Dmitry Baryshkov
2026-08-12 9:34 ` [PATCH v2 10/14] arm64: dts: qcom: ipq5332: Add Super-Speed UNIPHY to USB node George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:55 ` sashiko-bot
2026-08-12 9:55 ` sashiko-bot
2026-08-12 10:56 ` Sergey Shtylyov
2026-08-12 10:56 ` Sergey Shtylyov
2026-08-12 9:34 ` [PATCH v2 11/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:57 ` sashiko-bot
2026-08-12 9:57 ` sashiko-bot
2026-08-12 10:57 ` Sergey Shtylyov
2026-08-12 10:57 ` Sergey Shtylyov
2026-08-12 9:34 ` [PATCH v2 12/14] arm64: dts: qcom: ipq5332: Enable USB Super-Speed PHY George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:54 ` sashiko-bot
2026-08-12 9:54 ` sashiko-bot
2026-08-13 8:59 ` Krzysztof Kozlowski
2026-08-13 8:59 ` Krzysztof Kozlowski
2026-08-12 9:34 ` [PATCH v2 13/14] arm64: dts: qcom: ipq5018: " George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
2026-08-12 9:57 ` sashiko-bot
2026-08-12 9:57 ` sashiko-bot
2026-08-12 9:34 ` [PATCH v2 14/14] arm64: defconfig: Enable qcom USB UNIPHY driver George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem via B4 Relay
2026-08-12 9:34 ` George Moussalem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71cfe76b-ea84-47f8-9ff7-945d69efbdcd@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.moussalem@outlook.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.