* [RFC PATCH v4 0/7] Specifying cache topology on ARM
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Specifying the cache layout in virtual machines is useful for
applications and operating systems to fetch accurate information about
the cache structure and make appropriate adjustments. Enforcing correct
sharing information can lead to better optimizations. This patch enables
the specification of cache layout through a command line parameter,
building on a patch set by Intel [1,2]. It uses this set as a
foundation. The device tree and ACPI/PPTT table, and device tree are
populated based on user-provided information and CPU topology.
Example:
+----------------+ +----------------+
| Socket 0 | | Socket 1 |
| (L3 Cache) | | (L3 Cache) |
+--------+-------+ +--------+-------+
| |
+--------+--------+ +--------+--------+
| Cluster 0 | | Cluster 0 |
| (L2 Cache) | | (L2 Cache) |
+--------+--------+ +--------+--------+
| |
+--------+--------+ +--------+--------+ +--------+--------+ +--------+----+
| Core 0 | | Core 1 | | Core 0 | | Core 1 |
| (L1i, L1d) | | (L1i, L1d) | | (L1i, L1d) | | (L1i, L1d)|
+--------+--------+ +--------+--------+ +--------+--------+ +--------+----+
| | | |
+--------+ +--------+ +--------+ +--------+
|Thread 0| |Thread 1| |Thread 1| |Thread 0|
+--------+ +--------+ +--------+ +--------+
|Thread 1| |Thread 0| |Thread 0| |Thread 1|
+--------+ +--------+ +--------+ +--------+
The following command will represent the system relying on **ACPI PPTT tables**.
./qemu-system-aarch64 \
-machine virt,smp-cache.0.cache=l1i,smp-cache.0.topology=core,smp-cache.1.cache=l1d,smp-cache.1.topology=core,smp-cache.2.cache=l2,smp-cache.2.topology=cluseter,smp-cache.3.cache=l3,smp-cache.3.topology=socket \
-cpu max \
-m 2048 \
-smp sockets=2,clusters=1,cores=2,threads=2 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
The following command will represent the system relying on **the device tree**.
./qemu-system-aarch64 \
-machine virt,smp-cache.0.cache=l1i,smp-cache.0.topology=core,smp-cache.1.cache=l1d,smp-cache.1.topology=core,smp-cache.2.cache=l2,smp-cache.2.topology=cluseter,smp-cache.3.cache=l3,smp-cache.3.topology=socket \
-cpu max \
-m 2048 \
-smp sockets=2,clusters=1,cores=2,threads=2 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
Failure cases:
1) there are cases where QEMU might not have any clusters selected in the
-smp option, while user specifies caches to be shared at cluster level. In
this situations, qemu returns error.
2) There are other scenarios where caches exist in systems' registers but
not left unspecified by users. In this case qemu returns failure.
3) At the moment, the device tree is not able to describe caches shared at
core level. In another word, SMT threads cannot share caches. This will need
adjustments in the SPEC. It is worth noting that this particular case is completely
OK in ACPI PPTT tables.
Currently only three levels of caches are supported to be specified from
the command line. However, increasing the value does not require
significant changes. Further, this patch assumes l2 and l3 unified
caches and does not allow l(2/3)(i/d). The level terminology is
thread/core/cluster/socket right now.
Here is the hierarchy assumed in this patch:
Socket level = Cluster level + 1 = Core level + 2 = Thread level + 3;
TODO:
1) Making the code to work with arbitrary levels
2) Separated data and instruction cache at L2 and L3.
3) Additional cache controls. e.g. size of L3 may not want to just
match the underlying system, because only some of the associated host
CPUs may be bound to this VM.
Depends-on: target/arm/tcg: refine cache descriptions with a wrapper
Depends-on: Msg-id: 20240903144550.280-1-alireza.sanaee@huawei.com
Depends-on: Building PPTT with root node and identical implementation flag
Depends-on: Msg-id: 20240926113323.55991-1-yangyicong@huawei.com
[1] https://lore.kernel.org/kvm/20240908125920.1160236-1-zhao1.liu@intel.com/
[2] https://lore.kernel.org/qemu-devel/20240704031603.1744546-1-zhao1.liu@intel.com/
v3->v4:
Device tree added.
Alireza Sanaee (7):
i386/cpu: add IsDefined flag to smp-cache property
target/arm/tcg: increase cache level for cpu=max
arm/virt.c: add cache hierarchy to device tree
bios-tables-test: prepare to change ARM ACPI virt PPTT
hw/acpi/aml-build.c: add cache hierarchy to pptt table
tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
Update the ACPI tables according to the acpi aml_build change, also
empty bios-tables-test-allowed-diff.h.
hw/acpi/aml-build.c | 235 ++++++++++++-
hw/arm/virt-acpi-build.c | 8 +-
hw/arm/virt.c | 390 +++++++++++++++++++++
hw/core/machine-smp.c | 2 +
hw/cpu/core.c | 97 +++++
include/hw/acpi/aml-build.h | 4 +-
include/hw/arm/virt.h | 5 +
include/hw/boards.h | 1 +
include/hw/cpu/core.h | 27 ++
target/arm/tcg/cpu64.c | 13 +
tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
tests/qtest/bios-tables-test.c | 6 +-
12 files changed, 779 insertions(+), 9 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 32+ messages in thread
* [RFC PATCH v4 0/7] Specifying cache topology on ARM
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Specifying the cache layout in virtual machines is useful for
applications and operating systems to fetch accurate information about
the cache structure and make appropriate adjustments. Enforcing correct
sharing information can lead to better optimizations. This patch enables
the specification of cache layout through a command line parameter,
building on a patch set by Intel [1,2]. It uses this set as a
foundation. The device tree and ACPI/PPTT table, and device tree are
populated based on user-provided information and CPU topology.
Example:
+----------------+ +----------------+
| Socket 0 | | Socket 1 |
| (L3 Cache) | | (L3 Cache) |
+--------+-------+ +--------+-------+
| |
+--------+--------+ +--------+--------+
| Cluster 0 | | Cluster 0 |
| (L2 Cache) | | (L2 Cache) |
+--------+--------+ +--------+--------+
| |
+--------+--------+ +--------+--------+ +--------+--------+ +--------+----+
| Core 0 | | Core 1 | | Core 0 | | Core 1 |
| (L1i, L1d) | | (L1i, L1d) | | (L1i, L1d) | | (L1i, L1d)|
+--------+--------+ +--------+--------+ +--------+--------+ +--------+----+
| | | |
+--------+ +--------+ +--------+ +--------+
|Thread 0| |Thread 1| |Thread 1| |Thread 0|
+--------+ +--------+ +--------+ +--------+
|Thread 1| |Thread 0| |Thread 0| |Thread 1|
+--------+ +--------+ +--------+ +--------+
The following command will represent the system relying on **ACPI PPTT tables**.
./qemu-system-aarch64 \
-machine virt,smp-cache.0.cache=l1i,smp-cache.0.topology=core,smp-cache.1.cache=l1d,smp-cache.1.topology=core,smp-cache.2.cache=l2,smp-cache.2.topology=cluseter,smp-cache.3.cache=l3,smp-cache.3.topology=socket \
-cpu max \
-m 2048 \
-smp sockets=2,clusters=1,cores=2,threads=2 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
The following command will represent the system relying on **the device tree**.
./qemu-system-aarch64 \
-machine virt,smp-cache.0.cache=l1i,smp-cache.0.topology=core,smp-cache.1.cache=l1d,smp-cache.1.topology=core,smp-cache.2.cache=l2,smp-cache.2.topology=cluseter,smp-cache.3.cache=l3,smp-cache.3.topology=socket \
-cpu max \
-m 2048 \
-smp sockets=2,clusters=1,cores=2,threads=2 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
Failure cases:
1) there are cases where QEMU might not have any clusters selected in the
-smp option, while user specifies caches to be shared at cluster level. In
this situations, qemu returns error.
2) There are other scenarios where caches exist in systems' registers but
not left unspecified by users. In this case qemu returns failure.
3) At the moment, the device tree is not able to describe caches shared at
core level. In another word, SMT threads cannot share caches. This will need
adjustments in the SPEC. It is worth noting that this particular case is completely
OK in ACPI PPTT tables.
Currently only three levels of caches are supported to be specified from
the command line. However, increasing the value does not require
significant changes. Further, this patch assumes l2 and l3 unified
caches and does not allow l(2/3)(i/d). The level terminology is
thread/core/cluster/socket right now.
Here is the hierarchy assumed in this patch:
Socket level = Cluster level + 1 = Core level + 2 = Thread level + 3;
TODO:
1) Making the code to work with arbitrary levels
2) Separated data and instruction cache at L2 and L3.
3) Additional cache controls. e.g. size of L3 may not want to just
match the underlying system, because only some of the associated host
CPUs may be bound to this VM.
Depends-on: target/arm/tcg: refine cache descriptions with a wrapper
Depends-on: Msg-id: 20240903144550.280-1-alireza.sanaee@huawei.com
Depends-on: Building PPTT with root node and identical implementation flag
Depends-on: Msg-id: 20240926113323.55991-1-yangyicong@huawei.com
[1] https://lore.kernel.org/kvm/20240908125920.1160236-1-zhao1.liu@intel.com/
[2] https://lore.kernel.org/qemu-devel/20240704031603.1744546-1-zhao1.liu@intel.com/
v3->v4:
Device tree added.
Alireza Sanaee (7):
i386/cpu: add IsDefined flag to smp-cache property
target/arm/tcg: increase cache level for cpu=max
arm/virt.c: add cache hierarchy to device tree
bios-tables-test: prepare to change ARM ACPI virt PPTT
hw/acpi/aml-build.c: add cache hierarchy to pptt table
tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
Update the ACPI tables according to the acpi aml_build change, also
empty bios-tables-test-allowed-diff.h.
hw/acpi/aml-build.c | 235 ++++++++++++-
hw/arm/virt-acpi-build.c | 8 +-
hw/arm/virt.c | 390 +++++++++++++++++++++
hw/core/machine-smp.c | 2 +
hw/cpu/core.c | 97 +++++
include/hw/acpi/aml-build.h | 4 +-
include/hw/arm/virt.h | 5 +
include/hw/boards.h | 1 +
include/hw/cpu/core.h | 27 ++
target/arm/tcg/cpu64.c | 13 +
tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
tests/qtest/bios-tables-test.c | 6 +-
12 files changed, 779 insertions(+), 9 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
This commit adds IsDefined flag to the object and this helps in avoiding
extra checks for every single layer of caches in both x86 and ARM.
There is already a discussion on mailing list to have this flag. A
patch that enables this flag will follow later.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
hw/core/machine-smp.c | 2 ++
include/hw/boards.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
index 9a28194676..5a02bbf584 100644
--- a/hw/core/machine-smp.c
+++ b/hw/core/machine-smp.c
@@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms,
return false;
}
+ ms->smp_cache.IsDefined = true;
+
return true;
}
diff --git a/include/hw/boards.h b/include/hw/boards.h
index db2aa2b706..2883a57084 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -373,6 +373,7 @@ typedef struct CpuTopology {
typedef struct SmpCache {
SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX];
+ bool IsDefined;
} SmpCache;
/**
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
This commit adds IsDefined flag to the object and this helps in avoiding
extra checks for every single layer of caches in both x86 and ARM.
There is already a discussion on mailing list to have this flag. A
patch that enables this flag will follow later.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
hw/core/machine-smp.c | 2 ++
include/hw/boards.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
index 9a28194676..5a02bbf584 100644
--- a/hw/core/machine-smp.c
+++ b/hw/core/machine-smp.c
@@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms,
return false;
}
+ ms->smp_cache.IsDefined = true;
+
return true;
}
diff --git a/include/hw/boards.h b/include/hw/boards.h
index db2aa2b706..2883a57084 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -373,6 +373,7 @@ typedef struct CpuTopology {
typedef struct SmpCache {
SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX];
+ bool IsDefined;
} SmpCache;
/**
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 2/7] target/arm/tcg: increase cache level for cpu=max
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
This patch addresses cache description in the `aarch64_max_tcg_initfn`
function for cpu=max. It introduces three layers of caches and modifies
the cache description registers accordingly.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
target/arm/tcg/cpu64.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 904a7e90b4..47d8c9c9ae 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1086,6 +1086,19 @@ void aarch64_max_tcg_initfn(Object *obj)
uint64_t t;
uint32_t u;
+ /*
+ * Expanded cache set
+ */
+ cpu->clidr = 0x8200123; /* 4 4 3 in 3 bit fields */
+ /* 64KB L1 dcache */
+ cpu->ccsidr[0] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 7);
+ /* 64KB L1 icache */
+ cpu->ccsidr[1] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 2);
+ /* 1MB L2 unified cache */
+ cpu->ccsidr[2] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 1 * MiB, 7);
+ /* 2MB L3 unified cache */
+ cpu->ccsidr[4] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 2 * MiB, 7);
+
/*
* Unset ARM_FEATURE_BACKCOMPAT_CNTFRQ, which we would otherwise default
* to because we started with aarch64_a57_initfn(). A 'max' CPU might
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 2/7] target/arm/tcg: increase cache level for cpu=max
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
This patch addresses cache description in the `aarch64_max_tcg_initfn`
function for cpu=max. It introduces three layers of caches and modifies
the cache description registers accordingly.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
target/arm/tcg/cpu64.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
index 904a7e90b4..47d8c9c9ae 100644
--- a/target/arm/tcg/cpu64.c
+++ b/target/arm/tcg/cpu64.c
@@ -1086,6 +1086,19 @@ void aarch64_max_tcg_initfn(Object *obj)
uint64_t t;
uint32_t u;
+ /*
+ * Expanded cache set
+ */
+ cpu->clidr = 0x8200123; /* 4 4 3 in 3 bit fields */
+ /* 64KB L1 dcache */
+ cpu->ccsidr[0] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 7);
+ /* 64KB L1 icache */
+ cpu->ccsidr[1] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 2);
+ /* 1MB L2 unified cache */
+ cpu->ccsidr[2] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 1 * MiB, 7);
+ /* 2MB L3 unified cache */
+ cpu->ccsidr[4] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 2 * MiB, 7);
+
/*
* Unset ARM_FEATURE_BACKCOMPAT_CNTFRQ, which we would otherwise default
* to because we started with aarch64_a57_initfn(). A 'max' CPU might
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 3/7] arm/virt.c: add cache hierarchy to device tree
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Specify which layer (core/cluster/socket) caches found at in the CPU
topology. Updating cache topology to device tree (spec v0.4).
Example:
Here, 2 sockets (packages), and 2 clusters, 4 cores and 2 threads
created, in aggregate 2*2*4*2 logical cores. In the smp-cache object,
cores will have l1d and l1i. However, extending this is not difficult).
The clusters will share a unified l2 level cache, and finally sockets
will share l3. In this patch, threads will share l1 caches by default,
but this can be adjusted if case required.
Currently only three levels of caches are supported. The patch does not
allow partial declaration of caches. In another word, all caches must be
defined or caches must be skipped.
./qemu-system-aarch64 \
-machine virt,\
smp-cache.0.cache=l1i,smp-cache.0.topology=core,\
smp-cache.1.cache=l1d,smp-cache.1.topology=core,\
smp-cache.2.cache=l2,smp-cache.2.topology=cluster,\
smp-cache.3.cache=l3,smp-cache.3.topology=socket\
-cpu max \
-m 2048 \
-smp sockets=2,clusters=2,cores=4,threads=1 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
For instance, following device tree will be generated for a scenario
where we have 2 sockets, 2 clusters, 2 cores and 2 threads, in total 16
PEs. L1i and L1d are private to each thread, and l2 and l3 are shared at
socket level as an example.
Limitation: SMT cores cannot share L1 cache for now. This
problem does not exist in PPTT tables.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
hw/arm/virt.c | 390 ++++++++++++++++++++++++++++++++++++++++++
hw/cpu/core.c | 97 +++++++++++
include/hw/arm/virt.h | 5 +
include/hw/cpu/core.h | 26 +++
4 files changed, 518 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 687fe0bb8b..ae35539fb9 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -228,6 +228,132 @@ static const int a15irqmap[] = {
[VIRT_PLATFORM_BUS] = 112, /* ...to 112 + PLATFORM_BUS_NUM_IRQS -1 */
};
+unsigned int virt_get_caches(const VirtMachineState *vms,
+ CPUCaches *caches)
+{
+ ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(0)); /* assume homogeneous CPUs */
+ bool ccidx = cpu_isar_feature(any_ccidx, armcpu);
+ unsigned int num_cache, i;
+ int level_instr = 1, level_data = 1;
+
+ for (i = 0, num_cache = 0; i < CPU_MAX_CACHES; i++, num_cache++) {
+ int type = (armcpu->clidr >> (3 * i)) & 7;
+ int bank_index;
+ int level;
+ CPUCacheType cache_type;
+
+ if (type == 0) {
+ break;
+ }
+
+ switch (type) {
+ case 1:
+ cache_type = INSTRUCTION;
+ level = level_instr;
+ break;
+ case 2:
+ cache_type = DATA;
+ level = level_data;
+ break;
+ case 4:
+ cache_type = UNIFIED;
+ level = level_instr > level_data ? level_instr : level_data;
+ break;
+ case 3: /* Split - Do data first */
+ cache_type = DATA;
+ level = level_data;
+ break;
+ default:
+ error_setg(&error_abort, "Unrecognized cache type");
+ return 0;
+ }
+ /*
+ * ccsidr is indexed using both the level and whether it is
+ * an instruction cache. Unified caches use the same storage
+ * as data caches.
+ */
+ bank_index = (i * 2) | ((type == 1) ? 1 : 0);
+ if (ccidx) {
+ caches[num_cache] = (CPUCaches) {
+ .type = cache_type,
+ .level = level,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ CCIDX_NUMSETS) + 1,
+ };
+ } else {
+ caches[num_cache] = (CPUCaches) {
+ .type = cache_type,
+ .level = level,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1, LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ NUMSETS) + 1,
+ };
+ }
+ caches[num_cache].size = caches[num_cache].associativity *
+ caches[num_cache].sets * caches[num_cache].linesize;
+
+ /* Break one 'split' entry up into two records */
+ if (type == 3) {
+ num_cache++;
+ bank_index = (i * 2) | 1;
+ if (ccidx) {
+ /* Instruction cache: bottom bit set when reading banked reg */
+ caches[num_cache] = (CPUCaches) {
+ .type = INSTRUCTION,
+ .level = level_instr,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ CCIDX_NUMSETS) + 1,
+ };
+ } else {
+ caches[num_cache] = (CPUCaches) {
+ .type = INSTRUCTION,
+ .level = level_instr,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1, LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ NUMSETS) + 1,
+ };
+ }
+ caches[num_cache].size = caches[num_cache].associativity *
+ caches[num_cache].sets * caches[num_cache].linesize;
+ }
+ switch (type) {
+ case 1:
+ level_instr++;
+ break;
+ case 2:
+ level_data++;
+ break;
+ case 3:
+ case 4:
+ level_instr++;
+ level_data++;
+ break;
+ }
+ }
+
+ return num_cache;
+}
+
static void create_randomness(MachineState *ms, const char *node)
{
struct {
@@ -411,6 +537,70 @@ static void fdt_add_timer_nodes(const VirtMachineState *vms)
}
}
+static void add_cache_node(void *fdt, char * nodepath, CPUCaches cache,
+ uint32_t *next_level) {
+ /* Assume L2/3 are unified caches. */
+
+ uint32_t phandle;
+
+ qemu_fdt_add_path(fdt, nodepath);
+ phandle = qemu_fdt_alloc_phandle(fdt);
+ qemu_fdt_setprop_cell(fdt, nodepath, "phandle", phandle);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-level", cache.level);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-size", cache.size);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-block-size", cache.linesize);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-sets", cache.sets);
+ qemu_fdt_setprop(fdt, nodepath, "cache-unified", NULL, 0);
+ if (cache.level != 3) {
+ /* top level cache doesn't have next-level-cache property */
+ qemu_fdt_setprop_cell(fdt, nodepath, "next-level-cache", *next_level);
+ }
+
+ *next_level = phandle;
+}
+
+static bool add_cpu_cache_hierarchy(void *fdt, CPUCaches* cache,
+ uint32_t cache_cnt,
+ uint32_t top_level,
+ uint32_t bottom_level,
+ uint32_t cpu_id,
+ uint32_t *next_level) {
+ bool found_cache = false;
+ char *nodepath;
+
+ for (int level = top_level; level >= bottom_level; level--) {
+ for (int i = 0; i < cache_cnt; i++) {
+ if (i != level) {
+ continue;
+ }
+
+ nodepath = g_strdup_printf("/cpus/cpu@%d/l%d-cache",
+ cpu_id, level);
+ add_cache_node(fdt, nodepath, cache[i], next_level);
+ found_cache = true;
+ g_free(nodepath);
+
+ }
+ }
+
+ return found_cache;
+}
+
+static void set_cache_properties(void *fdt, const char *nodename,
+ const char *prefix, CPUCaches cache)
+{
+ char prop_name[64];
+
+ snprintf(prop_name, sizeof(prop_name), "%s-block-size", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.linesize);
+
+ snprintf(prop_name, sizeof(prop_name), "%s-size", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.size);
+
+ snprintf(prop_name, sizeof(prop_name), "%s-sets", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.sets);
+}
+
static void fdt_add_cpu_nodes(const VirtMachineState *vms)
{
int cpu;
@@ -418,6 +608,24 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
const MachineState *ms = MACHINE(vms);
const VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
int smp_cpus = ms->smp.cpus;
+ int socket_id, cluster_id, core_id, thread_id;
+ uint32_t next_level = 0;
+ uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
+ uint32_t thread_offset = 0;
+ int last_socket = -1, last_cluster = -1, last_core = -1, last_thread = -1;
+ int top_node = 3, top_cluster = 3, top_core = 3, top_thread = 3;
+ int bottom_node = 3, bottom_cluster = 3, bottom_core = 3, bottom_thread = 3;
+ unsigned int num_cache;
+ CPUCaches caches[16];
+ bool cache_created = false;
+
+ num_cache = virt_get_caches(vms, caches);
+
+ if (ms->smp_cache.IsDefined &&
+ partial_cache_description(ms, caches, num_cache)) {
+ error_setg(&error_fatal, "Missing cache description");
+ return;
+ }
/*
* See Linux Documentation/devicetree/bindings/arm/cpus.yaml
@@ -446,9 +654,15 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#size-cells", 0x0);
for (cpu = smp_cpus - 1; cpu >= 0; cpu--) {
+ socket_id = cpu / (ms->smp.clusters * ms->smp.cores * ms->smp.threads);
+ cluster_id = cpu / (ms->smp.cores * ms->smp.threads) % ms->smp.clusters;
+ core_id = cpu / (ms->smp.threads) % ms->smp.cores;
+ thread_id = cpu % ms->smp.cores;
+
char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu));
CPUState *cs = CPU(armcpu);
+ const char *prefix = NULL;
qemu_fdt_add_subnode(ms->fdt, nodename);
qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "cpu");
@@ -478,6 +692,177 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
qemu_fdt_alloc_phandle(ms->fdt));
}
+ if (!vmc->no_cpu_topology && num_cache) {
+ for (uint8_t i = 0; i < num_cache; i++) {
+ /* only level 1 in the CPU entry */
+ if (caches[i].level > 1) {
+ continue;
+ }
+
+
+ if (caches[i].type == INSTRUCTION) {
+ prefix = "i-cache";
+ } else if (caches[i].type == DATA) {
+ prefix = "d-cache";
+ } else if (caches[i].type == UNIFIED) {
+ error_setg(&error_fatal,
+ "Unified type is not implemented at level %d",
+ caches[i].level);
+ return;
+ } else {
+ error_setg(&error_fatal, "Undefined cache type");
+ return;
+ }
+
+ set_cache_properties(ms->fdt, nodename, prefix, caches[i]);
+ }
+ }
+
+ if (socket_id != last_socket) {
+ bottom_node = top_node;
+ /* this assumes socket as the highest topological level */
+ socket_offset = 0;
+ cluster_offset = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_node,
+ CPU_TOPOLOGY_LEVEL_SOCKET)) {
+
+ if (bottom_node == 1) {
+ error_report("Cannot share L1 at socket_id %d.", socket_id);
+ }
+
+ cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
+ num_cache,
+ top_node,
+ bottom_node, cpu,
+ &socket_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Socket: No caches at levels %d-%d",
+ top_node, bottom_node);
+ return;
+ }
+
+ top_cluster = bottom_node - 1;
+ }
+
+ last_socket = socket_id;
+ }
+
+ if (cluster_id != last_cluster) {
+ bottom_cluster = top_cluster;
+ cluster_offset = socket_offset;
+ core_offset = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_cluster,
+ CPU_TOPOLOGY_LEVEL_CLUSTER)) {
+
+ cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
+ num_cache,
+ top_cluster,
+ bottom_cluster, cpu,
+ &cluster_offset);
+ if (bottom_cluster == 1) {
+ error_report(
+ "Cannot share L1 at socket_id %d, cluster_id %d.",
+ socket_id, cluster_id);
+ }
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Cluster: No caches at levels %d-%d",
+ top_cluster, bottom_cluster);
+ return;
+ }
+
+ top_core = bottom_cluster - 1;
+ top_thread = top_core;
+ } else if (top_cluster == bottom_node - 1) {
+ top_core = bottom_node - 1;
+ top_thread = top_core;
+ }
+
+ last_cluster = cluster_id;
+ }
+
+ if (core_id != last_core) {
+ bottom_core = top_core;
+ core_offset = cluster_offset;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CORE) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_core,
+ CPU_TOPOLOGY_LEVEL_CORE)) {
+
+ if (bottom_core == 1) {
+ bottom_core++;
+ } else {
+ cache_created = add_cpu_cache_hierarchy(ms->fdt,
+ caches,
+ num_cache,
+ top_core,
+ bottom_core, cpu,
+ &core_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Core: No caches at levels %d-%d",
+ top_core, bottom_core);
+ return;
+ }
+ }
+
+ top_thread = bottom_core - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache and no core cache */
+ top_thread = top_cluster;
+ } else if (top_core == bottom_cluster - 1) {
+ /* cluster cache but no socket and no core cache */
+ top_thread = top_core;
+ }
+
+ last_core = core_id;
+ }
+
+ if (ms->smp.threads > 1) {
+ thread_offset = core_offset;
+ if (thread_id != last_thread) {
+ bottom_thread = top_thread;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_THREAD) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_thread,
+ CPU_TOPOLOGY_LEVEL_THREAD)) {
+
+ if (bottom_thread == 1) {
+ bottom_thread++;
+ } else {
+ cache_created = add_cpu_cache_hierarchy(ms->fdt,
+ caches,
+ num_cache,
+ top_thread,
+ bottom_thread,
+ cpu,
+ &thread_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "No caches at levels %d-%d",
+ top_thread, bottom_thread);
+ return;
+ }
+ }
+ }
+
+ last_thread = thread_id;
+ }
+ }
+
+ next_level = (ms->smp.threads > 1) ? thread_offset : core_offset;
+ qemu_fdt_setprop_cell(ms->fdt, nodename, "next-level-cache",
+ next_level);
+
g_free(nodename);
}
@@ -3094,6 +3479,11 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
hc->unplug = virt_machine_device_unplug_cb;
mc->nvdimm_supported = true;
mc->smp_props.clusters_supported = true;
+ /* Supported caches */
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L1D] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L1I] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L2] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L3] = true;
mc->auto_enable_numa_with_memhp = true;
mc->auto_enable_numa_with_memdev = true;
/* platform instead of architectural choice */
diff --git a/hw/cpu/core.c b/hw/cpu/core.c
index 495a5c30ff..186bb367e7 100644
--- a/hw/cpu/core.c
+++ b/hw/cpu/core.c
@@ -102,4 +102,101 @@ static void cpu_core_register_types(void)
type_register_static(&cpu_core_type_info);
}
+bool cache_described_at(const MachineState *ms, CpuTopologyLevel level)
+{
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D) == level) {
+ return true;
+ }
+ return false;
+}
+
+int partial_cache_description(const MachineState *ms,
+ CPUCaches *caches,
+ int num_caches)
+{
+ int level, c;
+
+ for (level = 1; level < num_caches; level++) {
+ for (c = 0; c < num_caches; c++) {
+ if (caches[c].level != level) {
+ continue;
+ }
+
+ switch (level) {
+ case 1:
+ /*
+ * L1 cache is assumed to have both L1I and L1D available.
+ * Technically both need to be checked.
+ */
+ if (machine_get_cache_topo_level(ms,
+ CACHE_LEVEL_AND_TYPE_L1I) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT)
+ {
+ assert(machine_get_cache_topo_level(ms,
+ CACHE_LEVEL_AND_TYPE_L1D) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT);
+ return level;
+ }
+ break;
+ case 2:
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ case 3:
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ }
+ }
+ }
+
+ return 0;
+}
+
+/*
+ * This function assumes l3 and l2 have unified cache and l1 is split l1d
+ * and l1i, and further prepares the lowest cache level for a topology
+ * level. The info will be fed to build_caches to create caches at the
+ * right level.
+ */
+int find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
+ int *level_found,
+ CpuTopologyLevel topo_level) {
+
+ CpuTopologyLevel level;
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I);
+ if (level == topo_level) {
+ *level_found = 1;
+ return 1;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D);
+ if (level == topo_level) {
+ *level_found = 1;
+ return 1;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2);
+ if (level == topo_level) {
+ *level_found = 2;
+ return 2;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3);
+ if (level == topo_level) {
+ *level_found = 3;
+ return 3;
+ }
+
+ return 0;
+}
+
type_init(cpu_core_register_types)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index a4d937ed45..7b0311ce6e 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -39,6 +39,7 @@
#include "sysemu/kvm.h"
#include "hw/intc/arm_gicv3_common.h"
#include "qom/object.h"
+#include "hw/cpu/core.h"
#define NUM_GICV2M_SPIS 64
#define NUM_VIRTIO_TRANSPORTS 32
@@ -50,6 +51,8 @@
/* GPIO pins */
#define GPIO_PIN_POWER_BUTTON 3
+#define CPU_MAX_CACHES 16
+
enum {
VIRT_FLASH,
VIRT_MEM,
@@ -188,6 +191,8 @@ OBJECT_DECLARE_TYPE(VirtMachineState, VirtMachineClass, VIRT_MACHINE)
void virt_acpi_setup(VirtMachineState *vms);
bool virt_is_acpi_enabled(VirtMachineState *vms);
+unsigned int virt_get_caches(const VirtMachineState *vms,
+ CPUCaches *caches);
/* Return number of redistributors that fit in the specified region */
static uint32_t virt_redist_capacity(VirtMachineState *vms, int region)
diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
index 98ab91647e..bcb9f7bb3e 100644
--- a/include/hw/cpu/core.h
+++ b/include/hw/cpu/core.h
@@ -25,6 +25,32 @@ struct CPUCore {
int nr_threads;
};
+typedef enum CPUCacheType {
+ DATA,
+ INSTRUCTION,
+ UNIFIED,
+} CPUCacheType;
+
+typedef struct CPUCaches {
+ CPUCacheType type;
+ uint32_t pptt_id;
+ uint32_t sets;
+ uint32_t size;
+ uint32_t level;
+ uint16_t linesize;
+ uint8_t attributes; /* write policy: 0x0 write back, 0x1 write through */
+ uint8_t associativity;
+} CPUCaches;
+
+int partial_cache_description(const MachineState *ms, CPUCaches *caches,
+ int num_caches);
+
+bool cache_described_at(const MachineState *ms, CpuTopologyLevel level);
+
+int find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
+ int *level_found,
+ CpuTopologyLevel topo_level);
+
/* Note: topology field names need to be kept in sync with
* 'CpuInstanceProperties' */
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 3/7] arm/virt.c: add cache hierarchy to device tree
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Specify which layer (core/cluster/socket) caches found at in the CPU
topology. Updating cache topology to device tree (spec v0.4).
Example:
Here, 2 sockets (packages), and 2 clusters, 4 cores and 2 threads
created, in aggregate 2*2*4*2 logical cores. In the smp-cache object,
cores will have l1d and l1i. However, extending this is not difficult).
The clusters will share a unified l2 level cache, and finally sockets
will share l3. In this patch, threads will share l1 caches by default,
but this can be adjusted if case required.
Currently only three levels of caches are supported. The patch does not
allow partial declaration of caches. In another word, all caches must be
defined or caches must be skipped.
./qemu-system-aarch64 \
-machine virt,\
smp-cache.0.cache=l1i,smp-cache.0.topology=core,\
smp-cache.1.cache=l1d,smp-cache.1.topology=core,\
smp-cache.2.cache=l2,smp-cache.2.topology=cluster,\
smp-cache.3.cache=l3,smp-cache.3.topology=socket\
-cpu max \
-m 2048 \
-smp sockets=2,clusters=2,cores=4,threads=1 \
-kernel ./Image.gz \
-append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
-initrd rootfs.cpio.gz \
-bios ./edk2-aarch64-code.fd \
-nographic
For instance, following device tree will be generated for a scenario
where we have 2 sockets, 2 clusters, 2 cores and 2 threads, in total 16
PEs. L1i and L1d are private to each thread, and l2 and l3 are shared at
socket level as an example.
Limitation: SMT cores cannot share L1 cache for now. This
problem does not exist in PPTT tables.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
hw/arm/virt.c | 390 ++++++++++++++++++++++++++++++++++++++++++
hw/cpu/core.c | 97 +++++++++++
include/hw/arm/virt.h | 5 +
include/hw/cpu/core.h | 26 +++
4 files changed, 518 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 687fe0bb8b..ae35539fb9 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -228,6 +228,132 @@ static const int a15irqmap[] = {
[VIRT_PLATFORM_BUS] = 112, /* ...to 112 + PLATFORM_BUS_NUM_IRQS -1 */
};
+unsigned int virt_get_caches(const VirtMachineState *vms,
+ CPUCaches *caches)
+{
+ ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(0)); /* assume homogeneous CPUs */
+ bool ccidx = cpu_isar_feature(any_ccidx, armcpu);
+ unsigned int num_cache, i;
+ int level_instr = 1, level_data = 1;
+
+ for (i = 0, num_cache = 0; i < CPU_MAX_CACHES; i++, num_cache++) {
+ int type = (armcpu->clidr >> (3 * i)) & 7;
+ int bank_index;
+ int level;
+ CPUCacheType cache_type;
+
+ if (type == 0) {
+ break;
+ }
+
+ switch (type) {
+ case 1:
+ cache_type = INSTRUCTION;
+ level = level_instr;
+ break;
+ case 2:
+ cache_type = DATA;
+ level = level_data;
+ break;
+ case 4:
+ cache_type = UNIFIED;
+ level = level_instr > level_data ? level_instr : level_data;
+ break;
+ case 3: /* Split - Do data first */
+ cache_type = DATA;
+ level = level_data;
+ break;
+ default:
+ error_setg(&error_abort, "Unrecognized cache type");
+ return 0;
+ }
+ /*
+ * ccsidr is indexed using both the level and whether it is
+ * an instruction cache. Unified caches use the same storage
+ * as data caches.
+ */
+ bank_index = (i * 2) | ((type == 1) ? 1 : 0);
+ if (ccidx) {
+ caches[num_cache] = (CPUCaches) {
+ .type = cache_type,
+ .level = level,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ CCIDX_NUMSETS) + 1,
+ };
+ } else {
+ caches[num_cache] = (CPUCaches) {
+ .type = cache_type,
+ .level = level,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1, LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ NUMSETS) + 1,
+ };
+ }
+ caches[num_cache].size = caches[num_cache].associativity *
+ caches[num_cache].sets * caches[num_cache].linesize;
+
+ /* Break one 'split' entry up into two records */
+ if (type == 3) {
+ num_cache++;
+ bank_index = (i * 2) | 1;
+ if (ccidx) {
+ /* Instruction cache: bottom bit set when reading banked reg */
+ caches[num_cache] = (CPUCaches) {
+ .type = INSTRUCTION,
+ .level = level_instr,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ CCIDX_ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ CCIDX_NUMSETS) + 1,
+ };
+ } else {
+ caches[num_cache] = (CPUCaches) {
+ .type = INSTRUCTION,
+ .level = level_instr,
+ .linesize = 1 << (FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1, LINESIZE) + 4),
+ .associativity = FIELD_EX64(armcpu->ccsidr[bank_index],
+ CCSIDR_EL1,
+ ASSOCIATIVITY) + 1,
+ .sets = FIELD_EX64(armcpu->ccsidr[bank_index], CCSIDR_EL1,
+ NUMSETS) + 1,
+ };
+ }
+ caches[num_cache].size = caches[num_cache].associativity *
+ caches[num_cache].sets * caches[num_cache].linesize;
+ }
+ switch (type) {
+ case 1:
+ level_instr++;
+ break;
+ case 2:
+ level_data++;
+ break;
+ case 3:
+ case 4:
+ level_instr++;
+ level_data++;
+ break;
+ }
+ }
+
+ return num_cache;
+}
+
static void create_randomness(MachineState *ms, const char *node)
{
struct {
@@ -411,6 +537,70 @@ static void fdt_add_timer_nodes(const VirtMachineState *vms)
}
}
+static void add_cache_node(void *fdt, char * nodepath, CPUCaches cache,
+ uint32_t *next_level) {
+ /* Assume L2/3 are unified caches. */
+
+ uint32_t phandle;
+
+ qemu_fdt_add_path(fdt, nodepath);
+ phandle = qemu_fdt_alloc_phandle(fdt);
+ qemu_fdt_setprop_cell(fdt, nodepath, "phandle", phandle);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-level", cache.level);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-size", cache.size);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-block-size", cache.linesize);
+ qemu_fdt_setprop_cell(fdt, nodepath, "cache-sets", cache.sets);
+ qemu_fdt_setprop(fdt, nodepath, "cache-unified", NULL, 0);
+ if (cache.level != 3) {
+ /* top level cache doesn't have next-level-cache property */
+ qemu_fdt_setprop_cell(fdt, nodepath, "next-level-cache", *next_level);
+ }
+
+ *next_level = phandle;
+}
+
+static bool add_cpu_cache_hierarchy(void *fdt, CPUCaches* cache,
+ uint32_t cache_cnt,
+ uint32_t top_level,
+ uint32_t bottom_level,
+ uint32_t cpu_id,
+ uint32_t *next_level) {
+ bool found_cache = false;
+ char *nodepath;
+
+ for (int level = top_level; level >= bottom_level; level--) {
+ for (int i = 0; i < cache_cnt; i++) {
+ if (i != level) {
+ continue;
+ }
+
+ nodepath = g_strdup_printf("/cpus/cpu@%d/l%d-cache",
+ cpu_id, level);
+ add_cache_node(fdt, nodepath, cache[i], next_level);
+ found_cache = true;
+ g_free(nodepath);
+
+ }
+ }
+
+ return found_cache;
+}
+
+static void set_cache_properties(void *fdt, const char *nodename,
+ const char *prefix, CPUCaches cache)
+{
+ char prop_name[64];
+
+ snprintf(prop_name, sizeof(prop_name), "%s-block-size", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.linesize);
+
+ snprintf(prop_name, sizeof(prop_name), "%s-size", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.size);
+
+ snprintf(prop_name, sizeof(prop_name), "%s-sets", prefix);
+ qemu_fdt_setprop_cell(fdt, nodename, prop_name, cache.sets);
+}
+
static void fdt_add_cpu_nodes(const VirtMachineState *vms)
{
int cpu;
@@ -418,6 +608,24 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
const MachineState *ms = MACHINE(vms);
const VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
int smp_cpus = ms->smp.cpus;
+ int socket_id, cluster_id, core_id, thread_id;
+ uint32_t next_level = 0;
+ uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
+ uint32_t thread_offset = 0;
+ int last_socket = -1, last_cluster = -1, last_core = -1, last_thread = -1;
+ int top_node = 3, top_cluster = 3, top_core = 3, top_thread = 3;
+ int bottom_node = 3, bottom_cluster = 3, bottom_core = 3, bottom_thread = 3;
+ unsigned int num_cache;
+ CPUCaches caches[16];
+ bool cache_created = false;
+
+ num_cache = virt_get_caches(vms, caches);
+
+ if (ms->smp_cache.IsDefined &&
+ partial_cache_description(ms, caches, num_cache)) {
+ error_setg(&error_fatal, "Missing cache description");
+ return;
+ }
/*
* See Linux Documentation/devicetree/bindings/arm/cpus.yaml
@@ -446,9 +654,15 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#size-cells", 0x0);
for (cpu = smp_cpus - 1; cpu >= 0; cpu--) {
+ socket_id = cpu / (ms->smp.clusters * ms->smp.cores * ms->smp.threads);
+ cluster_id = cpu / (ms->smp.cores * ms->smp.threads) % ms->smp.clusters;
+ core_id = cpu / (ms->smp.threads) % ms->smp.cores;
+ thread_id = cpu % ms->smp.cores;
+
char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu));
CPUState *cs = CPU(armcpu);
+ const char *prefix = NULL;
qemu_fdt_add_subnode(ms->fdt, nodename);
qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "cpu");
@@ -478,6 +692,177 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
qemu_fdt_alloc_phandle(ms->fdt));
}
+ if (!vmc->no_cpu_topology && num_cache) {
+ for (uint8_t i = 0; i < num_cache; i++) {
+ /* only level 1 in the CPU entry */
+ if (caches[i].level > 1) {
+ continue;
+ }
+
+
+ if (caches[i].type == INSTRUCTION) {
+ prefix = "i-cache";
+ } else if (caches[i].type == DATA) {
+ prefix = "d-cache";
+ } else if (caches[i].type == UNIFIED) {
+ error_setg(&error_fatal,
+ "Unified type is not implemented at level %d",
+ caches[i].level);
+ return;
+ } else {
+ error_setg(&error_fatal, "Undefined cache type");
+ return;
+ }
+
+ set_cache_properties(ms->fdt, nodename, prefix, caches[i]);
+ }
+ }
+
+ if (socket_id != last_socket) {
+ bottom_node = top_node;
+ /* this assumes socket as the highest topological level */
+ socket_offset = 0;
+ cluster_offset = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_node,
+ CPU_TOPOLOGY_LEVEL_SOCKET)) {
+
+ if (bottom_node == 1) {
+ error_report("Cannot share L1 at socket_id %d.", socket_id);
+ }
+
+ cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
+ num_cache,
+ top_node,
+ bottom_node, cpu,
+ &socket_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Socket: No caches at levels %d-%d",
+ top_node, bottom_node);
+ return;
+ }
+
+ top_cluster = bottom_node - 1;
+ }
+
+ last_socket = socket_id;
+ }
+
+ if (cluster_id != last_cluster) {
+ bottom_cluster = top_cluster;
+ cluster_offset = socket_offset;
+ core_offset = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_cluster,
+ CPU_TOPOLOGY_LEVEL_CLUSTER)) {
+
+ cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
+ num_cache,
+ top_cluster,
+ bottom_cluster, cpu,
+ &cluster_offset);
+ if (bottom_cluster == 1) {
+ error_report(
+ "Cannot share L1 at socket_id %d, cluster_id %d.",
+ socket_id, cluster_id);
+ }
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Cluster: No caches at levels %d-%d",
+ top_cluster, bottom_cluster);
+ return;
+ }
+
+ top_core = bottom_cluster - 1;
+ top_thread = top_core;
+ } else if (top_cluster == bottom_node - 1) {
+ top_core = bottom_node - 1;
+ top_thread = top_core;
+ }
+
+ last_cluster = cluster_id;
+ }
+
+ if (core_id != last_core) {
+ bottom_core = top_core;
+ core_offset = cluster_offset;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CORE) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_core,
+ CPU_TOPOLOGY_LEVEL_CORE)) {
+
+ if (bottom_core == 1) {
+ bottom_core++;
+ } else {
+ cache_created = add_cpu_cache_hierarchy(ms->fdt,
+ caches,
+ num_cache,
+ top_core,
+ bottom_core, cpu,
+ &core_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "Core: No caches at levels %d-%d",
+ top_core, bottom_core);
+ return;
+ }
+ }
+
+ top_thread = bottom_core - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache and no core cache */
+ top_thread = top_cluster;
+ } else if (top_core == bottom_cluster - 1) {
+ /* cluster cache but no socket and no core cache */
+ top_thread = top_core;
+ }
+
+ last_core = core_id;
+ }
+
+ if (ms->smp.threads > 1) {
+ thread_offset = core_offset;
+ if (thread_id != last_thread) {
+ bottom_thread = top_thread;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_THREAD) &&
+ find_the_lowest_level_cache_defined_at_level(ms,
+ &bottom_thread,
+ CPU_TOPOLOGY_LEVEL_THREAD)) {
+
+ if (bottom_thread == 1) {
+ bottom_thread++;
+ } else {
+ cache_created = add_cpu_cache_hierarchy(ms->fdt,
+ caches,
+ num_cache,
+ top_thread,
+ bottom_thread,
+ cpu,
+ &thread_offset);
+
+ if (!cache_created) {
+ error_setg(&error_fatal,
+ "No caches at levels %d-%d",
+ top_thread, bottom_thread);
+ return;
+ }
+ }
+ }
+
+ last_thread = thread_id;
+ }
+ }
+
+ next_level = (ms->smp.threads > 1) ? thread_offset : core_offset;
+ qemu_fdt_setprop_cell(ms->fdt, nodename, "next-level-cache",
+ next_level);
+
g_free(nodename);
}
@@ -3094,6 +3479,11 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
hc->unplug = virt_machine_device_unplug_cb;
mc->nvdimm_supported = true;
mc->smp_props.clusters_supported = true;
+ /* Supported caches */
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L1D] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L1I] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L2] = true;
+ mc->smp_props.cache_supported[CACHE_LEVEL_AND_TYPE_L3] = true;
mc->auto_enable_numa_with_memhp = true;
mc->auto_enable_numa_with_memdev = true;
/* platform instead of architectural choice */
diff --git a/hw/cpu/core.c b/hw/cpu/core.c
index 495a5c30ff..186bb367e7 100644
--- a/hw/cpu/core.c
+++ b/hw/cpu/core.c
@@ -102,4 +102,101 @@ static void cpu_core_register_types(void)
type_register_static(&cpu_core_type_info);
}
+bool cache_described_at(const MachineState *ms, CpuTopologyLevel level)
+{
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I) == level ||
+ machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D) == level) {
+ return true;
+ }
+ return false;
+}
+
+int partial_cache_description(const MachineState *ms,
+ CPUCaches *caches,
+ int num_caches)
+{
+ int level, c;
+
+ for (level = 1; level < num_caches; level++) {
+ for (c = 0; c < num_caches; c++) {
+ if (caches[c].level != level) {
+ continue;
+ }
+
+ switch (level) {
+ case 1:
+ /*
+ * L1 cache is assumed to have both L1I and L1D available.
+ * Technically both need to be checked.
+ */
+ if (machine_get_cache_topo_level(ms,
+ CACHE_LEVEL_AND_TYPE_L1I) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT)
+ {
+ assert(machine_get_cache_topo_level(ms,
+ CACHE_LEVEL_AND_TYPE_L1D) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT);
+ return level;
+ }
+ break;
+ case 2:
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ case 3:
+ if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) ==
+ CPU_TOPOLOGY_LEVEL_DEFAULT) {
+ return level;
+ }
+ break;
+ }
+ }
+ }
+
+ return 0;
+}
+
+/*
+ * This function assumes l3 and l2 have unified cache and l1 is split l1d
+ * and l1i, and further prepares the lowest cache level for a topology
+ * level. The info will be fed to build_caches to create caches at the
+ * right level.
+ */
+int find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
+ int *level_found,
+ CpuTopologyLevel topo_level) {
+
+ CpuTopologyLevel level;
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I);
+ if (level == topo_level) {
+ *level_found = 1;
+ return 1;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D);
+ if (level == topo_level) {
+ *level_found = 1;
+ return 1;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2);
+ if (level == topo_level) {
+ *level_found = 2;
+ return 2;
+ }
+
+ level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3);
+ if (level == topo_level) {
+ *level_found = 3;
+ return 3;
+ }
+
+ return 0;
+}
+
type_init(cpu_core_register_types)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index a4d937ed45..7b0311ce6e 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -39,6 +39,7 @@
#include "sysemu/kvm.h"
#include "hw/intc/arm_gicv3_common.h"
#include "qom/object.h"
+#include "hw/cpu/core.h"
#define NUM_GICV2M_SPIS 64
#define NUM_VIRTIO_TRANSPORTS 32
@@ -50,6 +51,8 @@
/* GPIO pins */
#define GPIO_PIN_POWER_BUTTON 3
+#define CPU_MAX_CACHES 16
+
enum {
VIRT_FLASH,
VIRT_MEM,
@@ -188,6 +191,8 @@ OBJECT_DECLARE_TYPE(VirtMachineState, VirtMachineClass, VIRT_MACHINE)
void virt_acpi_setup(VirtMachineState *vms);
bool virt_is_acpi_enabled(VirtMachineState *vms);
+unsigned int virt_get_caches(const VirtMachineState *vms,
+ CPUCaches *caches);
/* Return number of redistributors that fit in the specified region */
static uint32_t virt_redist_capacity(VirtMachineState *vms, int region)
diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
index 98ab91647e..bcb9f7bb3e 100644
--- a/include/hw/cpu/core.h
+++ b/include/hw/cpu/core.h
@@ -25,6 +25,32 @@ struct CPUCore {
int nr_threads;
};
+typedef enum CPUCacheType {
+ DATA,
+ INSTRUCTION,
+ UNIFIED,
+} CPUCacheType;
+
+typedef struct CPUCaches {
+ CPUCacheType type;
+ uint32_t pptt_id;
+ uint32_t sets;
+ uint32_t size;
+ uint32_t level;
+ uint16_t linesize;
+ uint8_t attributes; /* write policy: 0x0 write back, 0x1 write through */
+ uint8_t associativity;
+} CPUCaches;
+
+int partial_cache_description(const MachineState *ms, CPUCaches *caches,
+ int num_caches);
+
+bool cache_described_at(const MachineState *ms, CpuTopologyLevel level);
+
+int find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
+ int *level_found,
+ CpuTopologyLevel topo_level);
+
/* Note: topology field names need to be kept in sync with
* 'CpuInstanceProperties' */
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 4/7] bios-tables-test: prepare to change ARM ACPI virt PPTT
2024-12-16 17:54 ` Alireza Sanaee via
` (3 preceding siblings ...)
(?)
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Prepare to update `build_pptt` function to add cache description
functionalities, thus add binaries in this patch.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..ba2a8180e9 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/aarch64/virt/PPTT.topology",
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 5/7] hw/acpi/aml-build.c: add cache hierarchy to pptt table
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Add cache topology to PPTT table. With this patch, both ACPI PPTT table
and device tree will represent the same cache topology given users
input.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
hw/acpi/aml-build.c | 235 +++++++++++++++++++++++++++++++++++-
hw/arm/virt-acpi-build.c | 8 +-
include/hw/acpi/aml-build.h | 4 +-
include/hw/cpu/core.h | 1 +
4 files changed, 240 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 15a6bc644a..c92c76ba59 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -1964,6 +1964,107 @@ void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms,
acpi_table_end(linker, &table);
}
+static void build_cache_nodes(GArray *tbl, CPUCaches *cache,
+ uint32_t next_offset, unsigned int id)
+{
+ int val;
+
+ /* Type 1 - cache */
+ build_append_byte(tbl, 1);
+ /* Length */
+ build_append_byte(tbl, 28);
+ /* Reserved */
+ build_append_int_noprefix(tbl, 0, 2);
+ /* Flags - everything except possibly the ID */
+ build_append_int_noprefix(tbl, 0xff, 4);
+ /* Offset of next cache up */
+ build_append_int_noprefix(tbl, next_offset, 4);
+ build_append_int_noprefix(tbl, cache->size, 4);
+ build_append_int_noprefix(tbl, cache->sets, 4);
+ build_append_byte(tbl, cache->associativity);
+ val = 0x3;
+ switch (cache->type) {
+ case INSTRUCTION:
+ val |= (1 << 2);
+ break;
+ case DATA:
+ val |= (0 << 2); /* Data */
+ break;
+ case UNIFIED:
+ val |= (3 << 2); /* Unified */
+ break;
+ }
+ build_append_byte(tbl, val);
+ build_append_int_noprefix(tbl, cache->linesize, 2);
+ build_append_int_noprefix(tbl,
+ (cache->type << 24) | (cache->level << 16) | id,
+ 4);
+}
+
+/*
+ * builds caches from the top level (`level_high` parameter) to the bottom
+ * level (`level_low` parameter). It searches for caches found in
+ * systems' registers, and fills up the table. Then it updates the
+ * `data_offset` and `instr_offset` parameters with the offset of the data
+ * and instruction caches of the lowest level, respectively.
+ */
+static bool build_caches(GArray *table_data, uint32_t pptt_start,
+ int num_caches, CPUCaches *caches,
+ int base_id,
+ uint8_t level_high, /* Inclusive */
+ uint8_t level_low, /* Inclusive */
+ uint32_t *data_offset,
+ uint32_t *instr_offset)
+{
+ uint32_t next_level_offset_data = 0, next_level_offset_instruction = 0;
+ uint32_t this_offset, next_offset = 0;
+ int c, level;
+ bool found_cache = false;
+
+ /* Walk caches from top to bottom */
+ for (level = level_high; level >= level_low; level--) {
+ for (c = 0; c < num_caches; c++) {
+ if (caches[c].level != level) {
+ continue;
+ }
+
+ /* Assume only unified above l1 for now */
+ this_offset = table_data->len - pptt_start;
+ switch (caches[c].type) {
+ case INSTRUCTION:
+ next_offset = next_level_offset_instruction;
+ break;
+ case DATA:
+ next_offset = next_level_offset_data;
+ break;
+ case UNIFIED:
+ /* Either is fine here */
+ next_offset = next_level_offset_instruction;
+ break;
+ }
+ build_cache_nodes(table_data, &caches[c], next_offset, base_id);
+ switch (caches[c].type) {
+ case INSTRUCTION:
+ next_level_offset_instruction = this_offset;
+ break;
+ case DATA:
+ next_level_offset_data = this_offset;
+ break;
+ case UNIFIED:
+ next_level_offset_instruction = this_offset;
+ next_level_offset_data = this_offset;
+ break;
+ }
+ *data_offset = next_level_offset_data;
+ *instr_offset = next_level_offset_instruction;
+
+ found_cache = true;
+ }
+ }
+
+ return found_cache;
+}
+
/*
* ACPI spec, Revision 6.3
* 5.2.29.1 Processor hierarchy node structure (Type 0)
@@ -2052,15 +2153,25 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,
* 5.2.29 Processor Properties Topology Table (PPTT)
*/
void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
- const char *oem_id, const char *oem_table_id)
+ const char *oem_id, const char *oem_table_id,
+ int num_caches, CPUCaches *caches)
{
MachineClass *mc = MACHINE_GET_CLASS(ms);
CPUArchIdList *cpus = ms->possible_cpus;
+ uint32_t thread_instr_offset = 0, thread_data_offset = 0;
+ uint32_t core_data_offset = 0, core_instr_offset = 0;
+ uint32_t cluster_instr_offset = 0, cluster_data_offset = 0;
+ uint32_t node_data_offset = 0, node_instr_offset = 0;
+ int top_node = 3, top_cluster = 3, top_core = 3, top_thread = 3;
+ int bottom_node = 3, bottom_cluster = 3, bottom_core = 3, bottom_thread = 3;
int64_t socket_id = -1, cluster_id = -1, core_id = -1;
uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
uint32_t pptt_start = table_data->len;
uint32_t root_offset;
int n;
+ uint32_t priv_rsrc[2];
+ uint32_t num_priv = 0;
+
AcpiTable table = { .sig = "PPTT", .rev = 3,
.oem_id = oem_id, .oem_table_id = oem_table_id };
@@ -2090,11 +2201,35 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
socket_id = cpus->cpus[n].props.socket_id;
cluster_id = -1;
core_id = -1;
+ bottom_node = top_node;
+ num_priv = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_node,
+ CPU_TOPOLOGY_LEVEL_SOCKET))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_node, bottom_node,
+ &node_data_offset, &node_instr_offset);
+
+ priv_rsrc[0] = node_instr_offset;
+ priv_rsrc[1] = node_data_offset;
+
+ if (node_instr_offset || node_data_offset) {
+ num_priv = node_instr_offset == node_data_offset ? 1 : 2;
+ }
+
+ top_cluster = bottom_node - 1;
+ }
+
socket_offset = table_data->len - pptt_start;
build_processor_hierarchy_node(table_data,
(1 << 0) | /* Physical package */
(1 << 4), /* Identical Implementation */
- root_offset, socket_id, NULL, 0);
+ root_offset, socket_id,
+ priv_rsrc, num_priv);
}
if (mc->smp_props.clusters_supported && mc->smp_props.has_clusters) {
@@ -2102,21 +2237,89 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
assert(cpus->cpus[n].props.cluster_id > cluster_id);
cluster_id = cpus->cpus[n].props.cluster_id;
core_id = -1;
+ bottom_cluster = top_cluster;
+ num_priv = 0;
+
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_cluster,
+ CPU_TOPOLOGY_LEVEL_CLUSTER))
+ {
+
+ build_caches(table_data, pptt_start,
+ num_caches, caches, n, top_cluster,
+ bottom_cluster, &cluster_data_offset,
+ &cluster_instr_offset);
+
+ priv_rsrc[0] = cluster_instr_offset;
+ priv_rsrc[1] = cluster_data_offset;
+
+ if (cluster_instr_offset || cluster_data_offset) {
+ num_priv =
+ cluster_instr_offset == cluster_data_offset ? 1 : 2;
+ }
+
+ top_core = bottom_cluster - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache */
+ top_core = bottom_node - 1;
+ }
+
cluster_offset = table_data->len - pptt_start;
build_processor_hierarchy_node(table_data,
(0 << 0) | /* Not a physical package */
(1 << 4), /* Identical Implementation */
- socket_offset, cluster_id, NULL, 0);
+ socket_offset, cluster_id,
+ priv_rsrc, num_priv);
}
} else {
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER)) {
+ error_setg(&error_fatal, "Not clusters found for the cache");
+ return;
+ }
+
cluster_offset = socket_offset;
+ top_core = bottom_node - 1; /* there is no cluster */
}
+ if (cpus->cpus[n].props.core_id != core_id) {
+ bottom_core = top_core;
+ num_priv = 0;
+
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CORE) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_core,
+ CPU_TOPOLOGY_LEVEL_CORE))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_core, bottom_core,
+ &core_data_offset, &core_instr_offset);
+
+ priv_rsrc[0] = core_instr_offset;
+ priv_rsrc[1] = core_data_offset;
+
+ num_priv = core_instr_offset == core_data_offset ? 1 : 2;
+
+ top_thread = bottom_core - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache and no core cache */
+ top_thread = top_cluster;
+ } else if (top_core == bottom_cluster - 1) {
+ /* cluster cache but no socket and no core cache */
+ top_thread = top_core;
+ }
+ }
+
+
if (ms->smp.threads == 1) {
build_processor_hierarchy_node(table_data,
(1 << 1) | /* ACPI Processor ID valid */
(1 << 3), /* Node is a Leaf */
- cluster_offset, n, NULL, 0);
+ cluster_offset, n,
+ priv_rsrc, num_priv);
} else {
if (cpus->cpus[n].props.core_id != core_id) {
assert(cpus->cpus[n].props.core_id > core_id);
@@ -2125,14 +2328,34 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
build_processor_hierarchy_node(table_data,
(0 << 0) | /* Not a physical package */
(1 << 4), /* Identical Implementation */
- cluster_offset, core_id, NULL, 0);
+ cluster_offset, core_id,
+ priv_rsrc, num_priv);
+ }
+
+ num_priv = 0;
+ bottom_thread = top_thread;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_THREAD) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_thread,
+ CPU_TOPOLOGY_LEVEL_THREAD))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_thread, bottom_thread,
+ &thread_data_offset, &thread_instr_offset);
+
+ priv_rsrc[0] = thread_instr_offset;
+ priv_rsrc[1] = thread_data_offset;
+
+ num_priv = thread_instr_offset == thread_data_offset ? 1 : 2;
}
build_processor_hierarchy_node(table_data,
(1 << 1) | /* ACPI Processor ID valid */
(1 << 2) | /* Processor is a Thread */
(1 << 3), /* Node is a Leaf */
- core_offset, n, NULL, 0);
+ core_offset, n, priv_rsrc, num_priv);
}
}
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f76fb117ad..4b35c576ce 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -899,6 +899,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
GArray *tables_blob = tables->table_data;
MachineState *ms = MACHINE(vms);
+ CPUCaches caches[CPU_MAX_CACHES]; /* Can select up to 16 */
+ unsigned int num_caches;
+
+ num_caches = virt_get_caches(vms, caches);
+
table_offsets = g_array_new(false, true /* clear */,
sizeof(uint32_t));
@@ -920,7 +925,8 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
if (!vmc->no_cpu_topology) {
acpi_add_table(table_offsets, tables_blob);
build_pptt(tables_blob, tables->linker, ms,
- vms->oem_id, vms->oem_table_id);
+ vms->oem_id, vms->oem_table_id,
+ num_caches, caches);
}
acpi_add_table(table_offsets, tables_blob);
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index a3784155cb..01555dfc12 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -3,6 +3,7 @@
#include "hw/acpi/acpi-defs.h"
#include "hw/acpi/bios-linker-loader.h"
+#include "hw/cpu/core.h"
#define ACPI_BUILD_APPNAME6 "BOCHS "
#define ACPI_BUILD_APPNAME8 "BXPC "
@@ -490,7 +491,8 @@ void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms,
const char *oem_id, const char *oem_table_id);
void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
- const char *oem_id, const char *oem_table_id);
+ const char *oem_id, const char *oem_table_id,
+ int num_caches, CPUCaches *caches);
void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f,
const char *oem_id, const char *oem_table_id);
diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
index bcb9f7bb3e..559e05d24a 100644
--- a/include/hw/cpu/core.h
+++ b/include/hw/cpu/core.h
@@ -11,6 +11,7 @@
#include "hw/qdev-core.h"
#include "qom/object.h"
+#include "qapi/qapi-types-machine-common.h"
#define TYPE_CPU_CORE "cpu-core"
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 5/7] hw/acpi/aml-build.c: add cache hierarchy to pptt table
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Add cache topology to PPTT table. With this patch, both ACPI PPTT table
and device tree will represent the same cache topology given users
input.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
---
hw/acpi/aml-build.c | 235 +++++++++++++++++++++++++++++++++++-
hw/arm/virt-acpi-build.c | 8 +-
include/hw/acpi/aml-build.h | 4 +-
include/hw/cpu/core.h | 1 +
4 files changed, 240 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 15a6bc644a..c92c76ba59 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -1964,6 +1964,107 @@ void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms,
acpi_table_end(linker, &table);
}
+static void build_cache_nodes(GArray *tbl, CPUCaches *cache,
+ uint32_t next_offset, unsigned int id)
+{
+ int val;
+
+ /* Type 1 - cache */
+ build_append_byte(tbl, 1);
+ /* Length */
+ build_append_byte(tbl, 28);
+ /* Reserved */
+ build_append_int_noprefix(tbl, 0, 2);
+ /* Flags - everything except possibly the ID */
+ build_append_int_noprefix(tbl, 0xff, 4);
+ /* Offset of next cache up */
+ build_append_int_noprefix(tbl, next_offset, 4);
+ build_append_int_noprefix(tbl, cache->size, 4);
+ build_append_int_noprefix(tbl, cache->sets, 4);
+ build_append_byte(tbl, cache->associativity);
+ val = 0x3;
+ switch (cache->type) {
+ case INSTRUCTION:
+ val |= (1 << 2);
+ break;
+ case DATA:
+ val |= (0 << 2); /* Data */
+ break;
+ case UNIFIED:
+ val |= (3 << 2); /* Unified */
+ break;
+ }
+ build_append_byte(tbl, val);
+ build_append_int_noprefix(tbl, cache->linesize, 2);
+ build_append_int_noprefix(tbl,
+ (cache->type << 24) | (cache->level << 16) | id,
+ 4);
+}
+
+/*
+ * builds caches from the top level (`level_high` parameter) to the bottom
+ * level (`level_low` parameter). It searches for caches found in
+ * systems' registers, and fills up the table. Then it updates the
+ * `data_offset` and `instr_offset` parameters with the offset of the data
+ * and instruction caches of the lowest level, respectively.
+ */
+static bool build_caches(GArray *table_data, uint32_t pptt_start,
+ int num_caches, CPUCaches *caches,
+ int base_id,
+ uint8_t level_high, /* Inclusive */
+ uint8_t level_low, /* Inclusive */
+ uint32_t *data_offset,
+ uint32_t *instr_offset)
+{
+ uint32_t next_level_offset_data = 0, next_level_offset_instruction = 0;
+ uint32_t this_offset, next_offset = 0;
+ int c, level;
+ bool found_cache = false;
+
+ /* Walk caches from top to bottom */
+ for (level = level_high; level >= level_low; level--) {
+ for (c = 0; c < num_caches; c++) {
+ if (caches[c].level != level) {
+ continue;
+ }
+
+ /* Assume only unified above l1 for now */
+ this_offset = table_data->len - pptt_start;
+ switch (caches[c].type) {
+ case INSTRUCTION:
+ next_offset = next_level_offset_instruction;
+ break;
+ case DATA:
+ next_offset = next_level_offset_data;
+ break;
+ case UNIFIED:
+ /* Either is fine here */
+ next_offset = next_level_offset_instruction;
+ break;
+ }
+ build_cache_nodes(table_data, &caches[c], next_offset, base_id);
+ switch (caches[c].type) {
+ case INSTRUCTION:
+ next_level_offset_instruction = this_offset;
+ break;
+ case DATA:
+ next_level_offset_data = this_offset;
+ break;
+ case UNIFIED:
+ next_level_offset_instruction = this_offset;
+ next_level_offset_data = this_offset;
+ break;
+ }
+ *data_offset = next_level_offset_data;
+ *instr_offset = next_level_offset_instruction;
+
+ found_cache = true;
+ }
+ }
+
+ return found_cache;
+}
+
/*
* ACPI spec, Revision 6.3
* 5.2.29.1 Processor hierarchy node structure (Type 0)
@@ -2052,15 +2153,25 @@ void build_spcr(GArray *table_data, BIOSLinker *linker,
* 5.2.29 Processor Properties Topology Table (PPTT)
*/
void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
- const char *oem_id, const char *oem_table_id)
+ const char *oem_id, const char *oem_table_id,
+ int num_caches, CPUCaches *caches)
{
MachineClass *mc = MACHINE_GET_CLASS(ms);
CPUArchIdList *cpus = ms->possible_cpus;
+ uint32_t thread_instr_offset = 0, thread_data_offset = 0;
+ uint32_t core_data_offset = 0, core_instr_offset = 0;
+ uint32_t cluster_instr_offset = 0, cluster_data_offset = 0;
+ uint32_t node_data_offset = 0, node_instr_offset = 0;
+ int top_node = 3, top_cluster = 3, top_core = 3, top_thread = 3;
+ int bottom_node = 3, bottom_cluster = 3, bottom_core = 3, bottom_thread = 3;
int64_t socket_id = -1, cluster_id = -1, core_id = -1;
uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
uint32_t pptt_start = table_data->len;
uint32_t root_offset;
int n;
+ uint32_t priv_rsrc[2];
+ uint32_t num_priv = 0;
+
AcpiTable table = { .sig = "PPTT", .rev = 3,
.oem_id = oem_id, .oem_table_id = oem_table_id };
@@ -2090,11 +2201,35 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
socket_id = cpus->cpus[n].props.socket_id;
cluster_id = -1;
core_id = -1;
+ bottom_node = top_node;
+ num_priv = 0;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_node,
+ CPU_TOPOLOGY_LEVEL_SOCKET))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_node, bottom_node,
+ &node_data_offset, &node_instr_offset);
+
+ priv_rsrc[0] = node_instr_offset;
+ priv_rsrc[1] = node_data_offset;
+
+ if (node_instr_offset || node_data_offset) {
+ num_priv = node_instr_offset == node_data_offset ? 1 : 2;
+ }
+
+ top_cluster = bottom_node - 1;
+ }
+
socket_offset = table_data->len - pptt_start;
build_processor_hierarchy_node(table_data,
(1 << 0) | /* Physical package */
(1 << 4), /* Identical Implementation */
- root_offset, socket_id, NULL, 0);
+ root_offset, socket_id,
+ priv_rsrc, num_priv);
}
if (mc->smp_props.clusters_supported && mc->smp_props.has_clusters) {
@@ -2102,21 +2237,89 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
assert(cpus->cpus[n].props.cluster_id > cluster_id);
cluster_id = cpus->cpus[n].props.cluster_id;
core_id = -1;
+ bottom_cluster = top_cluster;
+ num_priv = 0;
+
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_cluster,
+ CPU_TOPOLOGY_LEVEL_CLUSTER))
+ {
+
+ build_caches(table_data, pptt_start,
+ num_caches, caches, n, top_cluster,
+ bottom_cluster, &cluster_data_offset,
+ &cluster_instr_offset);
+
+ priv_rsrc[0] = cluster_instr_offset;
+ priv_rsrc[1] = cluster_data_offset;
+
+ if (cluster_instr_offset || cluster_data_offset) {
+ num_priv =
+ cluster_instr_offset == cluster_data_offset ? 1 : 2;
+ }
+
+ top_core = bottom_cluster - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache */
+ top_core = bottom_node - 1;
+ }
+
cluster_offset = table_data->len - pptt_start;
build_processor_hierarchy_node(table_data,
(0 << 0) | /* Not a physical package */
(1 << 4), /* Identical Implementation */
- socket_offset, cluster_id, NULL, 0);
+ socket_offset, cluster_id,
+ priv_rsrc, num_priv);
}
} else {
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CLUSTER)) {
+ error_setg(&error_fatal, "Not clusters found for the cache");
+ return;
+ }
+
cluster_offset = socket_offset;
+ top_core = bottom_node - 1; /* there is no cluster */
}
+ if (cpus->cpus[n].props.core_id != core_id) {
+ bottom_core = top_core;
+ num_priv = 0;
+
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_CORE) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_core,
+ CPU_TOPOLOGY_LEVEL_CORE))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_core, bottom_core,
+ &core_data_offset, &core_instr_offset);
+
+ priv_rsrc[0] = core_instr_offset;
+ priv_rsrc[1] = core_data_offset;
+
+ num_priv = core_instr_offset == core_data_offset ? 1 : 2;
+
+ top_thread = bottom_core - 1;
+ } else if (top_cluster == bottom_node - 1) {
+ /* socket cache but no cluster cache and no core cache */
+ top_thread = top_cluster;
+ } else if (top_core == bottom_cluster - 1) {
+ /* cluster cache but no socket and no core cache */
+ top_thread = top_core;
+ }
+ }
+
+
if (ms->smp.threads == 1) {
build_processor_hierarchy_node(table_data,
(1 << 1) | /* ACPI Processor ID valid */
(1 << 3), /* Node is a Leaf */
- cluster_offset, n, NULL, 0);
+ cluster_offset, n,
+ priv_rsrc, num_priv);
} else {
if (cpus->cpus[n].props.core_id != core_id) {
assert(cpus->cpus[n].props.core_id > core_id);
@@ -2125,14 +2328,34 @@ void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
build_processor_hierarchy_node(table_data,
(0 << 0) | /* Not a physical package */
(1 << 4), /* Identical Implementation */
- cluster_offset, core_id, NULL, 0);
+ cluster_offset, core_id,
+ priv_rsrc, num_priv);
+ }
+
+ num_priv = 0;
+ bottom_thread = top_thread;
+ if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_THREAD) &&
+ find_the_lowest_level_cache_defined_at_level(
+ ms,
+ &bottom_thread,
+ CPU_TOPOLOGY_LEVEL_THREAD))
+ {
+ build_caches(table_data, pptt_start,
+ num_caches, caches,
+ n, top_thread, bottom_thread,
+ &thread_data_offset, &thread_instr_offset);
+
+ priv_rsrc[0] = thread_instr_offset;
+ priv_rsrc[1] = thread_data_offset;
+
+ num_priv = thread_instr_offset == thread_data_offset ? 1 : 2;
}
build_processor_hierarchy_node(table_data,
(1 << 1) | /* ACPI Processor ID valid */
(1 << 2) | /* Processor is a Thread */
(1 << 3), /* Node is a Leaf */
- core_offset, n, NULL, 0);
+ core_offset, n, priv_rsrc, num_priv);
}
}
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index f76fb117ad..4b35c576ce 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -899,6 +899,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
GArray *tables_blob = tables->table_data;
MachineState *ms = MACHINE(vms);
+ CPUCaches caches[CPU_MAX_CACHES]; /* Can select up to 16 */
+ unsigned int num_caches;
+
+ num_caches = virt_get_caches(vms, caches);
+
table_offsets = g_array_new(false, true /* clear */,
sizeof(uint32_t));
@@ -920,7 +925,8 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
if (!vmc->no_cpu_topology) {
acpi_add_table(table_offsets, tables_blob);
build_pptt(tables_blob, tables->linker, ms,
- vms->oem_id, vms->oem_table_id);
+ vms->oem_id, vms->oem_table_id,
+ num_caches, caches);
}
acpi_add_table(table_offsets, tables_blob);
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index a3784155cb..01555dfc12 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -3,6 +3,7 @@
#include "hw/acpi/acpi-defs.h"
#include "hw/acpi/bios-linker-loader.h"
+#include "hw/cpu/core.h"
#define ACPI_BUILD_APPNAME6 "BOCHS "
#define ACPI_BUILD_APPNAME8 "BXPC "
@@ -490,7 +491,8 @@ void build_slit(GArray *table_data, BIOSLinker *linker, MachineState *ms,
const char *oem_id, const char *oem_table_id);
void build_pptt(GArray *table_data, BIOSLinker *linker, MachineState *ms,
- const char *oem_id, const char *oem_table_id);
+ const char *oem_id, const char *oem_table_id,
+ int num_caches, CPUCaches *caches);
void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f,
const char *oem_id, const char *oem_table_id);
diff --git a/include/hw/cpu/core.h b/include/hw/cpu/core.h
index bcb9f7bb3e..559e05d24a 100644
--- a/include/hw/cpu/core.h
+++ b/include/hw/cpu/core.h
@@ -11,6 +11,7 @@
#include "hw/qdev-core.h"
#include "qom/object.h"
+#include "qapi/qapi-types-machine-common.h"
#define TYPE_CPU_CORE "cpu-core"
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Test new PPTT topolopy with cache representation.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/qtest/bios-tables-test.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 36e5c0adde..0f72520664 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -2019,7 +2019,11 @@ static void test_acpi_aarch64_virt_tcg_topology(void)
.scan_len = 128ULL * 1024 * 1024,
};
- test_acpi_one("-cpu cortex-a57 "
+ test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
+ "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
+ "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
+ "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
+ "-cpu cortex-a57 "
"-smp sockets=1,clusters=2,cores=2,threads=2", &data);
free_test_data(&data);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
Test new PPTT topolopy with cache representation.
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/qtest/bios-tables-test.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 36e5c0adde..0f72520664 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -2019,7 +2019,11 @@ static void test_acpi_aarch64_virt_tcg_topology(void)
.scan_len = 128ULL * 1024 * 1024,
};
- test_acpi_one("-cpu cortex-a57 "
+ test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
+ "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
+ "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
+ "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
+ "-cpu cortex-a57 "
"-smp sockets=1,clusters=2,cores=2,threads=2", &data);
free_test_data(&data);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-16 17:54 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
The disassembled differences between actual and expected PPTT based on
the following cache topology representation:
```
test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
"smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
"smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
"smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
"-cpu cortex-a57 "
"-smp sockets=1,clusters=2,cores=2,threads=2", &data);
```
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20200925 (64-bit version)
* Copyright (c) 2000 - 2020 Intel Corporation
*
* Disassembly of ../../../tests/data/acpi/aarch64/virt/PPTT.topology, Mon Oct 7 16:57:29 2024
*
* ACPI Data Table [PPTT]
*
* Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
*/
[000h 0000 4] Signature : "PPTT" [Processor Properties Topology Table]
[004h 0004 4] Table Length : 0000021C
[008h 0008 1] Revision : 03
[009h 0009 1] Checksum : 4D
[00Ah 0010 6] Oem ID : "BOCHS "
[010h 0016 8] Oem Table ID : "BXPC "
[018h 0024 4] Oem Revision : 00000001
[01Ch 0028 4] Asl Compiler ID : "BXPC"
[020h 0032 4] Asl Compiler Revision : 00000001
[024h 0036 1] Subtable Type : 00 [Processor Hierarchy Node]
[025h 0037 1] Length : 14
[026h 0038 2] Reserved : 0000
[028h 0040 4] Flags (decoded below) : 00000011
Physical package : 1
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[02Ch 0044 4] Parent : 00000000
[030h 0048 4] ACPI Processor ID : 00000000
[034h 0052 4] Private Resource Number : 00000000
[038h 0056 1] Subtable Type : 00 [Processor Hierarchy Node]
[039h 0057 1] Length : 14
[03Ah 0058 2] Reserved : 0000
[03Ch 0060 4] Flags (decoded below) : 00000011
Physical package : 1
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[040h 0064 4] Parent : 00000024
[044h 0068 4] ACPI Processor ID : 00000000
[048h 0072 4] Private Resource Number : 00000000
[04Ch 0076 1] Subtable Type : 01 [Cache Type]
[04Dh 0077 1] Length : 1C
[04Eh 0078 2] Reserved : 0000
[050h 0080 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[054h 0084 4] Next Level of Cache : 00000000
[058h 0088 4] Size : 00200000
[05Ch 0092 4] Number of Sets : 00000800
[060h 0096 1] Associativity : 10
[061h 0097 1] Attributes : 0F
Allocation Type : 3
Cache Type : 3
Write Policy : 0
[062h 0098 2] Line Size : 0040
[068h 0104 1] Subtable Type : 01 [Cache Type]
[069h 0105 1] Length : 1C
[06Ah 0106 2] Reserved : 0000
[06Ch 0108 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[070h 0112 4] Next Level of Cache : 0000004C
[074h 0116 4] Size : 00008000
[078h 0120 4] Number of Sets : 00000080
[07Ch 0124 1] Associativity : 04
[07Dh 0125 1] Attributes : 03
Allocation Type : 3
Cache Type : 0
Write Policy : 0
[07Eh 0126 2] Line Size : 0040
[084h 0132 1] Subtable Type : 01 [Cache Type]
[085h 0133 1] Length : 1C
[086h 0134 2] Reserved : 0000
[088h 0136 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[08Ch 0140 4] Next Level of Cache : 0000004C
[090h 0144 4] Size : 0000C000
[094h 0148 4] Number of Sets : 00000100
[098h 0152 1] Associativity : 03
[099h 0153 1] Attributes : 07
Allocation Type : 3
Cache Type : 1
Write Policy : 0
[09Ah 0154 2] Line Size : 0040
[0A0h 0160 1] Subtable Type : 00 [Processor Hierarchy Node]
[0A1h 0161 1] Length : 1C
[0A2h 0162 2] Reserved : 0000
[0A4h 0164 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0A8h 0168 4] Parent : 00000038
[0ACh 0172 4] ACPI Processor ID : 00000000
[0B0h 0176 4] Private Resource Number : 00000002
[0B4h 0180 4] Private Resource : 00000084
[0B8h 0184 4] Private Resource : 00000068
[0BCh 0188 1] Subtable Type : 00 [Processor Hierarchy Node]
[0BDh 0189 1] Length : 14
[0BEh 0190 2] Reserved : 0000
[0C0h 0192 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0C4h 0196 4] Parent : 000000A0
[0C8h 0200 4] ACPI Processor ID : 00000000
[0CCh 0204 4] Private Resource Number : 00000000
[0D0h 0208 1] Subtable Type : 00 [Processor Hierarchy Node]
[0D1h 0209 1] Length : 14
[0D2h 0210 2] Reserved : 0000
[0D4h 0212 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[0D8h 0216 4] Parent : 000000BC
[0DCh 0220 4] ACPI Processor ID : 00000000
[0E0h 0224 4] Private Resource Number : 00000000
[0E4h 0228 1] Subtable Type : 00 [Processor Hierarchy Node]
[0E5h 0229 1] Length : 14
[0E6h 0230 2] Reserved : 0000
[0E8h 0232 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[0ECh 0236 4] Parent : 000000BC
[0F0h 0240 4] ACPI Processor ID : 00000001
[0F4h 0244 4] Private Resource Number : 00000000
[0F8h 0248 1] Subtable Type : 00 [Processor Hierarchy Node]
[0F9h 0249 1] Length : 14
[0FAh 0250 2] Reserved : 0000
[0FCh 0252 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[100h 0256 4] Parent : 000000A0
[104h 0260 4] ACPI Processor ID : 00000001
[108h 0264 4] Private Resource Number : 00000000
[10Ch 0268 1] Subtable Type : 00 [Processor Hierarchy Node]
[10Dh 0269 1] Length : 14
[10Eh 0270 2] Reserved : 0000
[110h 0272 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[114h 0276 4] Parent : 000000F8
[118h 0280 4] ACPI Processor ID : 00000002
[11Ch 0284 4] Private Resource Number : 00000000
[120h 0288 1] Subtable Type : 00 [Processor Hierarchy Node]
[121h 0289 1] Length : 14
[122h 0290 2] Reserved : 0000
[124h 0292 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[128h 0296 4] Parent : 000000F8
[12Ch 0300 4] ACPI Processor ID : 00000003
[130h 0304 4] Private Resource Number : 00000000
[134h 0308 1] Subtable Type : 01 [Cache Type]
[135h 0309 1] Length : 1C
[136h 0310 2] Reserved : 0000
[138h 0312 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[13Ch 0316 4] Next Level of Cache : 00000000
[140h 0320 4] Size : 00200000
[144h 0324 4] Number of Sets : 00000800
[148h 0328 1] Associativity : 10
[149h 0329 1] Attributes : 0F
Allocation Type : 3
Cache Type : 3
Write Policy : 0
[14Ah 0330 2] Line Size : 0040
[150h 0336 1] Subtable Type : 01 [Cache Type]
[151h 0337 1] Length : 1C
[152h 0338 2] Reserved : 0000
[154h 0340 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[158h 0344 4] Next Level of Cache : 00000134
[15Ch 0348 4] Size : 00008000
[160h 0352 4] Number of Sets : 00000080
[164h 0356 1] Associativity : 04
[165h 0357 1] Attributes : 03
Allocation Type : 3
Cache Type : 0
Write Policy : 0
[166h 0358 2] Line Size : 0040
[16Ch 0364 1] Subtable Type : 01 [Cache Type]
[16Dh 0365 1] Length : 1C
[16Eh 0366 2] Reserved : 0000
[170h 0368 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[174h 0372 4] Next Level of Cache : 00000134
[178h 0376 4] Size : 0000C000
[17Ch 0380 4] Number of Sets : 00000100
[180h 0384 1] Associativity : 03
[181h 0385 1] Attributes : 07
Allocation Type : 3
Cache Type : 1
Write Policy : 0
[182h 0386 2] Line Size : 0040
[188h 0392 1] Subtable Type : 00 [Processor Hierarchy Node]
[189h 0393 1] Length : 1C
[18Ah 0394 2] Reserved : 0000
[18Ch 0396 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[190h 0400 4] Parent : 00000038
[194h 0404 4] ACPI Processor ID : 00000001
[198h 0408 4] Private Resource Number : 00000002
[19Ch 0412 4] Private Resource : 0000016C
[1A0h 0416 4] Private Resource : 00000150
[1A4h 0420 1] Subtable Type : 00 [Processor Hierarchy Node]
[1A5h 0421 1] Length : 14
[1A6h 0422 2] Reserved : 0000
[1A8h 0424 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[1ACh 0428 4] Parent : 00000188
[1B0h 0432 4] ACPI Processor ID : 00000000
[1B4h 0436 4] Private Resource Number : 00000000
[1B8h 0440 1] Subtable Type : 00 [Processor Hierarchy Node]
[1B9h 0441 1] Length : 14
[1BAh 0442 2] Reserved : 0000
[1BCh 0444 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[1C0h 0448 4] Parent : 000001A4
[1C4h 0452 4] ACPI Processor ID : 00000004
[1C8h 0456 4] Private Resource Number : 00000000
[1CCh 0460 1] Subtable Type : 00 [Processor Hierarchy Node]
[1CDh 0461 1] Length : 14
[1CEh 0462 2] Reserved : 0000
[1D0h 0464 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[1D4h 0468 4] Parent : 000001A4
[1D8h 0472 4] ACPI Processor ID : 00000005
[1DCh 0476 4] Private Resource Number : 00000000
[1E0h 0480 1] Subtable Type : 00 [Processor Hierarchy Node]
[1E1h 0481 1] Length : 14
[1E2h 0482 2] Reserved : 0000
[1E4h 0484 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[1E8h 0488 4] Parent : 00000188
[1ECh 0492 4] ACPI Processor ID : 00000001
[1F0h 0496 4] Private Resource Number : 00000000
[1F4h 0500 1] Subtable Type : 00 [Processor Hierarchy Node]
[1F5h 0501 1] Length : 14
[1F6h 0502 2] Reserved : 0000
[1F8h 0504 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[1FCh 0508 4] Parent : 000001E0
[200h 0512 4] ACPI Processor ID : 00000006
[204h 0516 4] Private Resource Number : 00000000
[208h 0520 1] Subtable Type : 00 [Processor Hierarchy Node]
[209h 0521 1] Length : 14
[20Ah 0522 2] Reserved : 0000
[20Ch 0524 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[210h 0528 4] Parent : 000001E0
[214h 0532 4] ACPI Processor ID : 00000007
[218h 0536 4] Private Resource Number : 00000000
Raw Table Data: Length 540 (0x21C)
0000: 50 50 54 54 1C 02 00 00 03 4D 42 4F 43 48 53 20 // PPTT.....MBOCHS
0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
0020: 01 00 00 00 00 14 00 00 11 00 00 00 00 00 00 00 // ................
0030: 00 00 00 00 00 00 00 00 00 14 00 00 11 00 00 00 // ................
0040: 24 00 00 00 00 00 00 00 00 00 00 00 01 1C 00 00 // $...............
0050: FF 00 00 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... .....
0060: 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 // ..@.............
0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40 00 // L.............@.
0080: 00 00 01 00 01 1C 00 00 FF 00 00 00 4C 00 00 00 // ............L...
0090: 00 C0 00 00 00 01 00 00 03 07 40 00 00 00 01 01 // ..........@.....
00A0: 00 1C 00 00 10 00 00 00 38 00 00 00 00 00 00 00 // ........8.......
00B0: 02 00 00 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h.......
00C0: 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 // ................
00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00 00 // ................
00E0: 00 00 00 00 00 14 00 00 0E 00 00 00 BC 00 00 00 // ................
00F0: 01 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
0100: A0 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
0110: 0E 00 00 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................
0120: 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 // ................
0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00 00 // ................
0140: 00 00 20 00 00 08 00 00 10 0F 40 00 04 00 02 02 // .. .......@.....
0150: 01 1C 00 00 FF 00 00 00 34 01 00 00 00 80 00 00 // ........4.......
0160: 80 00 00 00 04 03 40 00 04 00 01 00 01 1C 00 00 // ......@.........
0170: FF 00 00 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4...........
0180: 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 // ..@.............
0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00 00 // 8...........l...
01A0: 50 01 00 00 00 14 00 00 10 00 00 00 88 01 00 00 // P...............
01B0: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
01C0: A4 01 00 00 04 00 00 00 00 00 00 00 00 14 00 00 // ................
01D0: 0E 00 00 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................
01E0: 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 // ................
01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00 00 // ................
0200: 06 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
0210: E0 01 00 00 07 00 00 00 00 00 00 00 // ............
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
2 files changed, 1 deletion(-)
diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology b/tests/data/acpi/aarch64/virt/PPTT.topology
index d0e5e11e90f33cbbbc231f9ad0bd48419e0fea65..f5f07b87c3777106e74f380de7941e1c01fc3447 100644
GIT binary patch
literal 540
zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!luq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
z%e!y9_D)?lO%?*tuH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
S>h0TY?~`Ec-II5*#Ig@|86g1x
literal 356
zcmWFt2nk7HWME*P=H&0}5v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?*x0RR91
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index ba2a8180e9..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,2 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/aarch64/virt/PPTT.topology",
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.
@ 2024-12-16 17:54 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-16 17:54 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: zhao1.liu, zhenyu.z.wang, dapeng1.mi, yongwei.ma, armbru, farman,
peter.maydell, mst, anisinha, shannon.zhaosl, imammedo, mtosatti,
berrange, richard.henderson, linuxarm, shameerali.kolothum.thodi,
Jonathan.Cameron, jiangkunkun, yangyicong, sarsanaee
The disassembled differences between actual and expected PPTT based on
the following cache topology representation:
```
test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
"smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
"smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
"smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
"-cpu cortex-a57 "
"-smp sockets=1,clusters=2,cores=2,threads=2", &data);
```
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20200925 (64-bit version)
* Copyright (c) 2000 - 2020 Intel Corporation
*
* Disassembly of ../../../tests/data/acpi/aarch64/virt/PPTT.topology, Mon Oct 7 16:57:29 2024
*
* ACPI Data Table [PPTT]
*
* Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
*/
[000h 0000 4] Signature : "PPTT" [Processor Properties Topology Table]
[004h 0004 4] Table Length : 0000021C
[008h 0008 1] Revision : 03
[009h 0009 1] Checksum : 4D
[00Ah 0010 6] Oem ID : "BOCHS "
[010h 0016 8] Oem Table ID : "BXPC "
[018h 0024 4] Oem Revision : 00000001
[01Ch 0028 4] Asl Compiler ID : "BXPC"
[020h 0032 4] Asl Compiler Revision : 00000001
[024h 0036 1] Subtable Type : 00 [Processor Hierarchy Node]
[025h 0037 1] Length : 14
[026h 0038 2] Reserved : 0000
[028h 0040 4] Flags (decoded below) : 00000011
Physical package : 1
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[02Ch 0044 4] Parent : 00000000
[030h 0048 4] ACPI Processor ID : 00000000
[034h 0052 4] Private Resource Number : 00000000
[038h 0056 1] Subtable Type : 00 [Processor Hierarchy Node]
[039h 0057 1] Length : 14
[03Ah 0058 2] Reserved : 0000
[03Ch 0060 4] Flags (decoded below) : 00000011
Physical package : 1
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[040h 0064 4] Parent : 00000024
[044h 0068 4] ACPI Processor ID : 00000000
[048h 0072 4] Private Resource Number : 00000000
[04Ch 0076 1] Subtable Type : 01 [Cache Type]
[04Dh 0077 1] Length : 1C
[04Eh 0078 2] Reserved : 0000
[050h 0080 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[054h 0084 4] Next Level of Cache : 00000000
[058h 0088 4] Size : 00200000
[05Ch 0092 4] Number of Sets : 00000800
[060h 0096 1] Associativity : 10
[061h 0097 1] Attributes : 0F
Allocation Type : 3
Cache Type : 3
Write Policy : 0
[062h 0098 2] Line Size : 0040
[068h 0104 1] Subtable Type : 01 [Cache Type]
[069h 0105 1] Length : 1C
[06Ah 0106 2] Reserved : 0000
[06Ch 0108 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[070h 0112 4] Next Level of Cache : 0000004C
[074h 0116 4] Size : 00008000
[078h 0120 4] Number of Sets : 00000080
[07Ch 0124 1] Associativity : 04
[07Dh 0125 1] Attributes : 03
Allocation Type : 3
Cache Type : 0
Write Policy : 0
[07Eh 0126 2] Line Size : 0040
[084h 0132 1] Subtable Type : 01 [Cache Type]
[085h 0133 1] Length : 1C
[086h 0134 2] Reserved : 0000
[088h 0136 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[08Ch 0140 4] Next Level of Cache : 0000004C
[090h 0144 4] Size : 0000C000
[094h 0148 4] Number of Sets : 00000100
[098h 0152 1] Associativity : 03
[099h 0153 1] Attributes : 07
Allocation Type : 3
Cache Type : 1
Write Policy : 0
[09Ah 0154 2] Line Size : 0040
[0A0h 0160 1] Subtable Type : 00 [Processor Hierarchy Node]
[0A1h 0161 1] Length : 1C
[0A2h 0162 2] Reserved : 0000
[0A4h 0164 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0A8h 0168 4] Parent : 00000038
[0ACh 0172 4] ACPI Processor ID : 00000000
[0B0h 0176 4] Private Resource Number : 00000002
[0B4h 0180 4] Private Resource : 00000084
[0B8h 0184 4] Private Resource : 00000068
[0BCh 0188 1] Subtable Type : 00 [Processor Hierarchy Node]
[0BDh 0189 1] Length : 14
[0BEh 0190 2] Reserved : 0000
[0C0h 0192 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[0C4h 0196 4] Parent : 000000A0
[0C8h 0200 4] ACPI Processor ID : 00000000
[0CCh 0204 4] Private Resource Number : 00000000
[0D0h 0208 1] Subtable Type : 00 [Processor Hierarchy Node]
[0D1h 0209 1] Length : 14
[0D2h 0210 2] Reserved : 0000
[0D4h 0212 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[0D8h 0216 4] Parent : 000000BC
[0DCh 0220 4] ACPI Processor ID : 00000000
[0E0h 0224 4] Private Resource Number : 00000000
[0E4h 0228 1] Subtable Type : 00 [Processor Hierarchy Node]
[0E5h 0229 1] Length : 14
[0E6h 0230 2] Reserved : 0000
[0E8h 0232 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[0ECh 0236 4] Parent : 000000BC
[0F0h 0240 4] ACPI Processor ID : 00000001
[0F4h 0244 4] Private Resource Number : 00000000
[0F8h 0248 1] Subtable Type : 00 [Processor Hierarchy Node]
[0F9h 0249 1] Length : 14
[0FAh 0250 2] Reserved : 0000
[0FCh 0252 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[100h 0256 4] Parent : 000000A0
[104h 0260 4] ACPI Processor ID : 00000001
[108h 0264 4] Private Resource Number : 00000000
[10Ch 0268 1] Subtable Type : 00 [Processor Hierarchy Node]
[10Dh 0269 1] Length : 14
[10Eh 0270 2] Reserved : 0000
[110h 0272 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[114h 0276 4] Parent : 000000F8
[118h 0280 4] ACPI Processor ID : 00000002
[11Ch 0284 4] Private Resource Number : 00000000
[120h 0288 1] Subtable Type : 00 [Processor Hierarchy Node]
[121h 0289 1] Length : 14
[122h 0290 2] Reserved : 0000
[124h 0292 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[128h 0296 4] Parent : 000000F8
[12Ch 0300 4] ACPI Processor ID : 00000003
[130h 0304 4] Private Resource Number : 00000000
[134h 0308 1] Subtable Type : 01 [Cache Type]
[135h 0309 1] Length : 1C
[136h 0310 2] Reserved : 0000
[138h 0312 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[13Ch 0316 4] Next Level of Cache : 00000000
[140h 0320 4] Size : 00200000
[144h 0324 4] Number of Sets : 00000800
[148h 0328 1] Associativity : 10
[149h 0329 1] Attributes : 0F
Allocation Type : 3
Cache Type : 3
Write Policy : 0
[14Ah 0330 2] Line Size : 0040
[150h 0336 1] Subtable Type : 01 [Cache Type]
[151h 0337 1] Length : 1C
[152h 0338 2] Reserved : 0000
[154h 0340 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[158h 0344 4] Next Level of Cache : 00000134
[15Ch 0348 4] Size : 00008000
[160h 0352 4] Number of Sets : 00000080
[164h 0356 1] Associativity : 04
[165h 0357 1] Attributes : 03
Allocation Type : 3
Cache Type : 0
Write Policy : 0
[166h 0358 2] Line Size : 0040
[16Ch 0364 1] Subtable Type : 01 [Cache Type]
[16Dh 0365 1] Length : 1C
[16Eh 0366 2] Reserved : 0000
[170h 0368 4] Flags (decoded below) : 000000FF
Size valid : 1
Number of Sets valid : 1
Associativity valid : 1
Allocation Type valid : 1
Cache Type valid : 1
Write Policy valid : 1
Line Size valid : 1
[174h 0372 4] Next Level of Cache : 00000134
[178h 0376 4] Size : 0000C000
[17Ch 0380 4] Number of Sets : 00000100
[180h 0384 1] Associativity : 03
[181h 0385 1] Attributes : 07
Allocation Type : 3
Cache Type : 1
Write Policy : 0
[182h 0386 2] Line Size : 0040
[188h 0392 1] Subtable Type : 00 [Processor Hierarchy Node]
[189h 0393 1] Length : 1C
[18Ah 0394 2] Reserved : 0000
[18Ch 0396 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[190h 0400 4] Parent : 00000038
[194h 0404 4] ACPI Processor ID : 00000001
[198h 0408 4] Private Resource Number : 00000002
[19Ch 0412 4] Private Resource : 0000016C
[1A0h 0416 4] Private Resource : 00000150
[1A4h 0420 1] Subtable Type : 00 [Processor Hierarchy Node]
[1A5h 0421 1] Length : 14
[1A6h 0422 2] Reserved : 0000
[1A8h 0424 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[1ACh 0428 4] Parent : 00000188
[1B0h 0432 4] ACPI Processor ID : 00000000
[1B4h 0436 4] Private Resource Number : 00000000
[1B8h 0440 1] Subtable Type : 00 [Processor Hierarchy Node]
[1B9h 0441 1] Length : 14
[1BAh 0442 2] Reserved : 0000
[1BCh 0444 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[1C0h 0448 4] Parent : 000001A4
[1C4h 0452 4] ACPI Processor ID : 00000004
[1C8h 0456 4] Private Resource Number : 00000000
[1CCh 0460 1] Subtable Type : 00 [Processor Hierarchy Node]
[1CDh 0461 1] Length : 14
[1CEh 0462 2] Reserved : 0000
[1D0h 0464 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[1D4h 0468 4] Parent : 000001A4
[1D8h 0472 4] ACPI Processor ID : 00000005
[1DCh 0476 4] Private Resource Number : 00000000
[1E0h 0480 1] Subtable Type : 00 [Processor Hierarchy Node]
[1E1h 0481 1] Length : 14
[1E2h 0482 2] Reserved : 0000
[1E4h 0484 4] Flags (decoded below) : 00000010
Physical package : 0
ACPI Processor ID valid : 0
Processor is a thread : 0
Node is a leaf : 0
Identical Implementation : 1
[1E8h 0488 4] Parent : 00000188
[1ECh 0492 4] ACPI Processor ID : 00000001
[1F0h 0496 4] Private Resource Number : 00000000
[1F4h 0500 1] Subtable Type : 00 [Processor Hierarchy Node]
[1F5h 0501 1] Length : 14
[1F6h 0502 2] Reserved : 0000
[1F8h 0504 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[1FCh 0508 4] Parent : 000001E0
[200h 0512 4] ACPI Processor ID : 00000006
[204h 0516 4] Private Resource Number : 00000000
[208h 0520 1] Subtable Type : 00 [Processor Hierarchy Node]
[209h 0521 1] Length : 14
[20Ah 0522 2] Reserved : 0000
[20Ch 0524 4] Flags (decoded below) : 0000000E
Physical package : 0
ACPI Processor ID valid : 1
Processor is a thread : 1
Node is a leaf : 1
Identical Implementation : 0
[210h 0528 4] Parent : 000001E0
[214h 0532 4] ACPI Processor ID : 00000007
[218h 0536 4] Private Resource Number : 00000000
Raw Table Data: Length 540 (0x21C)
0000: 50 50 54 54 1C 02 00 00 03 4D 42 4F 43 48 53 20 // PPTT.....MBOCHS
0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
0020: 01 00 00 00 00 14 00 00 11 00 00 00 00 00 00 00 // ................
0030: 00 00 00 00 00 00 00 00 00 14 00 00 11 00 00 00 // ................
0040: 24 00 00 00 00 00 00 00 00 00 00 00 01 1C 00 00 // $...............
0050: FF 00 00 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... .....
0060: 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 // ..@.............
0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40 00 // L.............@.
0080: 00 00 01 00 01 1C 00 00 FF 00 00 00 4C 00 00 00 // ............L...
0090: 00 C0 00 00 00 01 00 00 03 07 40 00 00 00 01 01 // ..........@.....
00A0: 00 1C 00 00 10 00 00 00 38 00 00 00 00 00 00 00 // ........8.......
00B0: 02 00 00 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h.......
00C0: 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 // ................
00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00 00 // ................
00E0: 00 00 00 00 00 14 00 00 0E 00 00 00 BC 00 00 00 // ................
00F0: 01 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
0100: A0 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
0110: 0E 00 00 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................
0120: 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 // ................
0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00 00 // ................
0140: 00 00 20 00 00 08 00 00 10 0F 40 00 04 00 02 02 // .. .......@.....
0150: 01 1C 00 00 FF 00 00 00 34 01 00 00 00 80 00 00 // ........4.......
0160: 80 00 00 00 04 03 40 00 04 00 01 00 01 1C 00 00 // ......@.........
0170: FF 00 00 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4...........
0180: 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 // ..@.............
0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00 00 // 8...........l...
01A0: 50 01 00 00 00 14 00 00 10 00 00 00 88 01 00 00 // P...............
01B0: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
01C0: A4 01 00 00 04 00 00 00 00 00 00 00 00 14 00 00 // ................
01D0: 0E 00 00 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................
01E0: 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 // ................
01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00 00 // ................
0200: 06 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
0210: E0 01 00 00 07 00 00 00 00 00 00 00 // ............
Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
---
tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
2 files changed, 1 deletion(-)
diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology b/tests/data/acpi/aarch64/virt/PPTT.topology
index d0e5e11e90f33cbbbc231f9ad0bd48419e0fea65..f5f07b87c3777106e74f380de7941e1c01fc3447 100644
GIT binary patch
literal 540
zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!luq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
z%e!y9_D)?lO%?*tuH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
S>h0TY?~`Ec-II5*#Ig@|86g1x
literal 356
zcmWFt2nk7HWME*P=H&0}5v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?*x0RR91
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index ba2a8180e9..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,2 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/aarch64/virt/PPTT.topology",
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH v4 2/7] target/arm/tcg: increase cache level for cpu=max
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-23 17:47 ` Jonathan Cameron via
-1 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 17:47 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:09 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> This patch addresses cache description in the `aarch64_max_tcg_initfn`
> function for cpu=max. It introduces three layers of caches and modifies
> the cache description registers accordingly.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
I think this makes sense as a MAX cpu with out an L3 sounds pretty minimal
and it provides a way to exercise the rest of this series in TCG. For KVM
it will come from host registers (or overridden ones) anyway.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> target/arm/tcg/cpu64.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
> index 904a7e90b4..47d8c9c9ae 100644
> --- a/target/arm/tcg/cpu64.c
> +++ b/target/arm/tcg/cpu64.c
> @@ -1086,6 +1086,19 @@ void aarch64_max_tcg_initfn(Object *obj)
> uint64_t t;
> uint32_t u;
>
> + /*
> + * Expanded cache set
> + */
> + cpu->clidr = 0x8200123; /* 4 4 3 in 3 bit fields */
> + /* 64KB L1 dcache */
> + cpu->ccsidr[0] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 7);
> + /* 64KB L1 icache */
> + cpu->ccsidr[1] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 2);
> + /* 1MB L2 unified cache */
> + cpu->ccsidr[2] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 1 * MiB, 7);
> + /* 2MB L3 unified cache */
> + cpu->ccsidr[4] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 2 * MiB, 7);
> +
> /*
> * Unset ARM_FEATURE_BACKCOMPAT_CNTFRQ, which we would otherwise default
> * to because we started with aarch64_a57_initfn(). A 'max' CPU might
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 2/7] target/arm/tcg: increase cache level for cpu=max
@ 2024-12-23 17:47 ` Jonathan Cameron via
0 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 17:47 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:09 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> This patch addresses cache description in the `aarch64_max_tcg_initfn`
> function for cpu=max. It introduces three layers of caches and modifies
> the cache description registers accordingly.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
I think this makes sense as a MAX cpu with out an L3 sounds pretty minimal
and it provides a way to exercise the rest of this series in TCG. For KVM
it will come from host registers (or overridden ones) anyway.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> target/arm/tcg/cpu64.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/target/arm/tcg/cpu64.c b/target/arm/tcg/cpu64.c
> index 904a7e90b4..47d8c9c9ae 100644
> --- a/target/arm/tcg/cpu64.c
> +++ b/target/arm/tcg/cpu64.c
> @@ -1086,6 +1086,19 @@ void aarch64_max_tcg_initfn(Object *obj)
> uint64_t t;
> uint32_t u;
>
> + /*
> + * Expanded cache set
> + */
> + cpu->clidr = 0x8200123; /* 4 4 3 in 3 bit fields */
> + /* 64KB L1 dcache */
> + cpu->ccsidr[0] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 7);
> + /* 64KB L1 icache */
> + cpu->ccsidr[1] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 4, 64, 64 * KiB, 2);
> + /* 1MB L2 unified cache */
> + cpu->ccsidr[2] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 1 * MiB, 7);
> + /* 2MB L3 unified cache */
> + cpu->ccsidr[4] = make_ccsidr(CCSIDR_FORMAT_LEGACY, 8, 64, 2 * MiB, 7);
> +
> /*
> * Unset ARM_FEATURE_BACKCOMPAT_CNTFRQ, which we would otherwise default
> * to because we started with aarch64_a57_initfn(). A 'max' CPU might
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-23 17:48 ` Jonathan Cameron via
-1 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 17:48 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:08 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> This commit adds IsDefined flag to the object and this helps in avoiding
> extra checks for every single layer of caches in both x86 and ARM.
>
> There is already a discussion on mailing list to have this flag. A
> patch that enables this flag will follow later.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Makes sense. Zhao Liu, is this something you plan to use in the x86
code?
Either way
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> hw/core/machine-smp.c | 2 ++
> include/hw/boards.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
> index 9a28194676..5a02bbf584 100644
> --- a/hw/core/machine-smp.c
> +++ b/hw/core/machine-smp.c
> @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms,
> return false;
> }
>
> + ms->smp_cache.IsDefined = true;
> +
> return true;
> }
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index db2aa2b706..2883a57084 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -373,6 +373,7 @@ typedef struct CpuTopology {
>
> typedef struct SmpCache {
> SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX];
> + bool IsDefined;
> } SmpCache;
>
> /**
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
@ 2024-12-23 17:48 ` Jonathan Cameron via
0 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 17:48 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:08 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> This commit adds IsDefined flag to the object and this helps in avoiding
> extra checks for every single layer of caches in both x86 and ARM.
>
> There is already a discussion on mailing list to have this flag. A
> patch that enables this flag will follow later.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
Makes sense. Zhao Liu, is this something you plan to use in the x86
code?
Either way
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> hw/core/machine-smp.c | 2 ++
> include/hw/boards.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
> index 9a28194676..5a02bbf584 100644
> --- a/hw/core/machine-smp.c
> +++ b/hw/core/machine-smp.c
> @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms,
> return false;
> }
>
> + ms->smp_cache.IsDefined = true;
> +
> return true;
> }
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index db2aa2b706..2883a57084 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -373,6 +373,7 @@ typedef struct CpuTopology {
>
> typedef struct SmpCache {
> SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX];
> + bool IsDefined;
> } SmpCache;
>
> /**
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 3/7] arm/virt.c: add cache hierarchy to device tree
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-23 18:09 ` Jonathan Cameron via
-1 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 18:09 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:10 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> Specify which layer (core/cluster/socket) caches found at in the CPU
> topology. Updating cache topology to device tree (spec v0.4).
> Example:
>
> Here, 2 sockets (packages), and 2 clusters, 4 cores and 2 threads
> created, in aggregate 2*2*4*2 logical cores. In the smp-cache object,
> cores will have l1d and l1i. However, extending this is not difficult).
> The clusters will share a unified l2 level cache, and finally sockets
> will share l3. In this patch, threads will share l1 caches by default,
> but this can be adjusted if case required.
>
> Currently only three levels of caches are supported. The patch does not
> allow partial declaration of caches. In another word, all caches must be
> defined or caches must be skipped.
>
> ./qemu-system-aarch64 \
> -machine virt,\
> smp-cache.0.cache=l1i,smp-cache.0.topology=core,\
> smp-cache.1.cache=l1d,smp-cache.1.topology=core,\
> smp-cache.2.cache=l2,smp-cache.2.topology=cluster,\
> smp-cache.3.cache=l3,smp-cache.3.topology=socket\
> -cpu max \
> -m 2048 \
> -smp sockets=2,clusters=2,cores=4,threads=1 \
> -kernel ./Image.gz \
> -append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
> -initrd rootfs.cpio.gz \
> -bios ./edk2-aarch64-code.fd \
> -nographic
>
> For instance, following device tree will be generated for a scenario
> where we have 2 sockets, 2 clusters, 2 cores and 2 threads, in total 16
> PEs. L1i and L1d are private to each thread, and l2 and l3 are shared at
> socket level as an example.
>
> Limitation: SMT cores cannot share L1 cache for now. This
> problem does not exist in PPTT tables.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Hi Ali,
Hmm. So the bit where the Co-dev makes sense is the utility functions pulled
forwards from the ACPI code. That is quite a bit of the code so fair enough.
A few comments and questions follow that I missed during internal reviews.
Sorry they are late!
What happens if we see registers that indicate an L4 or higher? Does it
just ignore it for now? I've no problem with it doing so as those are
rare systems at best and describing the lower caches is still better
than nothing. I'm not sure what Linux does though if the CPU registers
say there are more caches than in DT / ACPI?
> ---
> hw/arm/virt.c | 390 ++++++++++++++++++++++++++++++++++++++++++
> hw/cpu/core.c | 97 +++++++++++
> include/hw/arm/virt.h | 5 +
> include/hw/cpu/core.h | 26 +++
> 4 files changed, 518 insertions(+)
> static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> {
> int cpu;
> @@ -418,6 +608,24 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> const MachineState *ms = MACHINE(vms);
> const VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
> int smp_cpus = ms->smp.cpus;
> + int socket_id, cluster_id, core_id, thread_id;
> + uint32_t next_level = 0;
> + uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
> + uint32_t thread_offset = 0;
> + int last_socket = -1, last_cluster = -1, last_core = -1, last_thread = -1;
> + int top_node = 3, top_cluster = 3, top_core = 3, top_thread = 3;
I wonder if a few comments here make sense, or something that makes it clear 3
is about the levels of cache currently describable.
> + int bottom_node = 3, bottom_cluster = 3, bottom_core = 3, bottom_thread = 3;
> + unsigned int num_cache;
> + CPUCaches caches[16];
> + bool cache_created = false;
> +
> + num_cache = virt_get_caches(vms, caches);
> +
> + if (ms->smp_cache.IsDefined &&
> + partial_cache_description(ms, caches, num_cache)) {
> + error_setg(&error_fatal, "Missing cache description");
> + return;
> + }
>
> /*
> * See Linux Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -446,9 +654,15 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#size-cells", 0x0);
>
> for (cpu = smp_cpus - 1; cpu >= 0; cpu--) {
> + socket_id = cpu / (ms->smp.clusters * ms->smp.cores * ms->smp.threads);
> + cluster_id = cpu / (ms->smp.cores * ms->smp.threads) % ms->smp.clusters;
> + core_id = cpu / (ms->smp.threads) % ms->smp.cores;
> + thread_id = cpu % ms->smp.cores;
> +
> char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
> ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu));
> CPUState *cs = CPU(armcpu);
> + const char *prefix = NULL;
>
> qemu_fdt_add_subnode(ms->fdt, nodename);
> qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "cpu");
> @@ -478,6 +692,177 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> qemu_fdt_alloc_phandle(ms->fdt));
> }
>
> + if (!vmc->no_cpu_topology && num_cache) {
> + for (uint8_t i = 0; i < num_cache; i++) {
> + /* only level 1 in the CPU entry */
> + if (caches[i].level > 1) {
> + continue;
> + }
> +
One blank line only.
> +
> + if (caches[i].type == INSTRUCTION) {
> + prefix = "i-cache";
> + } else if (caches[i].type == DATA) {
> + prefix = "d-cache";
> + } else if (caches[i].type == UNIFIED) {
> + error_setg(&error_fatal,
> + "Unified type is not implemented at level %d",
> + caches[i].level);
> + return;
> + } else {
> + error_setg(&error_fatal, "Undefined cache type");
> + return;
> + }
> +
> + set_cache_properties(ms->fdt, nodename, prefix, caches[i]);
> + }
> + }
> +
> + if (socket_id != last_socket) {
> + bottom_node = top_node;
> + /* this assumes socket as the highest topological level */
Is there any way we can check that remains true? Maybe a question for other
reviewers.
> + socket_offset = 0;
> + cluster_offset = 0;
> + if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
> + find_the_lowest_level_cache_defined_at_level(ms,
> + &bottom_node,
> + CPU_TOPOLOGY_LEVEL_SOCKET)) {
> +
> + if (bottom_node == 1) {
> + error_report("Cannot share L1 at socket_id %d.", socket_id);
Maybe add a comment on why. (DT limitation rather than a theoretical one).
> + }
> +
> + cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
> + num_cache,
> + top_node,
> + bottom_node, cpu,
> + &socket_offset);
> +
> + if (!cache_created) {
> + error_setg(&error_fatal,
> + "Socket: No caches at levels %d-%d",
> + top_node, bottom_node);
> + return;
> + }
> +
> + top_cluster = bottom_node - 1;
> + }
> +
> + last_socket = socket_id;
> + }
> +
...
> diff --git a/hw/cpu/core.c b/hw/cpu/core.c
> index 495a5c30ff..186bb367e7 100644
> --- a/hw/cpu/core.c
> +++ b/hw/cpu/core.c
> @@ -102,4 +102,101 @@ static void cpu_core_register_types(void)
> type_register_static(&cpu_core_type_info);
> }
>
> +bool cache_described_at(const MachineState *ms, CpuTopologyLevel level)
> +{
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D) == level) {
> + return true;
> + }
> + return false;
> +}
> +
> +int partial_cache_description(const MachineState *ms,
> + CPUCaches *caches,
> + int num_caches)
Can be wrapped onto fewer sub 80 char lines.
> +{
> + int level, c;
> +
> + for (level = 1; level < num_caches; level++) {
> + for (c = 0; c < num_caches; c++) {
> + if (caches[c].level != level) {
> + continue;
> + }
> +
> + switch (level) {
> + case 1:
> + /*
> + * L1 cache is assumed to have both L1I and L1D available.
> + * Technically both need to be checked.
> + */
> + if (machine_get_cache_topo_level(ms,
> + CACHE_LEVEL_AND_TYPE_L1I) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT)
> + {
> + assert(machine_get_cache_topo_level(ms,
> + CACHE_LEVEL_AND_TYPE_L1D) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT);
assert not really appropriate way to trigger an exit.
error_setg() or similar or just trigger an error_fatal.
Not sure what is common in related code.
> + return level;
> + }
> + break;
> + case 2:
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + case 3:
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + }
> + }
> + }
> +
> + return 0;
> +}
> +
> +/*
> + * This function assumes l3 and l2 have unified cache and l1 is split l1d
> + * and l1i, and further prepares the lowest cache level for a topology
> + * level. The info will be fed to build_caches to create caches at the
> + * right level.
> + */
> +int find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
> + int *level_found,
> + CpuTopologyLevel topo_level) {
> +
> + CpuTopologyLevel level;
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I);
> + if (level == topo_level) {
> + *level_found = 1;
> + return 1;
This code evolved, but now it makes little sense to return the level found
and the put it in level_found. Perhaps just return a bool?
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D);
> + if (level == topo_level) {
> + *level_found = 1;
> + return 1;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2);
> + if (level == topo_level) {
> + *level_found = 2;
> + return 2;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3);
> + if (level == topo_level) {
> + *level_found = 3;
> + return 3;
> + }
> +
> + return 0;
> +}
> +
> type_init(cpu_core_register_types)
> diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
> index a4d937ed45..7b0311ce6e 100644
> --- a/include/hw/arm/virt.h
> +++ b/include/hw/arm/virt.h
> @@ -39,6 +39,7 @@
> #include "sysemu/kvm.h"
> #include "hw/intc/arm_gicv3_common.h"
> #include "qom/object.h"
> +#include "hw/cpu/core.h"
>
> #define NUM_GICV2M_SPIS 64
> #define NUM_VIRTIO_TRANSPORTS 32
> @@ -50,6 +51,8 @@
> /* GPIO pins */
> #define GPIO_PIN_POWER_BUTTON 3
>
> +#define CPU_MAX_CACHES 16
> +
> enum {
> VIRT_FLASH,
> VIRT_MEM,
> @@ -188,6 +191,8 @@ OBJECT_DECLARE_TYPE(VirtMachineState, VirtMachineClass, VIRT_MACHINE)
>
> void virt_acpi_setup(VirtMachineState *vms);
> bool virt_is_acpi_enabled(VirtMachineState *vms);
> +unsigned int virt_get_caches(const VirtMachineState *vms,
> + CPUCaches *caches);
>
Fits on one line under 80 chars, so undo that wrap.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 3/7] arm/virt.c: add cache hierarchy to device tree
@ 2024-12-23 18:09 ` Jonathan Cameron via
0 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 18:09 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:10 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> Specify which layer (core/cluster/socket) caches found at in the CPU
> topology. Updating cache topology to device tree (spec v0.4).
> Example:
>
> Here, 2 sockets (packages), and 2 clusters, 4 cores and 2 threads
> created, in aggregate 2*2*4*2 logical cores. In the smp-cache object,
> cores will have l1d and l1i. However, extending this is not difficult).
> The clusters will share a unified l2 level cache, and finally sockets
> will share l3. In this patch, threads will share l1 caches by default,
> but this can be adjusted if case required.
>
> Currently only three levels of caches are supported. The patch does not
> allow partial declaration of caches. In another word, all caches must be
> defined or caches must be skipped.
>
> ./qemu-system-aarch64 \
> -machine virt,\
> smp-cache.0.cache=l1i,smp-cache.0.topology=core,\
> smp-cache.1.cache=l1d,smp-cache.1.topology=core,\
> smp-cache.2.cache=l2,smp-cache.2.topology=cluster,\
> smp-cache.3.cache=l3,smp-cache.3.topology=socket\
> -cpu max \
> -m 2048 \
> -smp sockets=2,clusters=2,cores=4,threads=1 \
> -kernel ./Image.gz \
> -append "console=ttyAMA0 root=/dev/ram rdinit=/init acpi=force" \
> -initrd rootfs.cpio.gz \
> -bios ./edk2-aarch64-code.fd \
> -nographic
>
> For instance, following device tree will be generated for a scenario
> where we have 2 sockets, 2 clusters, 2 cores and 2 threads, in total 16
> PEs. L1i and L1d are private to each thread, and l2 and l3 are shared at
> socket level as an example.
>
> Limitation: SMT cores cannot share L1 cache for now. This
> problem does not exist in PPTT tables.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> Co-developed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> Signed-off-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Hi Ali,
Hmm. So the bit where the Co-dev makes sense is the utility functions pulled
forwards from the ACPI code. That is quite a bit of the code so fair enough.
A few comments and questions follow that I missed during internal reviews.
Sorry they are late!
What happens if we see registers that indicate an L4 or higher? Does it
just ignore it for now? I've no problem with it doing so as those are
rare systems at best and describing the lower caches is still better
than nothing. I'm not sure what Linux does though if the CPU registers
say there are more caches than in DT / ACPI?
> ---
> hw/arm/virt.c | 390 ++++++++++++++++++++++++++++++++++++++++++
> hw/cpu/core.c | 97 +++++++++++
> include/hw/arm/virt.h | 5 +
> include/hw/cpu/core.h | 26 +++
> 4 files changed, 518 insertions(+)
> static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> {
> int cpu;
> @@ -418,6 +608,24 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> const MachineState *ms = MACHINE(vms);
> const VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
> int smp_cpus = ms->smp.cpus;
> + int socket_id, cluster_id, core_id, thread_id;
> + uint32_t next_level = 0;
> + uint32_t socket_offset = 0, cluster_offset = 0, core_offset = 0;
> + uint32_t thread_offset = 0;
> + int last_socket = -1, last_cluster = -1, last_core = -1, last_thread = -1;
> + int top_node = 3, top_cluster = 3, top_core = 3, top_thread = 3;
I wonder if a few comments here make sense, or something that makes it clear 3
is about the levels of cache currently describable.
> + int bottom_node = 3, bottom_cluster = 3, bottom_core = 3, bottom_thread = 3;
> + unsigned int num_cache;
> + CPUCaches caches[16];
> + bool cache_created = false;
> +
> + num_cache = virt_get_caches(vms, caches);
> +
> + if (ms->smp_cache.IsDefined &&
> + partial_cache_description(ms, caches, num_cache)) {
> + error_setg(&error_fatal, "Missing cache description");
> + return;
> + }
>
> /*
> * See Linux Documentation/devicetree/bindings/arm/cpus.yaml
> @@ -446,9 +654,15 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> qemu_fdt_setprop_cell(ms->fdt, "/cpus", "#size-cells", 0x0);
>
> for (cpu = smp_cpus - 1; cpu >= 0; cpu--) {
> + socket_id = cpu / (ms->smp.clusters * ms->smp.cores * ms->smp.threads);
> + cluster_id = cpu / (ms->smp.cores * ms->smp.threads) % ms->smp.clusters;
> + core_id = cpu / (ms->smp.threads) % ms->smp.cores;
> + thread_id = cpu % ms->smp.cores;
> +
> char *nodename = g_strdup_printf("/cpus/cpu@%d", cpu);
> ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(cpu));
> CPUState *cs = CPU(armcpu);
> + const char *prefix = NULL;
>
> qemu_fdt_add_subnode(ms->fdt, nodename);
> qemu_fdt_setprop_string(ms->fdt, nodename, "device_type", "cpu");
> @@ -478,6 +692,177 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
> qemu_fdt_alloc_phandle(ms->fdt));
> }
>
> + if (!vmc->no_cpu_topology && num_cache) {
> + for (uint8_t i = 0; i < num_cache; i++) {
> + /* only level 1 in the CPU entry */
> + if (caches[i].level > 1) {
> + continue;
> + }
> +
One blank line only.
> +
> + if (caches[i].type == INSTRUCTION) {
> + prefix = "i-cache";
> + } else if (caches[i].type == DATA) {
> + prefix = "d-cache";
> + } else if (caches[i].type == UNIFIED) {
> + error_setg(&error_fatal,
> + "Unified type is not implemented at level %d",
> + caches[i].level);
> + return;
> + } else {
> + error_setg(&error_fatal, "Undefined cache type");
> + return;
> + }
> +
> + set_cache_properties(ms->fdt, nodename, prefix, caches[i]);
> + }
> + }
> +
> + if (socket_id != last_socket) {
> + bottom_node = top_node;
> + /* this assumes socket as the highest topological level */
Is there any way we can check that remains true? Maybe a question for other
reviewers.
> + socket_offset = 0;
> + cluster_offset = 0;
> + if (cache_described_at(ms, CPU_TOPOLOGY_LEVEL_SOCKET) &&
> + find_the_lowest_level_cache_defined_at_level(ms,
> + &bottom_node,
> + CPU_TOPOLOGY_LEVEL_SOCKET)) {
> +
> + if (bottom_node == 1) {
> + error_report("Cannot share L1 at socket_id %d.", socket_id);
Maybe add a comment on why. (DT limitation rather than a theoretical one).
> + }
> +
> + cache_created = add_cpu_cache_hierarchy(ms->fdt, caches,
> + num_cache,
> + top_node,
> + bottom_node, cpu,
> + &socket_offset);
> +
> + if (!cache_created) {
> + error_setg(&error_fatal,
> + "Socket: No caches at levels %d-%d",
> + top_node, bottom_node);
> + return;
> + }
> +
> + top_cluster = bottom_node - 1;
> + }
> +
> + last_socket = socket_id;
> + }
> +
...
> diff --git a/hw/cpu/core.c b/hw/cpu/core.c
> index 495a5c30ff..186bb367e7 100644
> --- a/hw/cpu/core.c
> +++ b/hw/cpu/core.c
> @@ -102,4 +102,101 @@ static void cpu_core_register_types(void)
> type_register_static(&cpu_core_type_info);
> }
>
> +bool cache_described_at(const MachineState *ms, CpuTopologyLevel level)
> +{
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I) == level ||
> + machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D) == level) {
> + return true;
> + }
> + return false;
> +}
> +
> +int partial_cache_description(const MachineState *ms,
> + CPUCaches *caches,
> + int num_caches)
Can be wrapped onto fewer sub 80 char lines.
> +{
> + int level, c;
> +
> + for (level = 1; level < num_caches; level++) {
> + for (c = 0; c < num_caches; c++) {
> + if (caches[c].level != level) {
> + continue;
> + }
> +
> + switch (level) {
> + case 1:
> + /*
> + * L1 cache is assumed to have both L1I and L1D available.
> + * Technically both need to be checked.
> + */
> + if (machine_get_cache_topo_level(ms,
> + CACHE_LEVEL_AND_TYPE_L1I) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT)
> + {
> + assert(machine_get_cache_topo_level(ms,
> + CACHE_LEVEL_AND_TYPE_L1D) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT);
assert not really appropriate way to trigger an exit.
error_setg() or similar or just trigger an error_fatal.
Not sure what is common in related code.
> + return level;
> + }
> + break;
> + case 2:
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + case 3:
> + if (machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3) ==
> + CPU_TOPOLOGY_LEVEL_DEFAULT) {
> + return level;
> + }
> + break;
> + }
> + }
> + }
> +
> + return 0;
> +}
> +
> +/*
> + * This function assumes l3 and l2 have unified cache and l1 is split l1d
> + * and l1i, and further prepares the lowest cache level for a topology
> + * level. The info will be fed to build_caches to create caches at the
> + * right level.
> + */
> +int find_the_lowest_level_cache_defined_at_level(const MachineState *ms,
> + int *level_found,
> + CpuTopologyLevel topo_level) {
> +
> + CpuTopologyLevel level;
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1I);
> + if (level == topo_level) {
> + *level_found = 1;
> + return 1;
This code evolved, but now it makes little sense to return the level found
and the put it in level_found. Perhaps just return a bool?
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L1D);
> + if (level == topo_level) {
> + *level_found = 1;
> + return 1;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L2);
> + if (level == topo_level) {
> + *level_found = 2;
> + return 2;
> + }
> +
> + level = machine_get_cache_topo_level(ms, CACHE_LEVEL_AND_TYPE_L3);
> + if (level == topo_level) {
> + *level_found = 3;
> + return 3;
> + }
> +
> + return 0;
> +}
> +
> type_init(cpu_core_register_types)
> diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
> index a4d937ed45..7b0311ce6e 100644
> --- a/include/hw/arm/virt.h
> +++ b/include/hw/arm/virt.h
> @@ -39,6 +39,7 @@
> #include "sysemu/kvm.h"
> #include "hw/intc/arm_gicv3_common.h"
> #include "qom/object.h"
> +#include "hw/cpu/core.h"
>
> #define NUM_GICV2M_SPIS 64
> #define NUM_VIRTIO_TRANSPORTS 32
> @@ -50,6 +51,8 @@
> /* GPIO pins */
> #define GPIO_PIN_POWER_BUTTON 3
>
> +#define CPU_MAX_CACHES 16
> +
> enum {
> VIRT_FLASH,
> VIRT_MEM,
> @@ -188,6 +191,8 @@ OBJECT_DECLARE_TYPE(VirtMachineState, VirtMachineClass, VIRT_MACHINE)
>
> void virt_acpi_setup(VirtMachineState *vms);
> bool virt_is_acpi_enabled(VirtMachineState *vms);
> +unsigned int virt_get_caches(const VirtMachineState *vms,
> + CPUCaches *caches);
>
Fits on one line under 80 chars, so undo that wrap.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-23 18:11 ` Jonathan Cameron via
-1 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 18:11 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:13 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> Test new PPTT topolopy with cache representation.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
> tests/qtest/bios-tables-test.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 36e5c0adde..0f72520664 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -2019,7 +2019,11 @@ static void test_acpi_aarch64_virt_tcg_topology(void)
> .scan_len = 128ULL * 1024 * 1024,
> };
>
> - test_acpi_one("-cpu cortex-a57 "
> + test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> + "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> + "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> + "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
> + "-cpu cortex-a57 "
Trivial but is there a reason the cpu must come after machine / -M bits?
If not I'd leave it on first line to reduce the churn in this patch a little.
Either way,
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> free_test_data(&data);
> }
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
@ 2024-12-23 18:11 ` Jonathan Cameron via
0 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 18:11 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:13 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> Test new PPTT topolopy with cache representation.
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
> tests/qtest/bios-tables-test.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 36e5c0adde..0f72520664 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -2019,7 +2019,11 @@ static void test_acpi_aarch64_virt_tcg_topology(void)
> .scan_len = 128ULL * 1024 * 1024,
> };
>
> - test_acpi_one("-cpu cortex-a57 "
> + test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> + "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> + "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> + "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
> + "-cpu cortex-a57 "
Trivial but is there a reason the cpu must come after machine / -M bits?
If not I'd leave it on first line to reduce the churn in this patch a little.
Either way,
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> free_test_data(&data);
> }
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.
2024-12-16 17:54 ` Alireza Sanaee via
@ 2024-12-23 18:13 ` Jonathan Cameron via
-1 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 18:13 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:14 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> The disassembled differences between actual and expected PPTT based on
> the following cache topology representation:
>
> ```
> test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
> "-cpu cortex-a57 "
> "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> ```
>
> /*
> * Intel ACPI Component Architecture
> * AML/ASL+ Disassembler version 20200925 (64-bit version)
> * Copyright (c) 2000 - 2020 Intel Corporation
> *
> * Disassembly of ../../../tests/data/acpi/aarch64/virt/PPTT.topology, Mon Oct 7 16:57:29 2024
> *
> * ACPI Data Table [PPTT]
> *
> * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> */
>
> [000h 0000 4] Signature : "PPTT" [Processor Properties Topology Table]
> [004h 0004 4] Table Length : 0000021C
> [008h 0008 1] Revision : 03
> [009h 0009 1] Checksum : 4D
> [00Ah 0010 6] Oem ID : "BOCHS "
> [010h 0016 8] Oem Table ID : "BXPC "
> [018h 0024 4] Oem Revision : 00000001
> [01Ch 0028 4] Asl Compiler ID : "BXPC"
> [020h 0032 4] Asl Compiler Revision : 00000001
>
> [024h 0036 1] Subtable Type : 00 [Processor Hierarchy Node]
> [025h 0037 1] Length : 14
> [026h 0038 2] Reserved : 0000
> [028h 0040 4] Flags (decoded below) : 00000011
> Physical package : 1
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [02Ch 0044 4] Parent : 00000000
> [030h 0048 4] ACPI Processor ID : 00000000
> [034h 0052 4] Private Resource Number : 00000000
>
> [038h 0056 1] Subtable Type : 00 [Processor Hierarchy Node]
> [039h 0057 1] Length : 14
> [03Ah 0058 2] Reserved : 0000
> [03Ch 0060 4] Flags (decoded below) : 00000011
> Physical package : 1
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [040h 0064 4] Parent : 00000024
> [044h 0068 4] ACPI Processor ID : 00000000
> [048h 0072 4] Private Resource Number : 00000000
>
> [04Ch 0076 1] Subtable Type : 01 [Cache Type]
> [04Dh 0077 1] Length : 1C
> [04Eh 0078 2] Reserved : 0000
> [050h 0080 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [054h 0084 4] Next Level of Cache : 00000000
> [058h 0088 4] Size : 00200000
> [05Ch 0092 4] Number of Sets : 00000800
> [060h 0096 1] Associativity : 10
> [061h 0097 1] Attributes : 0F
> Allocation Type : 3
> Cache Type : 3
> Write Policy : 0
> [062h 0098 2] Line Size : 0040
>
> [068h 0104 1] Subtable Type : 01 [Cache Type]
> [069h 0105 1] Length : 1C
> [06Ah 0106 2] Reserved : 0000
> [06Ch 0108 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [070h 0112 4] Next Level of Cache : 0000004C
> [074h 0116 4] Size : 00008000
> [078h 0120 4] Number of Sets : 00000080
> [07Ch 0124 1] Associativity : 04
> [07Dh 0125 1] Attributes : 03
> Allocation Type : 3
> Cache Type : 0
> Write Policy : 0
> [07Eh 0126 2] Line Size : 0040
>
> [084h 0132 1] Subtable Type : 01 [Cache Type]
> [085h 0133 1] Length : 1C
> [086h 0134 2] Reserved : 0000
> [088h 0136 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [08Ch 0140 4] Next Level of Cache : 0000004C
> [090h 0144 4] Size : 0000C000
> [094h 0148 4] Number of Sets : 00000100
> [098h 0152 1] Associativity : 03
> [099h 0153 1] Attributes : 07
> Allocation Type : 3
> Cache Type : 1
> Write Policy : 0
> [09Ah 0154 2] Line Size : 0040
>
> [0A0h 0160 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0A1h 0161 1] Length : 1C
> [0A2h 0162 2] Reserved : 0000
> [0A4h 0164 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0A8h 0168 4] Parent : 00000038
> [0ACh 0172 4] ACPI Processor ID : 00000000
> [0B0h 0176 4] Private Resource Number : 00000002
> [0B4h 0180 4] Private Resource : 00000084
> [0B8h 0184 4] Private Resource : 00000068
>
> [0BCh 0188 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0BDh 0189 1] Length : 14
> [0BEh 0190 2] Reserved : 0000
> [0C0h 0192 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0C4h 0196 4] Parent : 000000A0
> [0C8h 0200 4] ACPI Processor ID : 00000000
> [0CCh 0204 4] Private Resource Number : 00000000
>
> [0D0h 0208 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0D1h 0209 1] Length : 14
> [0D2h 0210 2] Reserved : 0000
> [0D4h 0212 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [0D8h 0216 4] Parent : 000000BC
> [0DCh 0220 4] ACPI Processor ID : 00000000
> [0E0h 0224 4] Private Resource Number : 00000000
>
> [0E4h 0228 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0E5h 0229 1] Length : 14
> [0E6h 0230 2] Reserved : 0000
> [0E8h 0232 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [0ECh 0236 4] Parent : 000000BC
> [0F0h 0240 4] ACPI Processor ID : 00000001
> [0F4h 0244 4] Private Resource Number : 00000000
>
> [0F8h 0248 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0F9h 0249 1] Length : 14
> [0FAh 0250 2] Reserved : 0000
> [0FCh 0252 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [100h 0256 4] Parent : 000000A0
> [104h 0260 4] ACPI Processor ID : 00000001
> [108h 0264 4] Private Resource Number : 00000000
>
> [10Ch 0268 1] Subtable Type : 00 [Processor Hierarchy Node]
> [10Dh 0269 1] Length : 14
> [10Eh 0270 2] Reserved : 0000
> [110h 0272 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [114h 0276 4] Parent : 000000F8
> [118h 0280 4] ACPI Processor ID : 00000002
> [11Ch 0284 4] Private Resource Number : 00000000
>
> [120h 0288 1] Subtable Type : 00 [Processor Hierarchy Node]
> [121h 0289 1] Length : 14
> [122h 0290 2] Reserved : 0000
> [124h 0292 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [128h 0296 4] Parent : 000000F8
> [12Ch 0300 4] ACPI Processor ID : 00000003
> [130h 0304 4] Private Resource Number : 00000000
>
> [134h 0308 1] Subtable Type : 01 [Cache Type]
> [135h 0309 1] Length : 1C
> [136h 0310 2] Reserved : 0000
> [138h 0312 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [13Ch 0316 4] Next Level of Cache : 00000000
> [140h 0320 4] Size : 00200000
> [144h 0324 4] Number of Sets : 00000800
> [148h 0328 1] Associativity : 10
> [149h 0329 1] Attributes : 0F
> Allocation Type : 3
> Cache Type : 3
> Write Policy : 0
> [14Ah 0330 2] Line Size : 0040
>
> [150h 0336 1] Subtable Type : 01 [Cache Type]
> [151h 0337 1] Length : 1C
> [152h 0338 2] Reserved : 0000
> [154h 0340 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [158h 0344 4] Next Level of Cache : 00000134
> [15Ch 0348 4] Size : 00008000
> [160h 0352 4] Number of Sets : 00000080
> [164h 0356 1] Associativity : 04
> [165h 0357 1] Attributes : 03
> Allocation Type : 3
> Cache Type : 0
> Write Policy : 0
> [166h 0358 2] Line Size : 0040
>
> [16Ch 0364 1] Subtable Type : 01 [Cache Type]
> [16Dh 0365 1] Length : 1C
> [16Eh 0366 2] Reserved : 0000
> [170h 0368 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [174h 0372 4] Next Level of Cache : 00000134
> [178h 0376 4] Size : 0000C000
> [17Ch 0380 4] Number of Sets : 00000100
> [180h 0384 1] Associativity : 03
> [181h 0385 1] Attributes : 07
> Allocation Type : 3
> Cache Type : 1
> Write Policy : 0
> [182h 0386 2] Line Size : 0040
>
> [188h 0392 1] Subtable Type : 00 [Processor Hierarchy Node]
> [189h 0393 1] Length : 1C
> [18Ah 0394 2] Reserved : 0000
> [18Ch 0396 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [190h 0400 4] Parent : 00000038
> [194h 0404 4] ACPI Processor ID : 00000001
> [198h 0408 4] Private Resource Number : 00000002
> [19Ch 0412 4] Private Resource : 0000016C
> [1A0h 0416 4] Private Resource : 00000150
>
> [1A4h 0420 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1A5h 0421 1] Length : 14
> [1A6h 0422 2] Reserved : 0000
> [1A8h 0424 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [1ACh 0428 4] Parent : 00000188
> [1B0h 0432 4] ACPI Processor ID : 00000000
> [1B4h 0436 4] Private Resource Number : 00000000
>
> [1B8h 0440 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1B9h 0441 1] Length : 14
> [1BAh 0442 2] Reserved : 0000
> [1BCh 0444 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [1C0h 0448 4] Parent : 000001A4
> [1C4h 0452 4] ACPI Processor ID : 00000004
> [1C8h 0456 4] Private Resource Number : 00000000
>
> [1CCh 0460 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1CDh 0461 1] Length : 14
> [1CEh 0462 2] Reserved : 0000
> [1D0h 0464 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [1D4h 0468 4] Parent : 000001A4
> [1D8h 0472 4] ACPI Processor ID : 00000005
> [1DCh 0476 4] Private Resource Number : 00000000
>
> [1E0h 0480 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1E1h 0481 1] Length : 14
> [1E2h 0482 2] Reserved : 0000
> [1E4h 0484 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [1E8h 0488 4] Parent : 00000188
> [1ECh 0492 4] ACPI Processor ID : 00000001
> [1F0h 0496 4] Private Resource Number : 00000000
>
> [1F4h 0500 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1F5h 0501 1] Length : 14
> [1F6h 0502 2] Reserved : 0000
> [1F8h 0504 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [1FCh 0508 4] Parent : 000001E0
> [200h 0512 4] ACPI Processor ID : 00000006
> [204h 0516 4] Private Resource Number : 00000000
>
> [208h 0520 1] Subtable Type : 00 [Processor Hierarchy Node]
> [209h 0521 1] Length : 14
> [20Ah 0522 2] Reserved : 0000
> [20Ch 0524 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [210h 0528 4] Parent : 000001E0
> [214h 0532 4] ACPI Processor ID : 00000007
> [218h 0536 4] Private Resource Number : 00000000
>
> Raw Table Data: Length 540 (0x21C)
>
> 0000: 50 50 54 54 1C 02 00 00 03 4D 42 4F 43 48 53 20 // PPTT.....MBOCHS
> 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
> 0020: 01 00 00 00 00 14 00 00 11 00 00 00 00 00 00 00 // ................
> 0030: 00 00 00 00 00 00 00 00 00 14 00 00 11 00 00 00 // ................
> 0040: 24 00 00 00 00 00 00 00 00 00 00 00 01 1C 00 00 // $...............
> 0050: FF 00 00 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... .....
> 0060: 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 // ..@.............
> 0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40 00 // L.............@.
> 0080: 00 00 01 00 01 1C 00 00 FF 00 00 00 4C 00 00 00 // ............L...
> 0090: 00 C0 00 00 00 01 00 00 03 07 40 00 00 00 01 01 // ..........@.....
> 00A0: 00 1C 00 00 10 00 00 00 38 00 00 00 00 00 00 00 // ........8.......
> 00B0: 02 00 00 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h.......
> 00C0: 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 // ................
> 00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00 00 // ................
> 00E0: 00 00 00 00 00 14 00 00 0E 00 00 00 BC 00 00 00 // ................
> 00F0: 01 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
> 0100: A0 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
> 0110: 0E 00 00 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................
> 0120: 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 // ................
> 0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00 00 // ................
> 0140: 00 00 20 00 00 08 00 00 10 0F 40 00 04 00 02 02 // .. .......@.....
> 0150: 01 1C 00 00 FF 00 00 00 34 01 00 00 00 80 00 00 // ........4.......
> 0160: 80 00 00 00 04 03 40 00 04 00 01 00 01 1C 00 00 // ......@.........
> 0170: FF 00 00 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4...........
> 0180: 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 // ..@.............
> 0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00 00 // 8...........l...
> 01A0: 50 01 00 00 00 14 00 00 10 00 00 00 88 01 00 00 // P...............
> 01B0: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 01C0: A4 01 00 00 04 00 00 00 00 00 00 00 00 14 00 00 // ................
> 01D0: 0E 00 00 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................
> 01E0: 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 // ................
> 01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00 00 // ................
> 0200: 06 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 0210: E0 01 00 00 07 00 00 00 00 00 00 00 // ............
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
I've spent too long staring at PPTT in the past (and reviewed this internally)
so all looks good to me. (If you update the test remember to update the comment
on it above).
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> 2 files changed, 1 deletion(-)
>
> diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology b/tests/data/acpi/aarch64/virt/PPTT.topology
> index d0e5e11e90f33cbbbc231f9ad0bd48419e0fea65..f5f07b87c3777106e74f380de7941e1c01fc3447 100644
> GIT binary patch
> literal 540
> zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!luq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
> z%e!y9_D)?lO%?*tuH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
> zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
> z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
> S>h0TY?~`Ec-II5*#Ig@|86g1x
>
> literal 356
> zcmWFt2nk7HWME*P=H&0}5v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
> ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
> cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?*x0RR91
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index ba2a8180e9..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,2 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/aarch64/virt/PPTT.topology",
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.
@ 2024-12-23 18:13 ` Jonathan Cameron via
0 siblings, 0 replies; 32+ messages in thread
From: Jonathan Cameron via @ 2024-12-23 18:13 UTC (permalink / raw)
To: Alireza Sanaee, linuxarm
Cc: qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang, dapeng1.mi,
yongwei.ma, armbru, farman, peter.maydell, mst, anisinha,
shannon.zhaosl, imammedo, mtosatti, berrange, richard.henderson,
shameerali.kolothum.thodi, Jonathan.Cameron, jiangkunkun,
yangyicong, sarsanaee
On Mon, 16 Dec 2024 17:54:14 +0000
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> The disassembled differences between actual and expected PPTT based on
> the following cache topology representation:
>
> ```
> test_acpi_one("-M virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
> "-cpu cortex-a57 "
> "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> ```
>
> /*
> * Intel ACPI Component Architecture
> * AML/ASL+ Disassembler version 20200925 (64-bit version)
> * Copyright (c) 2000 - 2020 Intel Corporation
> *
> * Disassembly of ../../../tests/data/acpi/aarch64/virt/PPTT.topology, Mon Oct 7 16:57:29 2024
> *
> * ACPI Data Table [PPTT]
> *
> * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> */
>
> [000h 0000 4] Signature : "PPTT" [Processor Properties Topology Table]
> [004h 0004 4] Table Length : 0000021C
> [008h 0008 1] Revision : 03
> [009h 0009 1] Checksum : 4D
> [00Ah 0010 6] Oem ID : "BOCHS "
> [010h 0016 8] Oem Table ID : "BXPC "
> [018h 0024 4] Oem Revision : 00000001
> [01Ch 0028 4] Asl Compiler ID : "BXPC"
> [020h 0032 4] Asl Compiler Revision : 00000001
>
> [024h 0036 1] Subtable Type : 00 [Processor Hierarchy Node]
> [025h 0037 1] Length : 14
> [026h 0038 2] Reserved : 0000
> [028h 0040 4] Flags (decoded below) : 00000011
> Physical package : 1
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [02Ch 0044 4] Parent : 00000000
> [030h 0048 4] ACPI Processor ID : 00000000
> [034h 0052 4] Private Resource Number : 00000000
>
> [038h 0056 1] Subtable Type : 00 [Processor Hierarchy Node]
> [039h 0057 1] Length : 14
> [03Ah 0058 2] Reserved : 0000
> [03Ch 0060 4] Flags (decoded below) : 00000011
> Physical package : 1
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [040h 0064 4] Parent : 00000024
> [044h 0068 4] ACPI Processor ID : 00000000
> [048h 0072 4] Private Resource Number : 00000000
>
> [04Ch 0076 1] Subtable Type : 01 [Cache Type]
> [04Dh 0077 1] Length : 1C
> [04Eh 0078 2] Reserved : 0000
> [050h 0080 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [054h 0084 4] Next Level of Cache : 00000000
> [058h 0088 4] Size : 00200000
> [05Ch 0092 4] Number of Sets : 00000800
> [060h 0096 1] Associativity : 10
> [061h 0097 1] Attributes : 0F
> Allocation Type : 3
> Cache Type : 3
> Write Policy : 0
> [062h 0098 2] Line Size : 0040
>
> [068h 0104 1] Subtable Type : 01 [Cache Type]
> [069h 0105 1] Length : 1C
> [06Ah 0106 2] Reserved : 0000
> [06Ch 0108 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [070h 0112 4] Next Level of Cache : 0000004C
> [074h 0116 4] Size : 00008000
> [078h 0120 4] Number of Sets : 00000080
> [07Ch 0124 1] Associativity : 04
> [07Dh 0125 1] Attributes : 03
> Allocation Type : 3
> Cache Type : 0
> Write Policy : 0
> [07Eh 0126 2] Line Size : 0040
>
> [084h 0132 1] Subtable Type : 01 [Cache Type]
> [085h 0133 1] Length : 1C
> [086h 0134 2] Reserved : 0000
> [088h 0136 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [08Ch 0140 4] Next Level of Cache : 0000004C
> [090h 0144 4] Size : 0000C000
> [094h 0148 4] Number of Sets : 00000100
> [098h 0152 1] Associativity : 03
> [099h 0153 1] Attributes : 07
> Allocation Type : 3
> Cache Type : 1
> Write Policy : 0
> [09Ah 0154 2] Line Size : 0040
>
> [0A0h 0160 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0A1h 0161 1] Length : 1C
> [0A2h 0162 2] Reserved : 0000
> [0A4h 0164 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0A8h 0168 4] Parent : 00000038
> [0ACh 0172 4] ACPI Processor ID : 00000000
> [0B0h 0176 4] Private Resource Number : 00000002
> [0B4h 0180 4] Private Resource : 00000084
> [0B8h 0184 4] Private Resource : 00000068
>
> [0BCh 0188 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0BDh 0189 1] Length : 14
> [0BEh 0190 2] Reserved : 0000
> [0C0h 0192 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [0C4h 0196 4] Parent : 000000A0
> [0C8h 0200 4] ACPI Processor ID : 00000000
> [0CCh 0204 4] Private Resource Number : 00000000
>
> [0D0h 0208 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0D1h 0209 1] Length : 14
> [0D2h 0210 2] Reserved : 0000
> [0D4h 0212 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [0D8h 0216 4] Parent : 000000BC
> [0DCh 0220 4] ACPI Processor ID : 00000000
> [0E0h 0224 4] Private Resource Number : 00000000
>
> [0E4h 0228 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0E5h 0229 1] Length : 14
> [0E6h 0230 2] Reserved : 0000
> [0E8h 0232 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [0ECh 0236 4] Parent : 000000BC
> [0F0h 0240 4] ACPI Processor ID : 00000001
> [0F4h 0244 4] Private Resource Number : 00000000
>
> [0F8h 0248 1] Subtable Type : 00 [Processor Hierarchy Node]
> [0F9h 0249 1] Length : 14
> [0FAh 0250 2] Reserved : 0000
> [0FCh 0252 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [100h 0256 4] Parent : 000000A0
> [104h 0260 4] ACPI Processor ID : 00000001
> [108h 0264 4] Private Resource Number : 00000000
>
> [10Ch 0268 1] Subtable Type : 00 [Processor Hierarchy Node]
> [10Dh 0269 1] Length : 14
> [10Eh 0270 2] Reserved : 0000
> [110h 0272 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [114h 0276 4] Parent : 000000F8
> [118h 0280 4] ACPI Processor ID : 00000002
> [11Ch 0284 4] Private Resource Number : 00000000
>
> [120h 0288 1] Subtable Type : 00 [Processor Hierarchy Node]
> [121h 0289 1] Length : 14
> [122h 0290 2] Reserved : 0000
> [124h 0292 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [128h 0296 4] Parent : 000000F8
> [12Ch 0300 4] ACPI Processor ID : 00000003
> [130h 0304 4] Private Resource Number : 00000000
>
> [134h 0308 1] Subtable Type : 01 [Cache Type]
> [135h 0309 1] Length : 1C
> [136h 0310 2] Reserved : 0000
> [138h 0312 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [13Ch 0316 4] Next Level of Cache : 00000000
> [140h 0320 4] Size : 00200000
> [144h 0324 4] Number of Sets : 00000800
> [148h 0328 1] Associativity : 10
> [149h 0329 1] Attributes : 0F
> Allocation Type : 3
> Cache Type : 3
> Write Policy : 0
> [14Ah 0330 2] Line Size : 0040
>
> [150h 0336 1] Subtable Type : 01 [Cache Type]
> [151h 0337 1] Length : 1C
> [152h 0338 2] Reserved : 0000
> [154h 0340 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [158h 0344 4] Next Level of Cache : 00000134
> [15Ch 0348 4] Size : 00008000
> [160h 0352 4] Number of Sets : 00000080
> [164h 0356 1] Associativity : 04
> [165h 0357 1] Attributes : 03
> Allocation Type : 3
> Cache Type : 0
> Write Policy : 0
> [166h 0358 2] Line Size : 0040
>
> [16Ch 0364 1] Subtable Type : 01 [Cache Type]
> [16Dh 0365 1] Length : 1C
> [16Eh 0366 2] Reserved : 0000
> [170h 0368 4] Flags (decoded below) : 000000FF
> Size valid : 1
> Number of Sets valid : 1
> Associativity valid : 1
> Allocation Type valid : 1
> Cache Type valid : 1
> Write Policy valid : 1
> Line Size valid : 1
> [174h 0372 4] Next Level of Cache : 00000134
> [178h 0376 4] Size : 0000C000
> [17Ch 0380 4] Number of Sets : 00000100
> [180h 0384 1] Associativity : 03
> [181h 0385 1] Attributes : 07
> Allocation Type : 3
> Cache Type : 1
> Write Policy : 0
> [182h 0386 2] Line Size : 0040
>
> [188h 0392 1] Subtable Type : 00 [Processor Hierarchy Node]
> [189h 0393 1] Length : 1C
> [18Ah 0394 2] Reserved : 0000
> [18Ch 0396 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [190h 0400 4] Parent : 00000038
> [194h 0404 4] ACPI Processor ID : 00000001
> [198h 0408 4] Private Resource Number : 00000002
> [19Ch 0412 4] Private Resource : 0000016C
> [1A0h 0416 4] Private Resource : 00000150
>
> [1A4h 0420 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1A5h 0421 1] Length : 14
> [1A6h 0422 2] Reserved : 0000
> [1A8h 0424 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [1ACh 0428 4] Parent : 00000188
> [1B0h 0432 4] ACPI Processor ID : 00000000
> [1B4h 0436 4] Private Resource Number : 00000000
>
> [1B8h 0440 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1B9h 0441 1] Length : 14
> [1BAh 0442 2] Reserved : 0000
> [1BCh 0444 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [1C0h 0448 4] Parent : 000001A4
> [1C4h 0452 4] ACPI Processor ID : 00000004
> [1C8h 0456 4] Private Resource Number : 00000000
>
> [1CCh 0460 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1CDh 0461 1] Length : 14
> [1CEh 0462 2] Reserved : 0000
> [1D0h 0464 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [1D4h 0468 4] Parent : 000001A4
> [1D8h 0472 4] ACPI Processor ID : 00000005
> [1DCh 0476 4] Private Resource Number : 00000000
>
> [1E0h 0480 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1E1h 0481 1] Length : 14
> [1E2h 0482 2] Reserved : 0000
> [1E4h 0484 4] Flags (decoded below) : 00000010
> Physical package : 0
> ACPI Processor ID valid : 0
> Processor is a thread : 0
> Node is a leaf : 0
> Identical Implementation : 1
> [1E8h 0488 4] Parent : 00000188
> [1ECh 0492 4] ACPI Processor ID : 00000001
> [1F0h 0496 4] Private Resource Number : 00000000
>
> [1F4h 0500 1] Subtable Type : 00 [Processor Hierarchy Node]
> [1F5h 0501 1] Length : 14
> [1F6h 0502 2] Reserved : 0000
> [1F8h 0504 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [1FCh 0508 4] Parent : 000001E0
> [200h 0512 4] ACPI Processor ID : 00000006
> [204h 0516 4] Private Resource Number : 00000000
>
> [208h 0520 1] Subtable Type : 00 [Processor Hierarchy Node]
> [209h 0521 1] Length : 14
> [20Ah 0522 2] Reserved : 0000
> [20Ch 0524 4] Flags (decoded below) : 0000000E
> Physical package : 0
> ACPI Processor ID valid : 1
> Processor is a thread : 1
> Node is a leaf : 1
> Identical Implementation : 0
> [210h 0528 4] Parent : 000001E0
> [214h 0532 4] ACPI Processor ID : 00000007
> [218h 0536 4] Private Resource Number : 00000000
>
> Raw Table Data: Length 540 (0x21C)
>
> 0000: 50 50 54 54 1C 02 00 00 03 4D 42 4F 43 48 53 20 // PPTT.....MBOCHS
> 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50 43 // BXPC ....BXPC
> 0020: 01 00 00 00 00 14 00 00 11 00 00 00 00 00 00 00 // ................
> 0030: 00 00 00 00 00 00 00 00 00 14 00 00 11 00 00 00 // ................
> 0040: 24 00 00 00 00 00 00 00 00 00 00 00 01 1C 00 00 // $...............
> 0050: FF 00 00 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... .....
> 0060: 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 // ..@.............
> 0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40 00 // L.............@.
> 0080: 00 00 01 00 01 1C 00 00 FF 00 00 00 4C 00 00 00 // ............L...
> 0090: 00 C0 00 00 00 01 00 00 03 07 40 00 00 00 01 01 // ..........@.....
> 00A0: 00 1C 00 00 10 00 00 00 38 00 00 00 00 00 00 00 // ........8.......
> 00B0: 02 00 00 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h.......
> 00C0: 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 // ................
> 00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00 00 // ................
> 00E0: 00 00 00 00 00 14 00 00 0E 00 00 00 BC 00 00 00 // ................
> 00F0: 01 00 00 00 00 00 00 00 00 14 00 00 10 00 00 00 // ................
> 0100: A0 00 00 00 01 00 00 00 00 00 00 00 00 14 00 00 // ................
> 0110: 0E 00 00 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................
> 0120: 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 // ................
> 0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00 00 // ................
> 0140: 00 00 20 00 00 08 00 00 10 0F 40 00 04 00 02 02 // .. .......@.....
> 0150: 01 1C 00 00 FF 00 00 00 34 01 00 00 00 80 00 00 // ........4.......
> 0160: 80 00 00 00 04 03 40 00 04 00 01 00 01 1C 00 00 // ......@.........
> 0170: FF 00 00 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4...........
> 0180: 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 // ..@.............
> 0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00 00 // 8...........l...
> 01A0: 50 01 00 00 00 14 00 00 10 00 00 00 88 01 00 00 // P...............
> 01B0: 00 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 01C0: A4 01 00 00 04 00 00 00 00 00 00 00 00 14 00 00 // ................
> 01D0: 0E 00 00 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................
> 01E0: 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 // ................
> 01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00 00 // ................
> 0200: 06 00 00 00 00 00 00 00 00 14 00 00 0E 00 00 00 // ................
> 0210: E0 01 00 00 07 00 00 00 00 00 00 00 // ............
>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
I've spent too long staring at PPTT in the past (and reviewed this internally)
so all looks good to me. (If you update the test remember to update the comment
on it above).
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> 2 files changed, 1 deletion(-)
>
> diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology b/tests/data/acpi/aarch64/virt/PPTT.topology
> index d0e5e11e90f33cbbbc231f9ad0bd48419e0fea65..f5f07b87c3777106e74f380de7941e1c01fc3447 100644
> GIT binary patch
> literal 540
> zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!luq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
> z%e!y9_D)?lO%?*tuH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
> zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
> z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
> S>h0TY?~`Ec-II5*#Ig@|86g1x
>
> literal 356
> zcmWFt2nk7HWME*P=H&0}5v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
> ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
> cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?*x0RR91
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index ba2a8180e9..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,2 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/aarch64/virt/PPTT.topology",
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
2024-12-23 17:48 ` Jonathan Cameron via
@ 2024-12-24 8:41 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-24 8:41 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linuxarm, qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Mon, 23 Dec 2024 17:48:18 +0000
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> On Mon, 16 Dec 2024 17:54:08 +0000
> Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> > This commit adds IsDefined flag to the object and this helps in
> > avoiding extra checks for every single layer of caches in both x86
> > and ARM.
> >
> > There is already a discussion on mailing list to have this flag. A
> > patch that enables this flag will follow later.
> >
> > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> Makes sense. Zhao Liu, is this something you plan to use in the x86
> code?
Hi Jonathan,
Yes this one comes from Zhao Liu's new patch-set, thanks to him. I will
have to send another version given that.
>
> Either way
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> > ---
> > hw/core/machine-smp.c | 2 ++
> > include/hw/boards.h | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
> > index 9a28194676..5a02bbf584 100644
> > --- a/hw/core/machine-smp.c
> > +++ b/hw/core/machine-smp.c
> > @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms,
> > return false;
> > }
> >
> > + ms->smp_cache.IsDefined = true;
> > +
> > return true;
> > }
> >
> > diff --git a/include/hw/boards.h b/include/hw/boards.h
> > index db2aa2b706..2883a57084 100644
> > --- a/include/hw/boards.h
> > +++ b/include/hw/boards.h
> > @@ -373,6 +373,7 @@ typedef struct CpuTopology {
> >
> > typedef struct SmpCache {
> > SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX];
> > + bool IsDefined;
> > } SmpCache;
> >
> > /**
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
@ 2024-12-24 8:41 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-24 8:41 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linuxarm, qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Mon, 23 Dec 2024 17:48:18 +0000
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> On Mon, 16 Dec 2024 17:54:08 +0000
> Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> > This commit adds IsDefined flag to the object and this helps in
> > avoiding extra checks for every single layer of caches in both x86
> > and ARM.
> >
> > There is already a discussion on mailing list to have this flag. A
> > patch that enables this flag will follow later.
> >
> > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> Makes sense. Zhao Liu, is this something you plan to use in the x86
> code?
Hi Jonathan,
Yes this one comes from Zhao Liu's new patch-set, thanks to him. I will
have to send another version given that.
>
> Either way
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> > ---
> > hw/core/machine-smp.c | 2 ++
> > include/hw/boards.h | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c
> > index 9a28194676..5a02bbf584 100644
> > --- a/hw/core/machine-smp.c
> > +++ b/hw/core/machine-smp.c
> > @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms,
> > return false;
> > }
> >
> > + ms->smp_cache.IsDefined = true;
> > +
> > return true;
> > }
> >
> > diff --git a/include/hw/boards.h b/include/hw/boards.h
> > index db2aa2b706..2883a57084 100644
> > --- a/include/hw/boards.h
> > +++ b/include/hw/boards.h
> > @@ -373,6 +373,7 @@ typedef struct CpuTopology {
> >
> > typedef struct SmpCache {
> > SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX];
> > + bool IsDefined;
> > } SmpCache;
> >
> > /**
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
2024-12-23 18:11 ` Jonathan Cameron via
@ 2024-12-24 8:44 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-24 8:44 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linuxarm, qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Mon, 23 Dec 2024 18:11:45 +0000
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> On Mon, 16 Dec 2024 17:54:13 +0000
> Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> > Test new PPTT topolopy with cache representation.
> >
> > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> > ---
> > tests/qtest/bios-tables-test.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/bios-tables-test.c
> > b/tests/qtest/bios-tables-test.c index 36e5c0adde..0f72520664 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -2019,7 +2019,11 @@ static void
> > test_acpi_aarch64_virt_tcg_topology(void) .scan_len = 128ULL * 1024
> > * 1024, };
> >
> > - test_acpi_one("-cpu cortex-a57 "
> > + test_acpi_one("-M
> > virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> > +
> > "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> > +
> > "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> > +
> > "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
> > + "-cpu cortex-a57 "
> Trivial but is there a reason the cpu must come after machine / -M
> bits? If not I'd leave it on first line to reduce the churn in this
> patch a little.
Noted. Less churn.
>
> Either way,
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
>
> > "-smp sockets=1,clusters=2,cores=2,threads=2",
> > &data); free_test_data(&data);
> > }
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology
@ 2024-12-24 8:44 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-24 8:44 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linuxarm, qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Mon, 23 Dec 2024 18:11:45 +0000
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> On Mon, 16 Dec 2024 17:54:13 +0000
> Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> > Test new PPTT topolopy with cache representation.
> >
> > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> > ---
> > tests/qtest/bios-tables-test.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/bios-tables-test.c
> > b/tests/qtest/bios-tables-test.c index 36e5c0adde..0f72520664 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -2019,7 +2019,11 @@ static void
> > test_acpi_aarch64_virt_tcg_topology(void) .scan_len = 128ULL * 1024
> > * 1024, };
> >
> > - test_acpi_one("-cpu cortex-a57 "
> > + test_acpi_one("-M
> > virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> > +
> > "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> > +
> > "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> > +
> > "smp-cache.3.cache=l3,smp-cache.3.topology=cluster "
> > + "-cpu cortex-a57 "
> Trivial but is there a reason the cpu must come after machine / -M
> bits? If not I'd leave it on first line to reduce the churn in this
> patch a little.
Noted. Less churn.
>
> Either way,
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
>
> > "-smp sockets=1,clusters=2,cores=2,threads=2",
> > &data); free_test_data(&data);
> > }
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.
2024-12-23 18:13 ` Jonathan Cameron via
@ 2024-12-24 8:53 ` Alireza Sanaee via
-1 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-24 8:53 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linuxarm, qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Mon, 23 Dec 2024 18:13:32 +0000
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> On Mon, 16 Dec 2024 17:54:14 +0000
> Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> > The disassembled differences between actual and expected PPTT based
> > on the following cache topology representation:
> >
> > ```
> > test_acpi_one("-M
> > virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> > "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> > "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> > "smp-cache.3.cache=l3,smp-cache.3.topology=cluster " "-cpu
> > cortex-a57 " "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> > ```
> >
> > /*
> > * Intel ACPI Component Architecture
> > * AML/ASL+ Disassembler version 20200925 (64-bit version)
> > * Copyright (c) 2000 - 2020 Intel Corporation
> > *
> > * Disassembly of
> > ../../../tests/data/acpi/aarch64/virt/PPTT.topology, Mon Oct 7
> > 16:57:29 2024 *
> > * ACPI Data Table [PPTT]
> > *
> > * Format: [HexOffset DecimalOffset ByteLength] FieldName :
> > FieldValue */
> >
> > [000h 0000 4] Signature : "PPTT" [Processor
> > Properties Topology Table] [004h 0004 4] Table
> > Length : 0000021C [008h 0008 1] Revision : 03
> > [009h 0009 1] Checksum : 4D
> > [00Ah 0010 6] Oem ID : "BOCHS "
> > [010h 0016 8] Oem Table ID : "BXPC "
> > [018h 0024 4] Oem Revision : 00000001
> > [01Ch 0028 4] Asl Compiler ID : "BXPC"
> > [020h 0032 4] Asl Compiler Revision : 00000001
> >
> > [024h 0036 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [025h 0037 1] Length : 14
> > [026h 0038 2] Reserved : 0000
> > [028h 0040 4] Flags (decoded below) : 00000011
> > Physical package : 1
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [02Ch 0044 4] Parent : 00000000
> > [030h 0048 4] ACPI Processor ID : 00000000
> > [034h 0052 4] Private Resource Number : 00000000
> >
> > [038h 0056 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [039h 0057 1] Length : 14
> > [03Ah 0058 2] Reserved : 0000
> > [03Ch 0060 4] Flags (decoded below) : 00000011
> > Physical package : 1
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [040h 0064 4] Parent : 00000024
> > [044h 0068 4] ACPI Processor ID : 00000000
> > [048h 0072 4] Private Resource Number : 00000000
> >
> > [04Ch 0076 1] Subtable Type : 01 [Cache Type]
> > [04Dh 0077 1] Length : 1C
> > [04Eh 0078 2] Reserved : 0000
> > [050h 0080 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [054h 0084 4] Next Level of Cache : 00000000
> > [058h 0088 4] Size : 00200000
> > [05Ch 0092 4] Number of Sets : 00000800
> > [060h 0096 1] Associativity : 10
> > [061h 0097 1] Attributes : 0F
> > Allocation Type : 3
> > Cache Type : 3
> > Write Policy : 0
> > [062h 0098 2] Line Size : 0040
> >
> > [068h 0104 1] Subtable Type : 01 [Cache Type]
> > [069h 0105 1] Length : 1C
> > [06Ah 0106 2] Reserved : 0000
> > [06Ch 0108 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [070h 0112 4] Next Level of Cache : 0000004C
> > [074h 0116 4] Size : 00008000
> > [078h 0120 4] Number of Sets : 00000080
> > [07Ch 0124 1] Associativity : 04
> > [07Dh 0125 1] Attributes : 03
> > Allocation Type : 3
> > Cache Type : 0
> > Write Policy : 0
> > [07Eh 0126 2] Line Size : 0040
> >
> > [084h 0132 1] Subtable Type : 01 [Cache Type]
> > [085h 0133 1] Length : 1C
> > [086h 0134 2] Reserved : 0000
> > [088h 0136 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [08Ch 0140 4] Next Level of Cache : 0000004C
> > [090h 0144 4] Size : 0000C000
> > [094h 0148 4] Number of Sets : 00000100
> > [098h 0152 1] Associativity : 03
> > [099h 0153 1] Attributes : 07
> > Allocation Type : 3
> > Cache Type : 1
> > Write Policy : 0
> > [09Ah 0154 2] Line Size : 0040
> >
> > [0A0h 0160 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0A1h 0161 1] Length : 1C
> > [0A2h 0162 2] Reserved : 0000
> > [0A4h 0164 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [0A8h 0168 4] Parent : 00000038
> > [0ACh 0172 4] ACPI Processor ID : 00000000
> > [0B0h 0176 4] Private Resource Number : 00000002
> > [0B4h 0180 4] Private Resource : 00000084
> > [0B8h 0184 4] Private Resource : 00000068
> >
> > [0BCh 0188 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0BDh 0189 1] Length : 14
> > [0BEh 0190 2] Reserved : 0000
> > [0C0h 0192 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [0C4h 0196 4] Parent : 000000A0
> > [0C8h 0200 4] ACPI Processor ID : 00000000
> > [0CCh 0204 4] Private Resource Number : 00000000
> >
> > [0D0h 0208 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0D1h 0209 1] Length : 14
> > [0D2h 0210 2] Reserved : 0000
> > [0D4h 0212 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [0D8h 0216 4] Parent : 000000BC
> > [0DCh 0220 4] ACPI Processor ID : 00000000
> > [0E0h 0224 4] Private Resource Number : 00000000
> >
> > [0E4h 0228 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0E5h 0229 1] Length : 14
> > [0E6h 0230 2] Reserved : 0000
> > [0E8h 0232 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [0ECh 0236 4] Parent : 000000BC
> > [0F0h 0240 4] ACPI Processor ID : 00000001
> > [0F4h 0244 4] Private Resource Number : 00000000
> >
> > [0F8h 0248 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0F9h 0249 1] Length : 14
> > [0FAh 0250 2] Reserved : 0000
> > [0FCh 0252 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [100h 0256 4] Parent : 000000A0
> > [104h 0260 4] ACPI Processor ID : 00000001
> > [108h 0264 4] Private Resource Number : 00000000
> >
> > [10Ch 0268 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [10Dh 0269 1] Length : 14
> > [10Eh 0270 2] Reserved : 0000
> > [110h 0272 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [114h 0276 4] Parent : 000000F8
> > [118h 0280 4] ACPI Processor ID : 00000002
> > [11Ch 0284 4] Private Resource Number : 00000000
> >
> > [120h 0288 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [121h 0289 1] Length : 14
> > [122h 0290 2] Reserved : 0000
> > [124h 0292 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [128h 0296 4] Parent : 000000F8
> > [12Ch 0300 4] ACPI Processor ID : 00000003
> > [130h 0304 4] Private Resource Number : 00000000
> >
> > [134h 0308 1] Subtable Type : 01 [Cache Type]
> > [135h 0309 1] Length : 1C
> > [136h 0310 2] Reserved : 0000
> > [138h 0312 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [13Ch 0316 4] Next Level of Cache : 00000000
> > [140h 0320 4] Size : 00200000
> > [144h 0324 4] Number of Sets : 00000800
> > [148h 0328 1] Associativity : 10
> > [149h 0329 1] Attributes : 0F
> > Allocation Type : 3
> > Cache Type : 3
> > Write Policy : 0
> > [14Ah 0330 2] Line Size : 0040
> >
> > [150h 0336 1] Subtable Type : 01 [Cache Type]
> > [151h 0337 1] Length : 1C
> > [152h 0338 2] Reserved : 0000
> > [154h 0340 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [158h 0344 4] Next Level of Cache : 00000134
> > [15Ch 0348 4] Size : 00008000
> > [160h 0352 4] Number of Sets : 00000080
> > [164h 0356 1] Associativity : 04
> > [165h 0357 1] Attributes : 03
> > Allocation Type : 3
> > Cache Type : 0
> > Write Policy : 0
> > [166h 0358 2] Line Size : 0040
> >
> > [16Ch 0364 1] Subtable Type : 01 [Cache Type]
> > [16Dh 0365 1] Length : 1C
> > [16Eh 0366 2] Reserved : 0000
> > [170h 0368 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [174h 0372 4] Next Level of Cache : 00000134
> > [178h 0376 4] Size : 0000C000
> > [17Ch 0380 4] Number of Sets : 00000100
> > [180h 0384 1] Associativity : 03
> > [181h 0385 1] Attributes : 07
> > Allocation Type : 3
> > Cache Type : 1
> > Write Policy : 0
> > [182h 0386 2] Line Size : 0040
> >
> > [188h 0392 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [189h 0393 1] Length : 1C
> > [18Ah 0394 2] Reserved : 0000
> > [18Ch 0396 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [190h 0400 4] Parent : 00000038
> > [194h 0404 4] ACPI Processor ID : 00000001
> > [198h 0408 4] Private Resource Number : 00000002
> > [19Ch 0412 4] Private Resource : 0000016C
> > [1A0h 0416 4] Private Resource : 00000150
> >
> > [1A4h 0420 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1A5h 0421 1] Length : 14
> > [1A6h 0422 2] Reserved : 0000
> > [1A8h 0424 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [1ACh 0428 4] Parent : 00000188
> > [1B0h 0432 4] ACPI Processor ID : 00000000
> > [1B4h 0436 4] Private Resource Number : 00000000
> >
> > [1B8h 0440 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1B9h 0441 1] Length : 14
> > [1BAh 0442 2] Reserved : 0000
> > [1BCh 0444 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [1C0h 0448 4] Parent : 000001A4
> > [1C4h 0452 4] ACPI Processor ID : 00000004
> > [1C8h 0456 4] Private Resource Number : 00000000
> >
> > [1CCh 0460 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1CDh 0461 1] Length : 14
> > [1CEh 0462 2] Reserved : 0000
> > [1D0h 0464 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [1D4h 0468 4] Parent : 000001A4
> > [1D8h 0472 4] ACPI Processor ID : 00000005
> > [1DCh 0476 4] Private Resource Number : 00000000
> >
> > [1E0h 0480 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1E1h 0481 1] Length : 14
> > [1E2h 0482 2] Reserved : 0000
> > [1E4h 0484 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [1E8h 0488 4] Parent : 00000188
> > [1ECh 0492 4] ACPI Processor ID : 00000001
> > [1F0h 0496 4] Private Resource Number : 00000000
> >
> > [1F4h 0500 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1F5h 0501 1] Length : 14
> > [1F6h 0502 2] Reserved : 0000
> > [1F8h 0504 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [1FCh 0508 4] Parent : 000001E0
> > [200h 0512 4] ACPI Processor ID : 00000006
> > [204h 0516 4] Private Resource Number : 00000000
> >
> > [208h 0520 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [209h 0521 1] Length : 14
> > [20Ah 0522 2] Reserved : 0000
> > [20Ch 0524 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [210h 0528 4] Parent : 000001E0
> > [214h 0532 4] ACPI Processor ID : 00000007
> > [218h 0536 4] Private Resource Number : 00000000
> >
> > Raw Table Data: Length 540 (0x21C)
> >
> > 0000: 50 50 54 54 1C 02 00 00 03 4D 42 4F 43 48 53 20 //
> > PPTT.....MBOCHS 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50
> > 43 // BXPC ....BXPC 0020: 01 00 00 00 00 14 00 00 11 00 00 00
> > 00 00 00 00 // ................ 0030: 00 00 00 00 00 00 00 00 00
> > 14 00 00 11 00 00 00 // ................ 0040: 24 00 00 00 00 00
> > 00 00 00 00 00 00 01 1C 00 00 // $............... 0050: FF 00 00
> > 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... ..... 0060:
> > 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 //
> > ..@............. 0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40
> > 00 // L.............@. 0080: 00 00 01 00 01 1C 00 00 FF 00 00 00
> > 4C 00 00 00 // ............L... 0090: 00 C0 00 00 00 01 00 00 03
> > 07 40 00 00 00 01 01 // ..........@..... 00A0: 00 1C 00 00 10 00
> > 00 00 38 00 00 00 00 00 00 00 // ........8....... 00B0: 02 00 00
> > 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h....... 00C0:
> > 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 //
> > ................ 00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00
> > 00 // ................ 00E0: 00 00 00 00 00 14 00 00 0E 00 00 00
> > BC 00 00 00 // ................ 00F0: 01 00 00 00 00 00 00 00 00
> > 14 00 00 10 00 00 00 // ................ 0100: A0 00 00 00 01 00
> > 00 00 00 00 00 00 00 14 00 00 // ................ 0110: 0E 00 00
> > 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................ 0120:
> > 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 //
> > ................ 0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00
> > 00 // ................ 0140: 00 00 20 00 00 08 00 00 10 0F 40 00
> > 04 00 02 02 // .. .......@..... 0150: 01 1C 00 00 FF 00 00 00 34
> > 01 00 00 00 80 00 00 // ........4....... 0160: 80 00 00 00 04 03
> > 40 00 04 00 01 00 01 1C 00 00 // ......@......... 0170: FF 00 00
> > 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4........... 0180:
> > 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 //
> > ..@............. 0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00
> > 00 // 8...........l... 01A0: 50 01 00 00 00 14 00 00 10 00 00 00
> > 88 01 00 00 // P............... 01B0: 00 00 00 00 00 00 00 00 00
> > 14 00 00 0E 00 00 00 // ................ 01C0: A4 01 00 00 04 00
> > 00 00 00 00 00 00 00 14 00 00 // ................ 01D0: 0E 00 00
> > 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................ 01E0:
> > 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 //
> > ................ 01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00
> > 00 // ................ 0200: 06 00 00 00 00 00 00 00 00 14 00 00
> > 0E 00 00 00 // ................ 0210: E0 01 00 00 07 00 00 00 00
> > 00 00 00 // ............
> >
> > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
>
> I've spent too long staring at PPTT in the past (and reviewed this
> internally) so all looks good to me. (If you update the test remember
> to update the comment on it above).
This comment should be moved to the prior patch.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
> > tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> > 2 files changed, 1 deletion(-)
> >
> > diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology
> > b/tests/data/acpi/aarch64/virt/PPTT.topology index
> > d0e5e11e90f33cbbbc231f9ad0bd48419e0fea65..f5f07b87c3777106e74f380de7941e1c01fc3447
> > 100644 GIT binary patch literal 540
> > zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!luq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
> > z%e!y9_D)?lO%?*tuH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
> > zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
> > z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
> > S>h0TY?~`Ec-II5*#Ig@|86g1x
> >
> > literal 356
> > zcmWFt2nk7HWME*P=H&0}5v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
> > ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
> > cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?*x0RR91
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
> > b/tests/qtest/bios-tables-test-allowed-diff.h index
> > ba2a8180e9..dfb8523c8b 100644 ---
> > a/tests/qtest/bios-tables-test-allowed-diff.h +++
> > b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,2 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/aarch64/virt/PPTT.topology",
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h.
@ 2024-12-24 8:53 ` Alireza Sanaee via
0 siblings, 0 replies; 32+ messages in thread
From: Alireza Sanaee via @ 2024-12-24 8:53 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linuxarm, qemu-devel, qemu-arm, zhao1.liu, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Mon, 23 Dec 2024 18:13:32 +0000
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> On Mon, 16 Dec 2024 17:54:14 +0000
> Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> > The disassembled differences between actual and expected PPTT based
> > on the following cache topology representation:
> >
> > ```
> > test_acpi_one("-M
> > virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster,"
> > "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster,"
> > "smp-cache.2.cache=l2,smp-cache.2.topology=cluster,"
> > "smp-cache.3.cache=l3,smp-cache.3.topology=cluster " "-cpu
> > cortex-a57 " "-smp sockets=1,clusters=2,cores=2,threads=2", &data);
> > ```
> >
> > /*
> > * Intel ACPI Component Architecture
> > * AML/ASL+ Disassembler version 20200925 (64-bit version)
> > * Copyright (c) 2000 - 2020 Intel Corporation
> > *
> > * Disassembly of
> > ../../../tests/data/acpi/aarch64/virt/PPTT.topology, Mon Oct 7
> > 16:57:29 2024 *
> > * ACPI Data Table [PPTT]
> > *
> > * Format: [HexOffset DecimalOffset ByteLength] FieldName :
> > FieldValue */
> >
> > [000h 0000 4] Signature : "PPTT" [Processor
> > Properties Topology Table] [004h 0004 4] Table
> > Length : 0000021C [008h 0008 1] Revision : 03
> > [009h 0009 1] Checksum : 4D
> > [00Ah 0010 6] Oem ID : "BOCHS "
> > [010h 0016 8] Oem Table ID : "BXPC "
> > [018h 0024 4] Oem Revision : 00000001
> > [01Ch 0028 4] Asl Compiler ID : "BXPC"
> > [020h 0032 4] Asl Compiler Revision : 00000001
> >
> > [024h 0036 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [025h 0037 1] Length : 14
> > [026h 0038 2] Reserved : 0000
> > [028h 0040 4] Flags (decoded below) : 00000011
> > Physical package : 1
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [02Ch 0044 4] Parent : 00000000
> > [030h 0048 4] ACPI Processor ID : 00000000
> > [034h 0052 4] Private Resource Number : 00000000
> >
> > [038h 0056 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [039h 0057 1] Length : 14
> > [03Ah 0058 2] Reserved : 0000
> > [03Ch 0060 4] Flags (decoded below) : 00000011
> > Physical package : 1
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [040h 0064 4] Parent : 00000024
> > [044h 0068 4] ACPI Processor ID : 00000000
> > [048h 0072 4] Private Resource Number : 00000000
> >
> > [04Ch 0076 1] Subtable Type : 01 [Cache Type]
> > [04Dh 0077 1] Length : 1C
> > [04Eh 0078 2] Reserved : 0000
> > [050h 0080 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [054h 0084 4] Next Level of Cache : 00000000
> > [058h 0088 4] Size : 00200000
> > [05Ch 0092 4] Number of Sets : 00000800
> > [060h 0096 1] Associativity : 10
> > [061h 0097 1] Attributes : 0F
> > Allocation Type : 3
> > Cache Type : 3
> > Write Policy : 0
> > [062h 0098 2] Line Size : 0040
> >
> > [068h 0104 1] Subtable Type : 01 [Cache Type]
> > [069h 0105 1] Length : 1C
> > [06Ah 0106 2] Reserved : 0000
> > [06Ch 0108 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [070h 0112 4] Next Level of Cache : 0000004C
> > [074h 0116 4] Size : 00008000
> > [078h 0120 4] Number of Sets : 00000080
> > [07Ch 0124 1] Associativity : 04
> > [07Dh 0125 1] Attributes : 03
> > Allocation Type : 3
> > Cache Type : 0
> > Write Policy : 0
> > [07Eh 0126 2] Line Size : 0040
> >
> > [084h 0132 1] Subtable Type : 01 [Cache Type]
> > [085h 0133 1] Length : 1C
> > [086h 0134 2] Reserved : 0000
> > [088h 0136 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [08Ch 0140 4] Next Level of Cache : 0000004C
> > [090h 0144 4] Size : 0000C000
> > [094h 0148 4] Number of Sets : 00000100
> > [098h 0152 1] Associativity : 03
> > [099h 0153 1] Attributes : 07
> > Allocation Type : 3
> > Cache Type : 1
> > Write Policy : 0
> > [09Ah 0154 2] Line Size : 0040
> >
> > [0A0h 0160 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0A1h 0161 1] Length : 1C
> > [0A2h 0162 2] Reserved : 0000
> > [0A4h 0164 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [0A8h 0168 4] Parent : 00000038
> > [0ACh 0172 4] ACPI Processor ID : 00000000
> > [0B0h 0176 4] Private Resource Number : 00000002
> > [0B4h 0180 4] Private Resource : 00000084
> > [0B8h 0184 4] Private Resource : 00000068
> >
> > [0BCh 0188 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0BDh 0189 1] Length : 14
> > [0BEh 0190 2] Reserved : 0000
> > [0C0h 0192 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [0C4h 0196 4] Parent : 000000A0
> > [0C8h 0200 4] ACPI Processor ID : 00000000
> > [0CCh 0204 4] Private Resource Number : 00000000
> >
> > [0D0h 0208 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0D1h 0209 1] Length : 14
> > [0D2h 0210 2] Reserved : 0000
> > [0D4h 0212 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [0D8h 0216 4] Parent : 000000BC
> > [0DCh 0220 4] ACPI Processor ID : 00000000
> > [0E0h 0224 4] Private Resource Number : 00000000
> >
> > [0E4h 0228 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0E5h 0229 1] Length : 14
> > [0E6h 0230 2] Reserved : 0000
> > [0E8h 0232 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [0ECh 0236 4] Parent : 000000BC
> > [0F0h 0240 4] ACPI Processor ID : 00000001
> > [0F4h 0244 4] Private Resource Number : 00000000
> >
> > [0F8h 0248 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [0F9h 0249 1] Length : 14
> > [0FAh 0250 2] Reserved : 0000
> > [0FCh 0252 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [100h 0256 4] Parent : 000000A0
> > [104h 0260 4] ACPI Processor ID : 00000001
> > [108h 0264 4] Private Resource Number : 00000000
> >
> > [10Ch 0268 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [10Dh 0269 1] Length : 14
> > [10Eh 0270 2] Reserved : 0000
> > [110h 0272 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [114h 0276 4] Parent : 000000F8
> > [118h 0280 4] ACPI Processor ID : 00000002
> > [11Ch 0284 4] Private Resource Number : 00000000
> >
> > [120h 0288 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [121h 0289 1] Length : 14
> > [122h 0290 2] Reserved : 0000
> > [124h 0292 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [128h 0296 4] Parent : 000000F8
> > [12Ch 0300 4] ACPI Processor ID : 00000003
> > [130h 0304 4] Private Resource Number : 00000000
> >
> > [134h 0308 1] Subtable Type : 01 [Cache Type]
> > [135h 0309 1] Length : 1C
> > [136h 0310 2] Reserved : 0000
> > [138h 0312 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [13Ch 0316 4] Next Level of Cache : 00000000
> > [140h 0320 4] Size : 00200000
> > [144h 0324 4] Number of Sets : 00000800
> > [148h 0328 1] Associativity : 10
> > [149h 0329 1] Attributes : 0F
> > Allocation Type : 3
> > Cache Type : 3
> > Write Policy : 0
> > [14Ah 0330 2] Line Size : 0040
> >
> > [150h 0336 1] Subtable Type : 01 [Cache Type]
> > [151h 0337 1] Length : 1C
> > [152h 0338 2] Reserved : 0000
> > [154h 0340 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [158h 0344 4] Next Level of Cache : 00000134
> > [15Ch 0348 4] Size : 00008000
> > [160h 0352 4] Number of Sets : 00000080
> > [164h 0356 1] Associativity : 04
> > [165h 0357 1] Attributes : 03
> > Allocation Type : 3
> > Cache Type : 0
> > Write Policy : 0
> > [166h 0358 2] Line Size : 0040
> >
> > [16Ch 0364 1] Subtable Type : 01 [Cache Type]
> > [16Dh 0365 1] Length : 1C
> > [16Eh 0366 2] Reserved : 0000
> > [170h 0368 4] Flags (decoded below) : 000000FF
> > Size valid : 1
> > Number of Sets valid : 1
> > Associativity valid : 1
> > Allocation Type valid : 1
> > Cache Type valid : 1
> > Write Policy valid : 1
> > Line Size valid : 1
> > [174h 0372 4] Next Level of Cache : 00000134
> > [178h 0376 4] Size : 0000C000
> > [17Ch 0380 4] Number of Sets : 00000100
> > [180h 0384 1] Associativity : 03
> > [181h 0385 1] Attributes : 07
> > Allocation Type : 3
> > Cache Type : 1
> > Write Policy : 0
> > [182h 0386 2] Line Size : 0040
> >
> > [188h 0392 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [189h 0393 1] Length : 1C
> > [18Ah 0394 2] Reserved : 0000
> > [18Ch 0396 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [190h 0400 4] Parent : 00000038
> > [194h 0404 4] ACPI Processor ID : 00000001
> > [198h 0408 4] Private Resource Number : 00000002
> > [19Ch 0412 4] Private Resource : 0000016C
> > [1A0h 0416 4] Private Resource : 00000150
> >
> > [1A4h 0420 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1A5h 0421 1] Length : 14
> > [1A6h 0422 2] Reserved : 0000
> > [1A8h 0424 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [1ACh 0428 4] Parent : 00000188
> > [1B0h 0432 4] ACPI Processor ID : 00000000
> > [1B4h 0436 4] Private Resource Number : 00000000
> >
> > [1B8h 0440 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1B9h 0441 1] Length : 14
> > [1BAh 0442 2] Reserved : 0000
> > [1BCh 0444 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [1C0h 0448 4] Parent : 000001A4
> > [1C4h 0452 4] ACPI Processor ID : 00000004
> > [1C8h 0456 4] Private Resource Number : 00000000
> >
> > [1CCh 0460 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1CDh 0461 1] Length : 14
> > [1CEh 0462 2] Reserved : 0000
> > [1D0h 0464 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [1D4h 0468 4] Parent : 000001A4
> > [1D8h 0472 4] ACPI Processor ID : 00000005
> > [1DCh 0476 4] Private Resource Number : 00000000
> >
> > [1E0h 0480 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1E1h 0481 1] Length : 14
> > [1E2h 0482 2] Reserved : 0000
> > [1E4h 0484 4] Flags (decoded below) : 00000010
> > Physical package : 0
> > ACPI Processor ID valid : 0
> > Processor is a thread : 0
> > Node is a leaf : 0
> > Identical Implementation : 1
> > [1E8h 0488 4] Parent : 00000188
> > [1ECh 0492 4] ACPI Processor ID : 00000001
> > [1F0h 0496 4] Private Resource Number : 00000000
> >
> > [1F4h 0500 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [1F5h 0501 1] Length : 14
> > [1F6h 0502 2] Reserved : 0000
> > [1F8h 0504 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [1FCh 0508 4] Parent : 000001E0
> > [200h 0512 4] ACPI Processor ID : 00000006
> > [204h 0516 4] Private Resource Number : 00000000
> >
> > [208h 0520 1] Subtable Type : 00 [Processor
> > Hierarchy Node] [209h 0521 1] Length : 14
> > [20Ah 0522 2] Reserved : 0000
> > [20Ch 0524 4] Flags (decoded below) : 0000000E
> > Physical package : 0
> > ACPI Processor ID valid : 1
> > Processor is a thread : 1
> > Node is a leaf : 1
> > Identical Implementation : 0
> > [210h 0528 4] Parent : 000001E0
> > [214h 0532 4] ACPI Processor ID : 00000007
> > [218h 0536 4] Private Resource Number : 00000000
> >
> > Raw Table Data: Length 540 (0x21C)
> >
> > 0000: 50 50 54 54 1C 02 00 00 03 4D 42 4F 43 48 53 20 //
> > PPTT.....MBOCHS 0010: 42 58 50 43 20 20 20 20 01 00 00 00 42 58 50
> > 43 // BXPC ....BXPC 0020: 01 00 00 00 00 14 00 00 11 00 00 00
> > 00 00 00 00 // ................ 0030: 00 00 00 00 00 00 00 00 00
> > 14 00 00 11 00 00 00 // ................ 0040: 24 00 00 00 00 00
> > 00 00 00 00 00 00 01 1C 00 00 // $............... 0050: FF 00 00
> > 00 00 00 00 00 00 00 20 00 00 08 00 00 // .......... ..... 0060:
> > 10 0F 40 00 00 00 02 02 01 1C 00 00 FF 00 00 00 //
> > ..@............. 0070: 4C 00 00 00 00 80 00 00 80 00 00 00 04 03 40
> > 00 // L.............@. 0080: 00 00 01 00 01 1C 00 00 FF 00 00 00
> > 4C 00 00 00 // ............L... 0090: 00 C0 00 00 00 01 00 00 03
> > 07 40 00 00 00 01 01 // ..........@..... 00A0: 00 1C 00 00 10 00
> > 00 00 38 00 00 00 00 00 00 00 // ........8....... 00B0: 02 00 00
> > 00 84 00 00 00 68 00 00 00 00 14 00 00 // ........h....... 00C0:
> > 10 00 00 00 A0 00 00 00 00 00 00 00 00 00 00 00 //
> > ................ 00D0: 00 14 00 00 0E 00 00 00 BC 00 00 00 00 00 00
> > 00 // ................ 00E0: 00 00 00 00 00 14 00 00 0E 00 00 00
> > BC 00 00 00 // ................ 00F0: 01 00 00 00 00 00 00 00 00
> > 14 00 00 10 00 00 00 // ................ 0100: A0 00 00 00 01 00
> > 00 00 00 00 00 00 00 14 00 00 // ................ 0110: 0E 00 00
> > 00 F8 00 00 00 02 00 00 00 00 00 00 00 // ................ 0120:
> > 00 14 00 00 0E 00 00 00 F8 00 00 00 03 00 00 00 //
> > ................ 0130: 00 00 00 00 01 1C 00 00 FF 00 00 00 00 00 00
> > 00 // ................ 0140: 00 00 20 00 00 08 00 00 10 0F 40 00
> > 04 00 02 02 // .. .......@..... 0150: 01 1C 00 00 FF 00 00 00 34
> > 01 00 00 00 80 00 00 // ........4....... 0160: 80 00 00 00 04 03
> > 40 00 04 00 01 00 01 1C 00 00 // ......@......... 0170: FF 00 00
> > 00 34 01 00 00 00 C0 00 00 00 01 00 00 // ....4........... 0180:
> > 03 07 40 00 04 00 01 01 00 1C 00 00 10 00 00 00 //
> > ..@............. 0190: 38 00 00 00 01 00 00 00 02 00 00 00 6C 01 00
> > 00 // 8...........l... 01A0: 50 01 00 00 00 14 00 00 10 00 00 00
> > 88 01 00 00 // P............... 01B0: 00 00 00 00 00 00 00 00 00
> > 14 00 00 0E 00 00 00 // ................ 01C0: A4 01 00 00 04 00
> > 00 00 00 00 00 00 00 14 00 00 // ................ 01D0: 0E 00 00
> > 00 A4 01 00 00 05 00 00 00 00 00 00 00 // ................ 01E0:
> > 00 14 00 00 10 00 00 00 88 01 00 00 01 00 00 00 //
> > ................ 01F0: 00 00 00 00 00 14 00 00 0E 00 00 00 E0 01 00
> > 00 // ................ 0200: 06 00 00 00 00 00 00 00 00 14 00 00
> > 0E 00 00 00 // ................ 0210: E0 01 00 00 07 00 00 00 00
> > 00 00 00 // ............
> >
> > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
>
> I've spent too long staring at PPTT in the past (and reviewed this
> internally) so all looks good to me. (If you update the test remember
> to update the comment on it above).
This comment should be moved to the prior patch.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> > tests/data/acpi/aarch64/virt/PPTT.topology | Bin 356 -> 540 bytes
> > tests/qtest/bios-tables-test-allowed-diff.h | 1 -
> > 2 files changed, 1 deletion(-)
> >
> > diff --git a/tests/data/acpi/aarch64/virt/PPTT.topology
> > b/tests/data/acpi/aarch64/virt/PPTT.topology index
> > d0e5e11e90f33cbbbc231f9ad0bd48419e0fea65..f5f07b87c3777106e74f380de7941e1c01fc3447
> > 100644 GIT binary patch literal 540
> > zcmZvXI}XAy5JV>*2o(g0GDQlGKtUNL4F!luq~Hh?93lk;$DrUC6gdjVpo1A>2S;LM
> > z%e!y9_D)?lO%?*tuH09fLtY;1DrW=$l<UL-nCtYzvZcp@40!i-4orY_R*;0D)3(xE
> > zvk*rGivR<yGYC;)v;cfFC0cVUI4UmOCl#DQ+D*9&vMKY2t95$J__56O`b@nqZvA7z
> > z_KHOoxp}{3-usL_pDR7u{(Q!sPos6zc}G5}4ScFq|DT!EDy+||au;^4J6ZgPjXWlw
> > S>h0TY?~`Ec-II5*#Ig@|86g1x
> >
> > literal 356
> > zcmWFt2nk7HWME*P=H&0}5v<@85#X!<1VAAM5F11@h%hh+f@ov_6;nYI69Dopu!#Af
> > ziSYsX2{^>Sc7o)9c7V(S=|vU;>74__Oh60<Ky@%NW+X9~TafjF#BRXUfM}@RH$Wx}
> > cOdLs!6-f-H7uh_Jy&6CPHY9a0F?OgJ00?*x0RR91
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
> > b/tests/qtest/bios-tables-test-allowed-diff.h index
> > ba2a8180e9..dfb8523c8b 100644 ---
> > a/tests/qtest/bios-tables-test-allowed-diff.h +++
> > b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,2 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/aarch64/virt/PPTT.topology",
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property
2024-12-24 8:41 ` Alireza Sanaee via
(?)
@ 2024-12-24 10:24 ` Zhao Liu
-1 siblings, 0 replies; 32+ messages in thread
From: Zhao Liu @ 2024-12-24 10:24 UTC (permalink / raw)
To: Alireza Sanaee
Cc: Jonathan Cameron, linuxarm, qemu-devel, qemu-arm, zhenyu.z.wang,
dapeng1.mi, yongwei.ma, armbru, farman, peter.maydell, mst,
anisinha, shannon.zhaosl, imammedo, mtosatti, berrange,
richard.henderson, shameerali.kolothum.thodi, jiangkunkun,
yangyicong, sarsanaee
On Tue, Dec 24, 2024 at 08:41:27AM +0000, Alireza Sanaee wrote:
> Date: Tue, 24 Dec 2024 08:41:27 +0000
> From: Alireza Sanaee <alireza.sanaee@huawei.com>
> Subject: Re: [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache
> property
> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32)
>
> On Mon, 23 Dec 2024 17:48:18 +0000
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
>
> > On Mon, 16 Dec 2024 17:54:08 +0000
> > Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
> >
> > > This commit adds IsDefined flag to the object and this helps in
> > > avoiding extra checks for every single layer of caches in both x86
> > > and ARM.
> > >
> > > There is already a discussion on mailing list to have this flag. A
> > > patch that enables this flag will follow later.
> > >
> > > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> > Makes sense. Zhao Liu, is this something you plan to use in the x86
> > code?
>
> Hi Jonathan,
>
> Yes this one comes from Zhao Liu's new patch-set, thanks to him. I will
> have to send another version given that.
Welcome! You can rebase this series on my v6. This way, there won't be
any conflicts, and once v6 is merged, yours can also be naturally picked
by maintainer. :-)
Regards,
Zhao
^ permalink raw reply [flat|nested] 32+ messages in thread
end of thread, other threads:[~2024-12-24 10:06 UTC | newest]
Thread overview: 32+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-16 17:54 [RFC PATCH v4 0/7] Specifying cache topology on ARM Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-16 17:54 ` [PATCH v4 1/7] i386/cpu: add IsDefined flag to smp-cache property Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-23 17:48 ` Jonathan Cameron via
2024-12-23 17:48 ` Jonathan Cameron via
2024-12-24 8:41 ` Alireza Sanaee via
2024-12-24 8:41 ` Alireza Sanaee via
2024-12-24 10:24 ` Zhao Liu
2024-12-16 17:54 ` [PATCH v4 2/7] target/arm/tcg: increase cache level for cpu=max Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-23 17:47 ` Jonathan Cameron via
2024-12-23 17:47 ` Jonathan Cameron via
2024-12-16 17:54 ` [PATCH v4 3/7] arm/virt.c: add cache hierarchy to device tree Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-23 18:09 ` Jonathan Cameron via
2024-12-23 18:09 ` Jonathan Cameron via
2024-12-16 17:54 ` [PATCH v4 4/7] bios-tables-test: prepare to change ARM ACPI virt PPTT Alireza Sanaee via
2024-12-16 17:54 ` [PATCH v4 5/7] hw/acpi/aml-build.c: add cache hierarchy to pptt table Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-16 17:54 ` [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-23 18:11 ` Jonathan Cameron via
2024-12-23 18:11 ` Jonathan Cameron via
2024-12-24 8:44 ` Alireza Sanaee via
2024-12-24 8:44 ` Alireza Sanaee via
2024-12-16 17:54 ` [PATCH v4 7/7] Update the ACPI tables according to the acpi aml_build change, also empty bios-tables-test-allowed-diff.h Alireza Sanaee via
2024-12-16 17:54 ` Alireza Sanaee via
2024-12-23 18:13 ` Jonathan Cameron via
2024-12-23 18:13 ` Jonathan Cameron via
2024-12-24 8:53 ` Alireza Sanaee via
2024-12-24 8:53 ` Alireza Sanaee via
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.