[Buildroot] [PATCH 1/3] whois: fix build with NLS disabled

[Buildroot] [PATCH 1/3] whois: fix build with NLS disabled

[Baruch Siach]

whois build uses the xgettext utility to build translation files.
This utility may not be available when NLS is disabled. Omit the pos and
install-pos Makefile targets from the default and the install targets
when NLS is disabled, respectively.

Fixes:
http://autobuild.buildroot.net/results/862/862d8165a59711c970c65d90009a527315a1a6b4/
http://autobuild.buildroot.net/results/b62/b62ec9d6f350e409731d47ffb585344c516944e8/
http://autobuild.buildroot.net/results/be2/be28d06ae004a46c87133d6f07709c6f909288d8/

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/whois/whois.mk | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/package/whois/whois.mk b/package/whois/whois.mk
index b77349997883..87cc65fac4c7 100644
--- a/package/whois/whois.mk
+++ b/package/whois/whois.mk
@@ -27,13 +27,22 @@ WHOIS_DEPENDENCIES += libidn
 WHOIS_MAKE_ENV += HAVE_LIBIDN=1
 endif
 
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
+WHOIS_BUILD_TARGETS =
+WHOIS_INSTALL_TARGETS = install
+else
+WHOIS_BUILD_TARGETS = Makefile.depend whois mkpasswd
+WHOIS_INSTALL_TARGETS = install-whois install-mkpasswd
+endif
+
 define WHOIS_BUILD_CMDS
-	$(WHOIS_MAKE_ENV) $(MAKE) $(WHOIS_MAKE_OPTS) -C $(@D)
+	$(WHOIS_MAKE_ENV) $(MAKE) $(WHOIS_MAKE_OPTS) \
+		$(WHOIS_BUILD_TARGETS) -C $(@D)
 endef
 
 define WHOIS_INSTALL_TARGET_CMDS
 	$(WHOIS_MAKE_ENV) $(MAKE) $(WHOIS_MAKE_OPTS) \
-		BASEDIR="$(TARGET_DIR)" install -C $(@D)
+		BASEDIR="$(TARGET_DIR)" $(WHOIS_INSTALL_TARGETS) -C $(@D)
 endef
 
 $(eval $(generic-package))
-- 
2.14.1

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Baruch Siach]

The github repo is more informative than the list Marco's software on
the previous link.

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/whois/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/whois/Config.in b/package/whois/Config.in
index 9505d5832056..d2a030282b76 100644
--- a/package/whois/Config.in
+++ b/package/whois/Config.in
@@ -4,4 +4,4 @@ config BR2_PACKAGE_WHOIS
 	help
 	  Improved whois client.
 
-	  http://www.linux.it/~md/software/
+	  https://github.com/rfc1036/whois
-- 
2.14.1

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Thomas Petazzoni]

Hello,

On Sun, 13 Aug 2017 21:34:18 +0300, Baruch Siach wrote:
> The github repo is more informative than the list Marco's software on
> the previous link.
> 
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

What about switching the upstream to be Github, instead of fetching
from Debian? The Github repo has all the releases available:
https://github.com/rfc1036/whois/releases.

Just make sure that the 5.2.14 tarball we were getting from Debian is
similar in contents to what we get from the Github repository for the
same version.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Baruch Siach]

Hi Thomas,

On Mon, Aug 14, 2017 at 10:03:54PM +0200, Thomas Petazzoni wrote:
> On Sun, 13 Aug 2017 21:34:18 +0300, Baruch Siach wrote:
> > The github repo is more informative than the list Marco's software on
> > the previous link.
> > 
> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> What about switching the upstream to be Github, instead of fetching
> from Debian? The Github repo has all the releases available:
> https://github.com/rfc1036/whois/releases.
> 
> Just make sure that the 5.2.14 tarball we were getting from Debian is
> similar in contents to what we get from the Github repository for the
> same version.

But we generally prefer upstream provided tarballs, aren't we? Moreover, in 
this case the Debian repo provides a smaller .tar.xz, and an upstream computed 
SHA256 in the .dsc file. You don't get that from github.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Arnout Vandecappelle]

On 15-08-17 06:14, Baruch Siach wrote:
> Hi Thomas,
> 
> On Mon, Aug 14, 2017 at 10:03:54PM +0200, Thomas Petazzoni wrote:
>> On Sun, 13 Aug 2017 21:34:18 +0300, Baruch Siach wrote:
>>> The github repo is more informative than the list Marco's software on
>>> the previous link.
>>>
>>> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> What about switching the upstream to be Github, instead of fetching
>> from Debian? The Github repo has all the releases available:
>> https://github.com/rfc1036/whois/releases.
>>
>> Just make sure that the 5.2.14 tarball we were getting from Debian is
>> similar in contents to what we get from the Github repository for the
>> same version.
> But we generally prefer upstream provided tarballs, aren't we? Moreover, in 
> this case the Debian repo provides a smaller .tar.xz, and an upstream computed 
> SHA256 in the .dsc file. You don't get that from github.

 On Sunday, I was going to ask the same question, and came to the same
conclusion about the tar.xz and the sha256. Unfortunately, I don't remember why
I didn't just apply it then and there...

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Thomas Petazzoni]

Hello,

On Tue, 15 Aug 2017 12:10:17 +0200, Arnout Vandecappelle wrote:

> > But we generally prefer upstream provided tarballs, aren't we? Moreover, in 
> > this case the Debian repo provides a smaller .tar.xz, and an upstream computed 
> > SHA256 in the .dsc file. You don't get that from github.  
> 
>  On Sunday, I was going to ask the same question, and came to the same
> conclusion about the tar.xz and the sha256. Unfortunately, I don't remember why
> I didn't just apply it then and there...

I definitely don't agree here. We should use upstream when it exists,
even if it provides things that are less "convenient" than Debian.

Otherwise, we're going to convert a *lot* of packages to use tarballs
from Debian rather than from upstream.

What will happen when we'll want to bump to a new upstream version that
hasn't been packaged by Debian ?

Sorry, but I definitely disagree here. Please use the real upstream.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Baruch Siach]

Hi Thomas,

On Tue, Aug 15, 2017 at 12:56:21PM +0200, Thomas Petazzoni wrote:
> On Tue, 15 Aug 2017 12:10:17 +0200, Arnout Vandecappelle wrote:
> 
> > > But we generally prefer upstream provided tarballs, aren't we? Moreover, in 
> > > this case the Debian repo provides a smaller .tar.xz, and an upstream computed 
> > > SHA256 in the .dsc file. You don't get that from github.  
> > 
> >  On Sunday, I was going to ask the same question, and came to the same
> > conclusion about the tar.xz and the sha256. Unfortunately, I don't remember why
> > I didn't just apply it then and there...
> 
> I definitely don't agree here. We should use upstream when it exists,
> even if it provides things that are less "convenient" than Debian.
> 
> Otherwise, we're going to convert a *lot* of packages to use tarballs
> from Debian rather than from upstream.
> 
> What will happen when we'll want to bump to a new upstream version that
> hasn't been packaged by Debian ?

As things stand now this is quite unlikely. The whois package Debian 
maintainer and the upstream developer are the same person, Marco d'Itri. The 
only upstream in-tree changelog file is at debian/changelog.

> Sorry, but I definitely disagree here. Please use the real upstream.

The real whois upstream README file says this:

  The canonical distribution point for releases of the program is
  http://ftp.debian.org/debian/pool/main/w/whois/ .

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Thomas Petazzoni]

Hello,

On Tue, 15 Aug 2017 14:20:18 +0300, Baruch Siach wrote:

> On Tue, Aug 15, 2017 at 12:56:21PM +0200, Thomas Petazzoni wrote:
> > On Tue, 15 Aug 2017 12:10:17 +0200, Arnout Vandecappelle wrote:
> >   
> > > > But we generally prefer upstream provided tarballs, aren't we? Moreover, in 
> > > > this case the Debian repo provides a smaller .tar.xz, and an upstream computed 
> > > > SHA256 in the .dsc file. You don't get that from github.    
> > > 
> > >  On Sunday, I was going to ask the same question, and came to the same
> > > conclusion about the tar.xz and the sha256. Unfortunately, I don't remember why
> > > I didn't just apply it then and there...  
> > 
> > I definitely don't agree here. We should use upstream when it exists,
> > even if it provides things that are less "convenient" than Debian.
> > 
> > Otherwise, we're going to convert a *lot* of packages to use tarballs
> > from Debian rather than from upstream.
> > 
> > What will happen when we'll want to bump to a new upstream version that
> > hasn't been packaged by Debian ?  
> 
> As things stand now this is quite unlikely. The whois package Debian 
> maintainer and the upstream developer are the same person, Marco d'Itri. The 
> only upstream in-tree changelog file is at debian/changelog.
> 
> > Sorry, but I definitely disagree here. Please use the real upstream.  
> 
> The real whois upstream README file says this:
> 
>   The canonical distribution point for releases of the program is
>   http://ftp.debian.org/debian/pool/main/w/whois/ .

Fair enough. But I still find it completely weird to have the Github
page as the "project home page" indicated in the Config.in file, and
not use that as the upstream.

And Arnout has put PATCH 1/3 back to the New state, while I still
disagree with the approach being taken.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 2/3] whois: use github repo as home page

[Arnout Vandecappelle]

On 15-08-17 14:07, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 15 Aug 2017 14:20:18 +0300, Baruch Siach wrote:
> 
>> On Tue, Aug 15, 2017 at 12:56:21PM +0200, Thomas Petazzoni wrote:
[snip]
>> The real whois upstream README file says this:
>>
>>   The canonical distribution point for releases of the program is
>>   http://ftp.debian.org/debian/pool/main/w/whois/ .
> 
> Fair enough. But I still find it completely weird to have the Github
> page as the "project home page" indicated in the Config.in file, and
> not use that as the upstream.

 It's weird, but it is what it is. Don't we have any other package where the
github repo is the upstream URL, but the release tarball comes from somewhere else?


> And Arnout has put PATCH 1/3 back to the New state, while I still
> disagree with the approach being taken.

 Sorry, I hadn't seen your reply to 1/3, I had also seen your reply to 2/3 and
considered that Baruch and I had given sufficient feedback to warrant going back
to New. With your reply to 1/3, it indeed makes sense to set the entire series
to Changes Requested.

 However, I'm just going to apply patch 3/3 now, since there is no objection to
that one. So only 1/3 and 2/3 will be Changes Requested.


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Baruch Siach]

Fixes serious usability issues (Debian changelog):

  * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv,
    broken by an ICANN-mandated output change:
    https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en

Use snapshot.debian.org for the .dsc reference, since files tend to
disappear from the official Debian ftp site over time.

Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---

This should go to master IMO.
---
 package/whois/whois.hash | 4 ++--
 package/whois/whois.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/whois/whois.hash b/package/whois/whois.hash
index 6f65074c2c48..29623b529f20 100644
--- a/package/whois/whois.hash
+++ b/package/whois/whois.hash
@@ -1,2 +1,2 @@
-# From http://ftp.debian.org/debian/pool/main/w/whois/whois_5.2.14.dsc
-sha256	a41daf41abed0fbfa8c9c4b0e4a3f5f22d9876dd6feb9091aac12f8f4c38b0d2	whois_5.2.14.tar.xz
+# From http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois/whois_5.2.17.dsc
+sha256	257585678f571e18964667b41dc6543fe9da6123ac95743660c9c3ae1eba9664	whois_5.2.17.tar.xz
diff --git a/package/whois/whois.mk b/package/whois/whois.mk
index 87cc65fac4c7..22117cf3aa88 100644
--- a/package/whois/whois.mk
+++ b/package/whois/whois.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-WHOIS_VERSION = 5.2.14
-WHOIS_SITE = http://snapshot.debian.org/archive/debian/20161230T032015Z/pool/main/w/whois
+WHOIS_VERSION = 5.2.17
+WHOIS_SITE = http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois
 WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz
 # take precedence over busybox implementation
 WHOIS_DEPENDENCIES = $(if $(BR2_PACKAGE_BUSYBOX),busybox) $(TARGET_NLS_DEPENDENCIES)
-- 
2.14.1

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Baruch Siach]

Hi Thomas,

On Sun, Aug 13, 2017 at 09:34:19PM +0300, Baruch Siach wrote:
> Fixes serious usability issues (Debian changelog):
> 
>   * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv,
>     broken by an ICANN-mandated output change:
>     https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en
> 
> Use snapshot.debian.org for the .dsc reference, since files tend to
> disappear from the official Debian ftp site over time.
> 
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Why has this patch been marked 'Changes Requested'? It is independent of other 
patches in this series.

baruch

> This should go to master IMO.
> ---
>  package/whois/whois.hash | 4 ++--
>  package/whois/whois.mk   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/whois/whois.hash b/package/whois/whois.hash
> index 6f65074c2c48..29623b529f20 100644
> --- a/package/whois/whois.hash
> +++ b/package/whois/whois.hash
> @@ -1,2 +1,2 @@
> -# From http://ftp.debian.org/debian/pool/main/w/whois/whois_5.2.14.dsc
> -sha256	a41daf41abed0fbfa8c9c4b0e4a3f5f22d9876dd6feb9091aac12f8f4c38b0d2	whois_5.2.14.tar.xz
> +# From http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois/whois_5.2.17.dsc
> +sha256	257585678f571e18964667b41dc6543fe9da6123ac95743660c9c3ae1eba9664	whois_5.2.17.tar.xz
> diff --git a/package/whois/whois.mk b/package/whois/whois.mk
> index 87cc65fac4c7..22117cf3aa88 100644
> --- a/package/whois/whois.mk
> +++ b/package/whois/whois.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -WHOIS_VERSION = 5.2.14
> -WHOIS_SITE = http://snapshot.debian.org/archive/debian/20161230T032015Z/pool/main/w/whois
> +WHOIS_VERSION = 5.2.17
> +WHOIS_SITE = http://snapshot.debian.org/archive/debian/20170727T214450Z/pool/main/w/whois
>  WHOIS_SOURCE = whois_$(WHOIS_VERSION).tar.xz
>  # take precedence over busybox implementation
>  WHOIS_DEPENDENCIES = $(if $(BR2_PACKAGE_BUSYBOX),busybox) $(TARGET_NLS_DEPENDENCIES)

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Thomas Petazzoni]

Hello,

On Tue, 15 Aug 2017 07:18:32 +0300, Baruch Siach wrote:

> On Sun, Aug 13, 2017 at 09:34:19PM +0300, Baruch Siach wrote:
> > Fixes serious usability issues (Debian changelog):
> > 
> >   * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv,
> >     broken by an ICANN-mandated output change:
> >     https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en
> > 
> > Use snapshot.debian.org for the .dsc reference, since files tend to
> > disappear from the official Debian ftp site over time.
> > 
> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>  
> 
> Why has this patch been marked 'Changes Requested'? It is independent of other 
> patches in this series.

Because I always mark all patches in a series as Changes Requested if
at least one of them had comments. Indeed, if it's a patch series, we
expect the submitter to resend a complete new iteration of the series,
even if some patches remain unchanged.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Arnout Vandecappelle]

On 15-08-17 10:40, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 15 Aug 2017 07:18:32 +0300, Baruch Siach wrote:
> 
>> On Sun, Aug 13, 2017 at 09:34:19PM +0300, Baruch Siach wrote:
>>> Fixes serious usability issues (Debian changelog):
>>>
>>>   * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv,
>>>     broken by an ICANN-mandated output change:
>>>     https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en
>>>
>>> Use snapshot.debian.org for the .dsc reference, since files tend to
>>> disappear from the official Debian ftp site over time.
>>>
>>> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
>>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>  
>>
>> Why has this patch been marked 'Changes Requested'? It is independent of other 
>> patches in this series.
> 
> Because I always mark all patches in a series as Changes Requested if
> at least one of them had comments. 

 Moreover, it was exactly this patch which had changes requested (switching
upstream would change this patch completely).

> Indeed, if it's a patch series, we
> expect the submitter to resend a complete new iteration of the series,
> even if some patches remain unchanged.

 But in this case, there are in fact no changes requested in the series (or
rather, the request has been refuted). So I've changed the status back to New.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Thomas Petazzoni]

Hello,

On Tue, 15 Aug 2017 12:12:01 +0200, Arnout Vandecappelle wrote:

> > Indeed, if it's a patch series, we
> > expect the submitter to resend a complete new iteration of the series,
> > even if some patches remain unchanged.  
> 
>  But in this case, there are in fact no changes requested in the series (or
> rather, the request has been refuted). So I've changed the status back to New.

Doh? Why? My comments still stand. It's not because Baruch said Debian
is a better upstream than the real upstream that I agree with his
comments.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Arnout Vandecappelle]

On 13-08-17 20:34, Baruch Siach wrote:
> Fixes serious usability issues (Debian changelog):
> 
>   * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv,
>     broken by an ICANN-mandated output change:
>     https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en
> 
> Use snapshot.debian.org for the .dsc reference, since files tend to
> disappear from the official Debian ftp site over time.
> 
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

 As mentioned before, applied to master, thanks.

 I first checked the differences between 5.2.14 and 5.2.17, and it really is
only in the whois databases (and in documentation) that there are changes.
Source code hasn't changed.

 Peter, this should probably go to the LTS branches as well.

 Regards,
 Arnout

> ---
> 
> This should go to master IMO.

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 3/3] whois: bump to version 5.2.17

[Peter Korsgaard]

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Fixes serious usability issues (Debian changelog):
 >   * Fixed whois referrals for .com, .net, .jobs, .bz, .cc and .tv,
 >     broken by an ICANN-mandated output change:
 >     https://www.icann.org/resources/pages/rdds-labeling-policy-2017-02-01-en

 > Use snapshot.debian.org for the .dsc reference, since files tend to
 > disappear from the official Debian ftp site over time.

 > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
 > ---

 > This should go to master IMO.

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/3] whois: fix build with NLS disabled

[Thomas Petazzoni]

Hello,

On Sun, 13 Aug 2017 21:34:17 +0300, Baruch Siach wrote:
> whois build uses the xgettext utility to build translation files.
> This utility may not be available when NLS is disabled. Omit the pos and
> install-pos Makefile targets from the default and the install targets
> when NLS is disabled, respectively.
> 
> Fixes:
> http://autobuild.buildroot.net/results/862/862d8165a59711c970c65d90009a527315a1a6b4/
> http://autobuild.buildroot.net/results/b62/b62ec9d6f350e409731d47ffb585344c516944e8/
> http://autobuild.buildroot.net/results/be2/be28d06ae004a46c87133d6f07709c6f909288d8/
> 
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Since there is an active upstream at https://github.com/rfc1036/whois,
what about doing something upstreamable, such as introducing an
HAVE_NLS variable, which the Makefile uses to determine if PO files
should be built or not?

The Makefile already supports HAVE_LIBIDN, HAVE_ICONV, HAVE_XCRYPT,
etc. so introducing HAVE_NLS should fit quite well into this, and it
really is a simple patch to do.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 1/3] whois: fix build with NLS disabled

[Thomas Petazzoni]

Hello,

On Sun, 13 Aug 2017 21:34:17 +0300, Baruch Siach wrote:
> whois build uses the xgettext utility to build translation files.
> This utility may not be available when NLS is disabled. Omit the pos and
> install-pos Makefile targets from the default and the install targets
> when NLS is disabled, respectively.
> 
> Fixes:
> http://autobuild.buildroot.net/results/862/862d8165a59711c970c65d90009a527315a1a6b4/
> http://autobuild.buildroot.net/results/b62/b62ec9d6f350e409731d47ffb585344c516944e8/
> http://autobuild.buildroot.net/results/be2/be28d06ae004a46c87133d6f07709c6f909288d8/
> 
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/whois/whois.mk | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)

Applied to master, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com