Re: [Buildroot] [PATCH 02/17] board/beagleboard: use partition-type-uuid "L"

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brandon Maier <brandon.maier@gmail.com>
Cc: buildroot@buildroot.org, Niklas Cassel <cassel@kernel.org>
Subject: Re: [Buildroot] [PATCH 02/17] board/beagleboard: use partition-type-uuid "L"
Date: Mon, 11 Nov 2024 21:57:48 +0100	[thread overview]
Message-ID: <20241111215748.4ee4e4e5@windsurf> (raw)
In-Reply-To: <20241109-genimage-partition-type-uuid-v1-2-9f23180c7195@gmail.com>

On Sat, 09 Nov 2024 16:16:16 -0600
Brandon Maier <brandon.maier@gmail.com> wrote:

> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  board/beagleboard/beaglev_fire/genimage.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/beagleboard/beaglev_fire/genimage.cfg b/board/beagleboard/beaglev_fire/genimage.cfg
> index ef650704c65f24eea37fb1fa8d53b5759062d570..0241480ad6041883a799ed68c6f080d8a3b29cae 100644
> --- a/board/beagleboard/beaglev_fire/genimage.cfg
> +++ b/board/beagleboard/beaglev_fire/genimage.cfg
> @@ -24,7 +24,7 @@ image sdcard.img {
>  	}
>  
>  	partition kernel {
> -		partition-type-uuid = 0FC63DAF-8483-4772-8E79-3D69D8477DE4
> +		partition-type-uuid = L
>  		bootable = "true"
>  		image = "boot.vfat"

Considering it's FAT partition, and not the root filesystem, this
change doesn't really match your documentation update in PATCH 01/17,
where you state:

+** +F+ for a FAT partition (expanded to +ebd0a0a2-b9e5-4433-87c0-68b6b72699c7+
+   by _genimage_)
+
+** +L+ for the root filesystem or other filesystems (expanded to
+   +0fc63daf-8483-4772-8e79-3d69d8477de4+ by _genimage_).

So I would rather be expecting F here, and not L.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot