Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

["Brandon Maier" <brandon.maier@gmail.com>]

On Mon Nov 11, 2024 at 3:12 PM CST, Thomas Petazzoni wrote:
> Hello Brandon,
>
> On Sat, 09 Nov 2024 16:16:14 -0600
> Brandon Maier <brandon.maier@gmail.com> wrote:
>
> > Buildroot boards using genimage's "partition-type-uuid" can use either a
> > full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> > manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> > but does not specify how any other GUID should be defined.
> >
> > This series tries to bring consistency to partition-type-uuid by making
> > shortcuts the preferred method. First we update the Buildroot manual to
> > say shortcuts should be preferred when available. Then we update all
> > boards to use shortcuts.
> >
> > This series is partially implementing Thomas suggestion to have
> > consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].
>
> Thanks for working on this! However, I'm slightly confused as to what
> the goal of this series is in the overall process of making things more
> consistent.
>
> With your series enabled, some root filesystems still use L, some use
> root-*, which isn't very consistent. Is your series "only" about
> replacing full GUID by shortcuts, for the moment?

You are correct, this was my goal. I wanted to go from where we are
today which is a mix of "L", "root-$ARCH", and "full GUID (both L and
root-$ARCH)", to just "L" and "root-$ARCH".

This is an easy first step to implement and review, and makes the future
transition from L -> root-$ARCH easier.

>
> I'm fine with going this way, but then the PATCH 01/17 should be
> accurate about what's recommended nowadays. Because saying in the doc
> we want L for the rootfs, but many genimage.cfg use root-* isn't really
> great.

Agreed, I was trying to avoid saying "prefer L" or "prefer root-$ARCH"
in that commit, as I did not have a strong understanding of which would
be preferable. However based on yours and Niklas feedback I didn't
communicate that clearly.

Based on feedback, it sounds like we would prefer to migrate to
root-$ARCH, so I will reword the docs accordingly. I would still prefer
to defer updating L -> root-$ARCH for a second patch series however, we
will likely need to split that into many patch series per-board, so the
developers for each board have a chance to test them.

Thank you!
Brandon

>
> Thanks!
>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot