Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brandon Maier <brandon.maier@gmail.com>
Cc: buildroot@buildroot.org, Niklas Cassel <cassel@kernel.org>
Subject: Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts
Date: Mon, 11 Nov 2024 22:12:28 +0100	[thread overview]
Message-ID: <20241111221228.211b7a61@windsurf> (raw)
In-Reply-To: <20241109-genimage-partition-type-uuid-v1-0-9f23180c7195@gmail.com>

Hello Brandon,

On Sat, 09 Nov 2024 16:16:14 -0600
Brandon Maier <brandon.maier@gmail.com> wrote:

> Buildroot boards using genimage's "partition-type-uuid" can use either a
> full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> but does not specify how any other GUID should be defined.
> 
> This series tries to bring consistency to partition-type-uuid by making
> shortcuts the preferred method. First we update the Buildroot manual to
> say shortcuts should be preferred when available. Then we update all
> boards to use shortcuts.
> 
> This series is partially implementing Thomas suggestion to have
> consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].

Thanks for working on this! However, I'm slightly confused as to what
the goal of this series is in the overall process of making things more
consistent.

With your series enabled, some root filesystems still use L, some use
root-*, which isn't very consistent. Is your series "only" about
replacing full GUID by shortcuts, for the moment?

I'm fine with going this way, but then the PATCH 01/17 should be
accurate about what's recommended nowadays. Because saying in the doc
we want L for the rootfs, but many genimage.cfg use root-* isn't really
great.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-11-11 21:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09 22:16 [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid Brandon Maier
2024-11-11 13:11   ` Niklas Cassel via buildroot
2024-11-11 14:26     ` Brandon Maier
2024-11-11 14:31       ` Niklas Cassel via buildroot
2024-11-11 21:00         ` Thomas Petazzoni via buildroot
2024-11-12 14:29           ` Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 02/17] board/beagleboard: use partition-type-uuid "L" Brandon Maier
2024-11-11 20:57   ` Thomas Petazzoni via buildroot
2024-11-09 22:16 ` [Buildroot] [PATCH 03/17] board/sifive: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 04/17] board/visionfive2: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 05/17] board/pc: use partition-type-uuid "root-x86" Brandon Maier
2024-11-11 21:02   ` Thomas Petazzoni via buildroot
2024-11-12 14:02     ` Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 06/17] support/testing/tests/boot/test_grub: " Brandon Maier
2024-11-11 13:16   ` Niklas Cassel via buildroot
2024-11-11 14:30     ` Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 07/17] board/mender: use partition-type-uuid "root-x86-64" Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 08/17] board/radxa: use partition-type-uuid "root-arm" Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 09/17] board/qemu/arm-ebbr: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 10/17] board/qemu/riscv64-virt-efi: use partition-type-uuid "root-riscv64" Brandon Maier
2024-11-11 13:22   ` Niklas Cassel via buildroot
2024-11-11 14:31     ` Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 11/17] board/aarch64-efi: use partition-type-uuid "root-arm64" Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 12/17] board/arm: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 13/17] board/pine64: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 14/17] board/qemu/aarch64-ebbr: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 15/17] board/qemu/aarch64-sbsa: " Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 16/17] board/visionfive2: use partition-type-uuid "xbootldr" Brandon Maier
2024-11-09 22:16 ` [Buildroot] [PATCH 17/17] support/testing/tests/boot/test_grub: use partition-type-uuid "U" Brandon Maier
2024-11-11 13:34 ` [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts Niklas Cassel via buildroot
2024-11-11 14:37   ` Brandon Maier
2024-11-11 21:12 ` Thomas Petazzoni via buildroot [this message]
2024-11-12 14:25   ` Brandon Maier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241111221228.211b7a61@windsurf \
    --to=buildroot@buildroot.org \
    --cc=brandon.maier@gmail.com \
    --cc=cassel@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox