Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Sat, Nov 09, 2024 at 04:16:14PM -0600, Brandon Maier wrote:
> Buildroot boards using genimage's "partition-type-uuid" can use either a
> full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> but does not specify how any other GUID should be defined.
> 
> This series tries to bring consistency to partition-type-uuid by making
> shortcuts the preferred method. First we update the Buildroot manual to
> say shortcuts should be preferred when available. Then we update all
> boards to use shortcuts.
> 
> This series is partially implementing Thomas suggestion to have
> consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].
> 
> [1] https://github.com/pengutronix/genimage/blob/master/image-hd.c#L264
> [2] https://lore.kernel.org/buildroot/20241022224945.4dc67b89@windsurf/

Other than some minor comments, the series looks good to me.
Good job!


You seem to have missed one conversion though:
board/radxa/rock5b/genimage.cfg:

partition-type-uuid = 3de21764-95bd-54bd-a5c3-4abe786f38a8

can use shortcut:
partition-type-uuid = u-boot-env


But now when I look at it, it was you who added this to genimage just a
week ago:
https://github.com/pengutronix/genimage/commit/3e0a2aea8d10431f8c8f652129f73544cfa16af2

So we might need to bump genimage in buildroot before we can make use of
that shortcut. (And for that we probably want to wait for a new tagged
release of genimage.)


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot