Re: [Buildroot] [PATCH 05/17] board/pc: use partition-type-uuid "root-x86"

From: "Brandon Maier" <brandon.maier@gmail.com>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: <buildroot@buildroot.org>, "Niklas Cassel" <cassel@kernel.org>
Subject: Re: [Buildroot] [PATCH 05/17] board/pc: use partition-type-uuid "root-x86"
Date: Tue, 12 Nov 2024 08:02:09 -0600	[thread overview]
Message-ID: <D5K97MPVS6P8.12VCXY5DPY570@gmail.com> (raw)
In-Reply-To: <20241111220247.321caa3b@windsurf>

Hi Thomas,

On Mon Nov 11, 2024 at 3:02 PM CST, Thomas Petazzoni wrote:
> On Sat, 09 Nov 2024 16:16:19 -0600
> Brandon Maier <brandon.maier@gmail.com> wrote:
>
> > Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> > ---
> >  board/pc/genimage-efi.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/board/pc/genimage-efi.cfg b/board/pc/genimage-efi.cfg
> > index c231e1b9b2626c5a788c85511b1f1e9d12759d33..7d3d69bd067c2c39f5188d82d2e1fd11088657e1 100644
> > --- a/board/pc/genimage-efi.cfg
> > +++ b/board/pc/genimage-efi.cfg
> > @@ -25,7 +25,7 @@ image disk.img {
> >  	}
> >  
> >  	partition root {
> > -		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
> > +		partition-type-uuid = root-x86
>
> I don't understand how this lines up with the policy you have updated
> in PATCH 01/17.

My intention for this series wasn't for the policy to be "prefer using
L" or "prefer using root-$ARCH". It was to be "prefer using shortcuts
over the full GUID", with the intent of having a second patch series
that would convert L to root-$ARCH.

Niklas also thought my changes to the docs meant "prefer using L", so I
am not communicating clearly, my apologies. I will try to make the
intent clearer in v2.

Thank you,
Brandon

>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot