Re: [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Mon, Nov 11, 2024 at 08:26:39AM -0600, Brandon Maier wrote:
> Hi Niklas
> 
> On Mon, Nov 11, 2024 at 7:11 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
> >
> > Like you wrote in the cover letter, this series is only partially
> > implementing Thomas' suggestion, which was:
> > "My point is that we want *consistency*. So either we use "L" for all
> > rootfs partitions. Or we use root-${ARCH} for all rootfs partitions."
> >
> >
> > While this series is just converting GUIDs to use a shortcut, if there is
> > one available, I still think that we can update the documentation to be
> > even stricter, something like:
> >
> > "For the rootfs partition, the partition type GUID should be set to the
> > architecture-specific shortcut (e.g. root-arm64), rather than the generic
> > +L+ shortcut (generic Linux rootfs). An explicit partition type GUID should
> > always be specified for the rootfs partition."
> 
> I left it out of this series as I haven't looked too closely into
> which of "L" or "root-*" is better. It doesn't seem like a simple
> choice, as U-Boot has a lot of board-specific settings.
> 
> Do you and Thomas feel confident that root-$ARCH should be the preferred type?

For new boards being added to buildroot, definitely.


Both me and Thomas tried to grep in the u-boot source code, and couldn't
find anything other than fastboot stuff that was making use of the
generic Linux rootfs partition type GUID, so it *should* be safe to change
for all buildroot boards making use of u-boot.

I didn't grep in the edk2 source code.


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot