* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 6:30 [Buildroot] [pull request] Pull request for branch gcc-remove-options Thomas Petazzoni
@ 2010-07-29 6:30 ` Thomas Petazzoni
2010-07-29 10:38 ` Michael S. Zick
2010-07-29 6:30 ` [Buildroot] [PATCH 2/2] toolchain: remove multilib Thomas Petazzoni
2010-07-29 6:53 ` [Buildroot] [pull request] Pull request for branch gcc-remove-options Peter Korsgaard
2 siblings, 1 reply; 17+ messages in thread
From: Thomas Petazzoni @ 2010-07-29 6:30 UTC (permalink / raw)
To: buildroot
This is a very advanced option, and it seems, according to
http://choices.cs.uiuc.edu/exceptions.pdf that SJLJ exceptions aren't
really interesting.
Users really interested by this can always use the
BR2_EXTRA_GCC_CONFIG_OPTIONS is they want.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
configs/arm_toolchain_defconfig | 1 -
configs/at91rm9200df_defconfig | 1 -
configs/at91sam9260dfc_defconfig | 1 -
configs/at91sam9260pf_defconfig | 1 -
configs/at91sam9261ek_defconfig | 1 -
configs/at91sam9263ek_defconfig | 1 -
configs/at91sam9g20dfc_defconfig | 1 -
configs/atngw100-base_defconfig | 1 -
configs/atngw100_defconfig | 1 -
configs/atstk1005_defconfig | 1 -
configs/atstk100x_defconfig | 1 -
configs/i386_defconfig | 1 -
configs/i686_defconfig | 1 -
configs/integrator926_defconfig | 1 -
configs/integrator926_huge_defconfig | 1 -
configs/kb9202_defconfig | 1 -
configs/v100sc2_defconfig | 1 -
toolchain/gcc/Config.in | 8 --------
toolchain/gcc/Makefile.in | 4 ----
toolchain/gcc/gcc-uclibc-4.x.mk | 2 --
20 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/configs/arm_toolchain_defconfig b/configs/arm_toolchain_defconfig
index 3062541..2ac7de3 100644
--- a/configs/arm_toolchain_defconfig
+++ b/configs/arm_toolchain_defconfig
@@ -245,7 +245,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_FORTRAN is not set
# BR2_INSTALL_LIBGCJ is not set
diff --git a/configs/at91rm9200df_defconfig b/configs/at91rm9200df_defconfig
index 98158b9..2a193cf 100644
--- a/configs/at91rm9200df_defconfig
+++ b/configs/at91rm9200df_defconfig
@@ -250,7 +250,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_FORTRAN is not set
# BR2_INSTALL_LIBGCJ is not set
diff --git a/configs/at91sam9260dfc_defconfig b/configs/at91sam9260dfc_defconfig
index f1d63df..98d3401 100644
--- a/configs/at91sam9260dfc_defconfig
+++ b/configs/at91sam9260dfc_defconfig
@@ -267,7 +267,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_CROSS_CXX=y
# BR2_GCC_CROSS_FORTRAN is not set
diff --git a/configs/at91sam9260pf_defconfig b/configs/at91sam9260pf_defconfig
index 651041f..ec4005d 100644
--- a/configs/at91sam9260pf_defconfig
+++ b/configs/at91sam9260pf_defconfig
@@ -173,7 +173,6 @@ BR2_GCC_VERSION_4_2_1=y
# BR2_GCC_IS_SNAP is not set
BR2_GCC_VERSION="4.2.1"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_CROSS_CXX=y
# BR2_GCC_CROSS_FORTRAN is not set
diff --git a/configs/at91sam9261ek_defconfig b/configs/at91sam9261ek_defconfig
index 0d2fa0b..7524c68 100644
--- a/configs/at91sam9261ek_defconfig
+++ b/configs/at91sam9261ek_defconfig
@@ -270,7 +270,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_CROSS_CXX=y
# BR2_GCC_CROSS_FORTRAN is not set
diff --git a/configs/at91sam9263ek_defconfig b/configs/at91sam9263ek_defconfig
index 6b4f592..85ccede 100644
--- a/configs/at91sam9263ek_defconfig
+++ b/configs/at91sam9263ek_defconfig
@@ -264,7 +264,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_FORTRAN is not set
# BR2_INSTALL_LIBGCJ is not set
diff --git a/configs/at91sam9g20dfc_defconfig b/configs/at91sam9g20dfc_defconfig
index 92171d5..57d72ae 100644
--- a/configs/at91sam9g20dfc_defconfig
+++ b/configs/at91sam9g20dfc_defconfig
@@ -264,7 +264,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_FORTRAN is not set
# BR2_INSTALL_LIBGCJ is not set
diff --git a/configs/atngw100-base_defconfig b/configs/atngw100-base_defconfig
index f5eba61..270c056 100644
--- a/configs/atngw100-base_defconfig
+++ b/configs/atngw100-base_defconfig
@@ -196,7 +196,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
# BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
# BR2_TOOLCHAIN_SYSROOT is not set
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_SHARED_LIBGCC is not set
diff --git a/configs/atngw100_defconfig b/configs/atngw100_defconfig
index d1db2da..a78372d 100644
--- a/configs/atngw100_defconfig
+++ b/configs/atngw100_defconfig
@@ -174,7 +174,6 @@ BR2_GCC_VERSION_4_2_2_AVR32_2_1_5=y
BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_SHARED_LIBGCC=y
BR2_GCC_ENABLE_TLS=y
diff --git a/configs/atstk1005_defconfig b/configs/atstk1005_defconfig
index b90761b..451e248 100644
--- a/configs/atstk1005_defconfig
+++ b/configs/atstk1005_defconfig
@@ -200,7 +200,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
# BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_SHARED_LIBGCC=y
diff --git a/configs/atstk100x_defconfig b/configs/atstk100x_defconfig
index c12ccf8..e39e608 100644
--- a/configs/atstk100x_defconfig
+++ b/configs/atstk100x_defconfig
@@ -195,7 +195,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
# BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_SHARED_LIBGCC=y
diff --git a/configs/i386_defconfig b/configs/i386_defconfig
index 65825be..026e206 100644
--- a/configs/i386_defconfig
+++ b/configs/i386_defconfig
@@ -195,7 +195,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.4.0"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_FORTRAN is not set
# BR2_INSTALL_LIBGCJ is not set
diff --git a/configs/i686_defconfig b/configs/i686_defconfig
index 31ce604..884ec7d 100644
--- a/configs/i686_defconfig
+++ b/configs/i686_defconfig
@@ -195,7 +195,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.4.0"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_FORTRAN is not set
# BR2_INSTALL_LIBGCJ is not set
diff --git a/configs/integrator926_defconfig b/configs/integrator926_defconfig
index 2eb22c5..4ec53f9 100644
--- a/configs/integrator926_defconfig
+++ b/configs/integrator926_defconfig
@@ -199,7 +199,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
# BR2_GCC_CROSS_CXX is not set
# BR2_GCC_CROSS_FORTRAN is not set
diff --git a/configs/integrator926_huge_defconfig b/configs/integrator926_huge_defconfig
index e44ac5f..b5c34df 100644
--- a/configs/integrator926_huge_defconfig
+++ b/configs/integrator926_huge_defconfig
@@ -199,7 +199,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
BR2_GCC_VERSION="4.3.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_CROSS_CXX=y
# BR2_GCC_CROSS_FORTRAN is not set
diff --git a/configs/kb9202_defconfig b/configs/kb9202_defconfig
index 40c6d18..1d0aa61 100644
--- a/configs/kb9202_defconfig
+++ b/configs/kb9202_defconfig
@@ -201,7 +201,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
# BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
BR2_GCC_VERSION="4.2.4"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_CROSS_CXX=y
# BR2_GCC_CROSS_FORTRAN is not set
diff --git a/configs/v100sc2_defconfig b/configs/v100sc2_defconfig
index ca261ee..5ba2899 100644
--- a/configs/v100sc2_defconfig
+++ b/configs/v100sc2_defconfig
@@ -170,7 +170,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
# BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
BR2_GCC_VERSION="4.2.2"
BR2_TOOLCHAIN_SYSROOT=y
-# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
BR2_EXTRA_GCC_CONFIG_OPTIONS=""
BR2_GCC_CROSS_CXX=y
BR2_INSTALL_LIBSTDCPP=y
diff --git a/toolchain/gcc/Config.in b/toolchain/gcc/Config.in
index 31eba6b..cbdc026 100644
--- a/toolchain/gcc/Config.in
+++ b/toolchain/gcc/Config.in
@@ -68,14 +68,6 @@ config BR2_GCC_VERSION
default "4.4.4" if BR2_GCC_VERSION_4_4_X
default $BR2_GCC_SNAP_DATE if BR2_GCC_VERSION_SNAP
-config BR2_GCC_USE_SJLJ_EXCEPTIONS
- bool "Enable setjmp/longjmp exceptions?"
- help
- For some platforms, proper stack unwinding works perfectly,
- while other platforms must use setjmp/longjmp exceptions for
- proper stack unwinding during exception handling. Most people
- can leave this set to n.
-
config BR2_EXTRA_GCC_CONFIG_OPTIONS
string "Additional gcc options"
default ""
diff --git a/toolchain/gcc/Makefile.in b/toolchain/gcc/Makefile.in
index 9537e9d..b6ebca9 100644
--- a/toolchain/gcc/Makefile.in
+++ b/toolchain/gcc/Makefile.in
@@ -13,10 +13,6 @@ else
GCC_SNAP_DATE:=
endif
-ifeq ($(BR2_GCC_USE_SJLJ_EXCEPTIONS),y)
-GCC_USE_SJLJ_EXCEPTIONS:=--enable-sjlj-exceptions
-endif
-
ifeq ($(BR2_SOFT_FLOAT),y)
SOFT_FLOAT_CONFIG_OPTION:=--with-float=soft
ifeq ($(BR2_arm)$(BR2_armeb),y) # only set float-abi for arm
diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
index dfc1790..d9269bd 100644
--- a/toolchain/gcc/gcc-uclibc-4.x.mk
+++ b/toolchain/gcc/gcc-uclibc-4.x.mk
@@ -290,7 +290,6 @@ $(GCC_BUILD_DIR2)/.configured: $(GCC_SRC_DIR)/.patched $(GCC_STAGING_PREREQ)
$(GCC_DECIMAL_FLOAT) \
$(SOFT_FLOAT_CONFIG_OPTION) \
$(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
- $(GCC_USE_SJLJ_EXCEPTIONS) \
$(DISABLE_LARGEFILE) \
$(EXTRA_GCC_CONFIG_OPTIONS) \
$(EXTRA_GCC2_CONFIG_OPTIONS) \
@@ -424,7 +423,6 @@ $(GCC_BUILD_DIR3)/.configured: $(GCC_BUILD_DIR3)/.prepared
$(GCC_DECIMAL_FLOAT) \
$(SOFT_FLOAT_CONFIG_OPTION) \
$(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
- $(GCC_USE_SJLJ_EXCEPTIONS) \
$(DISABLE_LARGEFILE) \
$(EXTRA_GCC_CONFIG_OPTIONS) \
$(EXTRA_TARGET_GCC_CONFIG_OPTIONS) \
--
1.7.0.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 6:30 ` [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions Thomas Petazzoni
@ 2010-07-29 10:38 ` Michael S. Zick
2010-07-29 11:38 ` Thomas Petazzoni
0 siblings, 1 reply; 17+ messages in thread
From: Michael S. Zick @ 2010-07-29 10:38 UTC (permalink / raw)
To: buildroot
On Thu July 29 2010, Thomas Petazzoni wrote:
> This is a very advanced option, and it seems, according to
> http://choices.cs.uiuc.edu/exceptions.pdf that SJLJ exceptions aren't
> really interesting.
>
And of course you confirmed that the Lua package's
error handling still works properly, complete with
same backtrace that is produced when SJLJ exceptions are enabled.
You did make that test didn't you?
Mike
> Users really interested by this can always use the
> BR2_EXTRA_GCC_CONFIG_OPTIONS is they want.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> configs/arm_toolchain_defconfig | 1 -
> configs/at91rm9200df_defconfig | 1 -
> configs/at91sam9260dfc_defconfig | 1 -
> configs/at91sam9260pf_defconfig | 1 -
> configs/at91sam9261ek_defconfig | 1 -
> configs/at91sam9263ek_defconfig | 1 -
> configs/at91sam9g20dfc_defconfig | 1 -
> configs/atngw100-base_defconfig | 1 -
> configs/atngw100_defconfig | 1 -
> configs/atstk1005_defconfig | 1 -
> configs/atstk100x_defconfig | 1 -
> configs/i386_defconfig | 1 -
> configs/i686_defconfig | 1 -
> configs/integrator926_defconfig | 1 -
> configs/integrator926_huge_defconfig | 1 -
> configs/kb9202_defconfig | 1 -
> configs/v100sc2_defconfig | 1 -
> toolchain/gcc/Config.in | 8 --------
> toolchain/gcc/Makefile.in | 4 ----
> toolchain/gcc/gcc-uclibc-4.x.mk | 2 --
> 20 files changed, 0 insertions(+), 31 deletions(-)
>
> diff --git a/configs/arm_toolchain_defconfig b/configs/arm_toolchain_defconfig
> index 3062541..2ac7de3 100644
> --- a/configs/arm_toolchain_defconfig
> +++ b/configs/arm_toolchain_defconfig
> @@ -245,7 +245,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_FORTRAN is not set
> # BR2_INSTALL_LIBGCJ is not set
> diff --git a/configs/at91rm9200df_defconfig b/configs/at91rm9200df_defconfig
> index 98158b9..2a193cf 100644
> --- a/configs/at91rm9200df_defconfig
> +++ b/configs/at91rm9200df_defconfig
> @@ -250,7 +250,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_FORTRAN is not set
> # BR2_INSTALL_LIBGCJ is not set
> diff --git a/configs/at91sam9260dfc_defconfig b/configs/at91sam9260dfc_defconfig
> index f1d63df..98d3401 100644
> --- a/configs/at91sam9260dfc_defconfig
> +++ b/configs/at91sam9260dfc_defconfig
> @@ -267,7 +267,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_CROSS_CXX=y
> # BR2_GCC_CROSS_FORTRAN is not set
> diff --git a/configs/at91sam9260pf_defconfig b/configs/at91sam9260pf_defconfig
> index 651041f..ec4005d 100644
> --- a/configs/at91sam9260pf_defconfig
> +++ b/configs/at91sam9260pf_defconfig
> @@ -173,7 +173,6 @@ BR2_GCC_VERSION_4_2_1=y
> # BR2_GCC_IS_SNAP is not set
> BR2_GCC_VERSION="4.2.1"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_CROSS_CXX=y
> # BR2_GCC_CROSS_FORTRAN is not set
> diff --git a/configs/at91sam9261ek_defconfig b/configs/at91sam9261ek_defconfig
> index 0d2fa0b..7524c68 100644
> --- a/configs/at91sam9261ek_defconfig
> +++ b/configs/at91sam9261ek_defconfig
> @@ -270,7 +270,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_CROSS_CXX=y
> # BR2_GCC_CROSS_FORTRAN is not set
> diff --git a/configs/at91sam9263ek_defconfig b/configs/at91sam9263ek_defconfig
> index 6b4f592..85ccede 100644
> --- a/configs/at91sam9263ek_defconfig
> +++ b/configs/at91sam9263ek_defconfig
> @@ -264,7 +264,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_FORTRAN is not set
> # BR2_INSTALL_LIBGCJ is not set
> diff --git a/configs/at91sam9g20dfc_defconfig b/configs/at91sam9g20dfc_defconfig
> index 92171d5..57d72ae 100644
> --- a/configs/at91sam9g20dfc_defconfig
> +++ b/configs/at91sam9g20dfc_defconfig
> @@ -264,7 +264,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_FORTRAN is not set
> # BR2_INSTALL_LIBGCJ is not set
> diff --git a/configs/atngw100-base_defconfig b/configs/atngw100-base_defconfig
> index f5eba61..270c056 100644
> --- a/configs/atngw100-base_defconfig
> +++ b/configs/atngw100-base_defconfig
> @@ -196,7 +196,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> # BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
> BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
> # BR2_TOOLCHAIN_SYSROOT is not set
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_SHARED_LIBGCC is not set
>
> diff --git a/configs/atngw100_defconfig b/configs/atngw100_defconfig
> index d1db2da..a78372d 100644
> --- a/configs/atngw100_defconfig
> +++ b/configs/atngw100_defconfig
> @@ -174,7 +174,6 @@ BR2_GCC_VERSION_4_2_2_AVR32_2_1_5=y
> BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_SHARED_LIBGCC=y
> BR2_GCC_ENABLE_TLS=y
> diff --git a/configs/atstk1005_defconfig b/configs/atstk1005_defconfig
> index b90761b..451e248 100644
> --- a/configs/atstk1005_defconfig
> +++ b/configs/atstk1005_defconfig
> @@ -200,7 +200,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> # BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
> BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_SHARED_LIBGCC=y
>
> diff --git a/configs/atstk100x_defconfig b/configs/atstk100x_defconfig
> index c12ccf8..e39e608 100644
> --- a/configs/atstk100x_defconfig
> +++ b/configs/atstk100x_defconfig
> @@ -195,7 +195,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> # BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
> BR2_GCC_VERSION="4.2.2-avr32-2.1.5"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_SHARED_LIBGCC=y
>
> diff --git a/configs/i386_defconfig b/configs/i386_defconfig
> index 65825be..026e206 100644
> --- a/configs/i386_defconfig
> +++ b/configs/i386_defconfig
> @@ -195,7 +195,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.4.0"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_FORTRAN is not set
> # BR2_INSTALL_LIBGCJ is not set
> diff --git a/configs/i686_defconfig b/configs/i686_defconfig
> index 31ce604..884ec7d 100644
> --- a/configs/i686_defconfig
> +++ b/configs/i686_defconfig
> @@ -195,7 +195,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.4.0"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_FORTRAN is not set
> # BR2_INSTALL_LIBGCJ is not set
> diff --git a/configs/integrator926_defconfig b/configs/integrator926_defconfig
> index 2eb22c5..4ec53f9 100644
> --- a/configs/integrator926_defconfig
> +++ b/configs/integrator926_defconfig
> @@ -199,7 +199,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> # BR2_GCC_CROSS_CXX is not set
> # BR2_GCC_CROSS_FORTRAN is not set
> diff --git a/configs/integrator926_huge_defconfig b/configs/integrator926_huge_defconfig
> index e44ac5f..b5c34df 100644
> --- a/configs/integrator926_huge_defconfig
> +++ b/configs/integrator926_huge_defconfig
> @@ -199,7 +199,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE=y
> BR2_GCC_VERSION="4.3.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_CROSS_CXX=y
> # BR2_GCC_CROSS_FORTRAN is not set
> diff --git a/configs/kb9202_defconfig b/configs/kb9202_defconfig
> index 40c6d18..1d0aa61 100644
> --- a/configs/kb9202_defconfig
> +++ b/configs/kb9202_defconfig
> @@ -201,7 +201,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> # BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
> BR2_GCC_VERSION="4.2.4"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_CROSS_CXX=y
> # BR2_GCC_CROSS_FORTRAN is not set
> diff --git a/configs/v100sc2_defconfig b/configs/v100sc2_defconfig
> index ca261ee..5ba2899 100644
> --- a/configs/v100sc2_defconfig
> +++ b/configs/v100sc2_defconfig
> @@ -170,7 +170,6 @@ BR2_GCC_SUPPORTS_SYSROOT=y
> # BR2_GCC_SUPPORTS_FINEGRAINEDMTUNE is not set
> BR2_GCC_VERSION="4.2.2"
> BR2_TOOLCHAIN_SYSROOT=y
> -# BR2_GCC_USE_SJLJ_EXCEPTIONS is not set
> BR2_EXTRA_GCC_CONFIG_OPTIONS=""
> BR2_GCC_CROSS_CXX=y
> BR2_INSTALL_LIBSTDCPP=y
> diff --git a/toolchain/gcc/Config.in b/toolchain/gcc/Config.in
> index 31eba6b..cbdc026 100644
> --- a/toolchain/gcc/Config.in
> +++ b/toolchain/gcc/Config.in
> @@ -68,14 +68,6 @@ config BR2_GCC_VERSION
> default "4.4.4" if BR2_GCC_VERSION_4_4_X
> default $BR2_GCC_SNAP_DATE if BR2_GCC_VERSION_SNAP
>
> -config BR2_GCC_USE_SJLJ_EXCEPTIONS
> - bool "Enable setjmp/longjmp exceptions?"
> - help
> - For some platforms, proper stack unwinding works perfectly,
> - while other platforms must use setjmp/longjmp exceptions for
> - proper stack unwinding during exception handling. Most people
> - can leave this set to n.
> -
> config BR2_EXTRA_GCC_CONFIG_OPTIONS
> string "Additional gcc options"
> default ""
> diff --git a/toolchain/gcc/Makefile.in b/toolchain/gcc/Makefile.in
> index 9537e9d..b6ebca9 100644
> --- a/toolchain/gcc/Makefile.in
> +++ b/toolchain/gcc/Makefile.in
> @@ -13,10 +13,6 @@ else
> GCC_SNAP_DATE:=
> endif
>
> -ifeq ($(BR2_GCC_USE_SJLJ_EXCEPTIONS),y)
> -GCC_USE_SJLJ_EXCEPTIONS:=--enable-sjlj-exceptions
> -endif
> -
> ifeq ($(BR2_SOFT_FLOAT),y)
> SOFT_FLOAT_CONFIG_OPTION:=--with-float=soft
> ifeq ($(BR2_arm)$(BR2_armeb),y) # only set float-abi for arm
> diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
> index dfc1790..d9269bd 100644
> --- a/toolchain/gcc/gcc-uclibc-4.x.mk
> +++ b/toolchain/gcc/gcc-uclibc-4.x.mk
> @@ -290,7 +290,6 @@ $(GCC_BUILD_DIR2)/.configured: $(GCC_SRC_DIR)/.patched $(GCC_STAGING_PREREQ)
> $(GCC_DECIMAL_FLOAT) \
> $(SOFT_FLOAT_CONFIG_OPTION) \
> $(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
> - $(GCC_USE_SJLJ_EXCEPTIONS) \
> $(DISABLE_LARGEFILE) \
> $(EXTRA_GCC_CONFIG_OPTIONS) \
> $(EXTRA_GCC2_CONFIG_OPTIONS) \
> @@ -424,7 +423,6 @@ $(GCC_BUILD_DIR3)/.configured: $(GCC_BUILD_DIR3)/.prepared
> $(GCC_DECIMAL_FLOAT) \
> $(SOFT_FLOAT_CONFIG_OPTION) \
> $(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
> - $(GCC_USE_SJLJ_EXCEPTIONS) \
> $(DISABLE_LARGEFILE) \
> $(EXTRA_GCC_CONFIG_OPTIONS) \
> $(EXTRA_TARGET_GCC_CONFIG_OPTIONS) \
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 10:38 ` Michael S. Zick
@ 2010-07-29 11:38 ` Thomas Petazzoni
2010-07-29 11:59 ` Michael S. Zick
0 siblings, 1 reply; 17+ messages in thread
From: Thomas Petazzoni @ 2010-07-29 11:38 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 29 Jul 2010 05:38:06 -0500
"Michael S. Zick" <minimod@morethan.org> wrote:
> And of course you confirmed that the Lua package's
> error handling still works properly, complete with
> same backtrace that is produced when SJLJ exceptions are enabled.
No, I did not.
> You did make that test didn't you?
Why do you need to be so aggressive ? It is possible that removing this
option was a mistake, but there's *really* no need to be so
aggressive. It only reduces the motivation to look at the problem...
So, trying to be constructive, how can I test that Lua still produces
correct backtraces ? (I'm not a Lua programmer at all).
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 11:38 ` Thomas Petazzoni
@ 2010-07-29 11:59 ` Michael S. Zick
2010-07-29 12:18 ` Michael S. Zick
2010-07-29 12:30 ` Thomas Petazzoni
0 siblings, 2 replies; 17+ messages in thread
From: Michael S. Zick @ 2010-07-29 11:59 UTC (permalink / raw)
To: buildroot
On Thu July 29 2010, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 29 Jul 2010 05:38:06 -0500
> "Michael S. Zick" <minimod@morethan.org> wrote:
>
> > And of course you confirmed that the Lua package's
> > error handling still works properly, complete with
> > same backtrace that is produced when SJLJ exceptions are enabled.
>
> No, I did not.
>
> > You did make that test didn't you?
>
> Why do you need to be so aggressive ? It is possible that removing this
> option was a mistake, but there's *really* no need to be so
> aggressive. It only reduces the motivation to look at the problem...
>
The last time this subject came up on the ML tests seemed to indicate
that the option was required by the Lua package.
I just presumed you have been following the mailing list postings.
> So, trying to be constructive, how can I test that Lua still produces
> correct backtraces ? (I'm not a Lua programmer at all).
>
Pass an illegal value to a library routine or to a routine that you write.
"Lua" refers to both a set of C libraries and to the interactive mode which
uses those same libraries.
So testing with the interactive mode should be enough to see a backtrace.
Since the libraries (written in ANSI C) are quite close to the interactive
environment (usually only one or two calls away) you will not see a very
long backtrace unless you write a function or two of your own, but you will
get one.
I.E:
mszick at wolf466:~$ lua
Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio
> os.exit("String Value")
stdin:1: bad argument #1 to 'exit' (number expected, got string)
stack traceback:
[C]: in function 'exit'
stdin:1: in main chunk
[C]: ?
The "[C]" just means that is a hunk of compiled C code, for which the
language does not have any more information to give you about it.
And: os.exit(0) should get you back out of the interactive Lua (or ctrl-D).
Mike
> Thanks,
>
> Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 11:59 ` Michael S. Zick
@ 2010-07-29 12:18 ` Michael S. Zick
2010-07-29 14:30 ` Thomas Petazzoni
2010-07-29 12:30 ` Thomas Petazzoni
1 sibling, 1 reply; 17+ messages in thread
From: Michael S. Zick @ 2010-07-29 12:18 UTC (permalink / raw)
To: buildroot
On Thu July 29 2010, Michael S. Zick wrote:
> On Thu July 29 2010, Thomas Petazzoni wrote:
> > Hello,
> >
> > On Thu, 29 Jul 2010 05:38:06 -0500
> > "Michael S. Zick" <minimod@morethan.org> wrote:
> >
> > > And of course you confirmed that the Lua package's
> > > error handling still works properly, complete with
> > > same backtrace that is produced when SJLJ exceptions are enabled.
> >
> > No, I did not.
> >
> > > You did make that test didn't you?
> >
> > Why do you need to be so aggressive ? It is possible that removing this
> > option was a mistake, but there's *really* no need to be so
> > aggressive. It only reduces the motivation to look at the problem...
> >
>
> The last time this subject came up on the ML tests seemed to indicate
> that the option was required by the Lua package.
>
> I just presumed you have been following the mailing list postings.
>
> > So, trying to be constructive, how can I test that Lua still produces
> > correct backtraces ? (I'm not a Lua programmer at all).
> >
>
> Pass an illegal value to a library routine or to a routine that you write.
> "Lua" refers to both a set of C libraries and to the interactive mode which
> uses those same libraries.
>
> So testing with the interactive mode should be enough to see a backtrace.
>
> Since the libraries (written in ANSI C) are quite close to the interactive
> environment (usually only one or two calls away) you will not see a very
> long backtrace unless you write a function or two of your own, but you will
> get one.
>
And if you write a function, just to show a longer backtrace:
(functions are first-class values, so they can be written as an assignment)
Try:
mszick at wolf466:~$ lua
Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio
> bye = function() return os.exit("String Value") end
> bye()
stdin:1: bad argument #1 to 'exit' (number expected, got string)
stack traceback:
[C]: in function 'exit'
stdin:1: in function 'bye'
stdin:1: in main chunk
[C]: ?
>
Mike
>
> I.E:
> mszick at wolf466:~$ lua
> Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio
> > os.exit("String Value")
> stdin:1: bad argument #1 to 'exit' (number expected, got string)
> stack traceback:
> [C]: in function 'exit'
> stdin:1: in main chunk
> [C]: ?
>
> The "[C]" just means that is a hunk of compiled C code, for which the
> language does not have any more information to give you about it.
>
> And: os.exit(0) should get you back out of the interactive Lua (or ctrl-D).
>
> Mike
>
> > Thanks,
> >
> > Thomas
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 12:18 ` Michael S. Zick
@ 2010-07-29 14:30 ` Thomas Petazzoni
2010-07-29 15:09 ` Michael S. Zick
2010-07-29 15:11 ` Michael S. Zick
0 siblings, 2 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2010-07-29 14:30 UTC (permalink / raw)
To: buildroot
Hello Michael,
On Thu, 29 Jul 2010 07:18:56 -0500
"Michael S. Zick" <minimod@morethan.org> wrote:
> mszick at wolf466:~$ lua
> Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio
> > bye = function() return os.exit("String Value") end
> > bye()
> stdin:1: bad argument #1 to 'exit' (number expected, got string)
> stack traceback:
> [C]: in function 'exit'
> stdin:1: in function 'bye'
> stdin:1: in main chunk
> [C]: ?
With the current Buildroot git (i.e, without SJLJ exceptions), I built
an ARM system with Lua, and made your test under Qemu. I had the exact
same output, with the exact same stack trace.
Are more complicated cases likely to make a difference ?
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 14:30 ` Thomas Petazzoni
@ 2010-07-29 15:09 ` Michael S. Zick
2010-07-29 15:11 ` Michael S. Zick
1 sibling, 0 replies; 17+ messages in thread
From: Michael S. Zick @ 2010-07-29 15:09 UTC (permalink / raw)
To: buildroot
On Thu July 29 2010, Thomas Petazzoni wrote:
> Hello Michael,
>
> On Thu, 29 Jul 2010 07:18:56 -0500
> "Michael S. Zick" <minimod@morethan.org> wrote:
>
> > mszick at wolf466:~$ lua
> > Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio
> > > bye = function() return os.exit("String Value") end
> > > bye()
> > stdin:1: bad argument #1 to 'exit' (number expected, got string)
> > stack traceback:
> > [C]: in function 'exit'
> > stdin:1: in function 'bye'
> > stdin:1: in main chunk
> > [C]: ?
>
> With the current Buildroot git (i.e, without SJLJ exceptions), I built
> an ARM system with Lua, and made your test under Qemu. I had the exact
> same output, with the exact same stack trace.
>
> Are more complicated cases likely to make a difference ?
>
Unknown.
The prior tests where on MIPS-32, and limited in scope to the simple
tests included in this thread.
Mike
> Regards,
>
> Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 14:30 ` Thomas Petazzoni
2010-07-29 15:09 ` Michael S. Zick
@ 2010-07-29 15:11 ` Michael S. Zick
1 sibling, 0 replies; 17+ messages in thread
From: Michael S. Zick @ 2010-07-29 15:11 UTC (permalink / raw)
To: buildroot
On Thu July 29 2010, Thomas Petazzoni wrote:
> Hello Michael,
>
> On Thu, 29 Jul 2010 07:18:56 -0500
> "Michael S. Zick" <minimod@morethan.org> wrote:
>
> > mszick at wolf466:~$ lua
> > Lua 5.1.4 Copyright (C) 1994-2008 Lua.org, PUC-Rio
> > > bye = function() return os.exit("String Value") end
> > > bye()
> > stdin:1: bad argument #1 to 'exit' (number expected, got string)
> > stack traceback:
> > [C]: in function 'exit'
> > stdin:1: in function 'bye'
> > stdin:1: in main chunk
> > [C]: ?
>
> With the current Buildroot git (i.e, without SJLJ exceptions), I built
> an ARM system with Lua, and made your test under Qemu. I had the exact
> same output, with the exact same stack trace.
>
> Are more complicated cases likely to make a difference ?
>
It might make a difference if you compile it with C++ rather than C
Lua is written in "clean C" it will compile with either compiler and
when used as an extension library for C++ usually is compiled with C++
Mike
> Regards,
>
> Thomas
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 11:59 ` Michael S. Zick
2010-07-29 12:18 ` Michael S. Zick
@ 2010-07-29 12:30 ` Thomas Petazzoni
2010-07-29 12:34 ` Peter Korsgaard
2010-07-29 12:47 ` Michael S. Zick
1 sibling, 2 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2010-07-29 12:30 UTC (permalink / raw)
To: buildroot
On Thu, 29 Jul 2010 06:59:36 -0500
"Michael S. Zick" <minimod@morethan.org> wrote:
> > Why do you need to be so aggressive ? It is possible that removing
> > this option was a mistake, but there's *really* no need to be so
> > aggressive. It only reduces the motivation to look at the problem...
>
> The last time this subject came up on the ML tests seemed to indicate
> that the option was required by the Lua package.
>
> I just presumed you have been following the mailing list postings.
Sorry, I couldn't find the postings you're refering to. Do you have a
pointer ?
And even though the subject already came up on the mailing list, there
is absolutely zero reason for being aggressive. For the record, a
thread about SJLJ was started on July, 22nd by Ossy reporting a build
failure when SJLJ is enabled. On July, 27th, in the same thread, I
proposed to remove the option altogether, and there has been no
reaction to this message. But I admit that between the 27th and the
29th when the patch was committed, there is very little time to react.
I just wanted to point out that the patch does come out of nowhere
without prior discussion on the list.
> Pass an illegal value to a library routine or to a routine that you
> write. "Lua" refers to both a set of C libraries and to the
> interactive mode which uses those same libraries.
>
> So testing with the interactive mode should be enough to see a
> backtrace.
>
> Since the libraries (written in ANSI C) are quite close to the
> interactive environment (usually only one or two calls away) you will
> not see a very long backtrace unless you write a function or two of
> your own, but you will get one.
Ok, thanks for the example, will try.
However, it seems that the --enable-sjlj-exceptions configuration
option only applies to libstdc++. Not having --enable-sjlj-exceptions
does not remove setjmp()/longjmp() support, it just seems to tell the
C++ library to not use setjmp()/longjmp() for its own exceptions. Which
doesn't prevent Lua from using setjmp/longjmp on its own.
But of course, I haven't tried, so I may be plain wrong.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 12:30 ` Thomas Petazzoni
@ 2010-07-29 12:34 ` Peter Korsgaard
2010-07-29 12:47 ` Michael S. Zick
1 sibling, 0 replies; 17+ messages in thread
From: Peter Korsgaard @ 2010-07-29 12:34 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
Thomas> And even though the subject already came up on the mailing
Thomas> list, there is absolutely zero reason for being aggressive.
Indeed, let's keep it civil here..
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 12:30 ` Thomas Petazzoni
2010-07-29 12:34 ` Peter Korsgaard
@ 2010-07-29 12:47 ` Michael S. Zick
2010-07-29 13:04 ` Thomas Petazzoni
1 sibling, 1 reply; 17+ messages in thread
From: Michael S. Zick @ 2010-07-29 12:47 UTC (permalink / raw)
To: buildroot
On Thu July 29 2010, Thomas Petazzoni wrote:
> On Thu, 29 Jul 2010 06:59:36 -0500
> "Michael S. Zick" <minimod@morethan.org> wrote:
>
> > > Why do you need to be so aggressive ? It is possible that removing
> > > this option was a mistake, but there's *really* no need to be so
> > > aggressive. It only reduces the motivation to look at the problem...
> >
> > The last time this subject came up on the ML tests seemed to indicate
> > that the option was required by the Lua package.
> >
> > I just presumed you have been following the mailing list postings.
>
> Sorry, I couldn't find the postings you're refering to. Do you have a
> pointer ?
>
No I don't have a pointer handy.
Look for one of the threads that you terminated discussion with a:
"If you don't like it, you can hire commercial support for it from my firm."
It may even be the same thread where the ethics of using an "Open Source
Project" as a "loss leader" to gain commercial customers was discussed.
Mike
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions
2010-07-29 12:47 ` Michael S. Zick
@ 2010-07-29 13:04 ` Thomas Petazzoni
0 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2010-07-29 13:04 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 29 Jul 2010 07:47:41 -0500
"Michael S. Zick" <minimod@morethan.org> wrote:
> > Sorry, I couldn't find the postings you're refering to. Do you have
> > a pointer ?
>
> No I don't have a pointer handy.
Ok. I looked in the archives for all messages with "lua" in the subject
since March 2008, and I didn't found one.
> Look for one of the threads that you terminated discussion with a:
>
> "If you don't like it, you can hire commercial support for it from my
> firm."
>
> It may even be the same thread where the ethics of using an "Open
> Source Project" as a "loss leader" to gain commercial customers was
> discussed.
Ah, ah, I now understand why you're so aggressive against me :-)
Please read that very thread again, and see how offensive you were
against the volunteers working on Buildroot. Just as you are in the
current thread, for no reason.
I think we're both trying to make Buildroot better, on a volunteer
basis. So let's do so in a nice and friendly atmosphere, no ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Buildroot] [PATCH 2/2] toolchain: remove multilib
2010-07-29 6:30 [Buildroot] [pull request] Pull request for branch gcc-remove-options Thomas Petazzoni
2010-07-29 6:30 ` [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions Thomas Petazzoni
@ 2010-07-29 6:30 ` Thomas Petazzoni
2010-07-29 6:53 ` [Buildroot] [pull request] Pull request for branch gcc-remove-options Peter Korsgaard
2 siblings, 0 replies; 17+ messages in thread
From: Thomas Petazzoni @ 2010-07-29 6:30 UTC (permalink / raw)
To: buildroot
Supporting multilib is much more than just passing --enable-multilib
to gcc. You have to actually build the C library several times (once
for each multilib variant you want to support in your toolchain), and
to pass MULTILIB_OPTIONS/MULTILIB_EXCEPTIONS values to gcc to let it
know the set of multilib variants you're interested in.
Since we'll probably never support multilib toolchains in Buildroot,
just get rid of this BR2_ENABLE_MULTILIB option.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
configs/arm_toolchain_defconfig | 1 -
configs/at91rm9200df_defconfig | 1 -
configs/at91sam9260dfc_defconfig | 1 -
configs/at91sam9260pf_defconfig | 1 -
configs/at91sam9261ek_defconfig | 1 -
configs/at91sam9263ek_defconfig | 1 -
configs/at91sam9g20dfc_defconfig | 1 -
configs/atngw100-base_defconfig | 1 -
configs/atngw100_defconfig | 1 -
configs/atstk1005_defconfig | 1 -
configs/atstk100x_defconfig | 1 -
configs/i386_defconfig | 1 -
configs/i686_defconfig | 1 -
configs/integrator926_defconfig | 1 -
configs/integrator926_huge_defconfig | 1 -
configs/kb9202_defconfig | 1 -
configs/v100sc2_defconfig | 1 -
target/xtensa/defconfig | 1 -
toolchain/Makefile.in | 6 ------
toolchain/binutils/binutils.mk | 2 --
toolchain/gcc/gcc-uclibc-4.x.mk | 5 +----
toolchain/toolchain-buildroot/Config.in.2 | 5 -----
22 files changed, 1 insertions(+), 35 deletions(-)
diff --git a/configs/arm_toolchain_defconfig b/configs/arm_toolchain_defconfig
index 2ac7de3..26a999a 100644
--- a/configs/arm_toolchain_defconfig
+++ b/configs/arm_toolchain_defconfig
@@ -284,7 +284,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
# BR2_VFP_FLOAT is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
diff --git a/configs/at91rm9200df_defconfig b/configs/at91rm9200df_defconfig
index 2a193cf..66a9984 100644
--- a/configs/at91rm9200df_defconfig
+++ b/configs/at91rm9200df_defconfig
@@ -299,7 +299,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
BR2_PACKAGE_SSTRIP_TARGET=y
BR2_PACKAGE_SSTRIP_HOST=y
-# BR2_ENABLE_MULTILIB is not set
# BR2_VFP_FLOAT is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
diff --git a/configs/at91sam9260dfc_defconfig b/configs/at91sam9260dfc_defconfig
index 98d3401..594b6e8 100644
--- a/configs/at91sam9260dfc_defconfig
+++ b/configs/at91sam9260dfc_defconfig
@@ -305,7 +305,6 @@ BR2_GDB_VERSION="6.8"
# BR2_MKLIBS is not set
BR2_PACKAGE_SSTRIP_TARGET=y
BR2_PACKAGE_SSTRIP_HOST=y
-# BR2_ENABLE_MULTILIB is not set
BR2_LARGEFILE=y
BR2_INET_IPV6=y
BR2_INET_RPC=y
diff --git a/configs/at91sam9260pf_defconfig b/configs/at91sam9260pf_defconfig
index ec4005d..76526c9 100644
--- a/configs/at91sam9260pf_defconfig
+++ b/configs/at91sam9260pf_defconfig
@@ -205,7 +205,6 @@ BR2_CCACHE=y
#
BR2_PACKAGE_SSTRIP_TARGET=y
BR2_PACKAGE_SSTRIP_HOST=y
-# BR2_ENABLE_MULTILIB is not set
BR2_LARGEFILE=y
BR2_INET_IPV6=y
BR2_INET_RPC=y
diff --git a/configs/at91sam9261ek_defconfig b/configs/at91sam9261ek_defconfig
index 7524c68..9a2de94 100644
--- a/configs/at91sam9261ek_defconfig
+++ b/configs/at91sam9261ek_defconfig
@@ -299,7 +299,6 @@ BR2_CCACHE_DIR="$(TOOLCHAIN_DIR)/ccache-$(CCACHE_VER)/cache"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
BR2_PACKAGE_SSTRIP_HOST=y
-# BR2_ENABLE_MULTILIB is not set
BR2_LARGEFILE=y
BR2_INET_IPV6=y
BR2_INET_RPC=y
diff --git a/configs/at91sam9263ek_defconfig b/configs/at91sam9263ek_defconfig
index 85ccede..99efe17 100644
--- a/configs/at91sam9263ek_defconfig
+++ b/configs/at91sam9263ek_defconfig
@@ -304,7 +304,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
BR2_PACKAGE_SSTRIP_HOST=y
-# BR2_ENABLE_MULTILIB is not set
# BR2_VFP_FLOAT is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
diff --git a/configs/at91sam9g20dfc_defconfig b/configs/at91sam9g20dfc_defconfig
index 57d72ae..90b94f1 100644
--- a/configs/at91sam9g20dfc_defconfig
+++ b/configs/at91sam9g20dfc_defconfig
@@ -304,7 +304,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
BR2_PACKAGE_SSTRIP_TARGET=y
BR2_PACKAGE_SSTRIP_HOST=y
-# BR2_ENABLE_MULTILIB is not set
# BR2_VFP_FLOAT is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
diff --git a/configs/atngw100-base_defconfig b/configs/atngw100-base_defconfig
index 270c056..5d27a22 100644
--- a/configs/atngw100-base_defconfig
+++ b/configs/atngw100-base_defconfig
@@ -230,7 +230,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
# BR2_CROSS_TOOLCHAIN_TARGET_UTILS is not set
#
diff --git a/configs/atngw100_defconfig b/configs/atngw100_defconfig
index a78372d..3d6c3f1 100644
--- a/configs/atngw100_defconfig
+++ b/configs/atngw100_defconfig
@@ -225,7 +225,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
#
diff --git a/configs/atstk1005_defconfig b/configs/atstk1005_defconfig
index 451e248..aa5af8b 100644
--- a/configs/atstk1005_defconfig
+++ b/configs/atstk1005_defconfig
@@ -244,7 +244,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
#
diff --git a/configs/atstk100x_defconfig b/configs/atstk100x_defconfig
index e39e608..036321f 100644
--- a/configs/atstk100x_defconfig
+++ b/configs/atstk100x_defconfig
@@ -241,7 +241,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
#
diff --git a/configs/i386_defconfig b/configs/i386_defconfig
index 026e206..8045476 100644
--- a/configs/i386_defconfig
+++ b/configs/i386_defconfig
@@ -240,7 +240,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
#
diff --git a/configs/i686_defconfig b/configs/i686_defconfig
index 884ec7d..a24a53e 100644
--- a/configs/i686_defconfig
+++ b/configs/i686_defconfig
@@ -240,7 +240,6 @@ BR2_TARGET_OPTIMIZATION="-Os -pipe"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_CROSS_TOOLCHAIN_TARGET_UTILS=y
#
diff --git a/configs/integrator926_defconfig b/configs/integrator926_defconfig
index 4ec53f9..ceb80d6 100644
--- a/configs/integrator926_defconfig
+++ b/configs/integrator926_defconfig
@@ -226,7 +226,6 @@ BR2_GCC_SHARED_LIBGCC=y
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
# BR2_LARGEFILE is not set
# BR2_INET_IPV6 is not set
# BR2_INET_RPC is not set
diff --git a/configs/integrator926_huge_defconfig b/configs/integrator926_huge_defconfig
index b5c34df..46503ab 100644
--- a/configs/integrator926_huge_defconfig
+++ b/configs/integrator926_huge_defconfig
@@ -227,7 +227,6 @@ BR2_GCC_SHARED_LIBGCC=y
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_LARGEFILE=y
BR2_INET_IPV6=y
BR2_INET_RPC=y
diff --git a/configs/kb9202_defconfig b/configs/kb9202_defconfig
index 1d0aa61..0db7866 100644
--- a/configs/kb9202_defconfig
+++ b/configs/kb9202_defconfig
@@ -229,7 +229,6 @@ BR2_GCC_SHARED_LIBGCC=y
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
# BR2_LARGEFILE is not set
# BR2_INET_IPV6 is not set
# BR2_INET_RPC is not set
diff --git a/configs/v100sc2_defconfig b/configs/v100sc2_defconfig
index 5ba2899..7a273e1 100644
--- a/configs/v100sc2_defconfig
+++ b/configs/v100sc2_defconfig
@@ -202,7 +202,6 @@ BR2_GDB_VERSION="6.7.1"
# BR2_MKLIBS is not set
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_LARGEFILE=y
BR2_INET_IPV6=y
BR2_INET_RPC=y
diff --git a/target/xtensa/defconfig b/target/xtensa/defconfig
index 49b7eb3..200ff21 100644
--- a/target/xtensa/defconfig
+++ b/target/xtensa/defconfig
@@ -77,7 +77,6 @@ BR2_GDB_VERSION="6.8"
#
# BR2_PACKAGE_SSTRIP_TARGET is not set
# BR2_PACKAGE_SSTRIP_HOST is not set
-# BR2_ENABLE_MULTILIB is not set
BR2_LARGEFILE=y
BR2_INET_RPC=y
BR2_TARGET_OPTIMIZATION="-Os -pipe"
diff --git a/toolchain/Makefile.in b/toolchain/Makefile.in
index d1af877..371509f 100644
--- a/toolchain/Makefile.in
+++ b/toolchain/Makefile.in
@@ -4,12 +4,6 @@ else
THREADS:=--enable-threads
endif
-ifeq ($(BR2_ENABLE_MULTILIB),y)
-MULTILIB:=--enable-multilib
-else
-MULTILIB:=--disable-multilib
-endif
-
BR2_CONFIGURE_DEVEL_SYSROOT=--with-sysroot=$(TOOLCHAIN_DIR)/uClibc_dev/
BR2_CONFIGURE_STAGING_SYSROOT=--with-sysroot=$(STAGING_DIR)
BR2_CONFIGURE_BUILD_TOOLS=--with-build-time-tools=$(STAGING_DIR)/usr/$(REAL_GNU_TARGET_NAME)/bin
diff --git a/toolchain/binutils/binutils.mk b/toolchain/binutils/binutils.mk
index 93dbbb0..e44707c 100644
--- a/toolchain/binutils/binutils.mk
+++ b/toolchain/binutils/binutils.mk
@@ -74,7 +74,6 @@ $(BINUTILS_DIR1)/.configured: $(BINUTILS_DIR)/.patched
$(BR2_CONFIGURE_DEVEL_SYSROOT) \
$(BR2_CONFIGURE_STAGING_SYSROOT) \
$(DISABLE_NLS) \
- $(MULTILIB) \
--disable-werror \
$(SOFT_FLOAT_CONFIG_OPTION) \
$(EXTRA_BINUTILS_CONFIG_OPTIONS) \
@@ -128,7 +127,6 @@ $(BINUTILS_DIR2)/.configured: $(BINUTILS_DIR)/.patched
--mandir=/usr/share/man \
--infodir=/usr/share/info \
$(DISABLE_NLS) \
- $(MULTILIB) \
$(BINUTILS_TARGET_CONFIG_OPTIONS) \
--disable-werror \
$(SOFT_FLOAT_CONFIG_OPTION) \
diff --git a/toolchain/gcc/gcc-uclibc-4.x.mk b/toolchain/gcc/gcc-uclibc-4.x.mk
index d9269bd..b87270f 100644
--- a/toolchain/gcc/gcc-uclibc-4.x.mk
+++ b/toolchain/gcc/gcc-uclibc-4.x.mk
@@ -167,7 +167,7 @@ ifeq ("$(strip $(ARCH))","armeb")
endif
endif
ifeq ($(ARCH)-$(BR2_GCC_SHARED_LIBGCC),powerpc-y)
-ifneq ($(BR2_SOFT_FLOAT)$(BR2_ENABLE_MULTILIB),)
+ifneq ($(BR2_SOFT_FLOAT),)
toolchain/patch-kernel.sh $(GCC_DIR) toolchain/gcc/$(GCC_VERSION) powerpc-link-with-math-lib.patch.conditional
endif
endif
@@ -206,7 +206,6 @@ $(GCC_BUILD_DIR1)/.configured: $(GCC_DIR)/.patched
$(GCC_WITH_HOST_MPFR) \
$(DISABLE_NLS) \
$(THREADS) \
- $(MULTILIB) \
$(GCC_DECIMAL_FLOAT) \
$(SOFT_FLOAT_CONFIG_OPTION) \
$(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
@@ -286,7 +285,6 @@ $(GCC_BUILD_DIR2)/.configured: $(GCC_SRC_DIR)/.patched $(GCC_STAGING_PREREQ)
$(GCC_WITH_HOST_MPFR) \
$(DISABLE_NLS) \
$(THREADS) \
- $(MULTILIB) \
$(GCC_DECIMAL_FLOAT) \
$(SOFT_FLOAT_CONFIG_OPTION) \
$(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
@@ -419,7 +417,6 @@ $(GCC_BUILD_DIR3)/.configured: $(GCC_BUILD_DIR3)/.prepared
$(GCC_WITH_TARGET_MPFR) \
$(DISABLE_NLS) \
$(THREADS) \
- $(MULTILIB) \
$(GCC_DECIMAL_FLOAT) \
$(SOFT_FLOAT_CONFIG_OPTION) \
$(GCC_WITH_ABI) $(GCC_WITH_ARCH) $(GCC_WITH_TUNE) \
diff --git a/toolchain/toolchain-buildroot/Config.in.2 b/toolchain/toolchain-buildroot/Config.in.2
index 512a608..2a17796 100644
--- a/toolchain/toolchain-buildroot/Config.in.2
+++ b/toolchain/toolchain-buildroot/Config.in.2
@@ -5,11 +5,6 @@ source "toolchain/elf2flt/Config.in"
source "toolchain/mklibs/Config.in"
source "toolchain/sstrip/Config.in"
-config BR2_ENABLE_MULTILIB
- bool "Enable multilib support?"
- help
- Build libraries to support different ABIs.
-
config BR2_VFP_FLOAT
bool "Use ARM Vector Floating Point unit"
depends on !BR2_SOFT_FLOAT
--
1.7.0.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [Buildroot] [pull request] Pull request for branch gcc-remove-options
2010-07-29 6:30 [Buildroot] [pull request] Pull request for branch gcc-remove-options Thomas Petazzoni
2010-07-29 6:30 ` [Buildroot] [PATCH 1/2] gcc: remove option on SJLJ exceptions Thomas Petazzoni
2010-07-29 6:30 ` [Buildroot] [PATCH 2/2] toolchain: remove multilib Thomas Petazzoni
@ 2010-07-29 6:53 ` Peter Korsgaard
2 siblings, 0 replies; 17+ messages in thread
From: Peter Korsgaard @ 2010-07-29 6:53 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Hello,
Thomas> This is the same patch set as yesterday, just rebased on top of Yann
Thomas> Morin changes that have been merged in the mean time.
Thanks, pulled and pushed.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 17+ messages in thread