Re: [PATCH 11/13] ARM: versatile: remove mps2 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `ARCH_MPS2` config symbol was removed from the tree, but it is still referenced in the `depends on` clause for `SERIAL_MPS2_UART` in the serial subsystem.
--

commit 6586f00f58e77d469ef87ccde160d87dd5f7e427
Author: Arnd Bergmann <arnd@arndb.de>

ARM: versatile: remove mps2 support

The Arm mps2 platform is the reference implementation for Arm
microcontrollers and is useful for testing but not expected to be used
as a production device. With all the Cortex-M based products gone, there
is no longer a need for a reference platform either, so remove it as well.

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 13b38be3353a3..cf380b6868676 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -443,20 +443,6 @@ source "arch/arm/mach-zte/Kconfig"
>  
>  source "arch/arm/mach-zynq/Kconfig"
>  
> -config ARCH_MPS2
> -	bool "ARM MPS2 platform (DEPRECATED)"

[Severity: Medium]
Since the ARCH_MPS2 config symbol is being removed from the tree here, should
it also be removed from the depends on clause for SERIAL_MPS2_UART?

Looking at drivers/tty/serial/Kconfig, it still references this deleted
symbol for the serial subsystem:

config SERIAL_MPS2_UART
	bool "MPS2 UART port"
	depends on ARCH_MPS2 || COMPILE_TEST

Will leaving this unresolved cause the SERIAL_MPS2_UART driver to only be
buildable under COMPILE_TEST and lead to silent Kconfig dependency
resolution issues?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908152808.3928630-1-arnd@kernel.org?part=11