Re: [PATCH 04/13] ARM: remove legacy pxa board files

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] Removed Kconfig symbols are still referenced in `depends on` statements of other subsystems, violating Kconfig dependency rules.
- [Low] Orphaned board-specific driver files and dead `#ifdef` blocks were left in the tree after their Kconfig options were removed.
- [Low] Dangling function declarations for removed platform data setters in subsystem headers.
--

commit ef1288803408f45e1d5ad605b925ffe5c498323f
Author: Arnd Bergmann <arnd@arndb.de>

ARM: remove legacy pxa board files

This patch removes support for several legacy PXA board files, including
the Sharp SL series and Gumstix expansion boards. It deletes the associated
machine initialization code, defconfigs, and board-specific headers.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index 2fb29b9ef7446..354e3dc177763 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
[ ... ]
> -config GUMSTIX_AM200EPD
> -	bool "Enable AM200EPD board support"
> -
> -config GUMSTIX_AM300EPD
> -	bool "Enable AM300EPD board support"
> -
> -endchoice
> -
> -config PXA_SHARPSL
> -	bool "SHARP Zaurus SL-5600, SL-C7xx and SL-Cxx00 Models (DEPRECATED)"

[Severity: Medium]
Since PXA_SHARPSL and related configs are removed here, does this leave
unmet dependencies in other subsystems?

For example, in drivers/pcmcia/Kconfig, PCMCIA_PXA2XX has:
    depends on ARM && ARCH_PXA && PCMCIA && PXA_SHARPSL

Similarly, LCD_CORGI in drivers/video/backlight/Kconfig and
SND_PXA2XX_SOC_SPITZ in sound/soc/pxa/Kconfig still depend on these
removed symbols, making them unreachable. Should these Kconfig entries
and makefile rules, like pxa2xx-obj-$(CONFIG_PXA_SHARPSL) in
drivers/pcmcia/Makefile, be removed as well?

[Severity: Low]
With the removal of these board configurations, are there orphaned drivers
and dead code blocks left in the tree?

For instance, drivers/pcmcia/pxa2xx_sharpsl.c,
drivers/video/backlight/corgi_lcd.c, and sound/soc/pxa/spitz.c appear
to be specific to the removed Sharp SL and Spitz boards. The sharpsl-nand
device probed in drivers/mtd/nand/raw/sharpsl.c is also no longer
registered.

Additionally, there are leftover ifdef blocks, such as
#ifdef CONFIG_GUMSTIX_AM200EPD in drivers/video/fbdev/core/fbmem.c
(inside register_framebuffer) and include/linux/fb.h, as well as
#ifdef CONFIG_SHARPSL_PM in drivers/hwmon/max1111.c (in max1111_read_channel).

Could these drivers and dead ifdef blocks be cleaned up in a follow-up?

> -	select SHARP_PARAM
> -	select SHARP_SCOOP
[ ... ]
> diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c
> index edad956a1483c..c2a2469a003a2 100644
> --- a/arch/arm/mach-pxa/devices.c
> +++ b/arch/arm/mach-pxa/devices.c
[ ... ]
> -void __init pxa_set_fb_info(struct device *parent, struct pxafb_mach_info *info)
> -{
> -	pxa_device_fb.dev.parent = parent;
> -	pxa_register_device(&pxa_device_fb, info);
> -}

[Severity: Low]
With the implementations of these platform data setters removed, should
their corresponding external declarations be cleaned up from the
subsystem headers to prevent dangling prototypes?

For example:
- pxa_set_fb_info() in include/linux/platform_data/video-pxafb.h
- pxa_set_ohci_info() in include/linux/platform_data/usb-ohci-pxa27x.h
- pxa_set_mci_info() in include/linux/platform_data/mmc-pxamci.h

> -
> -static struct resource pxa_resource_ffuart[] = {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908152808.3928630-1-arnd@kernel.org?part=4