Re: [PATCH 03/13] ARM: remove riscpc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete removal of the ARCH_RPC platform and ARCH_ACORN config dependency, leaving orphaned device drivers, Makefile/Kconfig references, and dead code.
--

commit 90a4954ac0a5a6d8d3608046095747cf4673b8dd
Author: Arnd Bergmann <arnd@arndb.de>

ARM: remove riscpc

The Acorn Risc PC platform and its associated drivers, configurations,
and board files are being removed as the required gcc-8 compiler and
-march=armv3 option are no longer supported.

>     The main limitation here is the CPU bus that does not allow 16-bit
>     wide data transfers and hence requires the kernel to be built with the
>     -march=armv3 compiler option that was discontinued in gcc-9.

[Severity: Low]
Since this compiler option is the explicitly stated reason for removal in the
commit message, should we also delete the compiler flag from the tree?

arch/arm/Makefile:
    arch-$(CONFIG_CPU_32v3)         :=-march=armv3m

Additionally, the config symbol for this architecture version is now
dead code because its only selector (ARCH_RPC) was removed:

arch/arm/mm/Kconfig:config CPU_32v3
    config CPU_32v3
        bool

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 81872f61b4317..fdd75b73bf293 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> -ARM MFM AND FLOPPY DRIVERS
> -M:	Ian Molton <spyro@f2s.com>
> -S:	Maintained
> -F:	arch/arm/include/asm/floppy.h
> -F:	arch/arm/mach-rpc/floppydma.S
> -

[Severity: Low]
Does this leave the floppy header as dead code in the tree? It is removed
from MAINTAINERS here, but the file itself was left in the tree:

arch/arm/include/asm/floppy.h:
    #ifndef __ASM_ARM_FLOPPY_H
    #define __ASM_ARM_FLOPPY_H

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index c3d6b8abc815f..5770deca136d3 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
[ ... ]
> @@ -429,8 +415,6 @@ source "arch/arm/mach-qcom/Kconfig"
>  
>  source "arch/arm/mach-realtek/Kconfig"
>  
> -source "arch/arm/mach-rpc/Kconfig"
> -
>  source "arch/arm/mach-rockchip/Kconfig"

[Severity: Low]
Are there dangling references to the removed CONFIG_ARCH_RPC?

The Makefile still references it:

arch/arm/Makefile:
    machine-$(CONFIG_ARCH_RPC)              += rpc
    
The machine type registry still contains it:

arch/arm/tools/mach-types:
    riscpc                  ARCH_RPC                RISCPC                  1
    
And the CPU selection still evaluates it:

arch/arm/mm/Kconfig:config CPU_SA110
    select CPU_32v3 if ARCH_RPC
    select CPU_32v4 if !ARCH_RPC

[ ... ]
> @@ -490,9 +474,6 @@ config ARCH_MPS2
>  	  This platform is scheduled for removal in early 2027
>  
>  # Definitions to make life easier
> -config ARCH_ACORN
> -	bool
> -

[Severity: Low]
Does removing ARCH_ACORN leave orphaned device drivers in the tree?

All Acorn SCSI drivers depend on this removed config, leaving the entire
directory as dead code:

drivers/scsi/arm/Kconfig:config SCSI_ACORN
    depends on ARCH_ACORN && SCSI

While these removed configs make the dependent drivers unselectable and thus
don't break the build or introduce runtime issues, it leaves a significant
amount of dead code. I have verified that this dead code is not removed in
subsequent patches in the series.

> diff --git a/arch/arm/include/asm/ecard.h b/arch/arm/include/asm/ecard.h
> deleted file mode 100644
> index 7cbe001bf9ccc..0000000000000
> --- a/arch/arm/include/asm/ecard.h
> +++ /dev/null
> @@ -1,219 +0,0 @@
[ ... ]
> -#ifndef __ASM_ECARD_H
> -#define __ASM_ECARD_H

[Severity: Low]
Does this leave behind unselectable drivers that still include this deleted
header?

One of the remaining Risc PC drivers left in the tree still tries to include
it:

drivers/ata/pata_icside.c:
    #include <asm/ecard.h>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908152808.3928630-1-arnd@kernel.org?part=3