From: "Arnd Bergmann" <arnd@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
"Damien Le Moal" <dlemoal@kernel.org>,
linux-rtc@vger.kernel.org,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Frank Li" <Frank.Li@kernel.org>,
linux-pci@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
imx@lists.linux.dev, "Niklas Cassel" <cassel@kernel.org>,
linux-ide@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 05/13] ARM: orion/dove/mv78xx0: remove all board files
Date: Tue, 08 Sep 2026 20:21:39 +0200 [thread overview]
Message-ID: <71266564-7be5-4621-ab03-29cf9ec49287@app.fastmail.com> (raw)
In-Reply-To: <20260908161125.E4A331F00A3A@smtp.kernel.org>
On Tue, Sep 8, 2026, at 18:11, sashiko-bot@kernel.org wrote:
> [Severity: Low]
> Since all the board files like arch/arm/mach-orion5x/ts78xx-setup.c are
> removed in this patch, should the MAINTAINERS entry for the TS-78xx platform
> further down in this file also be removed?
>
> The pattern F: arch/arm/mach-orion5x/ts78xx-* now points to deleted files,
> which leaves an orphaned entry for Alexander Clouter.
I fixed this instance now. I tried to automate this with a script
but could not figure out how to deal with wildcard matches and
only did the ones that have an exact file match.
If anyone has suggestions for doing this better, please let me know,
or run your script on
https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=board-remove-7.3
and send me the results.
> [ ... ]
>
>> diff --git a/arch/arm/mach-orion5x/Makefile b/arch/arm/mach-orion5x/Makefile
>> index 6f54d7fef27a7..7e9634e043185 100644
>> --- a/arch/arm/mach-orion5x/Makefile
>> +++ b/arch/arm/mach-orion5x/Makefile
>> @@ -2,15 +2,6 @@
>> ccflags-y := -I$(srctree)/arch/arm/plat-orion/include
>>
>> obj-y += common.o pci.o irq.o mpp.o
>> -obj-$(CONFIG_MACH_KUROBOX_PRO) += kurobox_pro-setup.o
>> -obj-$(CONFIG_MACH_TERASTATION_PRO2) += terastation_pro2-setup.o
>
> [Severity: Low]
> Are irq.o and mpp.o now completely unreachable code?
>
> Since all the board files that called into these APIs have been removed,
> it appears these objects are now unnecessarily compiled into the kernel
> image. Should they be removed from obj-y here?
Added this to the patch, removing the two files and recursively
seven more that become orphaned afterwards:
arch/arm/mach-orion5x/Makefile | 2 +-
arch/arm/mach-orion5x/irq.c | 51 ---
arch/arm/mach-orion5x/irqs.h | 9 -
arch/arm/mach-orion5x/mpp.c | 41 --
arch/arm/mach-orion5x/mpp.h | 130 ------
arch/arm/plat-orion/Makefile | 4 +-
arch/arm/plat-orion/gpio.c | 616 --------------------------
arch/arm/plat-orion/include/plat/irq.h | 15 -
arch/arm/plat-orion/include/plat/mpp.h | 34 --
arch/arm/plat-orion/include/plat/orion-gpio.h | 38 --
arch/arm/plat-orion/irq.c | 39 --
arch/arm/plat-orion/mpp.c | 82 ----
13 files changed, 2 insertions(+), 1066 deletions(-)
This leaves only pcie.{c,h} in arch/arm/plat-orion/, which
should be folded into arch/arm/mach-orion5x/pci.c, along
with parts of arch/arm/kernel/bios32.c that nothing else
uses any more. I don't have a patch for that yet.
Arnd
next prev parent reply other threads:[~2026-09-08 18:22 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 15:27 [PATCH 00/13] ARM: deprecated platform removal Arnd Bergmann
2026-09-08 15:27 ` [PATCH 01/13] ARM: remove sa1100 platform Arnd Bergmann
2026-09-08 16:26 ` Guenter Roeck
2026-09-08 17:23 ` Linus Walleij
2026-09-08 19:39 ` Karl Mehltretter
2026-09-08 20:09 ` Arnd Bergmann
2026-09-08 20:36 ` Nicolas Pitre
2026-09-08 21:26 ` David Laight
2026-09-08 21:32 ` Arnd Bergmann
2026-09-09 12:38 ` Alexandre Belloni
2026-09-08 15:27 ` [PATCH 02/13] ARM: remove footbridge Arnd Bergmann
2026-09-08 15:55 ` sashiko-bot
2026-09-08 17:57 ` Arnd Bergmann
2026-09-08 17:27 ` Linus Walleij
2026-09-09 15:09 ` Ralph Siemsen
2026-09-08 15:27 ` [PATCH 03/13] ARM: remove riscpc Arnd Bergmann
2026-09-08 15:52 ` sashiko-bot
2026-09-08 16:10 ` Arnd Bergmann
2026-09-09 8:04 ` Thomas Zimmermann
2026-09-09 16:42 ` Bart Van Assche
2026-09-09 20:09 ` Arnd Bergmann
2026-09-11 3:44 ` Ethan Nelson-Moore
2026-09-11 9:07 ` Linus Walleij
2026-09-11 13:25 ` Bart Van Assche
2026-09-11 13:37 ` Linus Walleij
2026-09-11 14:38 ` Daniel Palmer
2026-09-11 18:14 ` Linus Walleij
2026-09-12 1:29 ` Daniel Palmer
2026-09-11 18:42 ` Karl Mehltretter
2026-09-12 2:08 ` Ethan Nelson-Moore
2026-09-12 3:59 ` Ethan Nelson-Moore
2026-09-08 15:27 ` [PATCH 04/13] ARM: remove legacy pxa board files Arnd Bergmann
2026-09-08 16:01 ` sashiko-bot
2026-09-08 18:06 ` Arnd Bergmann
2026-09-08 17:30 ` Linus Walleij
2026-09-08 18:32 ` Daniel Mack
2026-09-08 15:27 ` [PATCH 05/13] ARM: orion/dove/mv78xx0: remove all " Arnd Bergmann
2026-09-08 15:34 ` Mark Brown
2026-09-08 16:11 ` sashiko-bot
2026-09-08 18:21 ` Arnd Bergmann [this message]
2026-09-09 12:42 ` [PATCH 05.2/13] ARM: orion5x: fold plat-orion/pcie.c and hw_pci into pci.c Arnd Bergmann
2026-09-08 16:12 ` [PATCH 05/13] ARM: orion/dove/mv78xx0: remove all board files Ulf Hansson
2026-09-08 16:18 ` Andrew Lunn
2026-09-08 17:33 ` Linus Walleij
2026-09-08 20:14 ` Niklas Cassel
2026-09-09 12:54 ` Gregory CLEMENT
2026-09-11 10:22 ` Daniel Lezcano
2026-09-08 15:27 ` [PATCH 06/13] ARM: omap2: remove omap24xx support Arnd Bergmann
2026-09-08 17:18 ` Aaro Koskinen
2026-09-08 17:35 ` Linus Walleij
2026-09-08 19:21 ` Karl Mehltretter
2026-09-08 19:42 ` Arnd Bergmann
2026-09-09 8:06 ` Thomas Zimmermann
2026-09-08 15:27 ` [PATCH 07/13] ARM: imx: remove i.MX31 SoC support Arnd Bergmann
2026-09-08 16:05 ` sashiko-bot
2026-09-08 18:01 ` Arnd Bergmann
2026-09-09 8:24 ` Vladimir Zapolskiy
2026-09-09 8:26 ` Daniel Baluta
2026-09-10 15:11 ` Frank Li
2026-09-08 15:27 ` [PATCH 08/13] ARM: imx: remove nommu support Arnd Bergmann
2026-09-08 15:43 ` sashiko-bot
2026-09-09 20:17 ` Fabio Estevam
2026-09-09 20:21 ` Fabio Estevam
2026-09-10 13:08 ` Jesse T
2026-09-10 16:08 ` Giulio Benetti
2026-09-10 15:14 ` Frank Li
2026-09-08 15:27 ` [PATCH 09/13] ARM: lpc18xx: remove entire platform Arnd Bergmann
2026-09-08 15:41 ` sashiko-bot
2026-09-08 15:43 ` Arnd Bergmann
2026-09-08 17:36 ` Linus Walleij
2026-09-09 8:28 ` Vladimir Zapolskiy
2026-09-08 15:28 ` [PATCH 10/13] ARM: stm32: remove stm32f4/f7/h7 MCU support Arnd Bergmann
2026-09-08 15:43 ` sashiko-bot
2026-09-08 15:54 ` Arnd Bergmann
2026-09-08 17:36 ` Linus Walleij
2026-09-11 15:46 ` Alexandre TORGUE
2026-09-08 15:28 ` [PATCH 11/13] ARM: versatile: remove mps2 support Arnd Bergmann
2026-09-08 15:41 ` Vladimir Murzin
2026-09-08 15:51 ` sashiko-bot
2026-09-08 17:37 ` Linus Walleij
2026-09-08 19:49 ` Sudeep Holla
2026-09-08 19:51 ` Arnd Bergmann
2026-09-08 19:58 ` Sudeep Holla
2026-09-08 19:54 ` Sudeep Holla
2026-09-08 15:28 ` [PATCH 12/13] ARM: at91: remove samv7 support Arnd Bergmann
2026-09-08 15:55 ` sashiko-bot
2026-09-08 16:40 ` Arnd Bergmann
2026-09-08 17:39 ` Linus Walleij
2026-09-08 21:09 ` Rob Herring
2026-09-08 21:30 ` Arnd Bergmann
2026-09-10 12:25 ` Nicolas Ferre
2026-09-09 12:41 ` Alexandre Belloni
2026-09-10 12:23 ` Nicolas Ferre
2026-09-08 15:28 ` [PATCH 13/13] ARM: axxia: remove entire platform Arnd Bergmann
2026-09-08 15:55 ` sashiko-bot
2026-09-08 17:40 ` Linus Walleij
2026-09-08 18:23 ` Krzysztof Kozlowski
2026-09-08 16:53 ` [PATCH 00/13] ARM: deprecated platform removal Randy Dunlap
2026-09-08 16:56 ` Randy Dunlap
2026-09-08 18:33 ` Arnd Bergmann
2026-09-08 18:39 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71266564-7be5-4621-ab03-29cf9ec49287@app.fastmail.com \
--to=arnd@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox