Re: [PATCH 07/13] ARM: imx: remove i.MX31 SoC support

["Arnd Bergmann" <arnd@kernel.org>]

On Tue, Sep 8, 2026, at 18:05, sashiko-bot@kernel.org wrote:

>
> [Severity: Medium]
> Can the removal of CONFIG_DEBUG_IMX31_UART leave obsolete preprocessor blocks
> in header files?
>
> In arch/arm/include/debug/imx-uart.h, there is still a check for this
> symbol:
>
> #elif defined(CONFIG_DEBUG_IMX31_UART)
> #define UART_PADDR      IMX_DEBUG_UART_BASE(IMX31)
>
> Could this block now be dead code because the config symbol no longer exists?

Fixed now, I did script the search for unused Kconfig symbols,
but missed the DEBUG_IMX31_UART dependency as that was a later
addition to the series. I'll run those scripts again.

>
> [Severity: Medium]
> Could the removal of SOC_IMX31 orphan the hardware random number generator
> driver?
>
> In drivers/char/hw_random/Kconfig, HW_RANDOM_MXC_RNGA currently has:
>
> config HW_RANDOM_MXC_RNGA
> 	tristate "Freescale i.MX RNGA Random Number Generator"
> 	depends on SOC_IMX31 || COMPILE_TEST
>
> Since SOC_IMX31 is no longer defined, this driver can now only be selected
> via COMPILE_TEST.
>
> Is there also a risk of leaving dead code in the clock driver?
>
> In drivers/clk/imx/Kconfig, CLK_IMX31 has:
>
> config CLK_IMX31
> 	def_bool SOC_IMX31
>
> Could this convert the driver code into uncompilable dead code since
> SOC_IMX31 is removed?

These are all addressed in a later series.

> [Severity: Medium]
> Are there dangling declarations left behind in the subsystem headers?
>
> In arch/arm/mach-imx/common.h, these declarations still exist:
>
> void mx31_map_io(void);
> void imx31_init_early(void);
>
> Could these dead declarations be removed as well?

Fixed now.

       Arnd