Re: [PATCH 12/13] ARM: at91: remove samv7 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete cleanup of SAMV7, SAMS7, and SAME7 platform macros.
--

commit 0e6ee4e12ed1996bcca25e4e14e2ee5176bc2d17
Author: Arnd Bergmann <arnd@arndb.de>

ARM: at91: remove samv7 support

This commit removes support for the deprecated samv7 platform. It deletes
the platform initialization code, Kconfig entries, Makefile hooks, and
the corresponding SoC definitions in the atmel/soc driver.

> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index d89f9dcade7d2..e276f86326ec7 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -210,41 +210,6 @@ static const struct at91_soc socs[] __initconst = {
>  		 AT91_CIDR_VERSION_MASK, SAMA5D44_EXID_MATCH,
>  		 "sama5d44", "sama5d4"),
>  #endif
> -#ifdef CONFIG_SOC_SAMV7
> -	AT91_SOC(SAME70Q21_CIDR_MATCH, AT91_CIDR_MATCH_MASK,

[Severity: Low]
Since this removes the usages of SAME70Q21_CIDR_MATCH and the other SAMV7/SAME7
macros from the socs[] array, should the corresponding macro definitions also be
removed from drivers/soc/atmel/soc.h? They appear to be dead code after this
change.

> -		 AT91_CIDR_VERSION_MASK, SAME70Q21_EXID_MATCH,
> -		 "same70q21", "same7"),
> -	AT91_SOC(SAME70Q20_CIDR_MATCH, AT91_CIDR_MATCH_MASK,

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908152808.3928630-1-arnd@kernel.org?part=12