From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3.5/5] drm/i915: Do eLLC detection earlier
Date: Sun, 14 Jul 2013 13:37:02 -0700 [thread overview]
Message-ID: <20130714203702.GC30966@bwidawsk.net> (raw)
In-Reply-To: <20130713093944.GN6143@phenom.ffwll.local>
On Sat, Jul 13, 2013 at 11:39:44AM +0200, Daniel Vetter wrote:
> On Thu, Jul 04, 2013 at 11:42:46AM -0700, Ben Widawsky wrote:
> > We need it before we set the pte_encode function pointers, which happens
> > really early, in gtt_init.
> >
> > The problem with just doing the normal sequence earlier is we don't have
> > the ability to use forcewake until after the pte functions have been set
> > up.
> >
> > Since all solutions are somewhat ugly (barring rewriting all the init
> > ordering), I've opted to do the detection really early, and the enabling
> > later - since the register to detect doesn't require forcewake.
> >
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> Looking at patch 3.5 here and patch 3 I think those should be squashed
> together. Ok if I do that when applying?
> -Daniel
Of course.
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-07-14 20:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 18:02 [PATCH 1/5] drm/i915/hsw: Set correct Haswell PTE encodings Ben Widawsky
2013-07-04 18:02 ` [PATCH 2/5] drm/i915: Define some of the eLLC magic Ben Widawsky
2013-07-13 0:02 ` Rodrigo Vivi
2013-07-14 20:36 ` Ben Widawsky
2013-07-04 18:02 ` [PATCH 3/5] drm/i915: store eLLC size Ben Widawsky
2013-07-04 18:42 ` [PATCH 3.5/5] drm/i915: Do eLLC detection earlier Ben Widawsky
2013-07-13 0:04 ` Rodrigo Vivi
2013-07-13 9:39 ` Daniel Vetter
2013-07-14 20:37 ` Ben Widawsky [this message]
2013-07-16 6:02 ` [PATCH 3/5] drm/i915: store eLLC size Daniel Vetter
2013-07-04 18:02 ` [PATCH 4/5] drm/i915: Use eLLC/LLC by default when available Ben Widawsky
2013-07-04 18:17 ` Daniel Vetter
2013-07-04 18:40 ` Ben Widawsky
2013-07-13 0:08 ` Rodrigo Vivi
2013-07-04 18:02 ` [PATCH 5/5] drm/i915: debugfs entries for [e]LLC Ben Widawsky
2013-07-04 18:14 ` Daniel Vetter
2013-07-04 18:40 ` Ben Widawsky
2013-07-04 18:43 ` Daniel Vetter
2013-07-04 18:46 ` Ben Widawsky
2013-07-09 18:35 ` Chad Versace
2013-07-09 20:16 ` Ben Widawsky
2013-07-04 18:47 ` [PATCH 6/6] drm/i915: Add a param for eLLC size Ben Widawsky
2013-07-16 6:10 ` Daniel Vetter
2013-07-13 0:11 ` [PATCH 5/5] drm/i915: debugfs entries for [e]LLC Rodrigo Vivi
2013-07-13 0:00 ` [PATCH 1/5] drm/i915/hsw: Set correct Haswell PTE encodings Rodrigo Vivi
2013-07-14 20:34 ` Ben Widawsky
2013-07-15 14:16 ` Damien Lespiau
2013-07-15 14:23 ` Damien Lespiau
2013-07-15 16:54 ` Ben Widawsky
2013-07-16 6:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130714203702.GC30966@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox