* [PATCH] drm/i915: vlv: fix RPS interrupt mask setting
@ 2014-04-03 17:02 Imre Deak
2014-04-03 20:28 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Imre Deak @ 2014-04-03 17:02 UTC (permalink / raw)
To: intel-gfx
This typo may lead to missed RPS interrupts and as a result a too
low or too high frequency for the current workload. The interrupt mask
will be set properly at a subsequent GPU idle event, but can get
corrupted again at the next RPS up/down event.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 00e4c7e..ef334f6 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3159,7 +3159,7 @@ void valleyview_set_rps(struct drm_device *dev, u8 val)
if (val != dev_priv->rps.cur_freq)
vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val);
- I915_WRITE(GEN6_PMINTRMSK, val);
+ I915_WRITE(GEN6_PMINTRMSK, gen6_rps_pm_mask(dev_priv, val));
dev_priv->rps.cur_freq = val;
trace_intel_gpu_freq_change(vlv_gpu_freq(dev_priv, val));
--
1.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: vlv: fix RPS interrupt mask setting
2014-04-03 17:02 [PATCH] drm/i915: vlv: fix RPS interrupt mask setting Imre Deak
@ 2014-04-03 20:28 ` Chris Wilson
2014-04-03 21:10 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2014-04-03 20:28 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
On Thu, Apr 03, 2014 at 08:02:42PM +0300, Imre Deak wrote:
> This typo may lead to missed RPS interrupts and as a result a too
> low or too high frequency for the current workload. The interrupt mask
> will be set properly at a subsequent GPU idle event, but can get
> corrupted again at the next RPS up/down event.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Embarrassing. Really odd as I thought I just cut'n'paste that line.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/i915: vlv: fix RPS interrupt mask setting
2014-04-03 20:28 ` Chris Wilson
@ 2014-04-03 21:10 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2014-04-03 21:10 UTC (permalink / raw)
To: Chris Wilson, Imre Deak, intel-gfx
On Thu, Apr 03, 2014 at 09:28:34PM +0100, Chris Wilson wrote:
> On Thu, Apr 03, 2014 at 08:02:42PM +0300, Imre Deak wrote:
> > This typo may lead to missed RPS interrupts and as a result a too
> > low or too high frequency for the current workload. The interrupt mask
> > will be set properly at a subsequent GPU idle event, but can get
> > corrupted again at the next RPS up/down event.
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> Embarrassing. Really odd as I thought I just cut'n'paste that line.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Picked up for -fixes, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-03 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 17:02 [PATCH] drm/i915: vlv: fix RPS interrupt mask setting Imre Deak
2014-04-03 20:28 ` Chris Wilson
2014-04-03 21:10 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox