public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/tgl: Enabling DSC on Pipe A for TGL
@ 2019-08-23  0:46 Madhumitha Tolakanahalli Pradeep
  2019-08-23  0:59 ` Manasi Navare
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Madhumitha Tolakanahalli Pradeep @ 2019-08-23  0:46 UTC (permalink / raw)
  To: intel-gfx

DSC was not supported on Pipe A for previous platforms. Tigerlake onwards,
all the pipes support DSC. Hence, the DSC and FEC restriction on
Pipe A needs to be removed.

v2: Changes in the logic around removing the restriction around
    Pipe A (Manasi, Lucas)

Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4884c87c8ed7..e2c8fe274c84 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1739,8 +1739,14 @@ static bool intel_dp_source_supports_fec(struct intel_dp *intel_dp,
 {
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
 
-	return INTEL_GEN(dev_priv) >= 11 &&
-		pipe_config->cpu_transcoder != TRANSCODER_A;
+	/* On TGL, FEC is supported on all Pipes */
+	if (INTEL_GEN(dev_priv) >= 12)
+		return true;
+
+	if (IS_GEN(dev_priv, 11) && pipe_config->cpu_transcoder != TRANSCODER_A)
+		return true;
+
+	return false;
 }
 
 static bool intel_dp_supports_fec(struct intel_dp *intel_dp,
@@ -1755,8 +1761,15 @@ static bool intel_dp_source_supports_dsc(struct intel_dp *intel_dp,
 {
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
 
-	return INTEL_GEN(dev_priv) >= 10 &&
-		pipe_config->cpu_transcoder != TRANSCODER_A;
+	/* On TGL, DSC is supported on all Pipes */
+	if (INTEL_GEN(dev_priv) >= 12)
+		return true;
+
+	if (INTEL_GEN(dev_priv) >= 10 &&
+	    pipe_config->cpu_transcoder != TRANSCODER_A)
+		return true;
+
+	return false;
 }
 
 static bool intel_dp_supports_dsc(struct intel_dp *intel_dp,
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] drm/i915/tgl: Enabling DSC on Pipe A for TGL
@ 2019-08-14 23:51 Madhumitha Tolakanahalli Pradeep
  2019-08-15 18:24 ` Manasi Navare
  0 siblings, 1 reply; 11+ messages in thread
From: Madhumitha Tolakanahalli Pradeep @ 2019-08-14 23:51 UTC (permalink / raw)
  To: intel-gfx

Removing restriction on Pipe A as TigerLake onwards, all the pipes support DSC.

Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 4884c87c8ed7..a5b50f93fac5 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1739,8 +1739,12 @@ static bool intel_dp_source_supports_fec(struct intel_dp *intel_dp,
 {
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
 
-	return INTEL_GEN(dev_priv) >= 11 &&
-		pipe_config->cpu_transcoder != TRANSCODER_A;
+	/* On TGL, DSC is supported on all Pipes */
+	if (INTEL_GEN(dev_priv) >= 12)
+		return true;
+	else
+		return INTEL_GEN(dev_priv) == 11 &&
+			pipe_config->cpu_transcoder != TRANSCODER_A;
 }
 
 static bool intel_dp_supports_fec(struct intel_dp *intel_dp,
@@ -1755,8 +1759,12 @@ static bool intel_dp_source_supports_dsc(struct intel_dp *intel_dp,
 {
 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
 
-	return INTEL_GEN(dev_priv) >= 10 &&
-		pipe_config->cpu_transcoder != TRANSCODER_A;
+	/* On TGL, DSC is supported on all Pipes */
+	if (INTEL_GEN(dev_priv) >= 12)
+		return true;
+	else
+		return (INTEL_GEN(dev_priv) == 10 || INTEL_GEN(dev_priv) == 11) &&
+			pipe_config->cpu_transcoder != TRANSCODER_A;
 }
 
 static bool intel_dp_supports_dsc(struct intel_dp *intel_dp,
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-28 20:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-23  0:46 [PATCH] drm/i915/tgl: Enabling DSC on Pipe A for TGL Madhumitha Tolakanahalli Pradeep
2019-08-23  0:59 ` Manasi Navare
2019-08-23  1:56 ` ✓ Fi.CI.BAT: success for drm/i915/tgl: Enabling DSC on Pipe A for TGL (rev2) Patchwork
2019-08-23  8:50 ` [PATCH] drm/i915/tgl: Enabling DSC on Pipe A for TGL Lucas De Marchi
2019-08-23 19:59 ` ✗ Fi.CI.IGT: failure for drm/i915/tgl: Enabling DSC on Pipe A for TGL (rev2) Patchwork
2019-08-28 20:12 ` [PATCH] drm/i915/tgl: Enabling DSC on Pipe A for TGL Manasi Navare
  -- strict thread matches above, loose matches on Subject: below --
2019-08-14 23:51 Madhumitha Tolakanahalli Pradeep
2019-08-15 18:24 ` Manasi Navare
2019-08-15 18:39   ` Tolakanahalli Pradeep, Madhumitha
2019-08-15 18:53     ` Manasi Navare
2019-08-15 19:07       ` Tolakanahalli Pradeep, Madhumitha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox