Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 0/8] cdclk consolidation and rework for BXT-TGL
Date: Fri,  6 Sep 2019 17:21:35 -0700	[thread overview]
Message-ID: <20190907002143.22591-1-matthew.d.roper@intel.com> (raw)

cdclk design hasn't changed much from BXT onward, but we still have
a lot of different codepaths to handle the different platforms and in
some cases they've evolved in different directions.  Let's try to
consolidate some of the common logic where it makes sense.

We also have some functions that are basically code repesentations of
tables in the bspec.  As new cdclk values get added/removed from the
bspec over time, or new platforms get enabled, it's easy to overlook
some of the places that we need to update various functions to reflect
those changes.  Let's try to address this by including a more literal
representation of the bspec tables in the driver and adapting our driver
to parse those tables to get the values they need.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Matt Roper (8):
  drm/i915: Consolidate bxt/cnl/icl cdclk readout
  drm/i915: Use literal representation of cdclk tables
  drm/i915: Combine bxt_set_cdclk and cnl_set_cdclk
  drm/i915: Kill cnl_sanitize_cdclk()
  drm/i915: Consolidate {bxt,cnl,icl}_uninit_cdclk
  drm/i915: Add calc_voltage_level display vfunc
  drm/i915: Enhance cdclk sanitization
  drm/i915: Consolidate {bxt,cnl,icl}_init_cdclk

 drivers/gpu/drm/i915/display/intel_cdclk.c | 977 ++++++++-------------
 drivers/gpu/drm/i915/display/intel_cdclk.h |   8 +
 drivers/gpu/drm/i915/i915_drv.h            |   5 +
 3 files changed, 358 insertions(+), 632 deletions(-)

-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2019-09-07  0:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07  0:21 Matt Roper [this message]
2019-09-07  0:21 ` [PATCH 1/8] drm/i915: Consolidate bxt/cnl/icl cdclk readout Matt Roper
2019-09-10 12:27   ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 2/8] drm/i915: Use literal representation of cdclk tables Matt Roper
2019-09-08  2:57   ` Matt Roper
2019-09-08  4:05     ` Matt Roper
2019-09-10 12:56       ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 3/8] drm/i915: Combine bxt_set_cdclk and cnl_set_cdclk Matt Roper
2019-09-10 12:35   ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 4/8] drm/i915: Kill cnl_sanitize_cdclk() Matt Roper
2019-09-10 12:37   ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 5/8] drm/i915: Consolidate {bxt, cnl, icl}_uninit_cdclk Matt Roper
2019-09-10 12:39   ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 6/8] drm/i915: Add calc_voltage_level display vfunc Matt Roper
2019-09-10 12:41   ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 7/8] drm/i915: Enhance cdclk sanitization Matt Roper
2019-09-10 12:42   ` Ville Syrjälä
2019-09-07  0:21 ` [PATCH 8/8] drm/i915: Consolidate {bxt, cnl, icl}_init_cdclk Matt Roper
2019-09-10 12:44   ` Ville Syrjälä
2019-09-07  0:43 ` ✗ Fi.CI.CHECKPATCH: warning for cdclk consolidation and rework for BXT-TGL Patchwork
2019-09-07  1:31 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-09-08  3:17 ` ✗ Fi.CI.BUILD: failure for cdclk consolidation and rework for BXT-TGL (rev2) Patchwork
2019-09-08  4:23 ` ✗ Fi.CI.CHECKPATCH: warning for cdclk consolidation and rework for BXT-TGL (rev3) Patchwork
2019-09-08  4:48 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-08  5:57 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190907002143.22591-1-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox