public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com
Subject: [PATCH v9 7/8] drm/i915/display: Compute vrr vsync params
Date: Fri, 24 May 2024 15:54:31 +0530	[thread overview]
Message-ID: <20240524102432.2499104-8-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20240524102432.2499104-1-mitulkumar.ajitkumar.golani@intel.com>

Compute vrr vsync params in case of FAVT as well instead of
only to AVT mode of operation.

--v2:
- Remove redundant computation for vrr_vsync_start
and vrr_vsync_end(Ankit).

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 3fbedd7366bb..07be70f7c536 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -224,14 +224,6 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
 	if (crtc_state->uapi.vrr_enabled) {
 		crtc_state->vrr.enable = true;
 		crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
-		if (intel_dp_as_sdp_supported(intel_dp)) {
-			crtc_state->vrr.vsync_start =
-				(crtc_state->hw.adjusted_mode.crtc_vtotal -
-					crtc_state->hw.adjusted_mode.vsync_start);
-			crtc_state->vrr.vsync_end =
-				(crtc_state->hw.adjusted_mode.crtc_vtotal -
-					crtc_state->hw.adjusted_mode.vsync_end);
-		}
 	} else if (is_cmrr_frac_required(crtc_state, is_edp)) {
 		crtc_state->vrr.enable = true;
 		crtc_state->vrr.vmax = cmrr_get_vtotal(crtc_state);
@@ -240,6 +232,15 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
 		crtc_state->mode_flags |= I915_MODE_FLAG_VRR;
 	}
 
+	if (intel_dp_as_sdp_supported(intel_dp)) {
+		crtc_state->vrr.vsync_start =
+			(crtc_state->hw.adjusted_mode.crtc_vtotal -
+			 crtc_state->hw.adjusted_mode.vsync_start);
+		crtc_state->vrr.vsync_end =
+			(crtc_state->hw.adjusted_mode.crtc_vtotal -
+			 crtc_state->hw.adjusted_mode.vsync_end);
+	}
+
 	/*
 	 * For XE_LPD+, we use guardband and pipeline override
 	 * is deprecated.
-- 
2.25.1


  parent reply	other threads:[~2024-05-24 10:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 10:24 [PATCH v9 0/8] Implement CMRR Support Mitul Golani
2024-05-24 10:24 ` [PATCH v9 1/8] drm/i915: Define and compute Transcoder CMRR registers Mitul Golani
2024-05-27 10:50   ` Jani Nikula
2024-05-27 10:52     ` Jani Nikula
2024-05-24 10:24 ` [PATCH v9 2/8] drm/i915: Update trans_vrr_ctl flag when cmrr is computed Mitul Golani
2024-05-28  9:06   ` Nautiyal, Ankit K
2024-05-24 10:24 ` [PATCH v9 3/8] drm/i915: Compute CMRR and calculate vtotal Mitul Golani
2024-05-28  9:34   ` Nautiyal, Ankit K
2024-05-29 11:43     ` Nautiyal, Ankit K
2024-05-24 10:24 ` [PATCH v9 4/8] Add refresh rate divider to struct representing AS SDP Mitul Golani
2024-05-28  9:35   ` Nautiyal, Ankit K
2024-05-24 10:24 ` [PATCH v9 5/8] drm/i915/display: Add support for pack and unpack Mitul Golani
2024-05-28  9:37   ` Nautiyal, Ankit K
2024-05-24 10:24 ` [PATCH v9 6/8] drm/i915/display: Compute Adaptive sync SDP params Mitul Golani
2024-05-28  9:39   ` Nautiyal, Ankit K
2024-05-24 10:24 ` Mitul Golani [this message]
2024-05-24 10:24 ` [PATCH v9 8/8] drm/i915/display: Compute cmrr.enable flag Mitul Golani
2024-05-24 11:02 ` ✗ Fi.CI.CHECKPATCH: warning for Implement CMRR Support (rev9) Patchwork
2024-05-24 11:02 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-24 11:13 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-05-27 10:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-27 15:15 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240524102432.2499104-8-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox