From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 10/11] drm/i915/psr: Fix using wrong mask in REG_FIELD_PREP
Date: Tue, 20 May 2025 14:39:19 +0530 [thread overview]
Message-ID: <76442d63-3ad2-4e14-bb7e-6794089cbb8c@intel.com> (raw)
In-Reply-To: <20250502085902.154740-11-jouni.hogander@intel.com>
On 5/2/2025 2:29 PM, Jouni Högander wrote:
> Wrong mask is used in PORT_ALPM_LFPS_CTL_FIRST_LFPS_HALF_CYCLE_DURATION and
> PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION.
>
> Fixes: 295099580f04 ("drm/i915/psr: Add missing ALPM AUX-Less register definitions")
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr_regs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr_regs.h b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> index aad3ac5f502ed..8afbf5a383353 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr_regs.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr_regs.h
> @@ -335,8 +335,8 @@
> #define PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION_MASK REG_GENMASK(20, 16)
> #define PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION(val) REG_FIELD_PREP(PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION_MASK, val)
> #define PORT_ALPM_LFPS_CTL_FIRST_LFPS_HALF_CYCLE_DURATION_MASK REG_GENMASK(12, 8)
> -#define PORT_ALPM_LFPS_CTL_FIRST_LFPS_HALF_CYCLE_DURATION(val) REG_FIELD_PREP(PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION_MASK, val)
> +#define PORT_ALPM_LFPS_CTL_FIRST_LFPS_HALF_CYCLE_DURATION(val) REG_FIELD_PREP(PORT_ALPM_LFPS_CTL_FIRST_LFPS_HALF_CYCLE_DURATION_MASK, val)
> #define PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION_MASK REG_GENMASK(4, 0)
> -#define PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION(val) REG_FIELD_PREP(PORT_ALPM_LFPS_CTL_LFPS_HALF_CYCLE_DURATION_MASK, val)
> +#define PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION(val) REG_FIELD_PREP(PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION_MASK, val)
>
> #endif /* __INTEL_PSR_REGS_H__ */
next prev parent reply other threads:[~2025-05-20 9:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 8:58 [PATCH 00/11] Panel Replay + Adaptive sync Jouni Högander
2025-05-02 8:58 ` [PATCH 01/11] drm/dp: Add Panel Replay capability bits from DP2.1 specification Jouni Högander
2025-05-02 9:19 ` Jani Nikula
2025-05-02 9:28 ` Hogander, Jouni
2025-05-20 8:36 ` Nautiyal, Ankit K
2025-05-20 16:53 ` Hogander, Jouni
2025-05-02 8:58 ` [PATCH 02/11] drm/i915/psr: Read both Panel Replay capability registers from DPCD Jouni Högander
2025-05-20 8:45 ` Nautiyal, Ankit K
2025-05-20 16:54 ` Hogander, Jouni
2025-05-02 8:58 ` [PATCH 03/11] drm/i915/alpm: Add PR_ALPM_CTL register definitions Jouni Högander
2025-05-20 8:46 ` Nautiyal, Ankit K
2025-05-02 8:58 ` [PATCH 04/11] drm/i915/alpm: Write PR_ALPM_CTL register Jouni Högander
2025-05-20 8:49 ` Nautiyal, Ankit K
2025-05-20 16:55 ` Hogander, Jouni
2025-05-02 8:58 ` [PATCH 05/11] drm/i915/psr: Add interface to check if AUXLess ALPM is needed by PSR Jouni Högander
2025-05-20 8:52 ` Nautiyal, Ankit K
2025-05-20 9:19 ` Nautiyal, Ankit K
2025-05-20 16:56 ` Hogander, Jouni
2025-05-02 8:58 ` [PATCH 06/11] drm/i915/alpm: Add new interface to check if AUXLess ALPM is used Jouni Högander
2025-05-20 8:54 ` Nautiyal, Ankit K
2025-05-20 16:57 ` Hogander, Jouni
2025-05-02 8:58 ` [PATCH 07/11] drm/i915/alpm: Move port alpm configuration Jouni Högander
2025-05-20 9:00 ` Nautiyal, Ankit K
2025-05-20 16:59 ` Hogander, Jouni
2025-05-02 8:58 ` [PATCH 08/11] drm/i915/display: Add PHY_CMN1_CONTROL register definitions Jouni Högander
2025-05-20 9:01 ` Nautiyal, Ankit K
2025-05-02 8:59 ` [PATCH 09/11] drm/i915/display: Add function to configure LFPS sending Jouni Högander
2025-05-20 9:08 ` Nautiyal, Ankit K
2025-05-20 17:01 ` Hogander, Jouni
2025-05-02 8:59 ` [PATCH 10/11] drm/i915/psr: Fix using wrong mask in REG_FIELD_PREP Jouni Högander
2025-05-20 9:09 ` Nautiyal, Ankit K [this message]
2025-05-02 8:59 ` [PATCH 11/11] drm/i915/psr: Do not disable Panel Replay in case VRR is enabled Jouni Högander
2025-05-20 9:13 ` Nautiyal, Ankit K
2025-05-02 13:08 ` ✗ Fi.CI.CHECKPATCH: warning for Panel Replay + Adaptive sync Patchwork
2025-05-02 13:08 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-05-02 13:30 ` ✓ i915.CI.BAT: success " Patchwork
2025-05-02 18:19 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76442d63-3ad2-4e14-bb7e-6794089cbb8c@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox