Re: [PATCH 05/11] drm/i915/psr: Add interface to check if AUXLess ALPM is needed by PSR

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 5/20/2025 2:22 PM, Nautiyal, Ankit K wrote:
>
> On 5/2/2025 2:28 PM, Jouni Högander wrote:
>> Currently we spread ugly PSR details into ALPM code to check if AUXLess
>> ALPM is needed. Prepare to hide these details to PSR code by adding new
>> interface for checking if AUXLess ALPM is needed.
>>
>> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_psr.c | 14 ++++++++++++++
>>   drivers/gpu/drm/i915/display/intel_psr.h |  2 ++
>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c 
>> b/drivers/gpu/drm/i915/display/intel_psr.c
>> index 2d78d64b8db8d..8d8fe1c34479d 100644
>> --- a/drivers/gpu/drm/i915/display/intel_psr.c
>> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
>> @@ -4227,3 +4227,17 @@ bool intel_psr_needs_alpm(struct intel_dp 
>> *intel_dp, const struct intel_crtc_sta
>>       return intel_dp_is_edp(intel_dp) && (crtc_state->has_sel_update ||
>>                            crtc_state->has_panel_replay);
>>   }
>> +
>> +/**
>> + * intel_psr_needs_alpm_aux_less - Check if PSR needs ALPM AUXLess
>> + * @intel_dp: Intel DP
>> + * @crtc_state: CRTC status
>
> I think you mean crtc state.
>
>
>> + *
>> + * This returns true if PSR needs AUXLess ALPM. I.e. if it's Panel 
>> Replay in
>> + * eDP.
>
> Lets use `Return:` as per kernel docs.

Or we can just drop the kernel doc comments, and have regular comments 
for smaller helpers like this.

Same for the subsequent patches.

Regards,

Ankit

>
> Patch LGTM.
>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>
>> + */
>> +bool intel_psr_needs_alpm_aux_less(struct intel_dp *intel_dp,
>> +                   const struct intel_crtc_state *crtc_state)
>> +{
>> +    return intel_dp_is_edp(intel_dp) && crtc_state->has_panel_replay;
>> +}
>> diff --git a/drivers/gpu/drm/i915/display/intel_psr.h 
>> b/drivers/gpu/drm/i915/display/intel_psr.h
>> index 73c3fa40844bc..0cf53184f13f9 100644
>> --- a/drivers/gpu/drm/i915/display/intel_psr.h
>> +++ b/drivers/gpu/drm/i915/display/intel_psr.h
>> @@ -77,5 +77,7 @@ int intel_psr_min_vblank_delay(const struct 
>> intel_crtc_state *crtc_state);
>>   void intel_psr_connector_debugfs_add(struct intel_connector 
>> *connector);
>>   void intel_psr_debugfs_register(struct intel_display *display);
>>   bool intel_psr_needs_alpm(struct intel_dp *intel_dp, const struct 
>> intel_crtc_state *crtc_state);
>> +bool intel_psr_needs_alpm_aux_less(struct intel_dp *intel_dp,
>> +                   const struct intel_crtc_state *crtc_state);
>>     #endif /* __INTEL_PSR_H__ */