Re: [Intel-gfx] [PATCH 4/4] drm/i915: Move the SDP split debug spew to the correct place

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2023-11-22 at 11:31 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Adding ad-hoc debug prints all over the place is not good.
> Move the SDP split debug spew into the proper place (state
> dumper).
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 3 +++
>  drivers/gpu/drm/i915/display/intel_dp.c              | 7 -------
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index 5bcdbf083281..e62afd298191 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -263,6 +263,9 @@ void intel_crtc_state_dump(const struct
> intel_crtc_state *pipe_config,
>                             str_enabled_disabled(pipe_config-
> >fec_enable),
>                             str_enabled_disabled(pipe_config-
> >enhanced_framing));
>  
> +               drm_dbg_kms(&i915->drm, "sdp split: %s\n",
> +                           str_enabled_disabled(pipe_config-
> >sdp_split_enable));
> +
>                 drm_dbg_kms(&i915->drm, "psr: %s, psr2: %s, selective
> fetch: %s\n",
>                             str_enabled_disabled(pipe_config-
> >has_psr),
>                             str_enabled_disabled(pipe_config-
> >has_psr2),
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 1422c2370269..c6e3fe8b75d3 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2844,19 +2844,12 @@ intel_dp_audio_compute_config(struct
> intel_encoder *encoder,
>                               struct intel_crtc_state *pipe_config,
>                               struct drm_connector_state *conn_state)
>  {
> -       struct drm_i915_private *i915 = to_i915(encoder->base.dev);
> -       struct drm_connector *connector = conn_state->connector;
> -
>         pipe_config->has_audio =
>                 intel_dp_has_audio(encoder, pipe_config, conn_state)
> &&
>                 intel_audio_compute_config(encoder, pipe_config,
> conn_state);
>  
>         pipe_config->sdp_split_enable = pipe_config->has_audio &&
>                                         intel_dp_is_uhbr(pipe_config)
> ;
> -
> -       drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] SDP split enable:
> %s\n",
> -                   connector->base.id, connector->name,
> -                   str_yes_no(pipe_config->sdp_split_enable));
>  }
>  
>  int