* [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-08-28 6:19 [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add support for mailbox #5 EDID Jani Nikula
@ 2020-08-28 6:19 ` Jani Nikula
2020-08-31 7:59 ` Shankar, Uma
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2020-08-28 6:19 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
If a panel's EDID is broken, there may be an override EDID set in the
ACPI OpRegion mailbox #5. Use it if available.
Cc: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index c57ac83bf563..d1307be196a2 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
goto out_vdd_off;
}
+ /* Set up override EDID, if any, from ACPI OpRegion */
+ intel_opregion_edid_override(intel_connector);
+
mutex_lock(&dev->mode_config.mutex);
edid = drm_get_edid(connector, &intel_dp->aux.ddc);
if (edid) {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-08-28 6:19 ` [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available Jani Nikula
@ 2020-08-31 7:59 ` Shankar, Uma
0 siblings, 0 replies; 8+ messages in thread
From: Shankar, Uma @ 2020-08-31 7:59 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx@lists.freedesktop.org; +Cc: Nikula, Jani
> -----Original Message-----
> From: Jani Nikula <jani.nikula@intel.com>
> Sent: Friday, August 28, 2020 11:50 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
> <uma.shankar@intel.com>
> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if
> available
>
> If a panel's EDID is broken, there may be an override EDID set in the ACPI
> OpRegion mailbox #5. Use it if available.
Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index c57ac83bf563..d1307be196a2 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct intel_dp
> *intel_dp,
> goto out_vdd_off;
> }
>
> + /* Set up override EDID, if any, from ACPI OpRegion */
> + intel_opregion_edid_override(intel_connector);
> +
> mutex_lock(&dev->mode_config.mutex);
> edid = drm_get_edid(connector, &intel_dp->aux.ddc);
> if (edid) {
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
@ 2020-10-12 8:37 Lee, Shawn C
2020-10-12 9:09 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Lee, Shawn C @ 2020-10-12 8:37 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Shankar, Uma; +Cc: Nikula, Jani
On Fri, Aug 28, 2020 at 06:19AM, Shankar Uma wrote:
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula@intel.com>
>> Sent: Friday, August 28, 2020 11:50 AM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
>> <uma.shankar@intel.com>
>> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if
>> available
>>
>> If a panel's EDID is broken, there may be an override EDID set in the ACPI
>> OpRegion mailbox #5. Use it if available.
>
>Looks Good to me.
>Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>
>> Cc: Uma Shankar <uma.shankar@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>> b/drivers/gpu/drm/i915/display/intel_dp.c
>> index c57ac83bf563..d1307be196a2 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct intel_dp
>> *intel_dp,
>> goto out_vdd_off;
>> }
>>
>> + /* Set up override EDID, if any, from ACPI OpRegion */
>> + intel_opregion_edid_override(intel_connector);
>> +
Customer report DUT still get EDID from eDP panel instead of mailbox #5.
After some investigations, this change can retrieve EDID from mailbox #5 properly.
But driver still used panel's EDID to enable eDP display. This is because of drm_get_edid()
was executed after intel_opregion_edid_override(). drm_get_edid() return panel's EDID
and overwrite mailbox #5's.
We try to move drm_get_edid() before intel_opregion_edid_override().
The test result is positive, mailbox #5 EDID will substitute for panel's.
It seems we may need some additional change for this patch. Thanks!
Best regards,
Shawn
>> mutex_lock(&dev->mode_config.mutex);
>> edid = drm_get_edid(connector, &intel_dp->aux.ddc);
>> if (edid) {
>> --
>> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-10-12 8:37 [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available Lee, Shawn C
@ 2020-10-12 9:09 ` Jani Nikula
2020-10-13 9:56 ` Lee, Shawn C
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2020-10-12 9:09 UTC (permalink / raw)
To: 20200828061941.17051-2-jani.nikula@intel.com,
intel-gfx@lists.freedesktop.org, Shankar, Uma
On Mon, 12 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> On Fri, Aug 28, 2020 at 06:19AM, Shankar Uma wrote:
>>> -----Original Message-----
>>> From: Jani Nikula <jani.nikula@intel.com>
>>> Sent: Friday, August 28, 2020 11:50 AM
>>> To: intel-gfx@lists.freedesktop.org
>>> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
>>> <uma.shankar@intel.com>
>>> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if
>>> available
>>>
>>> If a panel's EDID is broken, there may be an override EDID set in the ACPI
>>> OpRegion mailbox #5. Use it if available.
>>
>>Looks Good to me.
>>Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>>
>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>>> b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index c57ac83bf563..d1307be196a2 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct intel_dp
>>> *intel_dp,
>>> goto out_vdd_off;
>>> }
>>>
>>> +/* Set up override EDID, if any, from ACPI OpRegion */
>>> +intel_opregion_edid_override(intel_connector);
>>> +
>
> Customer report DUT still get EDID from eDP panel instead of mailbox #5.
> After some investigations, this change can retrieve EDID from mailbox #5 properly.
> But driver still used panel's EDID to enable eDP display. This is because of drm_get_edid()
> was executed after intel_opregion_edid_override(). drm_get_edid() return panel's EDID
> and overwrite mailbox #5's.
In recent kernels, drm_get_edid() respects EDID override, and calling
drm_get_edid() will return the override EDID from mailbox #5 instead of
retrieving the actual EDID.
Check the kernel version they're using and the drm_get_edid()
implementation.
BR,
Jani.
>
> We try to move drm_get_edid() before intel_opregion_edid_override().
> The test result is positive, mailbox #5 EDID will substitute for panel's.
> It seems we may need some additional change for this patch. Thanks!
>
> Best regards,
> Shawn
>
>>> mutex_lock(&dev->mode_config.mutex);
>>> edid = drm_get_edid(connector, &intel_dp->aux.ddc);
>>> if (edid) {
>>> --
>>> 2.20.1
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-10-12 9:09 ` Jani Nikula
@ 2020-10-13 9:56 ` Lee, Shawn C
2020-10-13 11:03 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Lee, Shawn C @ 2020-10-13 9:56 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx@lists.freedesktop.org, Shankar, Uma
On Mon, Oct 12, 2020 at 5:09 PM, Jani Nikula wrote:
>On Mon, 12 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>> On Fri, Aug 28, 2020 at 06:19AM, Shankar Uma wrote:
>>>> -----Original Message-----
>>>> From: Jani Nikula <jani.nikula@intel.com>
>>>> Sent: Friday, August 28, 2020 11:50 AM
>>>> To: intel-gfx@lists.freedesktop.org
>>>> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
>>>> <uma.shankar@intel.com>
>>>> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for
>>>> eDP, if available
>>>>
>>>> If a panel's EDID is broken, there may be an override EDID set in
>>>> the ACPI OpRegion mailbox #5. Use it if available.
>>>
>>>Looks Good to me.
>>>Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>>>
>>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>>>> b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> index c57ac83bf563..d1307be196a2 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct
>>>> intel_dp *intel_dp, goto out_vdd_off; }
>>>>
>>>> +/* Set up override EDID, if any, from ACPI OpRegion */
>>>> +intel_opregion_edid_override(intel_connector);
>>>> +
>>
>> Customer report DUT still get EDID from eDP panel instead of mailbox #5.
>> After some investigations, this change can retrieve EDID from mailbox #5 properly.
>> But driver still used panel's EDID to enable eDP display. This is
>> because of drm_get_edid() was executed after
>> intel_opregion_edid_override(). drm_get_edid() return panel's EDID and overwrite mailbox #5's.
>
>In recent kernels, drm_get_edid() respects EDID override, and calling
>drm_get_edid() will return the override EDID from mailbox #5 instead of retrieving the actual EDID.
>
>Check the kernel version they're using and the drm_get_edid() implementation.
>
>BR,
>Jani.
>
Just confirm customer is using kernel v5.8. Seems drm_edid.c already include
the change for override_edid.
BTW. override_edid should be "true" and used to over EDID in intel_opregion_edid_override() in patch 1. Right?
But it is "false" in the patch 1.
+ connector->override_edid = false;
Best regards,
Shawn
>
>>
>> We try to move drm_get_edid() before intel_opregion_edid_override().
>> The test result is positive, mailbox #5 EDID will substitute for panel's.
>> It seems we may need some additional change for this patch. Thanks!
>>
>> Best regards,
>> Shawn
>>
>>>> mutex_lock(&dev->mode_config.mutex);
>>>> edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) {
>>>> --
>>>> 2.20.1
>
>--
>Jani Nikula, Intel Open Source Graphics Center
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-10-13 9:56 ` Lee, Shawn C
@ 2020-10-13 11:03 ` Jani Nikula
2020-10-14 14:11 ` Lee, Shawn C
0 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2020-10-13 11:03 UTC (permalink / raw)
To: 20200828061941.17051-2-jani.nikula@intel.com,
intel-gfx@lists.freedesktop.org, Shankar, Uma
On Tue, 13 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> On Mon, Oct 12, 2020 at 5:09 PM, Jani Nikula wrote:
>>On Mon, 12 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>>> On Fri, Aug 28, 2020 at 06:19AM, Shankar Uma wrote:
>>>>> -----Original Message-----
>>>>> From: Jani Nikula <jani.nikula@intel.com>
>>>>> Sent: Friday, August 28, 2020 11:50 AM
>>>>> To: intel-gfx@lists.freedesktop.org
>>>>> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
>>>>> <uma.shankar@intel.com>
>>>>> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for
>>>>> eDP, if available
>>>>>
>>>>> If a panel's EDID is broken, there may be an override EDID set in
>>>>> the ACPI OpRegion mailbox #5. Use it if available.
>>>>
>>>>Looks Good to me.
>>>>Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>>>>
>>>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>>> ---
>>>>> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> index c57ac83bf563..d1307be196a2 100644
>>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct
>>>>> intel_dp *intel_dp, goto out_vdd_off; }
>>>>>
>>>>> +/* Set up override EDID, if any, from ACPI OpRegion */
>>>>> +intel_opregion_edid_override(intel_connector);
>>>>> +
>>>
>>> Customer report DUT still get EDID from eDP panel instead of mailbox #5.
>>> After some investigations, this change can retrieve EDID from mailbox #5 properly.
>>> But driver still used panel's EDID to enable eDP display. This is
>>> because of drm_get_edid() was executed after
>>> intel_opregion_edid_override(). drm_get_edid() return panel's EDID and overwrite mailbox #5's.
>>
>>In recent kernels, drm_get_edid() respects EDID override, and calling
>>drm_get_edid() will return the override EDID from mailbox #5 instead of retrieving the actual EDID.
>>
>>Check the kernel version they're using and the drm_get_edid() implementation.
>>
>>BR,
>>Jani.
>>
>
> Just confirm customer is using kernel v5.8. Seems drm_edid.c already include
> the change for override_edid.
>
> BTW. override_edid should be "true" and used to over EDID in intel_opregion_edid_override() in patch 1. Right?
> But it is "false" in the patch 1.
>
> +connector->override_edid = false;
>
+
+ connector->override_edid = false;
+ ret = drm_connector_update_edid_property(connector, edid);
+ if (ret)
+ return;
+
+ connector->override_edid = true;
+ drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s]\n",
+ connector->base.id, connector->name);
http://lore.kernel.org/r/20200831083657.15600-1-jani.nikula@intel.com
BR,
Jani.
> Best regards,
> Shawn
>
>>
>>>
>>> We try to move drm_get_edid() before intel_opregion_edid_override().
>>> The test result is positive, mailbox #5 EDID will substitute for panel's.
>>> It seems we may need some additional change for this patch. Thanks!
>>>
>>> Best regards,
>>> Shawn
>>>
>>>>> mutex_lock(&dev->mode_config.mutex);
>>>>> edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) {
>>>>> --
>>>>> 2.20.1
>>
>>--
>>Jani Nikula, Intel Open Source Graphics Center
>>_______________________________________________
>>Intel-gfx mailing list
>>Intel-gfx@lists.freedesktop.org
>>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-10-13 11:03 ` Jani Nikula
@ 2020-10-14 14:11 ` Lee, Shawn C
2020-10-14 14:14 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Lee, Shawn C @ 2020-10-14 14:11 UTC (permalink / raw)
To: Nikula, Jani, 20200828061941.17051-2-jani.nikula@intel.com,
intel-gfx@lists.freedesktop.org, Shankar, Uma
On Tue, Oct 13, 2020 at 7:05 PM, Jani Nikula wrote:
>On Tue, 13 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>> On Mon, Oct 12, 2020 at 5:09 PM, Jani Nikula wrote:
>>>On Mon, 12 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
>>>> On Fri, Aug 28, 2020 at 06:19AM, Shankar Uma wrote:
>>>>>> -----Original Message-----
>>>>>> From: Jani Nikula <jani.nikula@intel.com>
>>>>>> Sent: Friday, August 28, 2020 11:50 AM
>>>>>> To: intel-gfx@lists.freedesktop.org
>>>>>> Cc: Nikula, Jani <jani.nikula@intel.com>; Shankar, Uma
>>>>>> <uma.shankar@intel.com>
>>>>>> Subject: [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for
>>>>>> eDP, if available
>>>>>>
>>>>>> If a panel's EDID is broken, there may be an override EDID set in
>>>>>> the ACPI OpRegion mailbox #5. Use it if available.
>>>>>
>>>>>Looks Good to me.
>>>>>Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>>>>>
>>>>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>>>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>>>>> ---
>>>>>> drivers/gpu/drm/i915/display/intel_dp.c | 3 +++
>>>>>> 1 file changed, 3 insertions(+)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> index c57ac83bf563..d1307be196a2 100644
>>>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> @@ -8114,6 +8114,9 @@ static bool intel_edp_init_connector(struct
>>>>>> intel_dp *intel_dp, goto out_vdd_off; }
>>>>>>
>>>>>> +/* Set up override EDID, if any, from ACPI OpRegion */
>>>>>> +intel_opregion_edid_override(intel_connector);
>>>>>> +
>>>>
>>>> Customer report DUT still get EDID from eDP panel instead of mailbox #5.
>>>> After some investigations, this change can retrieve EDID from mailbox #5 properly.
>>>> But driver still used panel's EDID to enable eDP display. This is
>>>> because of drm_get_edid() was executed after
>>>> intel_opregion_edid_override(). drm_get_edid() return panel's EDID and overwrite mailbox #5's.
>>>
>>>In recent kernels, drm_get_edid() respects EDID override, and calling
>>>drm_get_edid() will return the override EDID from mailbox #5 instead of retrieving the actual EDID.
>>>
>>>Check the kernel version they're using and the drm_get_edid() implementation.
>>>
>>>BR,
>>>Jani.
>>>
>>
>> Just confirm customer is using kernel v5.8. Seems drm_edid.c already
>> include the change for override_edid.
>>
>> BTW. override_edid should be "true" and used to over EDID in intel_opregion_edid_override() in patch 1. Right?
>> But it is "false" in the patch 1.
>>
>> +connector->override_edid = false;
>>
>
>
>+
>+ connector->override_edid = false;
>+ ret = drm_connector_update_edid_property(connector, edid);
>+ if (ret)
>+ return;
>+
>+ connector->override_edid = true;
>+ drm_dbg_kms(&i915->drm, "Using OpRegion EDID for [CONNECTOR:%d:%s]\n",
>+ connector->base.id, connector->name);
>
>
>http://lore.kernel.org/r/20200831083657.15600-1-jani.nikula@intel.com
>
>BR,
>Jani.
>
I think I got the problem now. The patch you attached is correct.
http://lore.kernel.org/r/20200831083657.15600-1-jani.nikula@intel.com
But customer refer to below patch without "override_edid = true".
https://patchwork.freedesktop.org/patch/388309/?series=81121&rev=1
This is why they can't get EDID from mailbox #5 properly.
Best regards,
Shawn
>
>
>> Best regards,
>> Shawn
>>
>>>
>>>>
>>>> We try to move drm_get_edid() before intel_opregion_edid_override().
>>>> The test result is positive, mailbox #5 EDID will substitute for panel's.
>>>> It seems we may need some additional change for this patch. Thanks!
>>>>
>>>> Best regards,
>>>> Shawn
>>>>
>>>>>> mutex_lock(&dev->mode_config.mutex);
>>>>>> edid = drm_get_edid(connector, &intel_dp->aux.ddc); if (edid) {
>>>>>> --
>>>>>> 2.20.1
>>>
>>>--
>>>Jani Nikula, Intel Open Source Graphics Center
>>>_______________________________________________
>>>Intel-gfx mailing list
>>>Intel-gfx@lists.freedesktop.org
>>>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Jani Nikula, Intel Open Source Graphics Center _______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available
2020-10-14 14:11 ` Lee, Shawn C
@ 2020-10-14 14:14 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2020-10-14 14:14 UTC (permalink / raw)
To: Lee, Shawn C, 20200828061941.17051-2-jani.nikula@intel.com,
intel-gfx@lists.freedesktop.org, Shankar, Uma
On Wed, 14 Oct 2020, "Lee, Shawn C" <shawn.c.lee@intel.com> wrote:
> I think I got the problem now. The patch you attached is correct.
> http://lore.kernel.org/r/20200831083657.15600-1-jani.nikula@intel.com
>
> But customer refer to below patch without "override_edid = true".
> https://patchwork.freedesktop.org/patch/388309/?series=81121&rev=1
>
> This is why they can't get EDID from mailbox #5 properly.
Yeah, there was that bug in v1 of the patch.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-10-14 14:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-12 8:37 [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available Lee, Shawn C
2020-10-12 9:09 ` Jani Nikula
2020-10-13 9:56 ` Lee, Shawn C
2020-10-13 11:03 ` Jani Nikula
2020-10-14 14:11 ` Lee, Shawn C
2020-10-14 14:14 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2020-08-28 6:19 [Intel-gfx] [PATCH 1/2] drm/i915/opregion: add support for mailbox #5 EDID Jani Nikula
2020-08-28 6:19 ` [Intel-gfx] [PATCH 2/2] drm/i915/dp: use opregion mailbox #5 EDID for eDP, if available Jani Nikula
2020-08-31 7:59 ` Shankar, Uma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox