* [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
@ 2023-05-12 23:56 Vinay Belgaumkar
2023-05-13 0:39 ` Dixit, Ashutosh
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Vinay Belgaumkar @ 2023-05-12 23:56 UTC (permalink / raw)
To: intel-gfx, dri-devel
rps_boost debugfs shows host turbo related info. This is not valid
when SLPC is enabled. guc_slpc_info already shows the number of boosts.
Add num_waiters there as well and disable rps_boost when SLPC is
enabled.
Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 ++++-
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
index 80dbbef86b1d..357e2f865727 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
@@ -539,7 +539,10 @@ static bool rps_eval(void *data)
{
struct intel_gt *gt = data;
- return HAS_RPS(gt->i915);
+ if (intel_guc_slpc_is_used(>->uc.guc))
+ return false;
+ else
+ return HAS_RPS(gt->i915);
}
DEFINE_INTEL_GT_DEBUGFS_ATTRIBUTE(rps_boost);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
index 56dbba1ef668..01b75529311c 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
@@ -837,6 +837,8 @@ int intel_guc_slpc_print_info(struct intel_guc_slpc *slpc, struct drm_printer *p
slpc_decode_min_freq(slpc));
drm_printf(p, "\twaitboosts: %u\n",
slpc->num_boosts);
+ drm_printf(p, "\tBoosts outstanding: %u\n",
+ atomic_read(&slpc->num_waiters));
}
}
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-12 23:56 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs Vinay Belgaumkar
@ 2023-05-13 0:39 ` Dixit, Ashutosh
2023-05-15 22:23 ` Belgaumkar, Vinay
2023-05-13 0:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Dixit, Ashutosh @ 2023-05-13 0:39 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx, dri-devel
On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote:
>
Hi Vinay,
> rps_boost debugfs shows host turbo related info. This is not valid
> when SLPC is enabled.
A couple of thoughts about this. It appears people are know only about
rps_boost_info and don't know about guc_slpc_info? So:
a. Instead of hiding the rps_boost_info file do we need to print there
saying "SLPC is enabled, go look at guc_slpc_info"?
b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two
files will show the same SLPC information)?
Ashutosh
> guc_slpc_info already shows the number of boosts. Add num_waiters there
> as well and disable rps_boost when SLPC is enabled.
>
> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-12 23:56 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs Vinay Belgaumkar
2023-05-13 0:39 ` Dixit, Ashutosh
@ 2023-05-13 0:51 ` Patchwork
2023-05-13 0:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-13 3:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-13 0:51 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc/slpc: Disable rps_boost debugfs
URL : https://patchwork.freedesktop.org/series/117711/
State : warning
== Summary ==
Error: dim checkpatch failed
0cd47cc8985c drm/i915/guc/slpc: Disable rps_boost debugfs
-:11: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Bug:', use 'Link:' or 'Closes:' instead
#11:
Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
total: 0 errors, 1 warnings, 0 checks, 19 lines checked
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-12 23:56 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs Vinay Belgaumkar
2023-05-13 0:39 ` Dixit, Ashutosh
2023-05-13 0:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2023-05-13 0:57 ` Patchwork
2023-05-13 3:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-13 0:57 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4505 bytes --]
== Series Details ==
Series: drm/i915/guc/slpc: Disable rps_boost debugfs
URL : https://patchwork.freedesktop.org/series/117711/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13143 -> Patchwork_117711v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_117711v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-tgl-1115g4: [PASS][1] -> [ABORT][2] ([i915#7953])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/fi-tgl-1115g4/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/fi-tgl-1115g4/igt@gem_ctx_create@basic-files.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][3] ([i915#6367] / [i915#7953])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][4] ([i915#6687] / [i915#7953] / [i915#7978])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][5] ([i915#5334]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@requests:
- {bat-mtlp-8}: [ABORT][7] ([i915#4983] / [i915#7920] / [i915#7953]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-mtlp-8/igt@i915_selftest@live@requests.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][9] ([i915#4983] / [i915#7461] / [i915#7953] / [i915#8347] / [i915#8384]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-rpls-1/igt@i915_selftest@live@reset.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- {bat-mtlp-6}: [DMESG-WARN][11] ([i915#6367] / [i915#7953]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* Linux: CI_DRM_13143 -> Patchwork_117711v1
CI-20190529: 20190529
CI_DRM_13143: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117711v1: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a8bc51407d9e drm/i915/guc/slpc: Disable rps_boost debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/index.html
[-- Attachment #2: Type: text/html, Size: 5601 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-12 23:56 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs Vinay Belgaumkar
` (2 preceding siblings ...)
2023-05-13 0:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-05-13 3:57 ` Patchwork
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2023-05-13 3:57 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10736 bytes --]
== Series Details ==
Series: drm/i915/guc/slpc: Disable rps_boost debugfs
URL : https://patchwork.freedesktop.org/series/117711/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13143_full -> Patchwork_117711v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_117711v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_117711v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_117711v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-apl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl3/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-apl4/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
Known issues
------------
Here are the changes found in Patchwork_117711v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@massive-random:
- shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-glk8/igt@gem_lmem_swapping@massive-random.html
* igt@kms_chamelium_color@ctm-max:
- shard-glk: NOTRUN -> [SKIP][4] ([fdo#109271]) +26 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-glk8/igt@kms_chamelium_color@ctm-max.html
* igt@kms_content_protection@atomic:
- shard-glk: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4579])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-glk8/igt@kms_content_protection@atomic.html
#### Possible fixes ####
* igt@gem_barrier_race@remote-request@rcs0:
- shard-glk: [ABORT][6] ([i915#7461] / [i915#8211]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@gem_barrier_race@remote-request@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-glk4/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][8] ([i915#6786]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-15/igt@gem_ctx_freq@sysfs.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-dg1-17/igt@gem_ctx_freq@sysfs.html
* igt@gem_eio@hibernate:
- {shard-dg1}: [ABORT][10] ([i915#7975] / [i915#8213]) -> [PASS][11] +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-dg1-14/igt@gem_eio@hibernate.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-dg1-17/igt@gem_eio@hibernate.html
* igt@gem_eio@in-flight-contexts-10ms:
- {shard-tglu}: [TIMEOUT][12] ([i915#3063] / [i915#7941]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-tglu-3/igt@gem_eio@in-flight-contexts-10ms.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-tglu-2/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [FAIL][14] ([i915#2842]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-apl2/igt@gem_exec_fair@basic-pace-share@rcs0.html
- {shard-tglu}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-tglu-10/igt@gem_exec_fair@basic-pace-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-tglu-7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [ABORT][20] ([i915#5566]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk1/igt@gen9_exec_parse@allowed-single.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-glk8/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-rkl}: [SKIP][22] ([i915#1937] / [i915#4579]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-6/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][24] ([i915#79]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html
* {igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2}:
- {shard-rkl}: [FAIL][26] ([i915#8292]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13143/shard-rkl-1/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/shard-rkl-4/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7941]: https://gitlab.freedesktop.org/drm/intel/issues/7941
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
Build changes
-------------
* Linux: CI_DRM_13143 -> Patchwork_117711v1
CI-20190529: 20190529
CI_DRM_13143: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7286: a482779488f11c432d7ddcb1980691ab1603f356 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117711v1: 222ff19f23b0bd6aca0b52001d69699f78f5a206 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117711v1/index.html
[-- Attachment #2: Type: text/html, Size: 9253 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-13 0:39 ` Dixit, Ashutosh
@ 2023-05-15 22:23 ` Belgaumkar, Vinay
2023-05-15 22:58 ` Dixit, Ashutosh
0 siblings, 1 reply; 9+ messages in thread
From: Belgaumkar, Vinay @ 2023-05-15 22:23 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx, dri-devel
On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote:
> On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote:
> Hi Vinay,
>
>> rps_boost debugfs shows host turbo related info. This is not valid
>> when SLPC is enabled.
> A couple of thoughts about this. It appears people are know only about
> rps_boost_info and don't know about guc_slpc_info? So:
>
> a. Instead of hiding the rps_boost_info file do we need to print there
> saying "SLPC is enabled, go look at guc_slpc_info"?
rps_boost_info has an eval() function which disables the interface when
RPS is OFF. This is indeed the case here, so shouldn't we just follow
that instead of trying to link the two?
>
> b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two
> files will show the same SLPC information)?
slpc_info has a lot of other info like the SLPC state, not sure that
matches up with the rps_boost_info name.
Thanks,
Vinay.
>
> Ashutosh
>
>
>> guc_slpc_info already shows the number of boosts. Add num_waiters there
>> as well and disable rps_boost when SLPC is enabled.
>>
>> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-15 22:23 ` Belgaumkar, Vinay
@ 2023-05-15 22:58 ` Dixit, Ashutosh
2023-05-16 0:22 ` Dixit, Ashutosh
0 siblings, 1 reply; 9+ messages in thread
From: Dixit, Ashutosh @ 2023-05-15 22:58 UTC (permalink / raw)
To: Belgaumkar, Vinay; +Cc: intel-gfx, mattst88, dri-devel
On Mon, 15 May 2023 15:23:58 -0700, Belgaumkar, Vinay wrote:
>
>
> On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote:
> > On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote:
> > Hi Vinay,
> >
> >> rps_boost debugfs shows host turbo related info. This is not valid
> >> when SLPC is enabled.
> > A couple of thoughts about this. It appears people are know only about
> > rps_boost_info and don't know about guc_slpc_info? So:
> >
> > a. Instead of hiding the rps_boost_info file do we need to print there
> > saying "SLPC is enabled, go look at guc_slpc_info"?
> rps_boost_info has an eval() function which disables the interface when RPS
> is OFF. This is indeed the case here, so shouldn't we just follow that
> instead of trying to link the two?
> >
> > b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two
> > files will show the same SLPC information)?
>
> slpc_info has a lot of other info like the SLPC state, not sure that
> matches up with the rps_boost_info name.
OK, I have asked in https://gitlab.freedesktop.org/drm/intel/-/issues/7632:
@mattst88: is it acceptable to hide the
/sys/kernel/debug/dri/0/i915_rps_boost_info file so that it doesn't cause
confusion. And then user would have to go look at
/sys/kernel/debug/dri/0/i915_guc_slpc_info or some such file when SLPC is
being used? That's what the patch above is doing.
Let's see what we hear from @mattst88.
> >
> >> guc_slpc_info already shows the number of boosts. Add num_waiters there
> >> as well and disable rps_boost when SLPC is enabled.
> >>
> >> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
> >> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
2023-05-15 22:58 ` Dixit, Ashutosh
@ 2023-05-16 0:22 ` Dixit, Ashutosh
0 siblings, 0 replies; 9+ messages in thread
From: Dixit, Ashutosh @ 2023-05-16 0:22 UTC (permalink / raw)
To: Belgaumkar, Vinay; +Cc: intel-gfx, dri-devel
On Mon, 15 May 2023 15:58:26 -0700, Dixit, Ashutosh wrote:
>
> On Mon, 15 May 2023 15:23:58 -0700, Belgaumkar, Vinay wrote:
> >
> >
> > On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote:
> > > On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote:
> > > Hi Vinay,
> > >
> > >> rps_boost debugfs shows host turbo related info. This is not valid
> > >> when SLPC is enabled.
> > > A couple of thoughts about this. It appears people are know only about
> > > rps_boost_info and don't know about guc_slpc_info? So:
> > >
> > > a. Instead of hiding the rps_boost_info file do we need to print there
> > > saying "SLPC is enabled, go look at guc_slpc_info"?
> > rps_boost_info has an eval() function which disables the interface when RPS
> > is OFF. This is indeed the case here, so shouldn't we just follow that
> > instead of trying to link the two?
> > >
> > > b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two
> > > files will show the same SLPC information)?
> >
> > slpc_info has a lot of other info like the SLPC state, not sure that
> > matches up with the rps_boost_info name.
>
> OK, I have asked in https://gitlab.freedesktop.org/drm/intel/-/issues/7632:
>
> @mattst88: is it acceptable to hide the
> /sys/kernel/debug/dri/0/i915_rps_boost_info file so that it doesn't cause
> confusion. And then user would have to go look at
> /sys/kernel/debug/dri/0/i915_guc_slpc_info or some such file when SLPC is
> being used? That's what the patch above is doing.
>
> Let's see what we hear from @mattst88.
@mattst88 agreed on #intel-gfx IRC, so ok by me:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> > >
> > >> guc_slpc_info already shows the number of boosts. Add num_waiters there
> > >> as well and disable rps_boost when SLPC is enabled.
> > >>
> > >> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
> > >> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>
> Thanks.
> --
> Ashutosh
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs
@ 2023-05-16 15:49 Vinay Belgaumkar
0 siblings, 0 replies; 9+ messages in thread
From: Vinay Belgaumkar @ 2023-05-16 15:49 UTC (permalink / raw)
To: intel-gfx, dri-devel
rps_boost debugfs shows host turbo related info. This is not valid
when SLPC is enabled. guc_slpc_info already shows the number of boosts.
Add num_waiters there as well and disable rps_boost when SLPC is
enabled.
v2: Replace Bug with Link to resolve checkpatch warning
Link: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 5 ++++-
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
index 80dbbef86b1d..357e2f865727 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
@@ -539,7 +539,10 @@ static bool rps_eval(void *data)
{
struct intel_gt *gt = data;
- return HAS_RPS(gt->i915);
+ if (intel_guc_slpc_is_used(>->uc.guc))
+ return false;
+ else
+ return HAS_RPS(gt->i915);
}
DEFINE_INTEL_GT_DEBUGFS_ATTRIBUTE(rps_boost);
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
index 56dbba1ef668..01b75529311c 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
@@ -837,6 +837,8 @@ int intel_guc_slpc_print_info(struct intel_guc_slpc *slpc, struct drm_printer *p
slpc_decode_min_freq(slpc));
drm_printf(p, "\twaitboosts: %u\n",
slpc->num_boosts);
+ drm_printf(p, "\tBoosts outstanding: %u\n",
+ atomic_read(&slpc->num_waiters));
}
}
--
2.38.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-05-16 15:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 23:56 [Intel-gfx] [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs Vinay Belgaumkar
2023-05-13 0:39 ` Dixit, Ashutosh
2023-05-15 22:23 ` Belgaumkar, Vinay
2023-05-15 22:58 ` Dixit, Ashutosh
2023-05-16 0:22 ` Dixit, Ashutosh
2023-05-13 0:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-05-13 0:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-13 3:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-16 15:49 [Intel-gfx] [PATCH] " Vinay Belgaumkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox