Re: [PATCH 05/12] drm/i915/xe3: Underrun recovery does not exist post Xe2

[Matt Roper <matthew.d.roper@intel.com>]

On Fri, Oct 18, 2024 at 01:49:34PM -0700, Matt Atwood wrote:
> From: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
> 
> From platforms xe3 Underrun recovery does not exist
> 
> BSpec: 68849
> Signed-off-by: Ravi Kumar Vodapalli <ravi.kumar.vodapalli@intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 01466611eebe..dad415650b40 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -861,7 +861,7 @@ static void icl_set_pipe_chicken(const struct intel_crtc_state *crtc_state)
>  	 */
>  	if (IS_DG2(dev_priv))
>  		tmp &= ~UNDERRUN_RECOVERY_ENABLE_DG2;
> -	else if (DISPLAY_VER(dev_priv) >= 13)
> +	else if (IS_DISPLAY_VER(dev_priv, IP_VER(13, 0), IP_VER(20, 0)))

I don't know if we're ready to assume that there won't be any more Xe2
platforms showing up that have their own display ID's in the 20 range.
It might be best to just write this as

        else if (DISPLAY_VER(dev_priv) >= 13 &&
                 DISPLAY_VER(dev_priv) < 30)

so that we won't have to remember to change this is some 21.0 or 20.1 or
whatever shows up.


Matt

>  		tmp |= UNDERRUN_RECOVERY_DISABLE_ADLP;
>  
>  	/* Wa_14010547955:dg2 */
> -- 
> 2.45.0
> 

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation