From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 11/14] drm/xe: Do not use stolen memory for DPT on IGFX and AuxCCS
Date: Wed, 22 Oct 2025 08:32:36 +0100 [thread overview]
Message-ID: <20251022073241.71401-12-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20251022073241.71401-1-tvrtko.ursulin@igalia.com>
With DPT in stolen memory there are occasional pipe crc IGT failures in
tests such as kms_flip_tiling. Allocate a normal system memory object
instead.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
---
drivers/gpu/drm/xe/display/xe_fb_pin.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
index af691eee398a..8217abc3a20d 100644
--- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
+++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
@@ -122,6 +122,20 @@ static void ggtt_flush_writes(struct xe_ggtt *ggtt)
}
}
+static bool try_dpt_stolen(const struct intel_framebuffer *fb, struct xe_bo *bo)
+{
+ /*
+ * XXX: DPT in stolen memory on IGFX platforms (at least Alderlake)
+ * suffers from occasional pipe crc IGT failures in tests such as
+ * kms_flip_tiling.
+ */
+ if (intel_fb_is_ccs_modifier(fb->base.modifier) &&
+ !xe_bo_is_vram(bo) && !xe_bo_is_stolen(bo))
+ return false;
+
+ return true;
+}
+
static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,
const struct i915_gtt_view *view,
struct i915_vma *vma,
@@ -131,7 +145,7 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,
struct xe_tile *tile0 = xe_device_get_root_tile(xe);
struct xe_ggtt *ggtt = tile0->mem.ggtt;
struct drm_gem_object *obj = intel_fb_bo(&fb->base);
- struct xe_bo *bo = gem_to_xe_bo(obj), *dpt;
+ struct xe_bo *bo = gem_to_xe_bo(obj), *dpt = ERR_PTR(-EINVAL);
u32 dpt_size, size = bo->ttm.base.size;
if (view->type == I915_GTT_VIEW_NORMAL)
@@ -152,7 +166,7 @@ static int __xe_pin_fb_vma_dpt(const struct intel_framebuffer *fb,
XE_BO_FLAG_GGTT |
XE_BO_FLAG_PAGETABLE,
alignment, false);
- else
+ else if (try_dpt_stolen(fb, bo))
dpt = xe_bo_create_pin_map_at_novm(xe, tile0,
dpt_size, ~0ull,
ttm_bo_type_kernel,
--
2.48.0
next prev parent reply other threads:[~2025-10-22 7:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 7:32 [CI 00/14] auxccs ci run no stolen with flush Tvrtko Ursulin
2025-10-22 7:32 ` [CI 01/14] drm/xe: Fix ggtt fb alignment Tvrtko Ursulin
2025-10-22 7:32 ` [CI 02/14] drm/xe/xelpg: Flush CCS when flushing caches Tvrtko Ursulin
2025-10-22 7:32 ` [CI 03/14] drm/xe/xelp: Quiesce memory traffic before invalidating AuxCCS Tvrtko Ursulin
2025-10-22 7:32 ` [CI 04/14] drm/xe/xelp: Support auxccs invalidation on blitter Tvrtko Ursulin
2025-10-22 7:32 ` [CI 05/14] drm/xe/xelp: Use MI_FLUSH_DW_CCS on auxccs platforms Tvrtko Ursulin
2025-10-22 7:32 ` [CI 06/14] drm/xe/xelp: Wait for AuxCCS invalidation to complete Tvrtko Ursulin
2025-10-22 7:32 ` [CI 07/14] drm/xe: Export xe_emit_aux_table_inv Tvrtko Ursulin
2025-10-22 7:32 ` [CI 08/14] drm/xe/xelp: Add AuxCCS invalidation to the indirect context workarounds Tvrtko Ursulin
2025-10-22 7:32 ` [CI 09/14] drm/xe: Flush GGTT writes after populating DPT Tvrtko Ursulin
2025-10-22 7:32 ` [CI 10/14] drm/xe: Handle DPT in system memory Tvrtko Ursulin
2025-10-22 7:32 ` Tvrtko Ursulin [this message]
2025-10-22 7:32 ` [CI 12/14] drm/xe: Force flush system memory AuxCCS framebuffers before scan out Tvrtko Ursulin
2025-10-22 7:32 ` [CI 13/14] drm/xe/display: Add support for AuxCCS Tvrtko Ursulin
2025-10-22 7:32 ` [CI 14/14] drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe Tvrtko Ursulin
2025-10-22 8:53 ` ✗ CI.checkpatch: warning for auxccs ci run no stolen with flush Patchwork
2025-10-22 8:54 ` ✓ CI.KUnit: success " Patchwork
2025-10-22 9:36 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22 11:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-22 17:16 ` ✗ CI.checkpatch: warning for auxccs ci run no stolen with flush (rev2) Patchwork
2025-10-22 17:17 ` ✓ CI.KUnit: success " Patchwork
2025-10-22 17:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22 20:47 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-23 9:31 ` ✗ CI.checkpatch: warning for auxccs ci run no stolen with flush (rev3) Patchwork
2025-10-23 9:32 ` ✓ CI.KUnit: success " Patchwork
2025-10-23 10:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-23 16:11 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022073241.71401-12-tvrtko.ursulin@igalia.com \
--to=tvrtko.ursulin@igalia.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox