Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: intel-xe@lists.freedesktop.org
Subject: [CI 03/14] drm/xe/xelp: Quiesce memory traffic before invalidating AuxCCS
Date: Wed, 22 Oct 2025 08:32:28 +0100	[thread overview]
Message-ID: <20251022073241.71401-4-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20251022073241.71401-1-tvrtko.ursulin@igalia.com>

According to i915 commit
ad8ebf12217e ("drm/i915/gt: Ensure memory quiesced before invalidation")
quiescing of the memory traffic is required before invalidating the AuxCCS
tables.

Add an extra pipe control flush to achieve that.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_ring_ops.c       | 10 +++++++++-
 drivers/gpu/drm/xe/xe_ring_ops_types.h |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
index 15fc4010a710..f384c9968859 100644
--- a/drivers/gpu/drm/xe/xe_ring_ops.c
+++ b/drivers/gpu/drm/xe/xe_ring_ops.c
@@ -363,12 +363,20 @@ static void __emit_job_gen12_render_compute(struct xe_sched_job *job,
 	struct xe_gt *gt = job->q->gt;
 	struct xe_device *xe = gt_to_xe(gt);
 	bool lacks_render = !(gt->info.engine_mask & XE_HW_ENGINE_RCS_MASK);
+	const bool aux_ccs = has_aux_ccs(xe);
 	u32 mask_flags = 0;
 
 	*head = lrc->ring.tail;
 
 	i = emit_copy_timestamp(lrc, dw, i);
 
+	/*
+	 * On AuxCCS platforms the invalidation of the Aux table requires
+	 * quiescing the memory traffic beforehand.
+	 */
+	if (aux_ccs)
+		i = emit_render_cache_flush(job, dw, i);
+
 	dw[i++] = preparser_disable(true);
 	if (lacks_render)
 		mask_flags = PIPE_CONTROL_3D_ARCH_FLAGS;
@@ -379,7 +387,7 @@ static void __emit_job_gen12_render_compute(struct xe_sched_job *job,
 	i = emit_pipe_invalidate(mask_flags, job->ring_ops_flush_tlb, dw, i);
 
 	/* hsdes: 1809175790 */
-	if (has_aux_ccs(xe))
+	if (aux_ccs)
 		i = emit_aux_table_inv(gt, CCS_AUX_INV, dw, i);
 
 	dw[i++] = preparser_disable(false);
diff --git a/drivers/gpu/drm/xe/xe_ring_ops_types.h b/drivers/gpu/drm/xe/xe_ring_ops_types.h
index d7e3e150a9a5..477dc7defd72 100644
--- a/drivers/gpu/drm/xe/xe_ring_ops_types.h
+++ b/drivers/gpu/drm/xe/xe_ring_ops_types.h
@@ -8,7 +8,7 @@
 
 struct xe_sched_job;
 
-#define MAX_JOB_SIZE_DW 58
+#define MAX_JOB_SIZE_DW 70
 #define MAX_JOB_SIZE_BYTES (MAX_JOB_SIZE_DW * 4)
 
 /**
-- 
2.48.0


  parent reply	other threads:[~2025-10-22  7:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  7:32 [CI 00/14] auxccs ci run no stolen with flush Tvrtko Ursulin
2025-10-22  7:32 ` [CI 01/14] drm/xe: Fix ggtt fb alignment Tvrtko Ursulin
2025-10-22  7:32 ` [CI 02/14] drm/xe/xelpg: Flush CCS when flushing caches Tvrtko Ursulin
2025-10-22  7:32 ` Tvrtko Ursulin [this message]
2025-10-22  7:32 ` [CI 04/14] drm/xe/xelp: Support auxccs invalidation on blitter Tvrtko Ursulin
2025-10-22  7:32 ` [CI 05/14] drm/xe/xelp: Use MI_FLUSH_DW_CCS on auxccs platforms Tvrtko Ursulin
2025-10-22  7:32 ` [CI 06/14] drm/xe/xelp: Wait for AuxCCS invalidation to complete Tvrtko Ursulin
2025-10-22  7:32 ` [CI 07/14] drm/xe: Export xe_emit_aux_table_inv Tvrtko Ursulin
2025-10-22  7:32 ` [CI 08/14] drm/xe/xelp: Add AuxCCS invalidation to the indirect context workarounds Tvrtko Ursulin
2025-10-22  7:32 ` [CI 09/14] drm/xe: Flush GGTT writes after populating DPT Tvrtko Ursulin
2025-10-22  7:32 ` [CI 10/14] drm/xe: Handle DPT in system memory Tvrtko Ursulin
2025-10-22  7:32 ` [CI 11/14] drm/xe: Do not use stolen memory for DPT on IGFX and AuxCCS Tvrtko Ursulin
2025-10-22  7:32 ` [CI 12/14] drm/xe: Force flush system memory AuxCCS framebuffers before scan out Tvrtko Ursulin
2025-10-22  7:32 ` [CI 13/14] drm/xe/display: Add support for AuxCCS Tvrtko Ursulin
2025-10-22  7:32 ` [CI 14/14] drm/i915/display: Expose AuxCCS frame buffer modifiers for Xe Tvrtko Ursulin
2025-10-22  8:53 ` ✗ CI.checkpatch: warning for auxccs ci run no stolen with flush Patchwork
2025-10-22  8:54 ` ✓ CI.KUnit: success " Patchwork
2025-10-22  9:36 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22 11:39 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-22 17:16 ` ✗ CI.checkpatch: warning for auxccs ci run no stolen with flush (rev2) Patchwork
2025-10-22 17:17 ` ✓ CI.KUnit: success " Patchwork
2025-10-22 17:55 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22 20:47 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-23  9:31 ` ✗ CI.checkpatch: warning for auxccs ci run no stolen with flush (rev3) Patchwork
2025-10-23  9:32 ` ✓ CI.KUnit: success " Patchwork
2025-10-23 10:42 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-23 16:11 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251022073241.71401-4-tvrtko.ursulin@igalia.com \
    --to=tvrtko.ursulin@igalia.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox