[kernel-hardening] Re: [PATCH RFC v6 2/6] gcc-plugins: Add STACKLEAK plugin for tracking the kernel stack

[Alexander Popov <alex.popov@linux.com>]

On 06.12.2017 21:57, Laura Abbott wrote:
> On 12/05/2017 03:33 PM, Alexander Popov wrote:
>> +	/* Parse the plugin arguments */
>> +	if (argc != 1) {
>> +		error(G_("bad number of the plugin arguments: %d"), argc);
>> +		return 1;
>> +	}
>> +
>> +	if (strcmp(argv[i].key, "track-min-size")) {
>> +		error(G_("unknown option '-fplugin-arg-%s-%s'"),
>> +				plugin_name, argv[i].key);
>> +		return 1;
>> +	}
>> +
>> +	if (!argv[i].value) {
>> +		error(G_("no value supplied for option '-fplugin-arg-%s-%s'"),
>> +				plugin_name, argv[i].key);
>> +		return 1;
>> +	}
>> +
>> +	track_frame_size = atoi(argv[i].value);
>> +	if (track_frame_size < 0) {
>> +		error(G_("invalid option argument '-fplugin-arg-%s-%s=%s'"),
>> +				plugin_name, argv[i].key, argv[i].value);
>> +		return 1;
>> +	}
> 
> I don't see i getting updated anywhere, which seems to be an artifact of
> removing the for loop. I'd prefer if you just kept the loop since the
> arm64 version requires a --disable option like structleak.

Ok, no problem, I'll return the loop and add --disable option in v7.

Best regards,
Alexander