Re: [PATCH v9 03/22] KVM: arm64: Reorganize PMU functions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kvm: arm_pmu.h relies on VGIC_NR_SGIS without including arm_vgic.h
--

commit 11313a8fb957f8fbf17d341d98c082ca4fdb6a91
Author: Colton Lewis <coltonlewis@google.com>
KVM: arm64: Reorganize PMU functions

This commit moves several functions that aren't specific to the emulated PMU
implementation out of pmu-emul.c and relocates them to the more appropriate
pmu.c file where shared PMU functions live.

[ ... ]

> diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h
> index 93f41ac77c25f..e1bf29de0b6dd 100644
> --- a/include/kvm/arm_pmu.h
> +++ b/include/kvm/arm_pmu.h
> @@ -50,18 +50,21 @@ struct arm_pmu_entry {
>  };
>  
>  bool kvm_supports_guest_pmuv3(void);
> -#define kvm_arm_pmu_irq_initialized(v)	((v)->arch.pmu.irq_num != 0)
> +#define kvm_arm_pmu_irq_initialized(v)	((v)->arch.pmu.irq_num >= VGIC_NR_SGIS)

[Severity: Low]
Does this make the include/kvm/arm_pmu.h header no longer self-contained?

The updated kvm_arm_pmu_irq_initialized() macro relies on VGIC_NR_SGIS, but 
the header doesn't appear to include <kvm/arm_vgic.h>. Any future C file that
includes this header and expands this macro without also including the VGIC 
header will likely fail to compile. 

Should we add the missing include to ensure the header remains self-contained?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924172928.2110956-1-coltonlewis@google.com?part=3