* Registering key events android (qemu based) emulator
2010-01-11 19:18 ` [PATCHv2] Add KVM paravirt cpuid leaf Anthony Liguori
@ 2010-01-11 19:33 ` Anwar Ghani
2010-01-11 20:40 ` [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Jan Kiszka
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Anwar Ghani @ 2010-01-11 19:33 UTC (permalink / raw)
To: Gleb Natapov, Anthony Liguori
Cc: Marcelo Tosatti, Jan Kiszka, qemu-devel, kvm-devel, Avi Kivity
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
Hi All
guys I am a bit new to this stuff. I want to call a method after user presses a combination of keys lets say alt+s or whatever. How can I do it using which event handler.
Best Regards
Anwar Ghani
+31 647 344 773
--- On Mon, 1/11/10, Anthony Liguori <anthony@codemonkey.ws> wrote:
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
To: "Gleb Natapov" <gleb@redhat.com>
Cc: "Marcelo Tosatti" <mtosatti@redhat.com>, "Jan Kiszka" <jan.kiszka@web.de>, qemu-devel@nongnu.org, "kvm-devel" <kvm@vger.kernel.org>, "Avi Kivity" <avi@redhat.com>
Date: Monday, January 11, 2010, 7:18 PM
On 01/07/2010 10:24 AM, Gleb Natapov wrote:
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 4084503..6a841de 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -17,6 +17,7 @@
> #include<sys/mman.h>
>
> #include<linux/kvm.h>
> +#include<linux/kvm_para.h>
This breaks the build on a default F12 install because while kvm.h is present, kvm_para.h is not. This is a hard one to fix.
We can default the kvm search path to /lib/modules/$(uname -r)/build, we can fix the glibc headers and live with it, or we can pull in the kvm headers into qemu.
Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
Regards,
Anthony Liguori
[-- Attachment #2: Type: text/html, Size: 1834 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
2010-01-11 19:18 ` [PATCHv2] Add KVM paravirt cpuid leaf Anthony Liguori
2010-01-11 19:33 ` Registering key events android (qemu based) emulator Anwar Ghani
@ 2010-01-11 20:40 ` Jan Kiszka
2010-01-11 21:36 ` Anthony Liguori
2010-01-12 7:23 ` Gleb Natapov
2010-01-12 8:42 ` Avi Kivity
3 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2010-01-11 20:40 UTC (permalink / raw)
To: Anthony Liguori
Cc: Gleb Natapov, qemu-devel, kvm-devel, Avi Kivity, Marcelo Tosatti
[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]
Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 4084503..6a841de 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -17,6 +17,7 @@
>> #include<sys/mman.h>
>>
>> #include<linux/kvm.h>
>> +#include<linux/kvm_para.h>
>
> This breaks the build on a default F12 install because while kvm.h is
> present, kvm_para.h is not. This is a hard one to fix.
>
> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
> can fix the glibc headers and live with it, or we can pull in the kvm
> headers into qemu.
>
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
release (missed the need for it so far). I'm planning to write a qemu
patch to ask pkg-config for kvm-kmod headers.
If we can live with considering the cpuid leaf a feature that depends on
a recent kvm-kmod version and is disabled otherwise, we are done. If
not, tricks like the above are required.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
2010-01-11 20:40 ` [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Jan Kiszka
@ 2010-01-11 21:36 ` Anthony Liguori
2010-01-11 23:22 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Anthony Liguori @ 2010-01-11 21:36 UTC (permalink / raw)
To: Jan Kiszka
Cc: Gleb Natapov, qemu-devel, kvm-devel, Avi Kivity, Marcelo Tosatti
On 01/11/2010 02:40 PM, Jan Kiszka wrote:
> Anthony Liguori wrote:
>
>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>
>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>> index 4084503..6a841de 100644
>>> --- a/target-i386/kvm.c
>>> +++ b/target-i386/kvm.c
>>> @@ -17,6 +17,7 @@
>>> #include<sys/mman.h>
>>>
>>> #include<linux/kvm.h>
>>> +#include<linux/kvm_para.h>
>>>
>> This breaks the build on a default F12 install because while kvm.h is
>> present, kvm_para.h is not. This is a hard one to fix.
>>
>> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
>> can fix the glibc headers and live with it, or we can pull in the kvm
>> headers into qemu.
>>
>> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>>
> kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
> release (missed the need for it so far). I'm planning to write a qemu
> patch to ask pkg-config for kvm-kmod headers.
>
That would be nice.
I assume a change has to be made in the kernel too so that the libc
headers are updated. IOW, I assume make headers_install doesn't
currently install kvm_para.h
> If we can live with considering the cpuid leaf a feature that depends on
> a recent kvm-kmod version and is disabled otherwise, we are done. If
> not, tricks like the above are required.
>
It's less than ideal, but I can live with it.
Regards,
Anthony Liguori
> Jan
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
2010-01-11 21:36 ` Anthony Liguori
@ 2010-01-11 23:22 ` Jan Kiszka
0 siblings, 0 replies; 8+ messages in thread
From: Jan Kiszka @ 2010-01-11 23:22 UTC (permalink / raw)
To: Anthony Liguori
Cc: Gleb Natapov, qemu-devel, kvm-devel, Avi Kivity, Marcelo Tosatti
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
Anthony Liguori wrote:
> On 01/11/2010 02:40 PM, Jan Kiszka wrote:
>> Anthony Liguori wrote:
>>
>>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>>
>>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>>> index 4084503..6a841de 100644
>>>> --- a/target-i386/kvm.c
>>>> +++ b/target-i386/kvm.c
>>>> @@ -17,6 +17,7 @@
>>>> #include<sys/mman.h>
>>>>
>>>> #include<linux/kvm.h>
>>>> +#include<linux/kvm_para.h>
>>>>
>>> This breaks the build on a default F12 install because while kvm.h is
>>> present, kvm_para.h is not. This is a hard one to fix.
>>>
>>> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
>>> can fix the glibc headers and live with it, or we can pull in the kvm
>>> headers into qemu.
>>>
>>> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>>>
>> kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
>> release (missed the need for it so far). I'm planning to write a qemu
>> patch to ask pkg-config for kvm-kmod headers.
>>
>
> That would be nice.
>
> I assume a change has to be made in the kernel too so that the libc
> headers are updated. IOW, I assume make headers_install doesn't
> currently install kvm_para.h
I does, I just failed to cherry-pick them from the temporary tree it
creates during 'make sync'.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
2010-01-11 19:18 ` [PATCHv2] Add KVM paravirt cpuid leaf Anthony Liguori
2010-01-11 19:33 ` Registering key events android (qemu based) emulator Anwar Ghani
2010-01-11 20:40 ` [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf Jan Kiszka
@ 2010-01-12 7:23 ` Gleb Natapov
2010-01-12 8:40 ` Avi Kivity
2010-01-12 8:42 ` Avi Kivity
3 siblings, 1 reply; 8+ messages in thread
From: Gleb Natapov @ 2010-01-12 7:23 UTC (permalink / raw)
To: Anthony Liguori
Cc: qemu-devel, kvm-devel, Avi Kivity, Jan Kiszka, Marcelo Tosatti
On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
> >diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> >index 4084503..6a841de 100644
> >--- a/target-i386/kvm.c
> >+++ b/target-i386/kvm.c
> >@@ -17,6 +17,7 @@
> > #include<sys/mman.h>
> >
> > #include<linux/kvm.h>
> >+#include<linux/kvm_para.h>
>
> This breaks the build on a default F12 install because while kvm.h
> is present, kvm_para.h is not. This is a hard one to fix.
>
Avi how qemu-kvm compiles there? Or it doesn't?
> We can default the kvm search path to /lib/modules/$(uname
> -r)/build, we can fix the glibc headers and live with it, or we can
> pull in the kvm headers into qemu.
>
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>
> Regards,
>
> Anthony Liguori
--
Gleb.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
2010-01-12 7:23 ` Gleb Natapov
@ 2010-01-12 8:40 ` Avi Kivity
0 siblings, 0 replies; 8+ messages in thread
From: Avi Kivity @ 2010-01-12 8:40 UTC (permalink / raw)
To: Gleb Natapov
Cc: Anthony Liguori, qemu-devel, kvm-devel, Jan Kiszka,
Marcelo Tosatti
On 01/12/2010 09:23 AM, Gleb Natapov wrote:
> On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote:
>
>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>
>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>> index 4084503..6a841de 100644
>>> --- a/target-i386/kvm.c
>>> +++ b/target-i386/kvm.c
>>> @@ -17,6 +17,7 @@
>>> #include<sys/mman.h>
>>>
>>> #include<linux/kvm.h>
>>> +#include<linux/kvm_para.h>
>>>
>> This breaks the build on a default F12 install because while kvm.h
>> is present, kvm_para.h is not. This is a hard one to fix.
>>
>>
> Avi how qemu-kvm compiles there? Or it doesn't?
>
>
include/linux/Kbuild has:
ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
$(srctree)/include/asm-$(SRCARCH)/kvm.h),)
unifdef-y += kvm.h
endif
ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
$(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
unifdef-y += kvm_para.h
endif
So it should be installed. Unfortunately this is starting 2.6.32, so we
need to backport the patch (da18acffc3) to the F12 kernel.
qemu-kvm doesn't depend on installed headers.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
2010-01-11 19:18 ` [PATCHv2] Add KVM paravirt cpuid leaf Anthony Liguori
` (2 preceding siblings ...)
2010-01-12 7:23 ` Gleb Natapov
@ 2010-01-12 8:42 ` Avi Kivity
3 siblings, 0 replies; 8+ messages in thread
From: Avi Kivity @ 2010-01-12 8:42 UTC (permalink / raw)
To: Anthony Liguori
Cc: Gleb Natapov, qemu-devel, kvm-devel, Jan Kiszka, Marcelo Tosatti
On 01/11/2010 09:18 PM, Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 4084503..6a841de 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -17,6 +17,7 @@
>> #include<sys/mman.h>
>>
>> #include<linux/kvm.h>
>> +#include<linux/kvm_para.h>
>
> This breaks the build on a default F12 install because while kvm.h is
> present, kvm_para.h is not. This is a hard one to fix.
>
> We can default the kvm search path to /lib/modules/$(uname -r)/build,
> we can fix the glibc headers and live with it, or we can pull in the
> kvm headers into qemu.
>
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>
Two options:
- make kvm detection depend on kvm_para.h being includable, fix all
relevant distro kernels to supply it, and live with the breakage
- add a new CONFIG_KVM_PARA, detect it at configure time, and only
include it if present
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 8+ messages in thread