Re: [PATCHv2] Add KVM paravirt cpuid leaf

Re: [PATCHv2] Add KVM paravirt cpuid leaf

[Anthony Liguori]

On 01/07/2010 10:24 AM, Gleb Natapov wrote:
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 4084503..6a841de 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -17,6 +17,7 @@
>   #include<sys/mman.h>
>
>   #include<linux/kvm.h>
> +#include<linux/kvm_para.h>

This breaks the build on a default F12 install because while kvm.h is 
present, kvm_para.h is not.  This is a hard one to fix.

We can default the kvm search path to /lib/modules/$(uname -r)/build, we 
can fix the glibc headers and live with it, or we can pull in the kvm 
headers into qemu.

Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?

Regards,

Anthony Liguori

Registering key events android (qemu based) emulator

[Anwar Ghani]

[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]

Hi All

guys I am a bit new to this stuff. I want to call a method after user presses a combination of keys lets say alt+s or whatever. How can I do it using which event handler.

Best Regards



Anwar Ghani

+31 647 344 773

--- On Mon, 1/11/10, Anthony Liguori <anthony@codemonkey.ws> wrote:

From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf
To: "Gleb Natapov" <gleb@redhat.com>
Cc: "Marcelo Tosatti" <mtosatti@redhat.com>, "Jan Kiszka" <jan.kiszka@web.de>, qemu-devel@nongnu.org, "kvm-devel" <kvm@vger.kernel.org>, "Avi Kivity" <avi@redhat.com>
Date: Monday, January 11, 2010, 7:18 PM

On 01/07/2010 10:24 AM, Gleb Natapov wrote:
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 4084503..6a841de 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -17,6 +17,7 @@
>   #include<sys/mman.h>
> 
>   #include<linux/kvm.h>
> +#include<linux/kvm_para.h>

This breaks the build on a default F12 install because while kvm.h is present, kvm_para.h is not.  This is a hard one to fix.

We can default the kvm search path to /lib/modules/$(uname -r)/build, we can fix the glibc headers and live with it, or we can pull in the kvm headers into qemu.

Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?

Regards,

Anthony Liguori





      

[-- Attachment #2: Type: text/html, Size: 1834 bytes --]

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 4084503..6a841de 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -17,6 +17,7 @@
>>   #include<sys/mman.h>
>>
>>   #include<linux/kvm.h>
>> +#include<linux/kvm_para.h>
> 
> This breaks the build on a default F12 install because while kvm.h is
> present, kvm_para.h is not.  This is a hard one to fix.
> 
> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
> can fix the glibc headers and live with it, or we can pull in the kvm
> headers into qemu.
> 
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?

kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
release (missed the need for it so far). I'm planning to write a qemu
patch to ask pkg-config for kvm-kmod headers.

If we can live with considering the cpuid leaf a feature that depends on
a recent kvm-kmod version and is disabled otherwise, we are done. If
not, tricks like the above are required.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

[Anthony Liguori]

On 01/11/2010 02:40 PM, Jan Kiszka wrote:
> Anthony Liguori wrote:
>    
>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>      
>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>> index 4084503..6a841de 100644
>>> --- a/target-i386/kvm.c
>>> +++ b/target-i386/kvm.c
>>> @@ -17,6 +17,7 @@
>>>    #include<sys/mman.h>
>>>
>>>    #include<linux/kvm.h>
>>> +#include<linux/kvm_para.h>
>>>        
>> This breaks the build on a default F12 install because while kvm.h is
>> present, kvm_para.h is not.  This is a hard one to fix.
>>
>> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
>> can fix the glibc headers and live with it, or we can pull in the kvm
>> headers into qemu.
>>
>> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>>      
> kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
> release (missed the need for it so far). I'm planning to write a qemu
> patch to ask pkg-config for kvm-kmod headers.
>    

That would be nice.

I assume a change has to be made in the kernel too so that the libc 
headers are updated.  IOW, I assume make headers_install doesn't 
currently install kvm_para.h

> If we can live with considering the cpuid leaf a feature that depends on
> a recent kvm-kmod version and is disabled otherwise, we are done. If
> not, tricks like the above are required.
>    

It's less than ideal, but I can live with it.

Regards,

Anthony Liguori

> Jan
>
>    

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

Anthony Liguori wrote:
> On 01/11/2010 02:40 PM, Jan Kiszka wrote:
>> Anthony Liguori wrote:
>>   
>>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>>     
>>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>>> index 4084503..6a841de 100644
>>>> --- a/target-i386/kvm.c
>>>> +++ b/target-i386/kvm.c
>>>> @@ -17,6 +17,7 @@
>>>>    #include<sys/mman.h>
>>>>
>>>>    #include<linux/kvm.h>
>>>> +#include<linux/kvm_para.h>
>>>>        
>>> This breaks the build on a default F12 install because while kvm.h is
>>> present, kvm_para.h is not.  This is a hard one to fix.
>>>
>>> We can default the kvm search path to /lib/modules/$(uname -r)/build, we
>>> can fix the glibc headers and live with it, or we can pull in the kvm
>>> headers into qemu.
>>>
>>> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>>>      
>> kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
>> release (missed the need for it so far). I'm planning to write a qemu
>> patch to ask pkg-config for kvm-kmod headers.
>>    
> 
> That would be nice.
> 
> I assume a change has to be made in the kernel too so that the libc
> headers are updated.  IOW, I assume make headers_install doesn't
> currently install kvm_para.h

I does, I just failed to cherry-pick them from the temporary tree it
creates during 'make sync'.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

[Gleb Natapov]

On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
> >diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> >index 4084503..6a841de 100644
> >--- a/target-i386/kvm.c
> >+++ b/target-i386/kvm.c
> >@@ -17,6 +17,7 @@
> >  #include<sys/mman.h>
> >
> >  #include<linux/kvm.h>
> >+#include<linux/kvm_para.h>
> 
> This breaks the build on a default F12 install because while kvm.h
> is present, kvm_para.h is not.  This is a hard one to fix.
> 
Avi how qemu-kvm compiles there? Or it doesn't?

> We can default the kvm search path to /lib/modules/$(uname
> -r)/build, we can fix the glibc headers and live with it, or we can
> pull in the kvm headers into qemu.
> 
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
> 
> Regards,
> 
> Anthony Liguori

--
			Gleb.

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

[Avi Kivity]

On 01/12/2010 09:23 AM, Gleb Natapov wrote:
> On Mon, Jan 11, 2010 at 01:18:32PM -0600, Anthony Liguori wrote:
>    
>> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>>      
>>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>>> index 4084503..6a841de 100644
>>> --- a/target-i386/kvm.c
>>> +++ b/target-i386/kvm.c
>>> @@ -17,6 +17,7 @@
>>>   #include<sys/mman.h>
>>>
>>>   #include<linux/kvm.h>
>>> +#include<linux/kvm_para.h>
>>>        
>> This breaks the build on a default F12 install because while kvm.h
>> is present, kvm_para.h is not.  This is a hard one to fix.
>>
>>      
> Avi how qemu-kvm compiles there? Or it doesn't?
>
>    

include/linux/Kbuild has:

ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm.h \
                   $(srctree)/include/asm-$(SRCARCH)/kvm.h),)
unifdef-y += kvm.h
endif
ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/include/asm/kvm_para.h \
                   $(srctree)/include/asm-$(SRCARCH)/kvm_para.h),)
unifdef-y += kvm_para.h
endif

So it should be installed.  Unfortunately this is starting 2.6.32, so we 
need to backport the patch (da18acffc3) to the F12 kernel.

qemu-kvm doesn't depend on installed headers.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

[Avi Kivity]

On 01/11/2010 09:18 PM, Anthony Liguori wrote:
> On 01/07/2010 10:24 AM, Gleb Natapov wrote:
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index 4084503..6a841de 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -17,6 +17,7 @@
>>   #include<sys/mman.h>
>>
>>   #include<linux/kvm.h>
>> +#include<linux/kvm_para.h>
>
> This breaks the build on a default F12 install because while kvm.h is 
> present, kvm_para.h is not.  This is a hard one to fix.
>
> We can default the kvm search path to /lib/modules/$(uname -r)/build, 
> we can fix the glibc headers and live with it, or we can pull in the 
> kvm headers into qemu.
>
> Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
>

Two options:

- make kvm detection depend on kvm_para.h being includable, fix all 
relevant distro kernels to supply it, and live with the breakage
- add a new CONFIG_KVM_PARA, detect it at configure time, and only 
include it if present

-- 
error compiling committee.c: too many arguments to function