Re: [PATCH v4 03/48] irqchip/gic-v5: Set up gic_kvm_info on ACPI hosts

[Marc Zyngier <maz@kernel.org>]

On Fri, 24 Jul 2026 12:19:20 +0100,
sashiko-bot@kernel.org wrote:
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] Failed ACPI GSI registration for maintenance IRQ due to missing GICv5 hardware IRQ type encoding.
> --

[...]

> [Severity: High]
> Does this fail to register the maintenance IRQ?
> 
> acpi_register_gsi() passes the raw maint_irq directly into fwspec.param[0].
> However, the GICv5 PPI domain select function expects the hardware IRQ type to
> be encoded in the upper bits:
> 
> drivers/irqchip/irq-gic-v5.c:gicv5_irq_ppi_domain_select() {
>     ...
>     if (is_fwnode_irqchip(fwspec->fwnode))
>         hwirq_type = FIELD_GET(GICV5_HWIRQ_TYPE, fwspec->param[0]);
> 
>     if (hwirq_type != GICV5_HWIRQ_TYPE_PPI)
>         return 0;
>     ...
> }
> 
> Because the raw MADT value doesn't have the GICV5_HWIRQ_TYPE_PPI bits set, the
> mapping will be rejected. Should the GSI be encoded with the PPI type before
> calling acpi_register_gsi()?

Where is this coming from? I can't even find any public documentation
for ACPI GICv5 support...

Sascha?

	M.

-- 
Jazz isn't dead. It just smells funny.