From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tengfei Fan <tengfei.fan@oss.qualcomm.com>,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 01/47] dt-bindings: clock: qcom: gcc-sdm845: Add CX power domain
Date: Tue, 25 Aug 2026 09:34:47 +0200 [thread overview]
Message-ID: <14805eb9-964a-48e5-b6fa-b2616b52bc0c@kernel.org> (raw)
In-Reply-To: <qcvnb5nifvwtocgrlc5nddkwgakqjdrqj7uazplj5jpy7jmasu@o555nrglms2j>
On 25/08/2026 09:30, Abel Vesa wrote:
>>>
>>> required:
>>> @@ -56,6 +58,8 @@ allOf:
>>> - const: bi_tcxo
>>> - const: bi_tcxo_ao
>>> - const: sleep_clk
>>> + required:
>>> + - power-domains
>>
>> Why? Commit msg should tell me why you are changing ABI. It is actual
>> ABI break without an explanation...
>
> Actually, I should've kept the same commit message as for the other
> bindings.
>
> Thanks for reviewing.
The others only mention "to match hardware description" but that is poor
reason for ABI break. If everything was working fine, thus domain is not
really required, why would "matching the hardware description" matter?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-25 7:34 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:53 [PATCH v3 00/47] clk: qcom: Tie CX power domains to GCCs Abel Vesa
2026-08-24 11:53 ` [PATCH v3 01/47] dt-bindings: clock: qcom: gcc-sdm845: Add CX power domain Abel Vesa
2026-08-24 20:39 ` Krzysztof Kozlowski
2026-08-25 7:30 ` Abel Vesa
2026-08-25 7:34 ` Krzysztof Kozlowski [this message]
2026-08-25 8:01 ` Abel Vesa
2026-08-24 11:53 ` [PATCH v3 02/47] dt-bindings: clock: qcom: gcc-sm8150: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 03/47] dt-bindings: clock: qcom: gcc-sm8250: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 04/47] dt-bindings: clock: qcom: gcc-sm8350: " Abel Vesa
2026-08-24 12:11 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 05/47] dt-bindings: clock: qcom: gcc-sm8450: " Abel Vesa
2026-08-24 12:13 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 06/47] dt-bindings: clock: qcom: qcs615-gcc: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 07/47] dt-bindings: clock: qcom: sm8550-gcc: " Abel Vesa
2026-08-24 12:08 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 08/47] dt-bindings: clock: qcom: sm8650-gcc: " Abel Vesa
2026-08-24 12:08 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 09/47] dt-bindings: clock: qcom: sm8750-gcc: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 10/47] clk: qcom: gcc-eliza: Tie the CX power domain to controller Abel Vesa
2026-08-24 11:53 ` [PATCH v3 11/47] clk: qcom: gcc-kaanapali: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 12/47] clk: qcom: gcc-qcs615: " Abel Vesa
2026-08-24 12:25 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 13/47] clk: qcom: gcc-qcs8300: " Abel Vesa
2026-08-24 12:25 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 14/47] clk: qcom: gcc-qdu1000: " Abel Vesa
2026-08-24 12:28 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 15/47] clk: qcom: gcc-sa8775p: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 16/47] clk: qcom: gcc-sar2130p: " Abel Vesa
2026-08-24 12:19 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 17/47] clk: qcom: gcc-sc7180: " Abel Vesa
2026-08-24 12:22 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 18/47] clk: qcom: gcc-sc7280: " Abel Vesa
2026-08-24 12:36 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 19/47] clk: qcom: gcc-sdm670: " Abel Vesa
2026-08-24 12:19 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 20/47] clk: qcom: gcc-sdm845: " Abel Vesa
2026-08-24 12:18 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 21/47] clk: qcom: gcc-sdx75: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 22/47] clk: qcom: gcc-sm4450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 23/47] clk: qcom: gcc-sm6350: " Abel Vesa
2026-08-24 12:22 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 24/47] clk: qcom: gcc-sm8150: " Abel Vesa
2026-08-24 12:28 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 25/47] clk: qcom: gcc-sm8250: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 26/47] clk: qcom: gcc-sm8350: " Abel Vesa
2026-08-24 12:20 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 27/47] clk: qcom: gcc-sm8450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 28/47] clk: qcom: gcc-sm8550: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 29/47] clk: qcom: gcc-sm8650: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 30/47] clk: qcom: gcc-sm8750: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 31/47] clk: qcom: gcc-x1e80100: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 32/47] arm64: dts: qcom: kaanapali: Add GCC CX power domain Abel Vesa
2026-08-24 11:54 ` [PATCH v3 33/47] arm64: dts: qcom: monaco: " Abel Vesa
2026-08-24 12:24 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 34/47] arm64: dts: qcom: qdu1000: " Abel Vesa
2026-08-24 12:27 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 35/47] arm64: dts: qcom: sar2130p: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 36/47] arm64: dts: qcom: sdm670: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 37/47] arm64: dts: qcom: sdx75: " Abel Vesa
2026-08-24 12:28 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 38/47] arm64: dts: qcom: sm4450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 39/47] arm64: dts: qcom: sm6350: " Abel Vesa
2026-08-24 12:30 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 40/47] arm64: dts: qcom: sm8150: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 41/47] arm64: dts: qcom: sm8250: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 42/47] arm64: dts: qcom: sm8350: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 43/47] arm64: dts: qcom: sm8450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 44/47] arm64: dts: qcom: sm8550: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 45/47] arm64: dts: qcom: sm8650: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 46/47] arm64: dts: qcom: sm8750: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 47/47] arm64: dts: qcom: talos: " Abel Vesa
2026-08-24 16:28 ` [PATCH v3 00/47] clk: qcom: Tie CX power domains to GCCs Vinod Koul
2026-08-25 7:32 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14805eb9-964a-48e5-b6fa-b2616b52bc0c@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jbrunet+clk@baylibre.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=tengfei.fan@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox