From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 37/47] arm64: dts: qcom: sdx75: Add GCC CX power domain
Date: Mon, 24 Aug 2026 12:28:18 +0000 [thread overview]
Message-ID: <20260824122819.390441F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260824-qcom-tie-cx-to-gcc-v3-37-f1205a92682b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `power-domains` property is added to the GCC device tree node, but it is not documented in the corresponding `qcom,sdx75-gcc.yaml` device tree binding schema.
--
--- Patch [37]: [PATCH v3 37/47] arm64: dts: qcom: sdx75: Add GCC CX power domain ---
commit 31a230bc14fd1ed4b8fc915db1a0015701f6c99b
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: sdx75: Add GCC CX power domain
This commit adds a reference to the RPMh CX power domain in the SDX75 GCC
node. This allows consumers of GCC-provided GDSCs to propagate their local
domain votes to the required CX state.
> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> index 85cc9c6e6f83f..d4ef90c4a8db2 100644
> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> @@ -487,6 +487,7 @@ gcc: clock-controller@80000 {
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> + power-domains = <&rpmhpd RPMHPD_CX>;
[Severity: Low]
Will adding this property cause a dtbs_check validation regression?
The Documentation/devicetree/bindings/clock/qcom,sdx75-gcc.yaml schema
does not appear to document the power-domains property, and it enforces
unevaluatedProperties: false.
Does the schema need to be updated alongside this change to prevent
validation errors?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-qcom-tie-cx-to-gcc-v3-0-f1205a92682b@oss.qualcomm.com?part=37
next prev parent reply other threads:[~2026-08-24 12:28 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:53 [PATCH v3 00/47] clk: qcom: Tie CX power domains to GCCs Abel Vesa
2026-08-24 11:53 ` [PATCH v3 01/47] dt-bindings: clock: qcom: gcc-sdm845: Add CX power domain Abel Vesa
2026-08-24 20:39 ` Krzysztof Kozlowski
2026-08-25 7:30 ` Abel Vesa
2026-08-25 7:34 ` Krzysztof Kozlowski
2026-08-25 8:01 ` Abel Vesa
2026-08-24 11:53 ` [PATCH v3 02/47] dt-bindings: clock: qcom: gcc-sm8150: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 03/47] dt-bindings: clock: qcom: gcc-sm8250: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 04/47] dt-bindings: clock: qcom: gcc-sm8350: " Abel Vesa
2026-08-24 12:11 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 05/47] dt-bindings: clock: qcom: gcc-sm8450: " Abel Vesa
2026-08-24 12:13 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 06/47] dt-bindings: clock: qcom: qcs615-gcc: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 07/47] dt-bindings: clock: qcom: sm8550-gcc: " Abel Vesa
2026-08-24 12:08 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 08/47] dt-bindings: clock: qcom: sm8650-gcc: " Abel Vesa
2026-08-24 12:08 ` sashiko-bot
2026-08-24 11:53 ` [PATCH v3 09/47] dt-bindings: clock: qcom: sm8750-gcc: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 10/47] clk: qcom: gcc-eliza: Tie the CX power domain to controller Abel Vesa
2026-08-24 11:53 ` [PATCH v3 11/47] clk: qcom: gcc-kaanapali: " Abel Vesa
2026-08-24 11:53 ` [PATCH v3 12/47] clk: qcom: gcc-qcs615: " Abel Vesa
2026-08-24 12:25 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 13/47] clk: qcom: gcc-qcs8300: " Abel Vesa
2026-08-24 12:25 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 14/47] clk: qcom: gcc-qdu1000: " Abel Vesa
2026-08-24 12:28 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 15/47] clk: qcom: gcc-sa8775p: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 16/47] clk: qcom: gcc-sar2130p: " Abel Vesa
2026-08-24 12:19 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 17/47] clk: qcom: gcc-sc7180: " Abel Vesa
2026-08-24 12:22 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 18/47] clk: qcom: gcc-sc7280: " Abel Vesa
2026-08-24 12:36 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 19/47] clk: qcom: gcc-sdm670: " Abel Vesa
2026-08-24 12:19 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 20/47] clk: qcom: gcc-sdm845: " Abel Vesa
2026-08-24 12:18 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 21/47] clk: qcom: gcc-sdx75: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 22/47] clk: qcom: gcc-sm4450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 23/47] clk: qcom: gcc-sm6350: " Abel Vesa
2026-08-24 12:22 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 24/47] clk: qcom: gcc-sm8150: " Abel Vesa
2026-08-24 12:28 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 25/47] clk: qcom: gcc-sm8250: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 26/47] clk: qcom: gcc-sm8350: " Abel Vesa
2026-08-24 12:20 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 27/47] clk: qcom: gcc-sm8450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 28/47] clk: qcom: gcc-sm8550: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 29/47] clk: qcom: gcc-sm8650: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 30/47] clk: qcom: gcc-sm8750: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 31/47] clk: qcom: gcc-x1e80100: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 32/47] arm64: dts: qcom: kaanapali: Add GCC CX power domain Abel Vesa
2026-08-24 11:54 ` [PATCH v3 33/47] arm64: dts: qcom: monaco: " Abel Vesa
2026-08-24 12:24 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 34/47] arm64: dts: qcom: qdu1000: " Abel Vesa
2026-08-24 12:27 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 35/47] arm64: dts: qcom: sar2130p: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 36/47] arm64: dts: qcom: sdm670: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 37/47] arm64: dts: qcom: sdx75: " Abel Vesa
2026-08-24 12:28 ` sashiko-bot [this message]
2026-08-24 11:54 ` [PATCH v3 38/47] arm64: dts: qcom: sm4450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 39/47] arm64: dts: qcom: sm6350: " Abel Vesa
2026-08-24 12:30 ` sashiko-bot
2026-08-24 11:54 ` [PATCH v3 40/47] arm64: dts: qcom: sm8150: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 41/47] arm64: dts: qcom: sm8250: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 42/47] arm64: dts: qcom: sm8350: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 43/47] arm64: dts: qcom: sm8450: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 44/47] arm64: dts: qcom: sm8550: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 45/47] arm64: dts: qcom: sm8650: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 46/47] arm64: dts: qcom: sm8750: " Abel Vesa
2026-08-24 11:54 ` [PATCH v3 47/47] arm64: dts: qcom: talos: " Abel Vesa
2026-08-24 16:28 ` [PATCH v3 00/47] clk: qcom: Tie CX power domains to GCCs Vinod Koul
2026-08-25 7:32 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260824122819.390441F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox