Re: [PATCH v3 04/47] dt-bindings: clock: qcom: gcc-sm8350: Add CX power domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The DT binding example includes the legacy `qcom-rpmpd.h` header instead of the correct `qcom,rpmhpd.h` for resolving RPMh power domain macros.
--

--- Patch [4]: [PATCH v3 04/47] dt-bindings: clock: qcom: gcc-sm8350: Add CX power domain ---
commit da9ae2ea7784410b1afc05b6fc669ae089286661
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

dt-bindings: clock: qcom: gcc-sm8350: Add CX power domain

The GDSCs provided by the SM8350 GCC are supplied by the RPMh CX power
domain. This commit models that parent domain in the GCC binding and
makes the CX power-domain entry required.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8350.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8350.yaml
> index 97ffae3b55227..d249b1574e0f6 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8350.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8350.yaml

[ ... ]

> @@ -65,12 +71,14 @@ unevaluatedProperties: false
>  examples:
>    - |
>      #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/power/qcom-rpmpd.h>

[Severity: Low]
This isn't a bug, but should this example include the RPMh specific header
dt-bindings/power/qcom,rpmhpd.h instead of the legacy
dt-bindings/power/qcom-rpmpd.h to resolve the RPMHPD_CX macro?

While dt-bindings/power/qcom-rpmpd.h transitively includes the correct
header, relying on the legacy RPM power domain header for an RPMh SoC might
provide misleading documentation for developers referencing the example.

>      clock-controller@100000 {
>        compatible = "qcom,gcc-sm8350";
>        reg = <0x00100000 0x1f0000>;
>        clocks = <&rpmhcc RPMH_CXO_CLK>,
>                 <&sleep_clk>;
>        clock-names = "bi_tcxo", "sleep_clk";
> +      power-domains = <&rpmhpd RPMHPD_CX>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-qcom-tie-cx-to-gcc-v3-0-f1205a92682b@oss.qualcomm.com?part=4