Re: [PATCH v3 34/47] arm64: dts: qcom: qdu1000: Add GCC CX power domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `power-domains` property is added to the `gcc` node in `qdu1000.dtsi`, but the corresponding dt-binding `qcom,qdu1000-gcc.yaml` is not updated to allow it.
--

--- Patch [34]: [PATCH v3 34/47] arm64: dts: qcom: qdu1000: Add GCC CX power domain ---
commit a47858da198026a42957240d575a834059b75374
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: qdu1000: Add GCC CX power domain

This commit adds the CX power-domain reference to the GCC node in the
QDU1000 device tree. This allows votes from GCC GDSC consumers to propagate
to the RPMh CX domain.

> diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> index af106aebd30dc..accb4b989655d 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi
> @@ -396,6 +396,7 @@ gcc: clock-controller@80000 {
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
>  			#power-domain-cells = <1>;
> +			power-domains = <&rpmhpd QDU1000_CX>;

[Severity: Low]
Does this new property require a corresponding update to the dt-binding
schema?

Because Documentation/devicetree/bindings/clock/qcom,qdu1000-gcc.yaml sets
unevaluatedProperties: false and does not currently define power-domains,
will this addition cause make dtbs_check to fail during validation?

>  		};
>  
>  		ecpricc: clock-controller@280000 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-qcom-tie-cx-to-gcc-v3-0-f1205a92682b@oss.qualcomm.com?part=34