Re: [PATCH v3 07/47] dt-bindings: clock: qcom: sm8550-gcc: Add CX power domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Making `power-domains` unconditionally `required` breaks schema backwards compatibility for existing Device Trees.
- [Low] Inconsistent indentation in the YAML example node.
--

--- Patch [7]: [PATCH v3 07/47] dt-bindings: clock: qcom: sm8550-gcc: Add CX power domain ---
commit 6ec2187de5227c13379772ac36b81930a158c612
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

dt-bindings: clock: qcom: sm8550-gcc: Add CX power domain

This commit adds the CX power domain to the SM8550 GCC binding so the provider
can describe the dependency in devicetree. It also updates the required
properties list and adds the property to the example.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
> index c4e9b9bb63f51..26b78bd0afe6b 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-gcc.yaml
[ ... ]
> @@ -31,9 +31,15 @@ properties:
[ ... ]
>  required:
>    - compatible
>    - clocks
> +  - power-domains

[Severity: Low]
Does making power-domains unconditionally required here break schema validation
for older devicetrees that were created before this property was introduced?

>    - '#power-domain-cells'
>  
>  allOf:
[ ... ]
> @@ -55,6 +62,7 @@ examples:
>                 <&ufs_mem_phy 1>,
>                 <&ufs_mem_phy 2>,
>                 <&usb_1_qmpphy>;
> +       power-domains = <&rpmhpd RPMHPD_CX>;

[Severity: Low]
This isn't a bug, but the indentation here uses 7 spaces whereas the surrounding
properties use 6. Should this be aligned to match the rest of the example node?

>        #clock-cells = <1>;
>        #reset-cells = <1>;
>        #power-domain-cells = <1>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824-qcom-tie-cx-to-gcc-v3-0-f1205a92682b@oss.qualcomm.com?part=7