Re: [PATCH 07/18] arm64: dts: ti: k3-j721e: Add overlay for fusion application daughter board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `bus-type` property in `csi2_phy0` endpoint for `cdns_csi2rx0`.
--

commit c46b85eb404e26671d904b1552f797a50e25e19d
Author: Vaishnav Achath <vaishnav.a@ti.com>

arm64: dts: ti: k3-j721e: Add overlay for fusion application daughter board

This patch adds a device tree overlay for the Fusion application daughter
board, which connects multiple FPDLink-III based sensors to TI EVMs. It
configures two DS90UB960 deserializers that aggregate input from up to 8
sensors over the two CSI RX ports on the J721E.

[1]: https://svtronics.com/product/fusion-application-daughter-board-evm577pfusion-v1-0/?srsltid=AfmBOooMsRAd5ibFOGJaKbjsC3j9-loTPK2wWqsqPq2Adj55g1nPluxX

> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-evm-fusion.dtso b/arch/arm64/boot/dts/ti/k3-j721e-evm-fusion.dtso
> new file mode 100644
> index 0000000000000..0df2e48a4089c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-evm-fusion.dtso
[ ... ]
> +&cdns_csi2rx0 {
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		csi0_port0: port@0 {
> +			reg = <0>;
> +			status = "okay";
> +
> +			csi2_phy0: endpoint {
> +				remote-endpoint = <&ds90ub960_0_csi_out>;
> +				clock-lanes = <0>;
> +				data-lanes = <1 2 3 4>;
> +				link-frequencies = /bits/ 64 <800000000>;
> +
> +			};

[Severity: Low]
Does the csi2_phy0 endpoint need an explicit bus-type property?

While device tree parsing will likely fall back to V4L2_MBUS_CSI2_DPHY
automatically because clock-lanes and data-lanes are present, the
bus-type = <4>; property is missing here.

This creates a minor inconsistency with the identically structured
csi2_phy1 endpoint just below it, which explicitly defines the bus type.

> +		};
> +	};
> +};
> +
> +&cdns_csi2rx1 {
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		csi1_port0: port@0 {
> +			reg = <0>;
> +			status = "okay";
> +
> +			csi2_phy1: endpoint {
> +				remote-endpoint = <&ds90ub960_1_csi_out>;
> +				bus-type = <4>; /* CSI2 DPHY */
> +				clock-lanes = <0>;
> +				data-lanes = <1 2 3 4>;
> +				link-frequencies = /bits/ 64 <800000000>;
> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702093123.1048575-1-y-abhilashchandra@ti.com?part=7