Re: [PATCH 10/18] arm64: dts: ti: k3-j722s-evm: Add overlay for fusion application daughter board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Incorrect EVM name in the file header comment.
- [Low] Unused header inclusion.
- [Low] Inconsistent formatting in port declarations.
--

commit 7986b08cfb6e71a222dd7aeeb1377324b1869253
Author: Vaishnav Achath <vaishnav.a@ti.com>

arm64: dts: ti: k3-j722s-evm: Add overlay for fusion application daughter board

This commit adds a device tree overlay for the Fusion application daughter
board on the TI J722S EVM. It configures two DS90UB960 deserializers to
aggregate input from up to 8x FPDLink-III sensors over the CSI RX ports.

> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-fusion.dtso b/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-fusion.dtso
> new file mode 100644
> index 0000000000000..cbad2409a9c18
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm-fpdlink-fusion.dtso
> @@ -0,0 +1,196 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * DT Overlay for Fusion (FPD-Link III) board on J721E EVM

[Severity: Low]
This isn't a bug, but should this read J722S EVM instead of J721E EVM to
match the target board mentioned in the commit message and file name?

> + * https://svtronics.com/portfolio/evm577pfusion-v1-0-fusion/
> + *
> + * Copyright (C) 2024 Texas Instruments Incorporated - http://www.ti.com/
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>

[Severity: Low]
This isn't a bug, but is this dt-bindings/gpio/gpio.h inclusion necessary?
It appears no GPIO-related bindings or constants are actually used in this
overlay.

[ ... ]

> +			ds90ub960_0_ports: ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0{
> +				reg= <0>;
> +				status = "disabled";
> +				};

[Severity: Low]
This isn't a bug, but does this spacing follow the standard device tree
formatting conventions? There appear to be missing spaces before the opening
brace and after the equals sign here, such as port@0 { instead of port@0{, 
and reg = <0>; instead of reg= <0>;.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702093123.1048575-1-y-abhilashchandra@ti.com?part=10